143451 2015-04-06 12:35:22 -0700 [WK2][iOS] Regression(r182323): ASSERTION FAILED: WebCore::SQLiteDatabaseTracker::hasTransactionInProgress() in NetworkCache::Statistics::initialize() 2015-04-06 13:50:35 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 143278 1 cdumez cdumez andersca koivisto mitz webkit-bug-importer oldest_to_newest 1083143 0 cdumez 2015-04-06 12:35:22 -0700 We sometimes hit the following assertion: ASSERTION FAILED: WebCore::SQLiteDatabaseTracker::hasTransactionInProgress() in NetworkCache::Statistics::initialize() 0x107ff3020 WTFCrash 0x1036fe3fc WebKit::NetworkCache::executeSQLCommand(WebCore::SQLiteDatabase&, WTF::String const&) 0x1036fdaaa WebKit::NetworkCache::Statistics::initialize(WTF::String const&)::$_0::operator()() const 0x1036fd6bc std::__1::__function::__func<WebKit::NetworkCache::Statistics::initialize(WTF::String const&)::$_0, std::__1::allocator<WebKit::NetworkCache::Statistics::initialize(WTF::String const&)::$_0>, void ()>::operator()() 0x107b4358a std::__1::function<void ()>::operator()() const 0x108014bb9 invocation function for block in WTF::WorkQueue::dispatch(std::__1::function<void ()>) 0x101beebfd _dispatch_call_block_and_release 0x101c0e40d _dispatch_client_callout 0x101bf50ff _dispatch_queue_drain 0x101bf46fc _dispatch_queue_invoke 0x101bf6c1f _dispatch_root_queue_drain 0x101bf66bc _dispatch_worker_thread3 0x101f308a6 _pthread_wqthread 0x101f2e0c5 start_wqthread I do have a "WebCore::SQLiteTransactionInProgressAutoCounter transactionCounter" in NetworkCache::Statistics::initialize(). My current guess is that the SQLiteDatabaseTrackerClient can get set after transactionCounter is initialized but before executeSQLCommand() is called. 1083150 1 cdumez 2015-04-06 13:06:18 -0700 I can reproduce. Working on a fix now. 1083151 2 webkit-bug-importer 2015-04-06 13:06:52 -0700 <rdar://problem/20437994> 1083152 3 250223 cdumez 2015-04-06 13:17:52 -0700 Created attachment 250223 Patch 1083159 4 250223 cdumez 2015-04-06 13:50:31 -0700 Comment on attachment 250223 Patch Clearing flags on attachment: 250223 Committed r182437: <http://trac.webkit.org/changeset/182437> 1083160 5 cdumez 2015-04-06 13:50:35 -0700 All reviewed patches have been landed. Closing bug. 250223 2015-04-06 13:17:52 -0700 2015-04-06 13:50:31 -0700 Patch bug-143451-20150406131722.patch text/plain 6546 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyNDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzUzOWNhYzNiYjNkNDg4 ZDg4ZTc4MTZjZDBmYzJlNjZjZGI2NzAyYS4uNDAzZjVlOTNmNDNhMjMwZTVlZWI5ZjBiM2FmYjIy ZjU1MmM5ODA0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDE1LTA0LTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1baU9TXSBSZWdyZXNz aW9uKHIxODIzMjMpOiBBU1NFUlRJT04gRkFJTEVEOiBXZWJDb3JlOjpTUUxpdGVEYXRhYmFzZVRy YWNrZXI6Omhhc1RyYW5zYWN0aW9uSW5Qcm9ncmVzcygpIGluIE5ldHdvcmtDYWNoZTo6U3RhdGlz dGljczo6aW5pdGlhbGl6ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDM0NTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwNDM3OTk0PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluaXRpYWxpemUg V2ViUHJvY2Vzczo6bV93ZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXIgYW5kCisgICAgICAgIE5ldHdv cmtQcm9jZXNzOjptX3dlYlNRTGl0ZURhdGFiYXNlVHJhY2tlciBpbiB0aGVpciByZXNwZWN0aXZl IGNsYXNzCisgICAgICAgIGNvbnN0cnVjdG9ycyBpbnN0ZWFkIG9mIGRvaW5nIGl0IGxhdGVyIGlu IHRoZSBpbml0aWFsaXplV2ViUHJvY2VzcygpIC8KKyAgICAgICAgaW5pdGlhbGl6ZU5ldHdvcmtQ cm9jZXNzKCkgbWV0aG9kcy4KKworICAgICAgICBJZiB3ZSBkbyBpdCBsYXRlciwgaXQgY2FuIGhh cHBlbiB0aGF0IHRoZSB0cmFja2VyIGdldHMgc2V0IGFmdGVyCisgICAgICAgIGEgU1FMaXRlVHJh bnNhY3Rpb25JblByb2dyZXNzQXV0b0NvdW50ZXIgaW5pdGlhbGl6YXRpb24gYW5kIGJlZm9yZQor ICAgICAgICB0aGUgYWN0dWFsIHRyYW5zYWN0aW9uLiBXaGVuIHRoaXMgaGFwcGVucywgdGhlCisg ICAgICAgIFNRTGl0ZVRyYW5zYWN0aW9uSW5Qcm9ncmVzc0F1dG9Db3VudGVyIHZhcmlhYmxlIGZh aWxzIHRvIGluY3JlbWVudCB0aGUKKyAgICAgICAgdHJhbnNhY3Rpb24gY291bnQuIFRoZW4gd2hl biB0aGUgdHJhbnNhY3Rpb24gaXMgZXhlY3V0ZWQsCisgICAgICAgIFNRTGl0ZURhdGFiYXNlVHJh Y2tlcjo6aGFzVHJhbnNhY3Rpb25JblByb2dyZXNzKCkgY2FuIHJldHVybiBmYWxzZS4KKyAgICAg ICAgVGhpcyB3b3VsZCBsZWFkIHRvIHBvc3NpYmxlIGFzc2VydGlvbnMgb24gc3RhcnQgdXAgb24g aU9TLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3BwOgorICAg ICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6TmV0d29ya1Byb2Nlc3MpOgorICAgICAgICAo V2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6aW5pdGlhbGl6ZU5ldHdvcmtQcm9jZXNzKToKKyAgICAg ICAgKiBOZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oOgorICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OldlYlByb2Nl c3MpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjppbml0aWFsaXplQ29ubmVjdGlvbik6 CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmg6CisKIDIwMTUtMDQtMDYgIENvbW1p dCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHIxODIyOTYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz cy9OZXR3b3JrUHJvY2Vzcy5jcHAKaW5kZXggYTdmNTQxNGYyZTNhNjU0NGQwZGNjYTQ2NmRmODg1 NWU3NWY5NzI4Ni4uMzBhOGU2MDdjZjhmMGJmYWRhM2YwMTkzMTVjYmI5Y2YwMTFlOWNlOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtQcm9jZXNzLmNwcApA QCAtNjQsMTAgKzY0LDYgQEAKICNpbmNsdWRlICJOZXR3b3JrQ2FjaGVDb2RlcnMuaCIKICNlbmRp ZgogCi0jaWYgUExBVEZPUk0oSU9TKQotI2luY2x1ZGUgIldlYlNRTGl0ZURhdGFiYXNlVHJhY2tl ci5oIgotI2VuZGlmCi0KIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2Vi S2l0IHsKQEAgLTg2LDYgKzgyLDkgQEAgTmV0d29ya1Byb2Nlc3M6Ok5ldHdvcmtQcm9jZXNzKCkK ICNpZiBQTEFURk9STShDT0NPQSkKICAgICAsIG1fY2xlYXJDYWNoZURpc3BhdGNoR3JvdXAoMCkK ICNlbmRpZgorI2lmIFBMQVRGT1JNKElPUykKKyAgICAsIG1fd2ViU1FMaXRlRGF0YWJhc2VUcmFj a2VyKCp0aGlzKQorI2VuZGlmCiB7CiAgICAgTmV0d29ya1Byb2Nlc3NQbGF0Zm9ybVN0cmF0ZWdp ZXM6OmluaXRpYWxpemUoKTsKIApAQCAtMTk4LDEwICsxOTcsNiBAQCB2b2lkIE5ldHdvcmtQcm9j ZXNzOjppbml0aWFsaXplTmV0d29ya1Byb2Nlc3MoY29uc3QgTmV0d29ya1Byb2Nlc3NDcmVhdGlv blBhcmFtZQogICAgIGlmIChwYXJhbWV0ZXJzLnNob3VsZFVzZVRlc3RpbmdOZXR3b3JrU2Vzc2lv bikKICAgICAgICAgTmV0d29ya1N0b3JhZ2VTZXNzaW9uOjpzd2l0Y2hUb05ld1Rlc3RpbmdTZXNz aW9uKCk7CiAKLSNpZiBQTEFURk9STShJT1MpCi0gICAgbV93ZWJTUUxpdGVEYXRhYmFzZVRyYWNr ZXIgPSBzdGQ6Om1ha2VfdW5pcXVlPFdlYlNRTGl0ZURhdGFiYXNlVHJhY2tlcj4oKnRoaXMpOwot I2VuZGlmCi0KICAgICBOZXR3b3JrUHJvY2Vzc1N1cHBsZW1lbnRNYXA6OmNvbnN0X2l0ZXJhdG9y IGl0ID0gbV9zdXBwbGVtZW50cy5iZWdpbigpOwogICAgIE5ldHdvcmtQcm9jZXNzU3VwcGxlbWVu dE1hcDo6Y29uc3RfaXRlcmF0b3IgZW5kID0gbV9zdXBwbGVtZW50cy5lbmQoKTsKICAgICBmb3Ig KDsgaXQgIT0gZW5kOyArK2l0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1By b2Nlc3MvTmV0d29ya1Byb2Nlc3MuaCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05l dHdvcmtQcm9jZXNzLmgKaW5kZXggZjFjOWU4YmFlZTc5M2RiZWM3ZTFmYjQ0NjczZTA2NjFlZTkz ZGQ1OS4uNTE2NjQ5OGI5ZDdhZjI2N2NmZDllNjZhMzJiYWExZDQ0OTRiMjkxOSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Byb2Nlc3MuaAorKysgYi9T b3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUHJvY2Vzcy5oCkBAIC0zOSw2ICsz OSwxMCBAQAogI2luY2x1ZGUgPHd0Zi9Gb3J3YXJkLmg+CiAjaW5jbHVkZSA8d3RmL05ldmVyRGVz dHJveWVkLmg+CiAKKyNpZiBQTEFURk9STShJT1MpCisjaW5jbHVkZSAiV2ViU1FMaXRlRGF0YWJh c2VUcmFja2VyLmgiCisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgQ2VydGlm aWNhdGVJbmZvOwogfQpAQCAtNTAsMTAgKzU0LDYgQEAgY2xhc3MgTmV0d29ya1Byb2Nlc3NTdXBw bGVtZW50Owogc3RydWN0IE5ldHdvcmtQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzOwogc3RydWN0 IFNlY3VyaXR5T3JpZ2luRGF0YTsKIAotI2lmIFBMQVRGT1JNKElPUykKLWNsYXNzIFdlYlNRTGl0 ZURhdGFiYXNlVHJhY2tlcjsKLSNlbmRpZgotCiBjbGFzcyBOZXR3b3JrUHJvY2VzcyA6IHB1Ymxp YyBDaGlsZFByb2Nlc3MsIHByaXZhdGUgRG93bmxvYWRNYW5hZ2VyOjpDbGllbnQgewogICAgIFdU Rl9NQUtFX05PTkNPUFlBQkxFKE5ldHdvcmtQcm9jZXNzKTsKICAgICBmcmllbmQgY2xhc3MgTmV2 ZXJEZXN0cm95ZWQ8TmV0d29ya1Byb2Nlc3M+OwpAQCAtMTc4LDcgKzE3OCw3IEBAIHByaXZhdGU6 CiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKElPUykKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8V2ViU1FM aXRlRGF0YWJhc2VUcmFja2VyPiBtX3dlYlNRTGl0ZURhdGFiYXNlVHJhY2tlcjsKKyAgICBXZWJT UUxpdGVEYXRhYmFzZVRyYWNrZXIgbV93ZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXI7CiAjZW5kaWYK IH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwCmluZGV4IGI2ZTQ0 Nzk4MTM5OGY1ZjQ2YjBkYzhlMWI4NDEyZjY5MTMwYmY3YjcuLjkwOGIyMDFmYjg2MGY1ZWY2ZDQ2 ZDIwZDk3OWUyMmEyZTVjNTE5M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUHJvY2Vzcy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9j ZXNzLmNwcApAQCAtMTE4LDEwICsxMTgsNiBAQAogI2luY2x1ZGUgIldlYk5vdGlmaWNhdGlvbk1h bmFnZXIuaCIKICNlbmRpZgogCi0jaWYgUExBVEZPUk0oSU9TKQotI2luY2x1ZGUgIldlYlNRTGl0 ZURhdGFiYXNlVHJhY2tlci5oIgotI2VuZGlmCi0KICNpZiBFTkFCTEUoQkFUVEVSWV9TVEFUVVMp CiAjaW5jbHVkZSAiV2ViQmF0dGVyeU1hbmFnZXIuaCIKICNlbmRpZgpAQCAtMTgxLDYgKzE3Nyw5 IEBAIFdlYlByb2Nlc3M6OldlYlByb2Nlc3MoKQogI2VuZGlmCiAgICAgLCBtX25vblZpc2libGVQ cm9jZXNzQ2xlYW51cFRpbWVyKCp0aGlzLCAmV2ViUHJvY2Vzczo6bm9uVmlzaWJsZVByb2Nlc3ND bGVhbnVwVGltZXJGaXJlZCkKICAgICAsIG1fd2ViT3JpZ2luRGF0YU1hbmFnZXIoc3RkOjptYWtl X3VuaXF1ZTxXZWJPcmlnaW5EYXRhTWFuYWdlcj4oKnRoaXMsICp0aGlzKSkKKyNpZiBQTEFURk9S TShJT1MpCisgICAgLCBtX3dlYlNRTGl0ZURhdGFiYXNlVHJhY2tlcigqdGhpcykKKyNlbmRpZgog ewogICAgIC8vIEluaXRpYWxpemUgb3VyIHBsYXRmb3JtIHN0cmF0ZWdpZXMuCiAgICAgV2ViUGxh dGZvcm1TdHJhdGVnaWVzOjppbml0aWFsaXplKCk7CkBAIC0yMzYsMTAgKzIzNSw2IEBAIHZvaWQg V2ViUHJvY2Vzczo6aW5pdGlhbGl6ZUNvbm5lY3Rpb24oSVBDOjpDb25uZWN0aW9uKiBjb25uZWN0 aW9uKQogI2lmIEVOQUJMRShTRUNfSVRFTV9TSElNKQogICAgIFNlY0l0ZW1TaGltOjpzaW5nbGV0 b24oKS5pbml0aWFsaXplQ29ubmVjdGlvbihjb25uZWN0aW9uKTsKICNlbmRpZgotCi0jaWYgUExB VEZPUk0oSU9TKQotICAgIG1fd2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyID0gc3RkOjptYWtlX3Vu aXF1ZTxXZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXI+KCp0aGlzKTsKLSNlbmRpZgogICAgIAogICAg IFdlYlByb2Nlc3NTdXBwbGVtZW50TWFwOjpjb25zdF9pdGVyYXRvciBpdCA9IG1fc3VwcGxlbWVu dHMuYmVnaW4oKTsKICAgICBXZWJQcm9jZXNzU3VwcGxlbWVudE1hcDo6Y29uc3RfaXRlcmF0b3Ig ZW5kID0gbV9zdXBwbGVtZW50cy5lbmQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUHJvY2Vzcy5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9j ZXNzLmgKaW5kZXggMDczZWQ4NWM5NWIyZDRjZTI1M2JlMTZlYTQxYThjNTM3Mzc3MTYyMC4uOTJh ZGJjMWVmMjgyYWQyNTFiN2IwZjk4YWVhNjBlZTlmMjU0YTI1NiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQcm9jZXNzLmgKQEAgLTUyLDYgKzUyLDEwIEBACiAjaW5jbHVkZSA8V2ViQ29y ZS9NYWNoU2VuZFJpZ2h0Lmg+CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKElPUykKKyNpbmNsdWRl ICJXZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXIuaCIKKyNlbmRpZgorCiBuYW1lc3BhY2UgQVBJIHsK IGNsYXNzIE9iamVjdDsKIH0KQEAgLTkwLDEwICs5NCw2IEBAIGNsYXNzIFdlYlJlc291cmNlTG9h ZFNjaGVkdWxlcjsKIGNsYXNzIFdlYlRvRGF0YWJhc2VQcm9jZXNzQ29ubmVjdGlvbjsKICNlbmRp ZgogCi0jaWYgUExBVEZPUk0oSU9TKQotY2xhc3MgV2ViU1FMaXRlRGF0YWJhc2VUcmFja2VyOwot I2VuZGlmCi0KIGNsYXNzIFdlYlByb2Nlc3MgOiBwdWJsaWMgQ2hpbGRQcm9jZXNzLCBwdWJsaWMg V2ViT3JpZ2luRGF0YU1hbmFnZXJTdXBwbGVtZW50LCBwcml2YXRlIERvd25sb2FkTWFuYWdlcjo6 Q2xpZW50IHsKICAgICBmcmllbmQgY2xhc3MgTmV2ZXJEZXN0cm95ZWQ8RG93bmxvYWRNYW5hZ2Vy PjsKIHB1YmxpYzoKQEAgLTM3OSw3ICszNzksNyBAQCBwcml2YXRlOgogCiAgICAgc3RkOjp1bmlx dWVfcHRyPFdlYk9yaWdpbkRhdGFNYW5hZ2VyPiBtX3dlYk9yaWdpbkRhdGFNYW5hZ2VyOwogI2lm IFBMQVRGT1JNKElPUykKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8V2ViU1FMaXRlRGF0YWJhc2VUcmFj a2VyPiBtX3dlYlNRTGl0ZURhdGFiYXNlVHJhY2tlcjsKKyAgICBXZWJTUUxpdGVEYXRhYmFzZVRy YWNrZXIgbV93ZWJTUUxpdGVEYXRhYmFzZVRyYWNrZXI7CiAjZW5kaWYKIH07CiAK