143450 2015-04-06 12:05:08 -0700 WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines 2015-04-06 12:59:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap andersca benjamin commit-queue thorton oldest_to_newest 1083132 0 ap 2015-04-06 12:05:08 -0700 The last subtest in WebKit1.SetAndUpdateCacheModelPreferencesChangeMix relies on the WebView to be deallocated/closed by webView.clear(). But this is not necessarily going to happen, because an autorelease pool can keep the view object alive until later. webView.clear(); EXPECT_EQ((int)WebCacheModelDocumentViewer, (int)[WebView _cacheModel]); // <-- Only works when the above clear() drops the last reference. Two ways to fix this: 1. Drain an autorelease pool before the check. 2. Call -close on the view explicitly. I like the latter more, as it's the -close that we are actually after. 1083134 1 250219 ap 2015-04-06 12:07:39 -0700 Created attachment 250219 proposed fix 1083148 2 250219 commit-queue 2015-04-06 12:58:58 -0700 Comment on attachment 250219 proposed fix Clearing flags on attachment: 250219 Committed r182434: <http://trac.webkit.org/changeset/182434> 1083149 3 commit-queue 2015-04-06 12:59:02 -0700 All reviewed patches have been landed. Closing bug. 250219 2015-04-06 12:07:39 -0700 2015-04-06 12:58:58 -0700 proposed fix SetAndUpdateCacheModelPreferencesChangeMix.txt text/plain 3025 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MjQzMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTA0LTA2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFdlYktpdDEuU2V0QW5kVXBkYXRlQ2FjaGVNb2RlbFByZWZlcmVuY2VzQ2hh bmdlTWl4IGZhaWxzIG9uIHNvbWUgbWFjaGluZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzQ1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvU2V0QW5kVXBk YXRlQ2FjaGVNb2RlbC5tbTogKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorICAgICAgICBNYWtlIHN1 cmUgdGhhdCB0aGUgdmlldyBpcyBhY3R1YWxseSBjbG9zZWQsIHJlZ2FyZGxlc3Mgb2YgYW55dGhp bmcgZWxzZSB0aGF0IGhhcHBlbnMgYmVuZWF0aC4KKyAgICAgICAgQWxzbywgcmVtb3ZlZCB1bm5l Y2Vzc2FyeSBnZXQoKSBjYWxscy4KKwogMjAxNS0wNC0wMyAgQWxleGV5IFByb3NrdXJ5YWtvdiAg PGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWR1Y2UgdGhlIGRlcGVuZGVuY3kgb24gRmxhc2gg aW4gcmVncmVzc2lvbiB0ZXN0cwpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMv U2V0QW5kVXBkYXRlQ2FjaGVNb2RlbC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL21hYy9TZXRBbmRVcGRhdGVDYWNoZU1vZGVsLm1tCShyZXZpc2lvbiAxODIxNDUp CisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9TZXRBbmRVcGRhdGVDYWNoZU1vZGVs Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC03NCwyOSArNzQsMjkgQEAgVEVTVChXZWJLaXQxLCBTZXRB bmRVcGRhdGVDYWNoZU1vZGVsUHJlZgogCiAgICAgW3N0YW5kYXJkUHJlZmVyZW5jZXMgc2V0Q2Fj aGVNb2RlbDpXZWJDYWNoZU1vZGVsRG9jdW1lbnRWaWV3ZXJdOwogICAgIEVYUEVDVF9FUSgoaW50 KVdlYkNhY2hlTW9kZWxEb2N1bWVudFZpZXdlciwgKGludClbV2ViVmlldyBfY2FjaGVNb2RlbF0p OwotICAgIFtjdXN0b21QcmVmZXJlbmNlcy5nZXQoKSBzZXRDYWNoZU1vZGVsOldlYkNhY2hlTW9k ZWxQcmltYXJ5V2ViQnJvd3Nlcl07CisgICAgW2N1c3RvbVByZWZlcmVuY2VzIHNldENhY2hlTW9k ZWw6V2ViQ2FjaGVNb2RlbFByaW1hcnlXZWJCcm93c2VyXTsKICAgICBFWFBFQ1RfRVEoKGludClX ZWJDYWNoZU1vZGVsUHJpbWFyeVdlYkJyb3dzZXIsIChpbnQpW1dlYlZpZXcgX2NhY2hlTW9kZWxd KTsKIAogCiAgICAgLy8gMikgVGhlIGNhY2hlIG1vZGVsIHNob3VsZCBmb2xsb3cgdGhlIGhpZ2hl c3QgdmFsdWUgb2YgY2FjaGUgbW9kZWwgYmV0d2VlbiB0aGUgdHdvIHByZWZlcmVuY2VzLgogICAg IFJldGFpblB0cjxXZWJWaWV3PiB3ZWJWaWV3ID0gYWRvcHROUyhbW1dlYlZpZXcgYWxsb2NdIGlu aXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCAxMjAsIDIwMCkgZnJhbWVOYW1lOm5pbCBncm91 cE5hbWU6bmlsXSk7Ci0gICAgW3dlYlZpZXcuZ2V0KCkgc2V0UHJlZmVyZW5jZXM6Y3VzdG9tUHJl ZmVyZW5jZXMuZ2V0KCldOworICAgIFt3ZWJWaWV3IHNldFByZWZlcmVuY2VzOmN1c3RvbVByZWZl cmVuY2VzLmdldCgpXTsKICAgICBFWFBFQ1RfRVEoKGludClXZWJDYWNoZU1vZGVsUHJpbWFyeVdl YkJyb3dzZXIsIChpbnQpW1dlYlZpZXcgX2NhY2hlTW9kZWxdKTsKIAotICAgIFtjdXN0b21QcmVm ZXJlbmNlcy5nZXQoKSBzZXRDYWNoZU1vZGVsOldlYkNhY2hlTW9kZWxEb2N1bWVudEJyb3dzZXJd OworICAgIFtjdXN0b21QcmVmZXJlbmNlcyBzZXRDYWNoZU1vZGVsOldlYkNhY2hlTW9kZWxEb2N1 bWVudEJyb3dzZXJdOwogICAgIEVYUEVDVF9FUSgoaW50KVdlYkNhY2hlTW9kZWxEb2N1bWVudEJy b3dzZXIsIChpbnQpW1dlYlZpZXcgX2NhY2hlTW9kZWxdKTsKIAogICAgIFtzdGFuZGFyZFByZWZl cmVuY2VzIHNldENhY2hlTW9kZWw6V2ViQ2FjaGVNb2RlbFByaW1hcnlXZWJCcm93c2VyXTsKICAg ICBFWFBFQ1RfRVEoKGludClXZWJDYWNoZU1vZGVsUHJpbWFyeVdlYkJyb3dzZXIsIChpbnQpW1dl YlZpZXcgX2NhY2hlTW9kZWxdKTsKLSAgICBbY3VzdG9tUHJlZmVyZW5jZXMuZ2V0KCkgc2V0Q2Fj aGVNb2RlbDpXZWJDYWNoZU1vZGVsRG9jdW1lbnRWaWV3ZXJdOworICAgIFtjdXN0b21QcmVmZXJl bmNlcyBzZXRDYWNoZU1vZGVsOldlYkNhY2hlTW9kZWxEb2N1bWVudFZpZXdlcl07CiAgICAgRVhQ RUNUX0VRKChpbnQpV2ViQ2FjaGVNb2RlbFByaW1hcnlXZWJCcm93c2VyLCAoaW50KVtXZWJWaWV3 IF9jYWNoZU1vZGVsXSk7CiAKICAgICAvLyAzKSBSZXNldHRpbmcgdGhlIHZpZXcgc2hvdWxkIGZh bGwgYmFjayB0byBzdGFuZGFyZFByZWZlcmVuY2VzLgogICAgIFtzdGFuZGFyZFByZWZlcmVuY2Vz IHNldENhY2hlTW9kZWw6V2ViQ2FjaGVNb2RlbERvY3VtZW50Vmlld2VyXTsKLSAgICBbY3VzdG9t UHJlZmVyZW5jZXMuZ2V0KCkgc2V0Q2FjaGVNb2RlbDpXZWJDYWNoZU1vZGVsUHJpbWFyeVdlYkJy b3dzZXJdOworICAgIFtjdXN0b21QcmVmZXJlbmNlcyBzZXRDYWNoZU1vZGVsOldlYkNhY2hlTW9k ZWxQcmltYXJ5V2ViQnJvd3Nlcl07CiAgICAgRVhQRUNUX0VRKChpbnQpV2ViQ2FjaGVNb2RlbFBy aW1hcnlXZWJCcm93c2VyLCAoaW50KVtXZWJWaWV3IF9jYWNoZU1vZGVsXSk7CiAKLSAgICB3ZWJW aWV3LmNsZWFyKCk7CisgICAgW3dlYlZpZXcgY2xvc2VdOwogICAgIEVYUEVDVF9FUSgoaW50KVdl YkNhY2hlTW9kZWxEb2N1bWVudFZpZXdlciwgKGludClbV2ViVmlldyBfY2FjaGVNb2RlbF0pOwog fQogCg==