143443 2015-04-06 07:52:23 -0700 [GTK] install-dependencies should install the right version of geoclue 2015-04-06 08:31:58 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED INVALID P2 Normal --- 1 mcatanzaro mcatanzaro cgarcia mcatanzaro mrobinson oldest_to_newest 1083083 0 mcatanzaro 2015-04-06 07:52:23 -0700 Our install-dependencies script is installing the wrong version of geoclue. Note, Debian seems to have the .pc file for new geoclue in the main package rather than a -dev package, as far as I can tell. That seems like a bug...? 1083084 1 250204 mcatanzaro 2015-04-06 07:54:29 -0700 Created attachment 250204 Patch 1083086 2 250204 cgarcia 2015-04-06 07:56:39 -0700 Comment on attachment 250204 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250204&action=review > Tools/gtk/install-dependencies:61 > + geoclue-2.0 \ Don't we need the -dev package? is 2.0 available in the bots? 1083088 3 mrobinson 2015-04-06 08:16:27 -0700 (In reply to comment #0) > Our install-dependencies script is installing the wrong version of geoclue. > > Note, Debian seems to have the .pc file for new geoclue in the main package > rather than a -dev package, as far as I can tell. That seems like a bug...? I wouldn't say it is "wrong" since both versions of Geoclue are supported. I wonder if it's possible to do this without the entire script failing on older versions of Debian or Ubuntu though. 1083092 4 mcatanzaro 2015-04-06 08:31:34 -0700 (In reply to comment #2) > Don't we need the -dev package? See comment #0 > is 2.0 available in the bots? I dunno; how do I check this? geoclue2 was a dependency of GNOME 3.10, so I presume you have it by now, but it looks like it was only added to Debian last summer, so it depends on how new the bots are. Do they run this script? (In reply to comment #3) > I wouldn't say it is "wrong" since both versions of Geoclue are supported. Hm, for some reason I thought only the newer geoclue was supported. Then I guess we don't need this patch. > I > wonder if it's possible to do this without the entire script failing on > older versions of Debian or Ubuntu though. Hm... on Fedora it would cause the script to fail, but geoclue2 exists on F20, the oldest supported version, so it doesn't matter. I don't know if apt-get would fail or just ignore the missing package, but I would guess fail. TBH, since old geoclue is supported, I'd say we can just close this bug. 250204 2015-04-06 07:54:29 -0700 2015-04-06 08:31:50 -0700 Patch bug-143443-20150406095341.patch text/plain 1878 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMzU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzk1MWRhMDk5OWUyNGNlN2NhYTgzODE0YzVjNWYwOGM2 OGE2ZDI2ZC4uNTNkOGZmZjlkNTY0N2Q3YzgxNWJmMDUwMjJjZjNiNDY2ZTU3YjRmNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTA0LTA2ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIFtHVEtdIGluc3RhbGwtZGVwZW5kZW5jaWVzIHNob3VsZCBpbnN0YWxsIHRo ZSByaWdodCB2ZXJzaW9uIG9mIGdlb2NsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MzQ0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEluc3RhbGwgZ2VvY2x1ZTIgaW5zdGVhZCBvZiB0aGUgb3JpZ2lu YWwgZ2VvY2x1ZS4KKworICAgICAgICAqIGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczoKKwogMjAx NS0wNC0wMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAg IHJ1bi1qc2Mtc3RyZXNzLXRlc3RzIC0tcmVtb3RlIHNob3VsZCBhZGQgbGlibGx2bUZvckpTQy5z byB0byB0aGUgYnVuZGxlIG9uIExpbnV4CmRpZmYgLS1naXQgYS9Ub29scy9ndGsvaW5zdGFsbC1k ZXBlbmRlbmNpZXMgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKaW5kZXggMDU0Mjll YWM4MzZjMjU4NzJkMzdjOGNhNjM1NTgzMDgwNmM1MWQ3Zi4uOTk3ODg1MzEyYmQxMzU5MzlkMjVk ZGFmZWVlYWMwYWIxY2ViNDE1YSAxMDA3NTUKLS0tIGEvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5k ZW5jaWVzCisrKyBiL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcwpAQCAtNTgsNiArNTgs NyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAgICAgICAgIGNtYWtl IFwKICAgICAgICAgZmxleCBcCiAgICAgICAgIGdhd2sgXAorICAgICAgICBnZW9jbHVlLTIuMCBc CiAgICAgICAgIGdub21lLWNvbW1vbiBcCiAgICAgICAgIGdwZXJmIFwKICAgICAgICAgZ3RrLWRv Yy10b29scyBcCkBAIC02Niw3ICs2Nyw2IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNX aXRoQXB0IHsKICAgICAgICAgbGliYXRrMS4wLWRldiBcCiAgICAgICAgIGxpYmVuY2hhbnQtZGV2 IFwKICAgICAgICAgbGliZmFhZC1kZXYgXAotICAgICAgICBsaWJnZW9jbHVlLWRldiBcCiAgICAg ICAgIGxpYmdpcmVwb3NpdG9yeTEuMC1kZXYgXAogICAgICAgICBsaWJnbDEtbWVzYS1kZXYgXAog ICAgICAgICBsaWJnbDEtbWVzYS1nbHggXApAQCAtMTkzLDcgKzE5Myw3IEBAIGZ1bmN0aW9uIGlu c3RhbGxEZXBlbmRlbmNpZXNXaXRoUGFjbWFuIHsKICAgICAgICAgYXRrIFwKICAgICAgICAgZW5j aGFudCBcCiAgICAgICAgIGZhYWQyIFwKLSAgICAgICAgZ2VvY2x1ZSBcCisgICAgICAgIGdlb2Ns dWUyIFwKICAgICAgICAgZ29iamVjdC1pbnRyb3NwZWN0aW9uIFwKICAgICAgICAgbWVzYSBcCiAg ICAgICAgIG1lc2EtbGliZ2wgXApAQCAtMzAxLDcgKzMwMSw3IEBAIGZ1bmN0aW9uIGluc3RhbGxG ZWRvcmFEZXBlbmRlbmNpZXMgewogICAgICAgICBmb250Y29uZmlnLWRldmVsIFwKICAgICAgICAg ZnJlZXR5cGUtZGV2ZWwgXAogICAgICAgICBnY2MtYysrIFwKLSAgICAgICAgZ2VvY2x1ZS1kZXZl bCBcCisgICAgICAgIGdlb2NsdWUyLWRldmVsIFwKICAgICAgICAgZ2V0dGV4dC1kZXZlbCBcCiAg ICAgICAgIGdvYmplY3QtaW50cm9zcGVjdGlvbi1kZXZlbCBcCiAgICAgICAgIGdwZXJmIFwK