143440 2015-04-06 04:50:58 -0700 Remove CSS functions min() and max() which had been dropped from specification 2015-04-08 00:45:51 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jh718.park jh718.park commit-queue darin gyuyoung.kim ossy rniwa oldest_to_newest 1083069 0 jh718.park 2015-04-06 04:50:58 -0700 In the latest specification of CSS Values and Units Module Level3(http://www.w3.org/TR/css3-values/) min() and max() function had been dropped already during the CR period. So remove these css functions which not conform with the current specification. 1083071 1 250200 jh718.park 2015-04-06 04:54:19 -0700 Created attachment 250200 Patch 1083096 2 250200 darin 2015-04-06 09:07:48 -0700 Comment on attachment 250200 Patch I don’t understand this patch. Is there a behavior change? Was this really the only code we had? No test covering it? 1083563 3 jh718.park 2015-04-07 23:39:47 -0700 (In reply to comment #2) > Comment on attachment 250200 [details] > Patch > > I don’t understand this patch. Is there a behavior change? Was this really > the only code we had? No test covering it? Yes, I think that's all of the calculation min() and max() related codes we have currently. If we choose to implement min() and max() functions which defined in http://www.w3.org/TR/2011/WD-css3-values-20110906/#calc it would needs patch like https://bugs.webkit.org/show_bug.cgi?id=143515, then LayoutTests/css3/calc/simple-minmax-expected.txt can be turned to pass result, but the latest specification of CSS Values and Units Module Level3 dropped those functions so I think the implementation of those are not needed anymore. :) 1083576 4 250200 commit-queue 2015-04-08 00:45:46 -0700 Comment on attachment 250200 Patch Clearing flags on attachment: 250200 Committed r182525: <http://trac.webkit.org/changeset/182525> 1083577 5 commit-queue 2015-04-08 00:45:51 -0700 All reviewed patches have been landed. Closing bug. 250200 2015-04-06 04:54:19 -0700 2015-04-08 00:45:46 -0700 Patch bug-143440-20150406205332.patch text/plain 2458 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWUxN2QwMTgzYzJlNGU3 ZDgzZWYzNTc3Nzk1MmIwNzRiZDhhYjRjZi4uZmYzNzBlZWJjYjE5YzExNzk0ZTU1YjdkNzc3MDc5 NDQ0ZDAxNzUxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0LTA2ICBKb29u Z2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSZW1vdmUgQ1NT IGZ1bmN0aW9ucyBtaW4oKSBhbmQgbWF4KCkgd2hpY2ggaGFkIGJlZW4gZHJvcHBlZCBmcm9tIHNw ZWNpZmljYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0MzQ0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgTm8gQmVoYXZpb3IgY2hhbmdlcy4KKworICAgICAgICAqIGNzcy9D U1NDYWxjdWxhdGlvblZhbHVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU0NhbGNWYWx1ZTo6 Y3JlYXRlKToKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNTU1BhcnNlcjo6aXNDYWxjdWxhdGlvbik6CisKIDIwMTUtMDQtMDYgIMW9YW4gRG9iZXLFoWVr ICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgRmlsZUxpc3QgY29uc3RydWN0b3Ig c2hvdWxkIG1vdmUgdGhlIHBhc3NlZC1pbiBWZWN0b3I8PiBydmFsdWUgcmVmZXJlbmNlIGludG8g dGhlIG1lbWJlciB2YXJpYWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU0Nh bGN1bGF0aW9uVmFsdWUuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0NhbGN1bGF0aW9uVmFs dWUuY3BwCmluZGV4IGM0NWE1MWExZTNjNjg5ZDZkYmQ3OTQ4ZGVhMjJkZjAyYjg3YjM5OWMuLjdi NzJmMTA5ODg4Y2ViYTBiMDIyOGMwN2NhMmE3MjI4ZGE5MzI1NDcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NDYWxjdWxhdGlvblZhbHVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTQ2FsY3VsYXRpb25WYWx1ZS5jcHAKQEAgLTc1OCw3ICs3NTgsNiBAQCBQYXNzUmVm UHRyPENTU0NhbGNWYWx1ZT4gQ1NTQ2FsY1ZhbHVlOjpjcmVhdGUoQ1NTUGFyc2VyU3RyaW5nIG5h bWUsIENTU1BhcnNlclZhbAogCiAgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKG5hbWUsICJjYWxj KCIpIHx8IGVxdWFsSWdub3JpbmdDYXNlKG5hbWUsICItd2Via2l0LWNhbGMoIikpCiAgICAgICAg IGV4cHJlc3Npb24gPSBwYXJzZXIucGFyc2VDYWxjKCZwYXJzZXJWYWx1ZUxpc3QpOwotICAgIC8v IEZJWE1FOiBjYWxjIChodHRwOi8vd2Via2l0Lm9yZy9iLzE2NjYyKSBBZGQgcGFyc2luZyBmb3Ig bWluIGFuZCBtYXggaGVyZQogCiAgICAgcmV0dXJuIGV4cHJlc3Npb24gPyBhZG9wdFJlZihuZXcg Q1NTQ2FsY1ZhbHVlKGV4cHJlc3Npb24ucmVsZWFzZU5vbk51bGwoKSwgcmFuZ2UgIT0gQ2FsY3Vs YXRpb25SYW5nZUFsbCkpIDogbnVsbHB0cjsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5k ZXggZTNjNzkxM2FlZmQ1NDA0YTRjNDk1ZTYxNmYzZDQ0ZjNkZmIzYzg1MS4uNDc4MzRkMDIyYWNj NDdkY2JiZTEyOGMyY2I5ZWQ3YTlhZWM3NzZkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAK QEAgLTcyMjMsOSArNzIyMyw3IEBAIGJvb2wgQ1NTUGFyc2VyOjppc0NhbGN1bGF0aW9uKENTU1Bh cnNlclZhbHVlJiB2YWx1ZSkKIHsKICAgICByZXR1cm4gKHZhbHVlLnVuaXQgPT0gQ1NTUGFyc2Vy VmFsdWU6OkZ1bmN0aW9uKQogICAgICAgICAmJiAoZXF1YWxJZ25vcmluZ0Nhc2UodmFsdWUuZnVu Y3Rpb24tPm5hbWUsICJjYWxjKCIpCi0gICAgICAgICAgICB8fCBlcXVhbElnbm9yaW5nQ2FzZSh2 YWx1ZS5mdW5jdGlvbi0+bmFtZSwgIi13ZWJraXQtY2FsYygiKQotICAgICAgICAgICAgfHwgZXF1 YWxJZ25vcmluZ0Nhc2UodmFsdWUuZnVuY3Rpb24tPm5hbWUsICItd2Via2l0LW1pbigiKQotICAg ICAgICAgICAgfHwgZXF1YWxJZ25vcmluZ0Nhc2UodmFsdWUuZnVuY3Rpb24tPm5hbWUsICItd2Vi a2l0LW1heCgiKSk7CisgICAgICAgICAgICB8fCBlcXVhbElnbm9yaW5nQ2FzZSh2YWx1ZS5mdW5j dGlvbi0+bmFtZSwgIi13ZWJraXQtY2FsYygiKSk7CiB9CiAKIGlubGluZSBpbnQgQ1NTUGFyc2Vy Ojpjb2xvckludEZyb21WYWx1ZShWYWx1ZVdpdGhDYWxjdWxhdGlvbiYgdmFsdWVXaXRoQ2FsY3Vs YXRpb24pCg==