143434 2015-04-05 18:33:38 -0700 Web Inspector: Add String/Array "includes" parameter display string 2015-04-05 21:02:40 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue dino graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1083005 0 joepeck 2015-04-05 18:33:38 -0700 * SUMMARY Add String/Array "includes" parameter display string. * TEST 1. js> dir([]) 2. Expand prototype => "includes" looks like it takes no parameters * EXPECTED "includes(searchElement, [startIndex=0])" like "indexOf" 1083006 1 webkit-bug-importer 2015-04-05 18:33:54 -0700 <rdar://problem/20430033> 1083007 2 250185 joepeck 2015-04-05 18:36:51 -0700 Created attachment 250185 [PATCH] Proposed Fix 1083027 3 250185 darin 2015-04-05 20:13:54 -0700 Comment on attachment 250185 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=250185&action=review > Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js:37 > + getOwnPropertySymbols: "object", Not mentioned in change log. 1083032 4 250185 commit-queue 2015-04-05 21:02:36 -0700 Comment on attachment 250185 [PATCH] Proposed Fix Clearing flags on attachment: 250185 Committed r182375: <http://trac.webkit.org/changeset/182375> 1083033 5 commit-queue 2015-04-05 21:02:40 -0700 All reviewed patches have been landed. Closing bug. 250185 2015-04-05 18:36:51 -0700 2015-04-05 21:02:36 -0700 [PATCH] Proposed Fix native.patch text/plain 2079 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE5YzEzYTQuLjcxY2VmY2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDE1LTA0LTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIFN0 cmluZy9BcnJheSAiaW5jbHVkZXMiIHBhcmFtZXRlciBkaXNwbGF5IHN0cmluZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNDM0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01v ZGVscy9OYXRpdmVGdW5jdGlvblBhcmFtZXRlcnMuanM6CisKKzIwMTUtMDQtMDUgIEpvc2VwaCBQ ZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBS ZWdyZXNzaW9uOiBNYXAgaW5zdGFuY2VzIGRvbid0IGV4cGFuZAogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNDI4CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9OYXRpdmVGdW5jdGlvblBhcmFt ZXRlcnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvTmF0 aXZlRnVuY3Rpb25QYXJhbWV0ZXJzLmpzCmluZGV4IGZhMGNlOTkuLjk5YjliNTkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9OYXRpdmVGdW5j dGlvblBhcmFtZXRlcnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvTW9kZWxzL05hdGl2ZUZ1bmN0aW9uUGFyYW1ldGVycy5qcwpAQCAtMzQsNiArMzQsNyBAQCBX ZWJJbnNwZWN0b3IuTmF0aXZlQ29uc3RydWN0b3JGdW5jdGlvblBhcmFtZXRlcnMgPSB7CiAgICAg ICAgIGZyZWV6ZTogIm9iamVjdCIsCiAgICAgICAgIGdldE93blByb3BlcnR5RGVzY3JpcHRvcjog Im9iamVjdCwgcHJvcGVydHlOYW1lIiwKICAgICAgICAgZ2V0T3duUHJvcGVydHlOYW1lczogIm9i amVjdCIsCisgICAgICAgIGdldE93blByb3BlcnR5U3ltYm9sczogIm9iamVjdCIsCiAgICAgICAg IGdldFByb3RvdHlwZU9mOiAib2JqZWN0IiwKICAgICAgICAgaXNFeHRlbnNpYmxlOiAib2JqZWN0 IiwKICAgICAgICAgaXNGcm96ZW46ICJvYmplY3QiLApAQCAtMTk1LDYgKzE5Niw3IEBAIFdlYklu c3BlY3Rvci5OYXRpdmVQcm90b3R5cGVGdW5jdGlvblBhcmFtZXRlcnMgPSB7CiAgICAgICAgIGZp bmQ6ICJjYWxsYmFjaywgW3RoaXNBcmddIiwKICAgICAgICAgZmluZEluZGV4OiAiY2FsbGJhY2ss IFt0aGlzQXJnXSIsCiAgICAgICAgIGZvckVhY2g6ICJjYWxsYmFjaywgW3RoaXNBcmddIiwKKyAg ICAgICAgaW5jbHVkZXM6ICJzZWFyY2hWYWx1ZSwgW3N0YXJ0SW5kZXg9MF0iLAogICAgICAgICBp bmRleE9mOiAic2VhcmNoVmFsdWUsIFtzdGFydEluZGV4PTBdIiwKICAgICAgICAgam9pbjogIltz ZXBhcmF0b3I9XCIsXCJdIiwKICAgICAgICAgbGFzdEluZGV4T2Y6ICJzZWFyY2hWYWx1ZSwgW3N0 YXJ0SW5kZXg9bGVuZ3RoXSIsCkBAIC0yOTgsNiArMzAwLDcgQEAgV2ViSW5zcGVjdG9yLk5hdGl2 ZVByb3RvdHlwZUZ1bmN0aW9uUGFyYW1ldGVycyA9IHsKICAgICAgICAgY2hhckF0OiAiaW5kZXgi LAogICAgICAgICBjaGFyQ29kZUF0OiAiaW5kZXgiLAogICAgICAgICBjb25jYXQ6ICJzdHJpbmcs IC4uLiIsCisgICAgICAgIGluY2x1ZGVzOiAic2VhcmNoVmFsdWUsIFtzdGFydEluZGV4PTBdIiwK ICAgICAgICAgaW5kZXhPZjogInNlYXJjaFZhbHVlLCBbc3RhcnRJbmRleD0wXSIsCiAgICAgICAg IGxhc3RJbmRleE9mOiAic2VhcmNoVmFsdWUsIFtzdGFydEluZGV4PWxlbmd0aF0iLAogICAgICAg ICBsb2NhbGVDb21wYXJlOiAic3RyaW5nIiwK