143433 2015-04-05 18:16:05 -0700 Web Inspector: wrap style class names in WebInspector.StyleClass helper 2026-01-12 09:01:39 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All NEW InRadar P2 Normal --- 1 burg webkit-unassigned graouts inspector-bugzilla-changes jonowells webkit-bug-importer oldest_to_newest 1082998 0 burg 2015-04-05 18:16:05 -0700 Since we are moving away from long-winded style properties on view constructors, here's an idea. Given the two following approaches: this.element.classList.add("inline-object-foo") this.element.classList.add(WebInspector.StyleClass("inline-object-foo")) The latter supports tooling to check for bogus style names. * This could be done mostly at compile-time by cross-checking against identifiers in CSS files. * Alternatively, in engineering builds we could collate a "style class whitelist" similar to localizedStrings.js. At runtime we do a lookup into the whitelist and log an error if a bogus style class is used. In production builds, use sed to remove the unnecessary lookup. Thoughts? 1082999 1 webkit-bug-importer 2015-04-05 18:16:32 -0700 <rdar://problem/20429964> 1083075 2 timothy 2015-04-06 06:02:11 -0700 I wonder if we could just runtime replace this.element.classList.add, remove, etc. to do the check? 1083089 3 burg 2015-04-06 08:21:20 -0700 (In reply to comment #2) > I wonder if we could just runtime replace this.element.classList.add, > remove, etc. to do the check? Maybe. A benefit of the proposed style which I didn't list: it makes it possible to trivially grep for all style strings in your favorite text editor. It is definitely kind of wordy. I think once ES6 modules land, we can debate whether and how to shorten WebInspector.Everything.