143430 2015-04-05 17:40:01 -0700 Use jsNontrivialString in more places if the string is guaranteed to be 2 or more characters 2015-04-08 18:39:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned benjamin ggaren joepeck oldest_to_newest 1082981 0 joepeck 2015-04-05 17:40:01 -0700 * SUMMARY Use jsNontrivialString in more places if the string is guaranteed to be 2 or more characters. * NOTES - "NaN", "Infinity", and large values with "e" are guaranteed to have 2 or more characters - Symbol's description string is guaranteed to at least have "Symbol()" - A quoted string is guaranteed to have at least the two quotes 1082982 1 250180 joepeck 2015-04-05 17:40:54 -0700 Created attachment 250180 [PATCH] Proposed Fix 1083025 2 250180 darin 2015-04-05 20:05:05 -0700 Comment on attachment 250180 [PATCH] Proposed Fix Symbol::descriptiveString should use makeString instead of StringBuilder. 1083804 3 joepeck 2015-04-08 18:39:11 -0700 http://trac.webkit.org/changeset/182577 1083805 4 joepeck 2015-04-08 18:39:27 -0700 (In reply to comment #2) > Comment on attachment 250180 [details] > [PATCH] Proposed Fix > > Symbol::descriptiveString should use makeString instead of StringBuilder. Will do this separately. 250180 2015-04-05 17:40:54 -0700 2015-04-05 20:05:05 -0700 [PATCH] Proposed Fix nontrivial.patch text/plain 4305 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDgxNTlkMDQuLjUzNmJlYTEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE1LTA0LTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgVXNlIGpzTm9udHJpdmlhbFN0cmlu ZyBpbiBtb3JlIHBsYWNlcyBpZiB0aGUgc3RyaW5nIGlzIGd1YXJhbnRlZWQgdG8gYmUgMiBvciBt b3JlIGNoYXJhY3RlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0MzQzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcDoKKyAgICAgICAgKEpTQzo6ZXJy b3JEZXNjcmlwdGlvbkZvclZhbHVlKToKKyAgICAgICAgKiBydW50aW1lL051bWJlclByb3RvdHlw ZS5jcHA6CisgICAgICAgIChKU0M6Om51bWJlclByb3RvRnVuY1RvUHJlY2lzaW9uKToKKyAgICAg ICAgKEpTQzo6bnVtYmVyUHJvdG9GdW5jVG9TdHJpbmcpOgorICAgICAgICAqIHJ1bnRpbWUvU3Ry aW5nQ29uc3RydWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpjYWxsU3RyaW5nQ29uc3RydWN0b3Ip OgorICAgICAgICAqIHJ1bnRpbWUvU3ltYm9sUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6 c3ltYm9sUHJvdG9GdW5jVG9TdHJpbmcpOgorCisyMDE1LTA0LTA1ICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogRVM2OiBTaG93 IFN5bWJvbCBwcm9wZXJ0aWVzIG9uIE9iamVjdHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTI3OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCmluZGV4IDNmMDJjMmYuLmViNWE0MmEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBl cnMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBl cnMuY3BwCkBAIC0xMDYsNyArMTA2LDcgQEAgSlNTdHJpbmcqIGVycm9yRGVzY3JpcHRpb25Gb3JW YWx1ZShFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdikKICAgICBpZiAodi5pc0ZhbHNlKCkpCiAg ICAgICAgIHJldHVybiB2bS5zbWFsbFN0cmluZ3MuZmFsc2VTdHJpbmcoKTsKICAgICBpZiAodi5p c1N0cmluZygpKQotICAgICAgICByZXR1cm4ganNTdHJpbmcoJnZtLCBtYWtlU3RyaW5nKCciJywg IGFzU3RyaW5nKHYpLT52YWx1ZShleGVjKSwgJyInKSk7CisgICAgICAgIHJldHVybiBqc05vbnRy aXZpYWxTdHJpbmcoJnZtLCBtYWtlU3RyaW5nKCciJywgIGFzU3RyaW5nKHYpLT52YWx1ZShleGVj KSwgJyInKSk7CiAgICAgaWYgKHYuaXNPYmplY3QoKSkgewogICAgICAgICBDYWxsRGF0YSBjYWxs RGF0YTsKICAgICAgICAgSlNPYmplY3QqIG9iamVjdCA9IGFzT2JqZWN0KHYpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTnVtYmVyUHJvdG90eXBlLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL051bWJlclByb3RvdHlwZS5jcHAKaW5kZXggOTQw Mzk1Yy4uMTEwMjM2NSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv TnVtYmVyUHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9O dW1iZXJQcm90b3R5cGUuY3BwCkBAIC00NDYsNyArNDQ2LDcgQEAgRW5jb2RlZEpTVmFsdWUgSlND X0hPU1RfQ0FMTCBudW1iZXJQcm90b0Z1bmNUb1ByZWNpc2lvbihFeGVjU3RhdGUqIGV4ZWMpCiAK ICAgICAvLyBIYW5kbGUgTmFOIGFuZCBJbmZpbml0eS4KICAgICBpZiAoIXN0ZDo6aXNmaW5pdGUo eCkpCi0gICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNTdHJpbmcoZXhlYywgU3RyaW5n OjpudW1iZXJUb1N0cmluZ0VDTUFTY3JpcHQoeCkpKTsKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6 OmVuY29kZShqc05vbnRyaXZpYWxTdHJpbmcoZXhlYywgU3RyaW5nOjpudW1iZXJUb1N0cmluZ0VD TUFTY3JpcHQoeCkpKTsKIAogICAgIE51bWJlclRvU3RyaW5nQnVmZmVyIGJ1ZmZlcjsKICAgICBy ZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzU3RyaW5nKGV4ZWMsIFN0cmluZyhudW1iZXJUb0ZpeGVk UHJlY2lzaW9uU3RyaW5nKHgsIHNpZ25pZmljYW50RmlndXJlcywgYnVmZmVyKSkpKTsKQEAgLTU0 MCw3ICs1NDAsNyBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIG51bWJlclByb3RvRnVu Y1RvU3RyaW5nKEV4ZWNTdGF0ZSogZXhlYykKICAgICB9CiAKICAgICBpZiAoIXN0ZDo6aXNmaW5p dGUoZG91YmxlVmFsdWUpKQotICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzU3RyaW5n KGV4ZWMsIFN0cmluZzo6bnVtYmVyVG9TdHJpbmdFQ01BU2NyaXB0KGRvdWJsZVZhbHVlKSkpOwor ICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTm9udHJpdmlhbFN0cmluZyhleGVjLCBT dHJpbmc6Om51bWJlclRvU3RyaW5nRUNNQVNjcmlwdChkb3VibGVWYWx1ZSkpKTsKIAogICAgIFJh ZGl4QnVmZmVyIHM7CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1N0cmluZyhleGVjLCB0 b1N0cmluZ1dpdGhSYWRpeChzLCBkb3VibGVWYWx1ZSwgcmFkaXgpKSk7CmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdDb25zdHJ1Y3Rvci5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdDb25zdHJ1Y3Rvci5jcHAKaW5kZXggYmVj YWNiZS4uZTI3ZTJiZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv U3RyaW5nQ29uc3RydWN0b3IuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1N0cmluZ0NvbnN0cnVjdG9yLmNwcApAQCAtMTEyLDcgKzExMiw3IEBAIHN0YXRpYyBFbmNvZGVk SlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGNhbGxTdHJpbmdDb25zdHJ1Y3RvcihFeGVjU3RhdGUqIGV4 ZWMpCiAgICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNFbXB0eVN0cmluZyhleGVjKSk7 CiAgICAgSlNWYWx1ZSBhcmd1bWVudCA9IGV4ZWMtPnVuY2hlY2tlZEFyZ3VtZW50KDApOwogICAg IGlmIChhcmd1bWVudC5pc1N5bWJvbCgpKQotICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2Rl KGpzU3RyaW5nKGV4ZWMsIGFzU3ltYm9sKGFyZ3VtZW50KS0+ZGVzY3JpcHRpdmVTdHJpbmcoKSkp OworICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTm9udHJpdmlhbFN0cmluZyhleGVj LCBhc1N5bWJvbChhcmd1bWVudCktPmRlc2NyaXB0aXZlU3RyaW5nKCkpKTsKICAgICByZXR1cm4g SlNWYWx1ZTo6ZW5jb2RlKGFyZ3VtZW50LnRvU3RyaW5nKGV4ZWMpKTsKIH0KIApkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3ltYm9sUHJvdG90eXBlLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N5bWJvbFByb3RvdHlwZS5jcHAKaW5kZXggYjhk YjE2MS4uMmY0YWM0ZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv U3ltYm9sUHJvdG90eXBlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9T eW1ib2xQcm90b3R5cGUuY3BwCkBAIC04Myw3ICs4Myw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19I T1NUX0NBTEwgc3ltYm9sUHJvdG9GdW5jVG9TdHJpbmcoRXhlY1N0YXRlKiBleGVjKQogICAgICAg ICBzeW1ib2wgPSBhc1N5bWJvbChqc0Nhc3Q8U3ltYm9sT2JqZWN0Kj4odGhpc09iamVjdCktPmlu dGVybmFsVmFsdWUoKSk7CiAgICAgfQogCi0gICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1N0 cmluZyhleGVjLCBzeW1ib2wtPmRlc2NyaXB0aXZlU3RyaW5nKCkpKTsKKyAgICByZXR1cm4gSlNW YWx1ZTo6ZW5jb2RlKGpzTm9udHJpdmlhbFN0cmluZyhleGVjLCBzeW1ib2wtPmRlc2NyaXB0aXZl U3RyaW5nKCkpKTsKIH0KIAogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBzeW1ib2xQcm90 b0Z1bmNWYWx1ZU9mKEV4ZWNTdGF0ZSogZXhlYykK