143426 2015-04-05 16:06:29 -0700 URI encoding/escaping should use efficient string building instead of calling snprintf(). 2015-04-05 18:33:08 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Performance P2 Normal --- 1 kling kling commit-queue oldest_to_newest 1082956 0 kling 2015-04-05 16:06:29 -0700 Seeing a bunch of time wasted inside snprintf(). 1082957 1 250172 kling 2015-04-05 16:07:01 -0700 Created attachment 250172 Patch 1083003 2 250172 commit-queue 2015-04-05 18:33:05 -0700 Comment on attachment 250172 Patch Clearing flags on attachment: 250172 Committed r182370: <http://trac.webkit.org/changeset/182370> 1083004 3 commit-queue 2015-04-05 18:33:08 -0700 All reviewed patches have been landed. Closing bug. 250172 2015-04-05 16:07:01 -0700 2015-04-05 18:33:05 -0700 Patch bug-143426.diff text/plain 3343 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDM5Yzc3NmYuLjM0MTQxZGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA0LTA1ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBVUkkgZW5jb2RpbmcvZXNjYXBpbmcgc2hv dWxkIHVzZSBlZmZpY2llbnQgc3RyaW5nIGJ1aWxkaW5nIGluc3RlYWQgb2YgY2FsbGluZyBzbnBy aW50ZigpLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQzNDI2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEkgc2F3IDAuNSUgb2YgbWFp biB0aHJlYWQgdGltZSBpbiBzbnByaW50ZigpIG9uIDxodHRwOi8vcG9seW1lcmxhYnMuZ2l0aHVi LmlvL2JlbmNobWFya3MvPgorICAgICAgICB3aGljaCBzZWVtZWQgcHJldHR5IHNpbGx5LiBUaGlz IGNoYW5nZSBnZXRzIHRoYXQgZG93biB0byBub3RoaW5nIGluIGZhdm9yIG9mIHVzaW5nIG91cgor ICAgICAgICBleGlzdGluZyBKU1N0cmluZ0J1aWxkZXIgYW5kIEhleE51bWJlci5oIGZhY2lsaXRp ZXMuCisKKyAgICAgICAgVGhlc2UgQVBJcyBhcmUgd2VsbC1leGVyY2lzZWQgYnkgb3VyIGV4aXN0 aW5nIHRlc3Qgc3VpdGUuCisKKyAgICAgICAgKiBydW50aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rp b25zLmNwcDoKKyAgICAgICAgKEpTQzo6ZW5jb2RlKToKKyAgICAgICAgKEpTQzo6Z2xvYmFsRnVu Y0VzY2FwZSk6CisKIDIwMTUtMDQtMDQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29t PgogCiAgICAgICAgIExvZ2ljYWxseSBlbXB0eSBXZWFrQmxvY2tzIHNob3VsZCBub3QgcGluIGRv d24gdGhlaXIgTWFya2VkQmxvY2tzIGluZGVmaW5pdGVseS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rpb25zLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rpb25zLmNwcAppbmRl eCA3MjIzNDM3Li5lZDFjODkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3RGdW5jdGlvbnMuY3BwCkBAIC00Miw2ICs0Miw3IEBA CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8d3RmL0FTQ0lJQ1R5cGUuaD4KICNpbmNs dWRlIDx3dGYvQXNzZXJ0aW9ucy5oPgorI2luY2x1ZGUgPHd0Zi9IZXhOdW1iZXIuaD4KICNpbmNs dWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogI2luY2x1ZGUgPHd0Zi9TdHJpbmdFeHRyYXMuaD4KICNp bmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+CkBAIC02NSw5ICs2Niw4IEBAIHN0YXRp YyBKU1ZhbHVlIGVuY29kZShFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IGNoYXIqIGRvTm90RXNjYXBl KQogICAgICAgICBpZiAoYyAmJiBzdHJjaHIoZG9Ob3RFc2NhcGUsIGMpKQogICAgICAgICAgICAg YnVpbGRlci5hcHBlbmQoc3RhdGljX2Nhc3Q8TENoYXI+KGMpKTsKICAgICAgICAgZWxzZSB7Ci0g ICAgICAgICAgICBjaGFyIHRtcFs0XTsKLSAgICAgICAgICAgIHNucHJpbnRmKHRtcCwgc2l6ZW9m KHRtcCksICIlJSUwMlgiLCBzdGF0aWNfY2FzdDx1bnNpZ25lZCBjaGFyPihjKSk7Ci0gICAgICAg ICAgICBidWlsZGVyLmFwcGVuZCh0bXApOworICAgICAgICAgICAgYnVpbGRlci5hcHBlbmQoc3Rh dGljX2Nhc3Q8TENoYXI+KCclJykpOworICAgICAgICAgICAgYXBwZW5kQnl0ZUFzSGV4KGMsIGJ1 aWxkZXIpOwogICAgICAgICB9CiAgICAgfQogICAgIHJldHVybiBidWlsZGVyLmJ1aWxkKGV4ZWMp OwpAQCAtNjc2LDkgKzY3Niw4IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgZ2xvYmFs RnVuY0VzY2FwZShFeGVjU3RhdGUqIGV4ZWMpCiAgICAgICAgICAgICBpZiAodSAmJiBzdHJjaHIo ZG9fbm90X2VzY2FwZSwgc3RhdGljX2Nhc3Q8Y2hhcj4odSkpKQogICAgICAgICAgICAgICAgIGJ1 aWxkZXIuYXBwZW5kKCpjKTsKICAgICAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgICAgIGNo YXIgdG1wWzRdOwotICAgICAgICAgICAgICAgIHNucHJpbnRmKHRtcCwgc2l6ZW9mKHRtcCksICIl JSUwMlgiLCB1KTsKLSAgICAgICAgICAgICAgICBidWlsZGVyLmFwcGVuZCh0bXApOworICAgICAg ICAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKHN0YXRpY19jYXN0PExDaGFyPignJScpKTsKKyAgICAg ICAgICAgICAgICBhcHBlbmRCeXRlQXNIZXgoc3RhdGljX2Nhc3Q8TENoYXI+KHUpLCBidWlsZGVy KTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCkBAIC02ODksMTUgKzY4OCwxNSBAQCBFbmNv ZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGdsb2JhbEZ1bmNFc2NhcGUoRXhlY1N0YXRlKiBleGVj KQogICAgIGZvciAodW5zaWduZWQgayA9IDA7IGsgPCBzdHIubGVuZ3RoKCk7IGsrKywgYysrKSB7 CiAgICAgICAgIGludCB1ID0gY1swXTsKICAgICAgICAgaWYgKHUgPiAyNTUpIHsKLSAgICAgICAg ICAgIGNoYXIgdG1wWzddOwotICAgICAgICAgICAgc25wcmludGYodG1wLCBzaXplb2YodG1wKSwg IiUldSUwNFgiLCB1KTsKLSAgICAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKHRtcCk7CisgICAgICAg ICAgICBidWlsZGVyLmFwcGVuZChzdGF0aWNfY2FzdDxMQ2hhcj4oJyUnKSk7CisgICAgICAgICAg ICBidWlsZGVyLmFwcGVuZChzdGF0aWNfY2FzdDxMQ2hhcj4oJ3UnKSk7CisgICAgICAgICAgICBh cHBlbmRCeXRlQXNIZXgodSA+PiA4LCBidWlsZGVyKTsKKyAgICAgICAgICAgIGFwcGVuZEJ5dGVB c0hleCh1ICYgMHhGRiwgYnVpbGRlcik7CiAgICAgICAgIH0gZWxzZSBpZiAodSAhPSAwICYmIHN0 cmNocihkb19ub3RfZXNjYXBlLCBzdGF0aWNfY2FzdDxjaGFyPih1KSkpCiAgICAgICAgICAgICBi dWlsZGVyLmFwcGVuZCgqYyk7CiAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgY2hhciB0bXBb NF07Ci0gICAgICAgICAgICBzbnByaW50Zih0bXAsIHNpemVvZih0bXApLCAiJSUlMDJYIiwgdSk7 Ci0gICAgICAgICAgICBidWlsZGVyLmFwcGVuZCh0bXApOworICAgICAgICAgICAgYnVpbGRlci5h cHBlbmQoc3RhdGljX2Nhc3Q8TENoYXI+KCclJykpOworICAgICAgICAgICAgYXBwZW5kQnl0ZUFz SGV4KHUsIGJ1aWxkZXIpOwogICAgICAgICB9CiAgICAgfQogCg==