143423 2015-04-05 14:12:09 -0700 [Mac] Spins seen in WKSetApplicationInformationItem, so it should not be called on the main thread 2015-04-05 15:25:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 darin darin andersca ap barraclough mitz sam oldest_to_newest 1082939 0 darin 2015-04-05 14:12:09 -0700 [Mac] Spins seen in WKSetApplicationInformationItem, so it should not be called on the main thread 1082941 1 250167 darin 2015-04-05 14:24:30 -0700 Created attachment 250167 Patch 1082947 2 250167 ap 2015-04-05 15:14:08 -0700 Comment on attachment 250167 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250167&action=review r=me assuming that there is a reason to believe that WKSetApplicationInformationItem can be used from a secondary thread. > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:270 > +#if USE(APPKIT) We should probably use PLATFORM(MAC) now, as USE(APPKIT) is just a more confusing way to say the same. > Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:304 > + WKSetApplicationInformationItem(CFSTR("LSActivePageUserVisibleOriginsKey"), activePageURLs.get()); Is this function documented to be usable from a secondary thread? It doesn't seem obvious that it would be safe - there is waiting for an IPC response, and dealing with app global data structures here. 1082948 3 darin 2015-04-05 15:22:19 -0700 (In reply to comment #2) > Is this function documented to be usable from a secondary thread? Yes. It says "Mac OS X threading: Thread safe" in the header. 1082949 4 250167 darin 2015-04-05 15:23:26 -0700 Comment on attachment 250167 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250167&action=review >> Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm:270 >> +#if USE(APPKIT) > > We should probably use PLATFORM(MAC) now, as USE(APPKIT) is just a more confusing way to say the same. I’m not sure what changed from when we first wrote the code, but I’ll do it. I think USE(APPKIT) is better than PLATFORM(MAC) when we are actually talking about AppKit, but I suppose WKSetApplicationInformationItem is hardly AppKit. 1082950 5 darin 2015-04-05 15:25:18 -0700 Committed r182366: <http://trac.webkit.org/changeset/182366> 1082951 6 mitz 2015-04-05 15:25:54 -0700 rdar://problem/18773785 250167 2015-04-05 14:24:30 -0700 2015-04-05 15:23:26 -0700 Patch bug-143423-20150405142342.patch text/plain 4335 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjk2Yjk2ZDhiOWU3OGNj ZTQ3OGUyNjU5YjRmYzIxODNmYjZlNTZkMS4uYjU2ZWVjMGRmOTczNTM2YzVlYjQ2MDczNWU4Y2Zl YjdlYTQyZDAyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTA0LTA1ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSBTcGlucyBzZWVuIGlu IFdLU2V0QXBwbGljYXRpb25JbmZvcm1hdGlvbkl0ZW0sIHNvIGl0IHNob3VsZCBub3QgYmUgY2Fs bGVkIG9uIHRoZSBtYWluIHRocmVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQzNDIzCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzE4NzczNzg1CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6b3JpZ2luKTog RmFjdG9yZWQgb3V0IHRoaXMgaGVscGVyIGZ1bmN0aW9uIGZyb20gdXBkYXRlQWN0aXZlUGFnZXMg YmVsb3csIHNvCisgICAgICAgIHRoZSBmdW5jdGlvbiBiZWxvdyBpcyBlYXNpZXIgdG8gcmVhZC4K KyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6dXBkYXRlQWN0aXZlUGFnZXMpOiBSZWZhY3Rv cmVkIHRvIHVzZSB0aGUgbmV3IG9yaWdpbiBmdW5jdGlvbi4KKyAgICAgICAgVXNlIGRpc3BhdGNo X2FzeW5jIHRvIGNhbGwgV0tTZXRBcHBsaWNhdGlvbkluZm9ybWF0aW9uSXRlbSB3aXRob3V0IGJs b2NraW5nLgorCiAyMDE1LTA0LTA1ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4K IAogICAgICAgICBCbG9vbSBmaWx0ZXIgc2hvdWxkIHN1cHBvcnQgbG9uZ2VyIGhhc2hlcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2Eu bW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQpp bmRleCAwMWM4YWFjZjhhMDRhYjA1M2M5MDI2NTAxODY5MWE5ZjhlNjI1MTBmLi5kOWVjNDlmODFl MzAwMWY1NjFmYmJjNmVhZWIxMTU5N2Y3ZjExYjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQpAQCAtMjY3LDMxICsyNjcsNDIg QEAgdm9pZCBXZWJQcm9jZXNzOjppbml0aWFsaXplU2FuZGJveChjb25zdCBDaGlsZFByb2Nlc3NJ bml0aWFsaXphdGlvblBhcmFtZXRlcnMmIHAKICNlbmRpZgogfQogCisjaWYgVVNFKEFQUEtJVCkK Kworc3RhdGljIE5TVVJMICpvcmlnaW4oV2ViUGFnZSYgcGFnZSkKK3sKKyAgICBXZWJGcmFtZSog bWFpbkZyYW1lID0gcGFnZS5tYWluV2ViRnJhbWUoKTsKKyAgICBpZiAoIW1haW5GcmFtZSkKKyAg ICAgICAgcmV0dXJuIG5pbDsKKworICAgIFVSTCBtYWluRnJhbWVVUkwoVVJMKCksIG1haW5GcmFt ZS0+dXJsKCkpOworICAgIFJlZlB0cjxTZWN1cml0eU9yaWdpbj4gbWFpbkZyYW1lT3JpZ2luID0g U2VjdXJpdHlPcmlnaW46OmNyZWF0ZShtYWluRnJhbWVVUkwpOworICAgIFN0cmluZyBtYWluRnJh bWVPcmlnaW5TdHJpbmc7CisgICAgaWYgKCFtYWluRnJhbWVPcmlnaW4tPmlzVW5pcXVlKCkpCisg ICAgICAgIG1haW5GcmFtZU9yaWdpblN0cmluZyA9IG1haW5GcmFtZU9yaWdpbi0+dG9SYXdTdHJp bmcoKTsKKyAgICBlbHNlCisgICAgICAgIG1haW5GcmFtZU9yaWdpblN0cmluZyA9IG1haW5GcmFt ZVVSTC5wcm90b2NvbCgpICsgJzonOyAvLyB0b1Jhd1N0cmluZygpIGlzIG5vdCBzdXBwb3NlZCB0 byB3b3JrIHdpdGggdW5pcXVlIG9yaWdpbnMsIGFuZCB3b3VsZCBqdXN0IHJldHVybiAiOi8vIi4K KworICAgIC8vICtbTlNVUkwgVVJMV2l0aFN0cmluZzpdIHJldHVybnMgbmlsIHdoZW4gaXRzIGFy Z3VtZW50IGlzIG1hbGZvcm1lZC4gSXQncyB1bmNsZWFyIHdoZW4gd2Ugd291bGQgaGF2ZSBhIG1h bGZvcm1lZCBVUkwgaGVyZSwKKyAgICAvLyBidXQgaXQgaGFwcGVucyBpbiBwcmFjdGljZSBhY2Nv cmRpbmcgdG8gPHJkYXI6Ly9wcm9ibGVtLzE0MTczMzg5Pi4gTGVhdmluZyBhbiBhc3NlcnRpb24g aW4gdG8gY2F0Y2ggYSByZXByb2R1Y2libGUgY2FzZS4KKyAgICBBU1NFUlQoW05TVVJMIFVSTFdp dGhTdHJpbmc6bWFpbkZyYW1lT3JpZ2luU3RyaW5nXSk7CisKKyAgICByZXR1cm4gW05TVVJMIFVS TFdpdGhTdHJpbmc6bWFpbkZyYW1lT3JpZ2luU3RyaW5nXTsKK30KKworI2VuZGlmCisKIHZvaWQg V2ViUHJvY2Vzczo6dXBkYXRlQWN0aXZlUGFnZXMoKQogewogI2lmIFVTRShBUFBLSVQpCiAgICAg UmV0YWluUHRyPENGTXV0YWJsZUFycmF5UmVmPiBhY3RpdmVQYWdlVVJMcyA9IGFkb3B0Q0YoQ0ZB cnJheUNyZWF0ZU11dGFibGUoMCwgMCwgJmtDRlR5cGVBcnJheUNhbGxCYWNrcykpOwotICAgIGZv ciAoY29uc3QgYXV0byYgaXRlcjogbV9wYWdlTWFwKSB7Ci0gICAgICAgIFdlYlBhZ2UqIHBhZ2Ug PSBpdGVyLnZhbHVlLmdldCgpOwotICAgICAgICBXZWJGcmFtZSogbWFpbkZyYW1lID0gcGFnZS0+ bWFpbldlYkZyYW1lKCk7Ci0gICAgICAgIGlmICghbWFpbkZyYW1lKQotICAgICAgICAgICAgY29u dGludWU7Ci0gICAgICAgIFN0cmluZyBtYWluRnJhbWVPcmlnaW5TdHJpbmc7Ci0gICAgICAgIFJl ZlB0cjxTZWN1cml0eU9yaWdpbj4gbWFpbkZyYW1lT3JpZ2luID0gU2VjdXJpdHlPcmlnaW46OmNy ZWF0ZUZyb21TdHJpbmcobWFpbkZyYW1lLT51cmwoKSk7Ci0gICAgICAgIGlmICghbWFpbkZyYW1l T3JpZ2luLT5pc1VuaXF1ZSgpKQotICAgICAgICAgICAgbWFpbkZyYW1lT3JpZ2luU3RyaW5nID0g bWFpbkZyYW1lT3JpZ2luLT50b1Jhd1N0cmluZygpOwotICAgICAgICBlbHNlCi0gICAgICAgICAg ICBtYWluRnJhbWVPcmlnaW5TdHJpbmcgPSBVUkwoVVJMKCksIG1haW5GcmFtZS0+dXJsKCkpLnBy b3RvY29sKCkgKyAnOic7IC8vIHRvUmF3U3RyaW5nKCkgaXMgbm90IHN1cHBvc2VkIHRvIHdvcmsg d2l0aCB1bmlxdWUgb3JpZ2lucywgYW5kIHdvdWxkIGp1c3QgcmV0dXJuICI6Ly8iLgotCi0gICAg ICAgIE5TVVJMICpvcmlnaW5Bc05TVVJMID0gW05TVVJMIFVSTFdpdGhTdHJpbmc6bWFpbkZyYW1l T3JpZ2luU3RyaW5nXTsKLSAgICAgICAgLy8gK1tOU1VSTCBVUkxXaXRoU3RyaW5nOl0gcmV0dXJu cyBuaWwgd2hlbiBpdHMgYXJndW1lbnQgaXMgbWFsZm9ybWVkLiBJdCdzIHVuY2xlYXIgaG93IHdl IGNhbiBwb3NzaWJseSBoYXZlIGEgbWFsZm9ybWVkIFVSTCBoZXJlLAotICAgICAgICAvLyBidXQg aXQgaGFwcGVucyBpbiBwcmFjdGljZSBhY2NvcmRpbmcgdG8gPHJkYXI6Ly9wcm9ibGVtLzE0MTcz Mzg5Pi4gTGVhdmluZyBhbiBhc3NlcnRpb24gaW4gdG8gY2F0Y2ggYSByZXByb2R1Y2libGUgY2Fz ZS4KLSAgICAgICAgQVNTRVJUKG9yaWdpbkFzTlNVUkwpOwotICAgICAgICBOU1N0cmluZyAqdXNl clZpc2libGVPcmlnaW5TdHJpbmcgPSBvcmlnaW5Bc05TVVJMID8gdXNlclZpc2libGVTdHJpbmco b3JpZ2luQXNOU1VSTCkgOiBAIihudWxsKSI7Ci0KLSAgICAgICAgQ0ZBcnJheUFwcGVuZFZhbHVl KGFjdGl2ZVBhZ2VVUkxzLmdldCgpLCB1c2VyVmlzaWJsZU9yaWdpblN0cmluZyk7CisgICAgZm9y IChhdXRvJiBwYWdlIDogbV9wYWdlTWFwLnZhbHVlcygpKSB7CisgICAgICAgIGlmIChOU1VSTCAq b3JpZ2luQXNVUkwgPSBvcmlnaW4oKnBhZ2UpKQorICAgICAgICAgICAgQ0ZBcnJheUFwcGVuZFZh bHVlKGFjdGl2ZVBhZ2VVUkxzLmdldCgpLCB1c2VyVmlzaWJsZVN0cmluZyhvcmlnaW5Bc1VSTCkp OwogICAgIH0KLSAgICBXS1NldEFwcGxpY2F0aW9uSW5mb3JtYXRpb25JdGVtKENGU1RSKCJMU0Fj dGl2ZVBhZ2VVc2VyVmlzaWJsZU9yaWdpbnNLZXkiKSwgYWN0aXZlUGFnZVVSTHMuZ2V0KCkpOwor ICAgIGRpc3BhdGNoX2FzeW5jKGRpc3BhdGNoX2dldF9nbG9iYWxfcXVldWUoRElTUEFUQ0hfUVVF VUVfUFJJT1JJVFlfREVGQVVMVCwgMCksIFthY3RpdmVQYWdlVVJMc10geworICAgICAgICBXS1Nl dEFwcGxpY2F0aW9uSW5mb3JtYXRpb25JdGVtKENGU1RSKCJMU0FjdGl2ZVBhZ2VVc2VyVmlzaWJs ZU9yaWdpbnNLZXkiKSwgYWN0aXZlUGFnZVVSTHMuZ2V0KCkpOworICAgIH0pOwogI2VuZGlmCiB9 CiAK