143413 2015-04-04 22:38:11 -0700 [WK2] API::Array::copy() should move the resulting Vector<> of copies into the Array::create() call 2015-04-06 02:56:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan oldest_to_newest 1082860 0 zan 2015-04-04 22:38:11 -0700 [WK2] API::Array::copy() should move the resulting Vector<> of copies into the Array::create() call 1082861 1 250149 zan 2015-04-04 22:40:59 -0700 Created attachment 250149 Patch 1082871 2 250151 zan 2015-04-05 00:27:34 -0700 Created attachment 250151 Patch 1082873 3 250152 zan 2015-04-05 00:31:21 -0700 Created attachment 250152 Patch 1082917 4 250152 darin 2015-04-05 13:08:41 -0700 Comment on attachment 250152 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250152&action=review > Source/WebKit2/Shared/API/APIArray.cpp:81 > +Array::Array(Vector<RefPtr<Object>>&& elements) Seems like this function should be inlined. > Source/WebKit2/Shared/API/APIArray.h:55 > + static PassRefPtr<Array> create(Vector<RefPtr<Object>>&& elements); I don’t think the name “elements” here adds anything. > Source/WebKit2/Shared/API/APIArray.h:88 > + explicit Array(Vector<RefPtr<Object>>&& elements); I don’t think the name “elements” here adds anything. 1082918 5 250152 darin 2015-04-05 13:09:13 -0700 Comment on attachment 250152 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250152&action=review > Source/WebKit2/Shared/API/APIArray.h:54 > static PassRefPtr<Array> create(); The return value of these functions should be changed to Ref<Array>. 1083059 6 250152 zan 2015-04-06 01:57:52 -0700 Comment on attachment 250152 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=250152&action=review >> Source/WebKit2/Shared/API/APIArray.h:54 >> static PassRefPtr<Array> create(); > > The return value of these functions should be changed to Ref<Array>. That would make sense, but it's a bigger task since a lot of callers already operate on a PassRefPtr<> or are leaking or accessing the stored object through a pointer. Something for a separate bug. 1083060 7 250198 zan 2015-04-06 02:03:59 -0700 Created attachment 250198 Patch for landing 1083065 8 250198 zan 2015-04-06 02:55:59 -0700 Comment on attachment 250198 Patch for landing Clearing flags on attachment: 250198 Committed r182388: <http://trac.webkit.org/changeset/182388> 1083066 9 zan 2015-04-06 02:56:07 -0700 All reviewed patches have been landed. Closing bug. 250149 2015-04-04 22:40:59 -0700 2015-04-05 00:27:29 -0700 Patch bug-143413-20150404224336.patch text/plain 1365 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjM1MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA0LTA0ICDFvWFuIERv YmVyxaFlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXSzJdIEFQSTo6QXJy YXk6OmNvcHkoKSBzaG91bGQgbW92ZSB0aGUgcmVzdWx0aW5nIFZlY3Rvcjw+IG9mIGNvcGllcyBp bnRvIHRoZSBBcnJheTo6Y3JlYXRlKCkgY2FsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNDEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL0FQSUFycmF5LmNwcDoKKyAgICAgICAg KEFQSTo6QXJyYXk6OmNvcHkpOiBNb3ZlIHRoZSBWZWN0b3I8PiBvYmplY3QgY29udGFpbmluZyB0 aGUgY29waWVkIGVsZW1lbnRzCisgICAgICAgIGludG8gdGhlIEFycmF5OjpjcmVhdGUoKSBjYWxs LCBhdm9pZGluZyBjb3B5aW5nIGFsbCB0aGUgZWxlbWVudHMgYWdhaW4uCisKIDIwMTUtMDQtMDQg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXVtDb2NvYV0g QWRkIGEgd2F5IHRvIHRlbXBvcmFyaWx5IGRpc2FibGUgdGhlIFdlYktpdCBOZXR3b3JrIENhY2hl IGZvciB0ZXN0aW5nCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0FQSUFycmF5LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0FQSUFycmF5LmNwcAko cmV2aXNpb24gMTgyMzUzKQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9BUElBcnJheS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTc1LDcgKzc1LDcgQEAgUmVmPEFQSTo6QXJyYXk+IEFycmF5 Ojpjb3B5KCkKICAgICBlbGVtZW50cy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KHNpemUpOwogICAg IGZvciAoY29uc3QgYXV0byYgZW50cnkgOiB0aGlzLT5lbGVtZW50cygpKQogICAgICAgICBlbGVt ZW50cy51bmNoZWNrZWRBcHBlbmQoZW50cnkpOwotICAgIHJldHVybiAqQXJyYXk6OmNyZWF0ZShl bGVtZW50cyk7CisgICAgcmV0dXJuICpBcnJheTo6Y3JlYXRlKFdURjo6bW92ZShlbGVtZW50cykp OwogfQogCiBBcnJheTo6QXJyYXkoVmVjdG9yPFJlZlB0cjxPYmplY3Q+PiBlbGVtZW50cykK 250151 2015-04-05 00:27:34 -0700 2015-04-05 00:31:14 -0700 Patch bug-143413-20150405003011.patch text/plain 2974 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjM1NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA0LTA1ICDFvWFuIERv YmVyxaFlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXSzJdIEFQSTo6QXJy YXk6OmNvcHkoKSBzaG91bGQgbW92ZSB0aGUgcmVzdWx0aW5nIFZlY3Rvcjw+IG9mIGNvcGllcyBp bnRvIHRoZSBBcnJheTo6Y3JlYXRlKCkgY2FsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNDEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0aGUgVmVjdG9yPD4gb2JqZWN0IGNvbnRhaW5pbmcg dGhlIGNvcGllZCBlbGVtZW50cyBpbnRvIHRoZSBBcnJheTo6Y3JlYXRlKCkKKyAgICAgICAgY2Fs bCwgYXZvaWRpbmcgY29weWluZyBhbGwgdGhlIGVsZW1lbnRzIGFnYWluLgorCisgICAgICAgIFdo aWxlIGhlcmUsIGNoYW5nZSB0aGUgVmVjdG9yPD4gcGFyYW1ldGVycyBmb3IgQXJyYXk6OmNyZWF0 ZSgpIGFuZCB0aGUgQXJyYXkKKyAgICAgICAgY29uc3RydWN0b3IgdG8gcnZhbHVlIHJlZmVyZW5j ZXMuIFRoaXMgd2lsbCBlbnN1cmUgdGhhdCB0aGUgcGFzc2VkLWluIG9iamVjdAorICAgICAgICBp cyBtb3ZlZCBpbnRvIHRoZSBBcnJheTo6Y3JlYXRlKCkgY2FsbCBpZiBwb3NzaWJsZSwgb3IgZXhw bGljaXRseSBjb3BpZWQKKyAgICAgICAgb3RoZXJ3aXNlLgorCisgICAgICAgICogU2hhcmVkL0FQ SS9BUElBcnJheS5jcHA6CisgICAgICAgIChBUEk6OkFycmF5OjpjcmVhdGUpOgorICAgICAgICAo QVBJOjpBcnJheTo6Y29weSk6CisgICAgICAgIChBUEk6OkFycmF5OjpBcnJheSk6CisgICAgICAg ICogU2hhcmVkL0FQSS9BUElBcnJheS5oOgorCiAyMDE1LTA0LTA0ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl1bQ29jb2FdIEFkZCBhIHdheSB0byB0ZW1w b3JhcmlseSBkaXNhYmxlIHRoZSBXZWJLaXQgTmV0d29yayBDYWNoZSBmb3IgdGVzdGluZwpJbmRl eDogU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9BUElBcnJheS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9BUElBcnJheS5jcHAJKHJldmlzaW9uIDE4MjM1MykK KysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQVBJQXJyYXkuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zNSw3ICszNSw3IEBAIFBhc3NSZWZQdHI8QXJyYXk+IEFycmF5OjpjcmVhdGUoKQogICAg IHJldHVybiBjcmVhdGUoVmVjdG9yPFJlZlB0cjxPYmplY3Q+PigpKTsKIH0KIAotUGFzc1JlZlB0 cjxBcnJheT4gQXJyYXk6OmNyZWF0ZShWZWN0b3I8UmVmUHRyPE9iamVjdD4+IGVsZW1lbnRzKQor UGFzc1JlZlB0cjxBcnJheT4gQXJyYXk6OmNyZWF0ZShWZWN0b3I8UmVmUHRyPE9iamVjdD4+JiYg ZWxlbWVudHMpCiB7CiAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQXJyYXkoV1RGOjptb3ZlKGVs ZW1lbnRzKSkpOwogfQpAQCAtNzUsMTAgKzc1LDExIEBAIFJlZjxBUEk6OkFycmF5PiBBcnJheTo6 Y29weSgpCiAgICAgZWxlbWVudHMucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShzaXplKTsKICAgICBm b3IgKGNvbnN0IGF1dG8mIGVudHJ5IDogdGhpcy0+ZWxlbWVudHMoKSkKICAgICAgICAgZWxlbWVu dHMudW5jaGVja2VkQXBwZW5kKGVudHJ5KTsKLSAgICByZXR1cm4gKkFycmF5OjpjcmVhdGUoZWxl bWVudHMpOworICAgIC8vIEZJWE1FOiBKdXN0IGNvcHkgdGhpcy0+ZWxlbWVudHMoKSA/CisgICAg cmV0dXJuICpBcnJheTo6Y3JlYXRlKFdURjo6bW92ZShlbGVtZW50cykpOwogfQogCi1BcnJheTo6 QXJyYXkoVmVjdG9yPFJlZlB0cjxPYmplY3Q+PiBlbGVtZW50cykKK0FycmF5OjpBcnJheShWZWN0 b3I8UmVmUHRyPE9iamVjdD4+JiYgZWxlbWVudHMpCiAgICAgOiBtX2VsZW1lbnRzKFdURjo6bW92 ZShlbGVtZW50cykpCiB7CiB9CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0FQSUFy cmF5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9BUElBcnJheS5o CShyZXZpc2lvbiAxODIzNTMpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0FQSUFycmF5 LmgJKHdvcmtpbmcgY29weSkKQEAgLTUyLDcgKzUyLDcgQEAgcHJpdmF0ZToKIAogcHVibGljOgog ICAgIHN0YXRpYyBQYXNzUmVmUHRyPEFycmF5PiBjcmVhdGUoKTsKLSAgICBzdGF0aWMgUGFzc1Jl ZlB0cjxBcnJheT4gY3JlYXRlKFZlY3RvcjxSZWZQdHI8T2JqZWN0Pj4gZWxlbWVudHMpOworICAg IHN0YXRpYyBQYXNzUmVmUHRyPEFycmF5PiBjcmVhdGUoVmVjdG9yPFJlZlB0cjxPYmplY3Q+PiYm IGVsZW1lbnRzKTsKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxBcnJheT4gY3JlYXRlU3RyaW5nQXJy YXkoY29uc3QgVmVjdG9yPFdURjo6U3RyaW5nPiYpOwogICAgIFZlY3RvcjxXVEY6OlN0cmluZz4g dG9TdHJpbmdWZWN0b3IoKTsKICAgICBSZWY8QXJyYXk+IGNvcHkoKTsKQEAgLTg1LDcgKzg1LDcg QEAgcHVibGljOgogCiAKIHByaXZhdGU6Ci0gICAgZXhwbGljaXQgQXJyYXkoVmVjdG9yPFJlZlB0 cjxPYmplY3Q+PiBlbGVtZW50cyk7CisgICAgZXhwbGljaXQgQXJyYXkoVmVjdG9yPFJlZlB0cjxP YmplY3Q+PiYmIGVsZW1lbnRzKTsKIAogICAgIFZlY3RvcjxSZWZQdHI8T2JqZWN0Pj4gbV9lbGVt ZW50czsKIH07Cg== 250152 2015-04-05 00:31:21 -0700 2015-04-06 02:03:51 -0700 Patch bug-143413-20150405003358.patch text/plain 2930 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjM1NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE1LTA0LTA1ICDFvWFuIERv YmVyxaFlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXSzJdIEFQSTo6QXJy YXk6OmNvcHkoKSBzaG91bGQgbW92ZSB0aGUgcmVzdWx0aW5nIFZlY3Rvcjw+IG9mIGNvcGllcyBp bnRvIHRoZSBBcnJheTo6Y3JlYXRlKCkgY2FsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNDEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTW92ZSB0aGUgVmVjdG9yPD4gb2JqZWN0IGNvbnRhaW5pbmcg dGhlIGNvcGllZCBlbGVtZW50cyBpbnRvIHRoZSBBcnJheTo6Y3JlYXRlKCkKKyAgICAgICAgY2Fs bCwgYXZvaWRpbmcgY29weWluZyBhbGwgdGhlIGVsZW1lbnRzIGFnYWluLgorCisgICAgICAgIFdo aWxlIGhlcmUsIGNoYW5nZSB0aGUgVmVjdG9yPD4gcGFyYW1ldGVycyBmb3IgQXJyYXk6OmNyZWF0 ZSgpIGFuZCB0aGUgQXJyYXkKKyAgICAgICAgY29uc3RydWN0b3IgdG8gcnZhbHVlIHJlZmVyZW5j ZXMuIFRoaXMgd2lsbCBlbnN1cmUgdGhhdCB0aGUgcGFzc2VkLWluIG9iamVjdAorICAgICAgICBp cyBtb3ZlZCBpbnRvIHRoZSBBcnJheTo6Y3JlYXRlKCkgY2FsbCBpZiBwb3NzaWJsZSwgb3IgZXhw bGljaXRseSBjb3BpZWQKKyAgICAgICAgb3RoZXJ3aXNlLgorCisgICAgICAgICogU2hhcmVkL0FQ SS9BUElBcnJheS5jcHA6CisgICAgICAgIChBUEk6OkFycmF5OjpjcmVhdGUpOgorICAgICAgICAo QVBJOjpBcnJheTo6Y29weSk6CisgICAgICAgIChBUEk6OkFycmF5OjpBcnJheSk6CisgICAgICAg ICogU2hhcmVkL0FQSS9BUElBcnJheS5oOgorCiAyMDE1LTA0LTA0ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl1bQ29jb2FdIEFkZCBhIHdheSB0byB0ZW1w b3JhcmlseSBkaXNhYmxlIHRoZSBXZWJLaXQgTmV0d29yayBDYWNoZSBmb3IgdGVzdGluZwpJbmRl eDogU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9BUElBcnJheS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9BUElBcnJheS5jcHAJKHJldmlzaW9uIDE4MjM1NSkK KysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQVBJQXJyYXkuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zNSw3ICszNSw3IEBAIFBhc3NSZWZQdHI8QXJyYXk+IEFycmF5OjpjcmVhdGUoKQogICAg IHJldHVybiBjcmVhdGUoVmVjdG9yPFJlZlB0cjxPYmplY3Q+PigpKTsKIH0KIAotUGFzc1JlZlB0 cjxBcnJheT4gQXJyYXk6OmNyZWF0ZShWZWN0b3I8UmVmUHRyPE9iamVjdD4+IGVsZW1lbnRzKQor UGFzc1JlZlB0cjxBcnJheT4gQXJyYXk6OmNyZWF0ZShWZWN0b3I8UmVmUHRyPE9iamVjdD4+JiYg ZWxlbWVudHMpCiB7CiAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgQXJyYXkoV1RGOjptb3ZlKGVs ZW1lbnRzKSkpOwogfQpAQCAtNzUsMTAgKzc1LDEwIEBAIFJlZjxBUEk6OkFycmF5PiBBcnJheTo6 Y29weSgpCiAgICAgZWxlbWVudHMucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShzaXplKTsKICAgICBm b3IgKGNvbnN0IGF1dG8mIGVudHJ5IDogdGhpcy0+ZWxlbWVudHMoKSkKICAgICAgICAgZWxlbWVu dHMudW5jaGVja2VkQXBwZW5kKGVudHJ5KTsKLSAgICByZXR1cm4gKkFycmF5OjpjcmVhdGUoZWxl bWVudHMpOworICAgIHJldHVybiAqQXJyYXk6OmNyZWF0ZShXVEY6Om1vdmUoZWxlbWVudHMpKTsK IH0KIAotQXJyYXk6OkFycmF5KFZlY3RvcjxSZWZQdHI8T2JqZWN0Pj4gZWxlbWVudHMpCitBcnJh eTo6QXJyYXkoVmVjdG9yPFJlZlB0cjxPYmplY3Q+PiYmIGVsZW1lbnRzKQogICAgIDogbV9lbGVt ZW50cyhXVEY6Om1vdmUoZWxlbWVudHMpKQogewogfQpJbmRleDogU291cmNlL1dlYktpdDIvU2hh cmVkL0FQSS9BUElBcnJheS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9B UEkvQVBJQXJyYXkuaAkocmV2aXNpb24gMTgyMzU1KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVk L0FQSS9BUElBcnJheS5oCSh3b3JraW5nIGNvcHkpCkBAIC01Miw3ICs1Miw3IEBAIHByaXZhdGU6 CiAKIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxBcnJheT4gY3JlYXRlKCk7Ci0gICAg c3RhdGljIFBhc3NSZWZQdHI8QXJyYXk+IGNyZWF0ZShWZWN0b3I8UmVmUHRyPE9iamVjdD4+IGVs ZW1lbnRzKTsKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxBcnJheT4gY3JlYXRlKFZlY3RvcjxSZWZQ dHI8T2JqZWN0Pj4mJiBlbGVtZW50cyk7CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8QXJyYXk+IGNy ZWF0ZVN0cmluZ0FycmF5KGNvbnN0IFZlY3RvcjxXVEY6OlN0cmluZz4mKTsKICAgICBWZWN0b3I8 V1RGOjpTdHJpbmc+IHRvU3RyaW5nVmVjdG9yKCk7CiAgICAgUmVmPEFycmF5PiBjb3B5KCk7CkBA IC04NSw3ICs4NSw3IEBAIHB1YmxpYzoKIAogCiBwcml2YXRlOgotICAgIGV4cGxpY2l0IEFycmF5 KFZlY3RvcjxSZWZQdHI8T2JqZWN0Pj4gZWxlbWVudHMpOworICAgIGV4cGxpY2l0IEFycmF5KFZl Y3RvcjxSZWZQdHI8T2JqZWN0Pj4mJiBlbGVtZW50cyk7CiAKICAgICBWZWN0b3I8UmVmUHRyPE9i amVjdD4+IG1fZWxlbWVudHM7CiB9Owo= 250198 2015-04-06 02:03:59 -0700 2015-04-06 02:03:59 -0700 Patch for landing bug-143413-20150406020636.patch text/plain 3125 zan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjM4NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE1LTA0LTA2ICDFvWFuIERv YmVyxaFlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtXSzJdIEFQSTo6QXJy YXk6OmNvcHkoKSBzaG91bGQgbW92ZSB0aGUgcmVzdWx0aW5nIFZlY3Rvcjw+IG9mIGNvcGllcyBp bnRvIHRoZSBBcnJheTo6Y3JlYXRlKCkgY2FsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNDEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCisKKyAgICAgICAgTW92ZSB0aGUgVmVjdG9yPD4gb2JqZWN0IGNvbnRhaW5pbmcgdGhl IGNvcGllZCBlbGVtZW50cyBpbnRvIHRoZSBBcnJheTo6Y3JlYXRlKCkKKyAgICAgICAgY2FsbCwg YXZvaWRpbmcgY29weWluZyBhbGwgdGhlIGVsZW1lbnRzIGFnYWluLgorCisgICAgICAgIFdoaWxl IGhlcmUsIGNoYW5nZSB0aGUgVmVjdG9yPD4gcGFyYW1ldGVycyBmb3IgQXJyYXk6OmNyZWF0ZSgp IGFuZCB0aGUgQXJyYXkKKyAgICAgICAgY29uc3RydWN0b3IgdG8gcnZhbHVlIHJlZmVyZW5jZXMu IFRoaXMgd2lsbCBlbnN1cmUgdGhhdCB0aGUgcGFzc2VkLWluIG9iamVjdAorICAgICAgICBpcyBt b3ZlZCBpbnRvIHRoZSBBcnJheTo6Y3JlYXRlKCkgY2FsbCBpZiBwb3NzaWJsZSwgb3IgZXhwbGlj aXRseSBjb3BpZWQKKyAgICAgICAgb3RoZXJ3aXNlLiBUaGUgY29uc3RydWN0b3IgaXMgbW92ZWQg aW50byB0aGUgaGVhZGVyIGZvciBpbmxpbmluZyBvcHBvcnR1bml0aWVzCisgICAgICAgIGFuZCB0 aGUgdW5uZWNlc3NhcnkgcGFyYW1ldGVyIGluIHRoZSBjcmVhdGUoVmVjdG9yPD4mJikgbWV0aG9k IGRlY2xhcmF0aW9uCisgICAgICAgIHJlbW92ZWQuCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL0FQ SUFycmF5LmNwcDoKKyAgICAgICAgKEFQSTo6QXJyYXk6OmNyZWF0ZSk6CisgICAgICAgIChBUEk6 OkFycmF5Ojpjb3B5KToKKyAgICAgICAgKEFQSTo6QXJyYXk6OkFycmF5KTogRGVsZXRlZC4KKyAg ICAgICAgKiBTaGFyZWQvQVBJL0FQSUFycmF5Lmg6CisKIDIwMTUtMDQtMDYgIMW9YW4gRG9iZXLF oWVrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgVXNlclNjcmlwdCwgVXNlclN0 eWxlU2hlZXQgY29uc3RydWN0b3JzIHNob3VsZCB0YWtlIGluIFZlY3RvcjxTdHJpbmc+IHJ2YWx1 ZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQVBJQXJyYXkuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQVBJQXJyYXkuY3BwCShyZXZpc2lvbiAx ODIzODQpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0FQSUFycmF5LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMzUsNyArMzUsNyBAQCBQYXNzUmVmUHRyPEFycmF5PiBBcnJheTo6Y3JlYXRl KCkKICAgICByZXR1cm4gY3JlYXRlKFZlY3RvcjxSZWZQdHI8T2JqZWN0Pj4oKSk7CiB9CiAKLVBh c3NSZWZQdHI8QXJyYXk+IEFycmF5OjpjcmVhdGUoVmVjdG9yPFJlZlB0cjxPYmplY3Q+PiBlbGVt ZW50cykKK1Bhc3NSZWZQdHI8QXJyYXk+IEFycmF5OjpjcmVhdGUoVmVjdG9yPFJlZlB0cjxPYmpl Y3Q+PiYmIGVsZW1lbnRzKQogewogICAgIHJldHVybiBhZG9wdFJlZigqbmV3IEFycmF5KFdURjo6 bW92ZShlbGVtZW50cykpKTsKIH0KQEAgLTc1LDEyICs3NSw3IEBAIFJlZjxBUEk6OkFycmF5PiBB cnJheTo6Y29weSgpCiAgICAgZWxlbWVudHMucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShzaXplKTsK ICAgICBmb3IgKGNvbnN0IGF1dG8mIGVudHJ5IDogdGhpcy0+ZWxlbWVudHMoKSkKICAgICAgICAg ZWxlbWVudHMudW5jaGVja2VkQXBwZW5kKGVudHJ5KTsKLSAgICByZXR1cm4gKkFycmF5OjpjcmVh dGUoZWxlbWVudHMpOwotfQotCi1BcnJheTo6QXJyYXkoVmVjdG9yPFJlZlB0cjxPYmplY3Q+PiBl bGVtZW50cykKLSAgICA6IG1fZWxlbWVudHMoV1RGOjptb3ZlKGVsZW1lbnRzKSkKLXsKKyAgICBy ZXR1cm4gKkFycmF5OjpjcmVhdGUoV1RGOjptb3ZlKGVsZW1lbnRzKSk7CiB9CiAKIEFycmF5Ojp+ QXJyYXkoKQpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9BUElBcnJheS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvQVBJQXJyYXkuaAkocmV2aXNpb24g MTgyMzg0KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9BUElBcnJheS5oCSh3b3JraW5n IGNvcHkpCkBAIC01Miw3ICs1Miw3IEBAIHByaXZhdGU6CiAKIHB1YmxpYzoKICAgICBzdGF0aWMg UGFzc1JlZlB0cjxBcnJheT4gY3JlYXRlKCk7Ci0gICAgc3RhdGljIFBhc3NSZWZQdHI8QXJyYXk+ IGNyZWF0ZShWZWN0b3I8UmVmUHRyPE9iamVjdD4+IGVsZW1lbnRzKTsKKyAgICBzdGF0aWMgUGFz c1JlZlB0cjxBcnJheT4gY3JlYXRlKFZlY3RvcjxSZWZQdHI8T2JqZWN0Pj4mJik7CiAgICAgc3Rh dGljIFBhc3NSZWZQdHI8QXJyYXk+IGNyZWF0ZVN0cmluZ0FycmF5KGNvbnN0IFZlY3RvcjxXVEY6 OlN0cmluZz4mKTsKICAgICBWZWN0b3I8V1RGOjpTdHJpbmc+IHRvU3RyaW5nVmVjdG9yKCk7CiAg ICAgUmVmPEFycmF5PiBjb3B5KCk7CkBAIC04NSw3ICs4NSwxMCBAQCBwdWJsaWM6CiAKIAogcHJp dmF0ZToKLSAgICBleHBsaWNpdCBBcnJheShWZWN0b3I8UmVmUHRyPE9iamVjdD4+IGVsZW1lbnRz KTsKKyAgICBleHBsaWNpdCBBcnJheShWZWN0b3I8UmVmUHRyPE9iamVjdD4+JiYgZWxlbWVudHMp CisgICAgICAgIDogbV9lbGVtZW50cyhXVEY6Om1vdmUoZWxlbWVudHMpKQorICAgIHsKKyAgICB9 CiAKICAgICBWZWN0b3I8UmVmUHRyPE9iamVjdD4+IG1fZWxlbWVudHM7CiB9Owo=