143361 2015-04-02 23:16:51 -0700 Fix the EFL and GTK build after r182243 2015-04-03 05:43:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 1 ossy zan achristensen commit-queue fpizlo ossy zan oldest_to_newest 1082468 0 ossy 2015-04-02 23:16:51 -0700 See https://bugs.webkit.org/show_bug.cgi?id=143293#c12 for details. The clean build is still broken. :( 1082497 1 zan 2015-04-03 02:59:19 -0700 I'll produce something. 1082509 2 250058 zan 2015-04-03 04:25:19 -0700 Created attachment 250058 Patch 1082511 3 commit-queue 2015-04-03 04:27:53 -0700 Attachment 250058 did not pass style-queue: ERROR: Source/WebKit2/PlatformGTK.cmake:425: There should be exactly one empty line instead of 0 between "" <file alias=\"images/panIcon\">panIcon.png</file>\n"" and "" <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n"". [list/emptyline] [5] ERROR: Source/WebKit2/PlatformGTK.cmake:426: Alphabetical sorting problem. "" <file alias=\"images/textAreaResizeCorner@2x\">textAreaResizeCorner@2x.png</file>\n"" should be before "" <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n"". [list/order] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1082512 4 zan 2015-04-03 04:33:10 -0700 (In reply to comment #2) > Created attachment 250058 [details] > Patch Fixes clean builds for the GTK port. EFL fix is speculative, so please test it out. 1082513 5 ossy 2015-04-03 04:34:31 -0700 (In reply to comment #4) > (In reply to comment #2) > > Created attachment 250058 [details] > > Patch > > Fixes clean builds for the GTK port. EFL fix is speculative, so please test > it out. Thanks for the fix, I'll check it immediately. 1082516 6 250058 ossy 2015-04-03 04:45:24 -0700 Comment on attachment 250058 Patch It works on EFL too, so r=me. 1082527 7 250058 zan 2015-04-03 05:23:55 -0700 Comment on attachment 250058 Patch Clearing flags on attachment: 250058 Committed r182315: <http://trac.webkit.org/changeset/182315> 1082528 8 zan 2015-04-03 05:24:05 -0700 All reviewed patches have been landed. Closing bug. 1082534 9 250058 gyuyoung.kim 2015-04-03 05:43:50 -0700 Comment on attachment 250058 Patch Thank you for the fix ! 250058 2015-04-03 04:25:19 -0700 2015-04-03 05:23:55 -0700 Patch bug-143361-20150403042756.patch text/plain 5864 zan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjMx MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA0 LTAzICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBGaXgg dGhlIEVGTCBhbmQgR1RLIGJ1aWxkIGFmdGVyIHIxODIyNDMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzM2MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL1BsYXRmb3JtRWZsLmNtYWtlOiBB ZGQgYSBjdXN0b20gY29tbWFuZCB0aGF0IGNvcGllcworICAgICAgICB0aGUgSW5zcGVjdG9yQmFj a2VuZENvbW1hbmRzLmpzIGZpbGUgaW50byB0aGUgcHJvcGVyIGRpcmVjdG9yeQorICAgICAgICB1 bmRlciBEZXJpdmVkU291cmNlcy9XZWJJbnNwZWN0b3JVSS8uCisKIDIwMTUtMDQtMDEgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBQcm9ncmVz cyB0b3dhcmRzIENNYWtlIG9uIFdpbmRvd3MgYW5kIE1hYy4KSW5kZXg6IFNvdXJjZS9QbGF0Zm9y bUVmbC5jbWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvUGxhdGZvcm1FZmwuY21ha2UJKHJldmlz aW9uIDE4MjMxMikKKysrIFNvdXJjZS9QbGF0Zm9ybUVmbC5jbWFrZQkod29ya2luZyBjb3B5KQpA QCAtMSwxMiArMSwyMCBAQAogYWRkX3N1YmRpcmVjdG9yeSgke1dFQkNPUkVfRElSfS9wbGF0Zm9y bS9lZmwvRGVmYXVsdFRoZW1lKQogCisjIERlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMuanMgaXMKKyMgZXhwZWN0ZWQgaW4gRGVy aXZlZFNvdXJjZXMvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC8uCithZGRf Y3VzdG9tX2NvbW1hbmQoCisgICAgT1VUUFVUICR7REVSSVZFRF9TT1VSQ0VTX1dFQklOU1BFQ1RP UlVJX0RJUn0vVXNlckludGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMu anMKKyAgICBERVBFTkRTICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vaW5z cGVjdG9yL0luc3BlY3RvckJhY2tlbmRDb21tYW5kcy5qcworICAgIENPTU1BTkQgY3AgJHtERVJJ VkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9pbnNwZWN0b3IvSW5zcGVjdG9yQmFja2Vu ZENvbW1hbmRzLmpzICR7REVSSVZFRF9TT1VSQ0VTX1dFQklOU1BFQ1RPUlVJX0RJUn0vVXNlcklu dGVyZmFjZS9Qcm90b2NvbC9JbnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMuanMKKykKKwogYWRkX2N1 c3RvbV90YXJnZXQoCiAgICAgd2ViLWluc3BlY3Rvci1yZXNvdXJjZXMgQUxMCiAgICAgQ09NTUFO RCAke0NNQUtFX0NPTU1BTkR9IC1FIGNvcHlfZGlyZWN0b3J5ICR7V0VCSU5TUEVDVE9SVUlfRElS fS9Vc2VySW50ZXJmYWNlICR7V0VCX0lOU1BFQ1RPUl9ESVJ9CiAgICAgQ09NTUFORCAke0NNQUtF X0NPTU1BTkR9IC1FIGNvcHkgJHtERVJJVkVEX1NPVVJDRVNfV0VCSU5TUEVDVE9SVUlfRElSfS9V c2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJhY2tlbmRDb21tYW5kcy5qcyAke1dFQl9J TlNQRUNUT1JfRElSfS9Qcm90b2NvbAogICAgIENPTU1BTkQgJHtDTUFLRV9DT01NQU5EfSAtRSBj b3B5ICR7V0VCSU5TUEVDVE9SVUlfRElSfS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXpl ZFN0cmluZ3MuanMgJHtXRUJfSU5TUEVDVE9SX0RJUn0KICAgICBDT01NQU5EICR7Q01BS0VfQ09N TUFORH0gLUUgY29weSAke1dFQktJVDJfRElSfS9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL2Zy b250LWVuZC9pbnNwZWN0b3JQYWdlSW5kZXguaHRtbCAke1dFQl9JTlNQRUNUT1JfRElSfQotICAg IERFUEVORFMgSmF2YVNjcmlwdENvcmUgV2ViQ29yZQorICAgIERFUEVORFMgSmF2YVNjcmlwdENv cmUgV2ViQ29yZSAke0RFUklWRURfU09VUkNFU19XRUJJTlNQRUNUT1JVSV9ESVJ9L1VzZXJJbnRl cmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLmpzCiAgICAgV09SS0lOR19E SVJFQ1RPUlkgJHtDTUFLRV9CSU5BUllfRElSfQogKQogaW5zdGFsbChESVJFQ1RPUlkgIiR7Q01B S0VfQklOQVJZX0RJUn0vJHtXRUJfSU5TUEVDVE9SX0RJUn0iCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cJKHJldmlzaW9uIDE4MjMxMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNS0wNC0wMyAgWmFuIERv YmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IHRoZSBFRkwgYW5k IEdUSyBidWlsZCBhZnRlciByMTgyMjQzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDMzNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OiBJbnNwZWN0b3JCYWNrZW5kQ29tbWFu ZHMuanMgaXMgZ2VuZXJhdGVkIGluIHRoZQorICAgICAgICBEZXJpdmVkU291cmNlcy9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvIGRpcmVjdG9yeS4KKwogMjAxNS0wNC0wMiAgTWFyayBMYW0gIDxt YXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRW5oYW5jZSBhYmlsaXR5IHRvIGR1bXAgSlND IE9wdGlvbnMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CShyZXZpc2lv biAxODIzMTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQJKHdvcmtp bmcgY29weSkKQEAgLTEwODgsNyArMTA4OCw3IEBAIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICAg ICAgICAgJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9pbnNwZWN0b3IvSW5z cGVjdG9yRnJvbnRlbmREaXNwYXRjaGVycy5oCiAgICAgICAgICAgICR7REVSSVZFRF9TT1VSQ0VT X0pBVkFTQ1JJUFRDT1JFX0RJUn0vaW5zcGVjdG9yL0luc3BlY3RvclByb3RvY29sT2JqZWN0cy5j cHAKICAgICAgICAgICAgJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9pbnNw ZWN0b3IvSW5zcGVjdG9yUHJvdG9jb2xPYmplY3RzLmgKLSAgICAgICAgICAgJHtERVJJVkVEX1NP VVJDRVNfV0VCSU5TUEVDVE9SVUlfRElSfS9pbnNwZWN0b3IvSW5zcGVjdG9yQmFja2VuZENvbW1h bmRzLmpzCisgICAgICAgICAgICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0v aW5zcGVjdG9yL0luc3BlY3RvckJhY2tlbmRDb21tYW5kcy5qcwogICAgIE1BSU5fREVQRU5ERU5D WSAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L0NvbWJpbmVkRG9tYWlucy5q c29uCiAgICAgREVQRU5EUyAke0phdmFTY3JpcHRDb3JlX0lOU1BFQ1RPUl9QUk9UT0NPTF9TQ1JJ UFRTfQogICAgIENPTU1BTkQgJHtQWVRIT05fRVhFQ1VUQUJMRX0gJHtKYXZhU2NyaXB0Q29yZV9J TlNQRUNUT1JfU0NSSVBUU19ESVJ9L2dlbmVyYXRlLWluc3BlY3Rvci1wcm90b2NvbC1iaW5kaW5n cy5weSAtLW91dHB1dERpciAiJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfS9p bnNwZWN0b3IiIC0tZnJhbWV3b3JrIEphdmFTY3JpcHRDb3JlICR7REVSSVZFRF9TT1VSQ0VTX0pB VkFTQ1JJUFRDT1JFX0RJUn0vQ29tYmluZWREb21haW5zLmpzb24KSW5kZXg6IFNvdXJjZS9XZWJL aXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MjMxMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTA0LTAzICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtA aWdhbGlhLmNvbT4KKworICAgICAgICBGaXggdGhlIEVGTCBhbmQgR1RLIGJ1aWxkIGFmdGVyIHIx ODIyNDMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 MzM2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog UGxhdGZvcm1HVEsuY21ha2U6IEFkZCBhIGN1c3RvbSBjb21tYW5kIHRoYXQgY29waWVzIHRoZQor ICAgICAgICBJbnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMuanMgZmlsZSBpbnRvIHRoZSBwcm9wZXIg ZGlyZWN0b3J5CisgICAgICAgIHVuZGVyIERlcml2ZWRTb3VyY2VzL1dlYkluc3BlY3RvclVJLy4K KwogMjAxNS0wNC0wMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgR1RLIGJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1BsYXRmb3JtR1RLLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3Jt R1RLLmNtYWtlCShyZXZpc2lvbiAxODIzMTIpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdU Sy5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtNDIyLDYgKzQyMiwxNCBAQCBmaWxlKEdMT0IgSW5z cGVjdG9yRmlsZXMKICAgICAke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL0ltYWdlcy9ndGsvKi5zdmcKICkKIAorIyBEZXJpdmVkU291cmNlcy9K YXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQmFja2VuZENvbW1hbmRzLmpzIGlzCisj IGV4cGVjdGVkIGluIERlcml2ZWRTb3VyY2VzL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv UHJvdG9jb2wvLgorYWRkX2N1c3RvbV9jb21tYW5kKAorICAgIE9VVFBVVCAke0RFUklWRURfU09V UkNFU19XRUJJTlNQRUNUT1JVSV9ESVJ9L1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9y QmFja2VuZENvbW1hbmRzLmpzCisgICAgREVQRU5EUyAke0RFUklWRURfU09VUkNFU19KQVZBU0NS SVBUQ09SRV9ESVJ9L2luc3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMuanMKKyAgICBD T01NQU5EIGNwICR7REVSSVZFRF9TT1VSQ0VTX0pBVkFTQ1JJUFRDT1JFX0RJUn0vaW5zcGVjdG9y L0luc3BlY3RvckJhY2tlbmRDb21tYW5kcy5qcyAke0RFUklWRURfU09VUkNFU19XRUJJTlNQRUNU T1JVSV9ESVJ9L1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yQmFja2VuZENvbW1hbmRz LmpzCispCisKIGxpc3QoQVBQRU5EIEluc3BlY3RvckZpbGVzCiAgICAgJHtDTUFLRV9TT1VSQ0Vf RElSfS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6 ZWRTdHJpbmdzLmpzCiAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCSU5TUEVDVE9SVUlfRElSfS9V c2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJhY2tlbmRDb21tYW5kcy5qcwo=