143334 2015-04-02 06:42:31 -0700 Remove unnecessary ASSERT from XMLDocumentParser::notifyFinished() 2022-08-14 13:49:20 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 rgabor webkit-unassigned ahmad.saleem792 ap beidson bfulgham cdumez darin koivisto rniwa oldest_to_newest 1082217 0 rgabor 2015-04-02 06:42:31 -0700 Remove the ASSERT(m_pendingScript->accessCount() > 0) because if the MemoryCache is disabled then we never icrease the accessCount. 1082218 1 249976 rgabor 2015-04-02 06:50:55 -0700 Created attachment 249976 proposed patch 1082458 2 249976 ap 2015-04-02 22:15:53 -0700 Comment on attachment 249976 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=249976&action=review > Source/WebCore/ChangeLog:9 > + Remove the ASSERT(m_pendingScript->accessCount() > 0) because if the MemoryCache is disabled > + then we never icrease the accessCount. Is it unnecessary, or incorrect? 1082503 3 rgabor 2015-04-03 03:46:21 -0700 (In reply to comment #2) > Comment on attachment 249976 [details] > proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249976&action=review > > > Source/WebCore/ChangeLog:9 > > + Remove the ASSERT(m_pendingScript->accessCount() > 0) because if the MemoryCache is disabled > > + then we never icrease the accessCount. > > Is it unnecessary, or incorrect? Well, maybe incorrect is a better word for it. I'm not sure whether we should change the assert or just remove it. 1086081 4 249976 cdumez 2015-04-16 14:53:27 -0700 Comment on attachment 249976 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=249976&action=review Couldn't we have a layout test for this by exposing MemoryCache::setDisabled() via Internals? > Source/WebCore/xml/parser/XMLDocumentParser.cpp:-226 > - ASSERT(m_pendingScript->accessCount() > 0); Maybe ASSERT(m_pendingScript->accessCount() > 0 || MemoryCache::singleton().disabled()); then? 1300813 5 249976 beidson 2017-04-24 19:06:51 -0700 Comment on attachment 249976 proposed patch This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant. 1888901 6 ahmad.saleem792 2022-08-04 10:28:51 -0700 >> ap@webkit.org - is this required? https://github.com/WebKit/WebKit/blob/1ffe018f5d5cd17e88f1a34ee7a62d47290ed07d/Source/WebCore/xml/parser/XMLDocumentParser.cpp#L227 Seems like m_pendingScript is now changed to nullptr and it does not asset. Thanks! 1891254 7 ap 2022-08-14 13:49:20 -0700 There is no such assertion in XMLDocumentParser::notifyFinished any more. 249976 2015-04-02 06:50:55 -0700 2017-04-24 19:07:58 -0700 proposed patch assert.patch text/plain 1435 rgabor ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5OWVhOWFjLi5jYjZkZTM2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE1LTA0LTAyICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgQVNTRVJUIGZyb20gWE1MRG9jdW1lbnRQYXJzZXI6 Om5vdGlmeUZpbmlzaGVkKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDMzMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW1vdmUgdGhlIEFTU0VSVChtX3BlbmRpbmdTY3JpcHQtPmFjY2Vzc0NvdW50 KCkgPiAwKSBiZWNhdXNlIGlmIHRoZSBNZW1vcnlDYWNoZSBpcyBkaXNhYmxlZAorICAgICAgICB0 aGVuIHdlIG5ldmVyIGljcmVhc2UgdGhlIGFjY2Vzc0NvdW50LgorCisgICAgICAgICogeG1sL3Bh cnNlci9YTUxEb2N1bWVudFBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxEb2N1bWVu dFBhcnNlcjo6bm90aWZ5RmluaXNoZWQpOgorCiAyMDE1LTA0LTAyICBKb29uZ2h1biBQYXJrICA8 amg3MTgucGFya0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbQ1NTIE11bHRpQ29sdW1uXSBQYXJz ZSAiY29sdW1uczogYXV0byA8bGVuZ3RoPiIgc2hvcnRoYW5kIHByb3BlcnR5IHZhbHVlIHByb3Bl cmx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvcGFyc2VyL1hNTERvY3VtZW50UGFy c2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3htbC9wYXJzZXIvWE1MRG9jdW1lbnRQYXJzZXIuY3Bw CmluZGV4IGY1NWE2MTUuLmQ0OWM0YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9w YXJzZXIvWE1MRG9jdW1lbnRQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9wYXJz ZXIvWE1MRG9jdW1lbnRQYXJzZXIuY3BwCkBAIC0yMjMsNyArMjIzLDYgQEAgdm9pZCBYTUxEb2N1 bWVudFBhcnNlcjo6aW5zZXJ0RXJyb3JNZXNzYWdlQmxvY2soKQogdm9pZCBYTUxEb2N1bWVudFBh cnNlcjo6bm90aWZ5RmluaXNoZWQoQ2FjaGVkUmVzb3VyY2UqIHVudXNlZFJlc291cmNlKQogewog ICAgIEFTU0VSVF9VTlVTRUQodW51c2VkUmVzb3VyY2UsIHVudXNlZFJlc291cmNlID09IG1fcGVu ZGluZ1NjcmlwdCk7Ci0gICAgQVNTRVJUKG1fcGVuZGluZ1NjcmlwdC0+YWNjZXNzQ291bnQoKSA+ IDApOwogCiAgICAgU2NyaXB0U291cmNlQ29kZSBzb3VyY2VDb2RlKG1fcGVuZGluZ1NjcmlwdC5n ZXQoKSk7CiAgICAgYm9vbCBlcnJvck9jY3VycmVkID0gbV9wZW5kaW5nU2NyaXB0LT5lcnJvck9j Y3VycmVkKCk7Cg==