143322 2015-04-01 15:35:29 -0700 Media controls should not always auto-hide 2015-04-02 06:55:27 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer oldest_to_newest 1082122 0 eric.carlson 2015-04-01 15:35:29 -0700 Don't hide controls for an <audio> element, when playing to an external device, or for optimized fullscreen. 1082127 1 eric.carlson 2015-04-01 15:43:41 -0700 <rdar://problem/20013740> 1082129 2 webkit-bug-importer 2015-04-01 15:44:24 -0700 <rdar://problem/20391156> 1082136 3 249951 eric.carlson 2015-04-01 16:11:00 -0700 Created attachment 249951 Proposed patch 1082138 4 249951 dino 2015-04-01 16:32:52 -0700 Comment on attachment 249951 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=249951&action=review > Source/WebCore/ChangeLog:15 > + and video.webkitWirelessVideoPlaybackDisabled because know when they change and use them Typo: because *we* know > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:18 > + this.currrentTargetIsWireless = false; Typo: currrent 1082140 5 eric.carlson 2015-04-01 16:46:05 -0700 (In reply to comment #4) > Comment on attachment 249951 [details] > Proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249951&action=review > > > Source/WebCore/ChangeLog:15 > > + and video.webkitWirelessVideoPlaybackDisabled because know when they change and use them > > Typo: because *we* know > Fixed. > > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:18 > > + this.currrentTargetIsWireless = false; > > Typo: currrent > Fixed. Thanks! 1082141 6 eric.carlson 2015-04-01 16:46:30 -0700 Committed r182262: https://trac.webkit.org/r182262 249951 2015-04-01 16:11:00 -0700 2015-04-02 06:55:27 -0700 Proposed patch controls_always_visible_patch_1.txt text/plain 4593 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjI1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE1LTA0LTAxICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1lZGlhIGNvbnRyb2xz IHNob3VsZCBub3QgYWx3YXlzIGF1dG8taGlkZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMzIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9s c0FwcGxlLmpzOgorICAgICAgICAoQ29udHJvbGxlcik6IEludGlhbGl6ZSBuZXcgcHJvcGVydGll cy4KKyAgICAgICAgKENvbnRyb2xsZXIucHJvdG90eXBlLmhpZGVDb250cm9scyk6IERvIG5vdGhp bmcgaWYgY29udHJvbHNBbHdheXNWaXNpYmxlKCkgcmV0dXJucyB0cnVlOworICAgICAgICAoQ29u dHJvbGxlci5wcm90b3R5cGUuY29udHJvbHNBbHdheXNWaXNpYmxlKTogTmV3LgorICAgICAgICAo Q29udHJvbGxlci5wcm90b3R5cGUuY29udHJvbHNBcmVIaWRkZW4pOiBDb25zdWx0IGNvbnRyb2xz QWx3YXlzVmlzaWJsZSgpLgorICAgICAgICAoQ29udHJvbGxlci5wcm90b3R5cGUuY3VycmVudFBs YXliYWNrVGFyZ2V0SXNXaXJlbGVzcyk6IFVzZSBuZXcgcHJvcGVydGllcy4KKyAgICAgICAgKENv bnRyb2xsZXIucHJvdG90eXBlLnVwZGF0ZVdpcmVsZXNzVGFyZ2V0QXZhaWxhYmxlKTogQ2FjaGUg dmlkZW8ud2Via2l0Q3VycmVudFBsYXliYWNrVGFyZ2V0SXNXaXJlbGVzcworICAgICAgICAgICAg YW5kIHZpZGVvLndlYmtpdFdpcmVsZXNzVmlkZW9QbGF5YmFja0Rpc2FibGVkIGJlY2F1c2Uga25v dyB3aGVuIHRoZXkgY2hhbmdlIGFuZCB1c2UgdGhlbQorICAgICAgICAgICAgZnJlcXVlbnRseS4K KyAgICAgICAgKiBNb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lPUy5qczoKKyAg ICAgICAgKENvbnRyb2xsZXJJT1MucHJvdG90eXBlLmNvbnRyb2xzQWx3YXlzVmlzaWJsZSk6IE5l dy4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXliYWNrVGFyZ2V0Lmg6CisK IDIwMTUtMDQtMDEgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTiAocjE4MjEyMSk6IFNWRyBhbmltYXRpb24gbWFjcm9zIGNhdXNlIHdhcm5p bmdzIGluIE1TVkMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9t ZWRpYUNvbnRyb2xzQXBwbGUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvTW9kdWxl cy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qcwkocmV2aXNpb24gMTgyMjQ0KQor KysgU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBs ZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMTUsNiArMTUsOCBAQCBmdW5jdGlvbiBDb250cm9sbGVy KHJvb3QsIHZpZGVvLCBob3N0KQogICAgIHRoaXMuaGFzVmlzdWFsTWVkaWEgPSBmYWxzZTsKICAg ICB0aGlzLmhhc1dpcmVsZXNzUGxheWJhY2tUYXJnZXRzID0gZmFsc2U7CiAgICAgdGhpcy5pc0xp c3RlbmluZ0ZvclBsYXliYWNrVGFyZ2V0QXZhaWxhYmlsaXR5RXZlbnQgPSBmYWxzZTsKKyAgICB0 aGlzLmN1cnJyZW50VGFyZ2V0SXNXaXJlbGVzcyA9IGZhbHNlOworICAgIHRoaXMud2lyZWxlc3NQ bGF5YmFja0Rpc2FibGVkID0gZmFsc2U7CiAKICAgICB0aGlzLmFkZFZpZGVvTGlzdGVuZXJzKCk7 CiAgICAgdGhpcy5jcmVhdGVCYXNlKCk7CkBAIC0xMjg1LDE1ICsxMjg3LDIzIEBAIENvbnRyb2xs ZXIucHJvdG90eXBlID0gewogCiAgICAgaGlkZUNvbnRyb2xzOiBmdW5jdGlvbigpCiAgICAgewor ICAgICAgICBpZiAodGhpcy5jb250cm9sc0Fsd2F5c1Zpc2libGUoKSkKKyAgICAgICAgICAgIHJl dHVybjsKKwogICAgICAgICB0aGlzLnVwZGF0ZVNob3VsZExpc3RlbkZvclBsYXliYWNrVGFyZ2V0 QXZhaWxhYmlsaXR5RXZlbnQoKTsKICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbC5jbGFzc0xp c3QucmVtb3ZlKHRoaXMuQ2xhc3NOYW1lcy5zaG93KTsKICAgICAgICAgaWYgKHRoaXMuY29udHJv bHMucGFuZWxCYWNrZ3JvdW5kKQogICAgICAgICAgICAgdGhpcy5jb250cm9scy5wYW5lbEJhY2tn cm91bmQuY2xhc3NMaXN0LnJlbW92ZSh0aGlzLkNsYXNzTmFtZXMuc2hvdyk7CiAgICAgfSwKIAor ICAgIGNvbnRyb2xzQWx3YXlzVmlzaWJsZTogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgcmV0 dXJuIHRoaXMuaXNBdWRpbygpIHx8IHRoaXMuY3VycmVudFBsYXliYWNrVGFyZ2V0SXNXaXJlbGVz cygpOworICAgIH0sCisKICAgICBjb250cm9sc0FyZUhpZGRlbjogZnVuY3Rpb24oKQogICAgIHsK LSAgICAgICAgcmV0dXJuICF0aGlzLmlzQXVkaW8oKSAmJiAhdGhpcy5jb250cm9scy5wYW5lbC5j bGFzc0xpc3QuY29udGFpbnModGhpcy5DbGFzc05hbWVzLnNob3cpOworICAgICAgICByZXR1cm4g IXRoaXMuY29udHJvbHNBbHdheXNWaXNpYmxlKCkgJiYgIXRoaXMuY29udHJvbHMucGFuZWwuY2xh c3NMaXN0LmNvbnRhaW5zKHRoaXMuQ2xhc3NOYW1lcy5zaG93KTsKICAgICB9LAogCiAgICAgcmVt b3ZlQ29udHJvbHM6IGZ1bmN0aW9uKCkKQEAgLTE2OTgsNyArMTcwOCw3IEBAIENvbnRyb2xsZXIu cHJvdG90eXBlID0gewogICAgICAgICBpZiAoQ29udHJvbGxlci5nU2ltdWxhdGVXaXJlbGVzc1Bs YXliYWNrVGFyZ2V0KQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICAgICAgaWYgKCF0 aGlzLnZpZGVvLndlYmtpdEN1cnJlbnRQbGF5YmFja1RhcmdldElzV2lyZWxlc3MgfHwgdGhpcy52 aWRlby53ZWJraXRXaXJlbGVzc1ZpZGVvUGxheWJhY2tEaXNhYmxlZCkKKyAgICAgICAgaWYgKCF0 aGlzLmN1cnJyZW50VGFyZ2V0SXNXaXJlbGVzcyB8fCB0aGlzLndpcmVsZXNzUGxheWJhY2tEaXNh YmxlZCkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgICAgICByZXR1cm4gdHJ1ZTsK QEAgLTE3NDYsOCArMTc1NiwxMSBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICB9LAog CiAgICAgdXBkYXRlV2lyZWxlc3NUYXJnZXRBdmFpbGFibGU6IGZ1bmN0aW9uKCkgeworICAgICAg ICB0aGlzLmN1cnJyZW50VGFyZ2V0SXNXaXJlbGVzcyA9IHRoaXMudmlkZW8ud2Via2l0Q3VycmVu dFBsYXliYWNrVGFyZ2V0SXNXaXJlbGVzczsKKyAgICAgICAgdGhpcy53aXJlbGVzc1BsYXliYWNr RGlzYWJsZWQgPSB0aGlzLnZpZGVvLndlYmtpdFdpcmVsZXNzVmlkZW9QbGF5YmFja0Rpc2FibGVk OworCiAgICAgICAgIHZhciB3aXJlbGVzc1BsYXliYWNrVGFyZ2V0c0F2YWlsYWJsZSA9IENvbnRy b2xsZXIuZ1NpbXVsYXRlV2lyZWxlc3NQbGF5YmFja1RhcmdldCB8fCB0aGlzLmhhc1dpcmVsZXNz UGxheWJhY2tUYXJnZXRzOwotICAgICAgICBpZiAodGhpcy52aWRlby53ZWJraXRXaXJlbGVzc1Zp ZGVvUGxheWJhY2tEaXNhYmxlZCkKKyAgICAgICAgaWYgKHRoaXMud2lyZWxlc3NQbGF5YmFja0Rp c2FibGVkKQogICAgICAgICAgICAgd2lyZWxlc3NQbGF5YmFja1RhcmdldHNBdmFpbGFibGUgPSBm YWxzZTsKIAogICAgICAgICBpZiAod2lyZWxlc3NQbGF5YmFja1RhcmdldHNBdmFpbGFibGUpCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc2lP Uy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMv bWVkaWFDb250cm9sc2lPUy5qcwkocmV2aXNpb24gMTgyMjQ0KQorKysgU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNpT1MuanMJKHdvcmtpbmcgY29weSkK QEAgLTY1MSw2ICs2NTEsMTUgQEAgQ29udHJvbGxlcklPUy5wcm90b3R5cGUgPSB7CiAgICAgICAg ICAgICB0aGlzLmNvbnRyb2xzLmZ1bGxzY3JlZW5CdXR0b24uY2xhc3NMaXN0LnJlbW92ZSh0aGlz LkNsYXNzTmFtZXMuaGlkZGVuKTsKICAgICB9LAogCisgICAgY29udHJvbHNBbHdheXNWaXNpYmxl OiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBpZiAodGhpcy5wcmVzZW50YXRpb25Nb2RlKCkg PT09ICdvcHRpbWl6ZWQnKQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICAgICAgcmV0 dXJuIENvbnRyb2xsZXIucHJvdG90eXBlLmNvbnRyb2xzQWx3YXlzVmlzaWJsZS5jYWxsKHRoaXMp OworICAgIH0sCisKKwogfTsKIAogT2JqZWN0LmNyZWF0ZShDb250cm9sbGVyLnByb3RvdHlwZSku ZXh0ZW5kKENvbnRyb2xsZXJJT1MucHJvdG90eXBlKTsK