143303 2015-04-01 05:21:56 -0700 Value assignment operator of Optional should be stricter 2015-04-02 08:55:13 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned andersca benjamin cmarcelo commit-queue mmaxfield oldest_to_newest 1081972 0 koivisto 2015-04-01 05:21:56 -0700 struct Foo { mutable Optional<std::chrono::seconds> s; }; Foo foo, foo2; foo = foo2; doesn't build because it tries to use wrong operator=. 1081973 1 249914 koivisto 2015-04-01 05:25:13 -0700 Created attachment 249914 patch 1082099 2 249914 kling 2015-04-01 13:54:38 -0700 Comment on attachment 249914 patch OK 1082101 3 koivisto 2015-04-01 14:02:53 -0700 https://trac.webkit.org/r182254 1082124 4 mmaxfield 2015-04-01 15:41:32 -0700 Where's your test!?!?!?! 1082230 5 koivisto 2015-04-02 08:55:13 -0700 I don't think something like this requires a test. There are no functional changes. Code like http://trac.webkit.org/changeset/182271 just doesn't compile without this. Note that Optional is simply our version of std::optional which is likely to be in C++17. 249914 2015-04-01 05:25:13 -0700 2015-04-01 13:54:38 -0700 patch optional-assignment-strict.patch text/plain 1283 koivisto SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODIyMzApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTA0LTAxICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KKworICAgICAgICBWYWx1ZSBhc3NpZ25tZW50IG9wZXJhdG9yIG9mIE9w dGlvbmFsIHNob3VsZCBiZSBzdHJpY3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgc3RydWN0IEZvbyB7IG11dGFibGUgT3B0aW9uYWw8c3RkOjpjaHJv bm86OnNlY29uZHM+IHM7IH07CisgICAgICAgIEZvbyBmb28sIGZvbzI7CisgICAgICAgIGZvbyA9 IGZvbzI7CisKKyAgICAgICAgZG9lc24ndCBidWlsZCBiZWNhdXNlIGl0IHRyaWVzIHRvIHVzZSB3 cm9uZyBvcGVyYXRvcj0uCisKKyAgICAgICAgKiB3dGYvT3B0aW9uYWwuaDoKKworICAgICAgICAg ICAgQWRkIGVuYWJsZV9pZiB0ZXN0IHNpbWlsYXIgdG8gc3RkOjpleHBlcmltZW50YWw6Om9wdGlv bmFsLgorCiAyMDE1LTAzLTMxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgog CiAgICAgICAgIEZpeCB0aGUgYnVpbGQgYWZ0ZXIgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hh bmdlc2V0LzE4MjIwNT4uCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9PcHRpb25hbC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XVEYvd3RmL09wdGlvbmFsLmgJKHJldmlzaW9uIDE4MjIyNSkKKysrIFNv dXJjZS9XVEYvd3RmL09wdGlvbmFsLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMiw3ICsxMjIsNyBA QCBwdWJsaWM6CiAgICAgICAgIHJldHVybiAqdGhpczsKICAgICB9CiAKLSAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBVPgorICAgIHRlbXBsYXRlPHR5cGVuYW1lIFUsIGNsYXNzID0gdHlwZW5hbWUgc3Rk OjplbmFibGVfaWY8c3RkOjppc19zYW1lPHR5cGVuYW1lIHN0ZDo6cmVtb3ZlX3JlZmVyZW5jZTxV Pjo6dHlwZSwgVD46OnZhbHVlPjo6dHlwZT4KICAgICBPcHRpb25hbCYgb3BlcmF0b3I9KFUmJiB1 KQogICAgIHsKICAgICAgICAgZGVzdHJveSgpOwo=