<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>143295</bug_id>
          
          <creation_ts>2015-03-31 23:52:11 -0700</creation_ts>
          <short_desc>[CMake] Make gtest/CMakeLists.txt more readable</short_desc>
          <delta_ts>2015-04-01 03:38:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gyuyoung Kim">gyuyoung.kim</reporter>
          <assigned_to name="Gyuyoung Kim">gyuyoung.kim</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1081912</commentid>
    <comment_count>0</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2015-03-31 23:52:11 -0700</bug_when>
    <thetext>gtest/CMakeLists.txt has used add_library() and include_directory() directly. It seems to me that it is unsorted use.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1081913</commentid>
    <comment_count>1</comment_count>
      <attachid>249898</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2015-03-31 23:52:56 -0700</bug_when>
    <thetext>Created attachment 249898
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1081914</commentid>
    <comment_count>2</comment_count>
      <attachid>249899</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2015-03-31 23:54:05 -0700</bug_when>
    <thetext>Created attachment 249899
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1081961</commentid>
    <comment_count>3</comment_count>
      <attachid>249899</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-04-01 03:38:55 -0700</bug_when>
    <thetext>Comment on attachment 249899
Patch

Clearing flags on attachment: 249899

Committed r182228: &lt;http://trac.webkit.org/changeset/182228&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1081962</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-04-01 03:38:59 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>249898</attachid>
            <date>2015-03-31 23:52:56 -0700</date>
            <delta_ts>2015-03-31 23:53:59 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-143295-20150401155212.patch</filename>
            <type>text/plain</type>
            <size>2112</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0
eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggNWY3MTg1ZmEx
MDU0NmU0NzE1MWVhOWNmNjE4MmM5M2QzMDYzZjdmYS4uMWUwYjcxZThmYTI1MWJmYWExNWY3OWYy
ZGU4YThmNDVhN2FlMzU4OCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1
LTAzLTMxICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1AY2hyb21pdW0ub3JnPgorCisgICAg
ICAgIFtDTWFrZV0gTWFrZSBndGVzdC9DTWFrZUxpc3RzLnR4dCBtb3JlIHJlYWRhYmxlCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMyOTUKKworICAg
ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBndGVzdC9DTWFrZUxp
c3RzLnR4dCBoYXMgdXNlZCBhZGRfbGlicmFyeSgpIGFuZCBpbmNsdWRlX2RpcmVjdG9yeSgpIGRp
cmVjdGx5LgorICAgICAgICBUaGlzIHBhdGNoIGFkZHMgR1RFU1RfSU5DTFVERV9ESVJFQ1RPUklF
UyBhbmQgR1RFU1RfU09VUkNFUywgYW5kIHVzZSBpdC4KKworICAgICAgICAqIGd0ZXN0L0NNYWtl
TGlzdHMudHh0OgorCiAyMDE1LTAzLTI5ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ft
c3VuZy5jb20+CiAKICAgICAgICAgW0NNYWtlXSBVcGRhdGUgb2xkIENNYWtlTGlzdC50eHQgaW4g
Z3Rlc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMudHh0
IGIvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvQ01ha2VMaXN0cy50eHQKaW5kZXggY2MxNjg4Yzdm
MTBkYTU4YjMxMDI1NGFhZmNlNzc3OTM1NWZiNGNiZC4uZGUyM2ZiMzY3MjM4ZmUwZDJlM2ZmZGMw
MzljMmYxZmM3ZmVlMTQ4NCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvQ01h
a2VMaXN0cy50eHQKKysrIGIvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvQ01ha2VMaXN0cy50eHQK
QEAgLTMsMTYgKzMsMTcgQEAKICMgZm9yIG91ciB0ZXN0cy4gVGhlIFdlYktpdCB2ZXJzaW9uIG9m
IGd0ZXN0IG5lZWRzIGFjY2VzcyB0byBzb21lCiAjIGhlYWRlcnMgZnJvbSBXVEYgYW5kIEpTQyBm
b3IgY29uZmlndXJhdGlvbi4KIAotaW5jbHVkZV9kaXJlY3Rvcmllcygke1RISVJEUEFSVFlfRElS
fS9ndGVzdAotICAgICR7VEhJUkRQQVJUWV9ESVJ9L2d0ZXN0L2luY2x1ZGUKLSAgICAke0pBVkFT
Q1JJUFRDT1JFX0RJUn0KLSAgICAke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9
Ci0gICAgJHtXVEZfRElSfQotKQotCiBzZXQoR1RFU1RfRElSICIke1RISVJEUEFSVFlfRElSfS9n
dGVzdCIpCiAKLWFkZF9saWJyYXJ5KGd0ZXN0IFNIQVJFRAorc2V0KEdURVNUX0lOQ0xVREVfRElS
RUNUT1JJRVMKKyAgICAiJHtHVEVTVF9ESVJ9IgorICAgICIke0dURVNUX0RJUn0vaW5jbHVkZSIK
KyAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9IgorICAgICIke0RFUklWRURfU09VUkNFU19KQVZB
U0NSSVBUQ09SRV9ESVJ9IgorICAgICIke1dURl9ESVJ9IgorKQorCitzZXQoR1RFU1RfU09VUkNF
UwogICAgICR7R1RFU1RfRElSfS9zcmMvZ3Rlc3QuY2MKICAgICAke0dURVNUX0RJUn0vc3JjL2d0
ZXN0LWRlYXRoLXRlc3QuY2MKICAgICAke0dURVNUX0RJUn0vc3JjL2d0ZXN0LWZpbGVwYXRoLmNj
CkBAIC0yMiw2ICsyMyw4IEBAIGFkZF9saWJyYXJ5KGd0ZXN0IFNIQVJFRAogICAgICR7R1RFU1Rf
RElSfS9zcmMvZ3Rlc3QtdHlwZWQtdGVzdC5jYwogKQogCithZGRfbGlicmFyeShndGVzdCBTSEFS
RUQgJHtHVEVTVF9TT1VSQ0VTfSkKK2luY2x1ZGVfZGlyZWN0b3JpZXMoJHtHVEVTVF9JTkNMVURF
X0RJUkVDVE9SSUVTfSkKIGFkZF9kZWZpbml0aW9ucygtREdURVNUX0NSRUFURV9TSEFSRURfTElC
UkFSWT0xIC1ER1RFU1RfSEFTX1JUVEk9MCkKIAogIyBGSVhNRTogVGhpcyB3b3JrcyBhcm91bmQg
Y29tcGF0aWJpbGl0eSBwcm9ibGVtcyBpbiB0aGUgb2xkIHZlcnNpb24gb2YgdGhlIHRoaXJkLXBh
cnkK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>249899</attachid>
            <date>2015-03-31 23:54:05 -0700</date>
            <delta_ts>2015-04-01 03:38:55 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-143295-20150401155320.patch</filename>
            <type>text/plain</type>
            <size>2110</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0
eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggNWY3MTg1ZmEx
MDU0NmU0NzE1MWVhOWNmNjE4MmM5M2QzMDYzZjdmYS4uMzIxZTcyZmY3ZGZiMTA3NzU0YThhNjU0
OGU3OTU0MDNlMDg3MTNhMCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n
CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1
LTAzLTMxICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0Lm9yZz4KKworICAgICAg
ICBbQ01ha2VdIE1ha2UgZ3Rlc3QvQ01ha2VMaXN0cy50eHQgbW9yZSByZWFkYWJsZQorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMjk1CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZ3Rlc3QvQ01ha2VMaXN0
cy50eHQgaGFzIHVzZWQgYWRkX2xpYnJhcnkoKSBhbmQgaW5jbHVkZV9kaXJlY3RvcnkoKSBkaXJl
Y3RseS4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIEdURVNUX0lOQ0xVREVfRElSRUNUT1JJRVMg
YW5kIEdURVNUX1NPVVJDRVMsIGFuZCB1c2UgaXQuCisKKyAgICAgICAgKiBndGVzdC9DTWFrZUxp
c3RzLnR4dDoKKwogMjAxNS0wMy0yOSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1
bmcuY29tPgogCiAgICAgICAgIFtDTWFrZV0gVXBkYXRlIG9sZCBDTWFrZUxpc3QudHh0IGluIGd0
ZXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC9DTWFrZUxpc3RzLnR4dCBi
L1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMudHh0CmluZGV4IGNjMTY4OGM3ZjEw
ZGE1OGIzMTAyNTRhYWZjZTc3NzkzNTVmYjRjYmQuLmRlMjNmYjM2NzIzOGZlMGQyZTNmZmRjMDM5
YzJmMWZjN2ZlZTE0ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtl
TGlzdHMudHh0CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMudHh0CkBA
IC0zLDE2ICszLDE3IEBACiAjIGZvciBvdXIgdGVzdHMuIFRoZSBXZWJLaXQgdmVyc2lvbiBvZiBn
dGVzdCBuZWVkcyBhY2Nlc3MgdG8gc29tZQogIyBoZWFkZXJzIGZyb20gV1RGIGFuZCBKU0MgZm9y
IGNvbmZpZ3VyYXRpb24uCiAKLWluY2x1ZGVfZGlyZWN0b3JpZXMoJHtUSElSRFBBUlRZX0RJUn0v
Z3Rlc3QKLSAgICAke1RISVJEUEFSVFlfRElSfS9ndGVzdC9pbmNsdWRlCi0gICAgJHtKQVZBU0NS
SVBUQ09SRV9ESVJ9Ci0gICAgJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVfRElSfQot
ICAgICR7V1RGX0RJUn0KLSkKLQogc2V0KEdURVNUX0RJUiAiJHtUSElSRFBBUlRZX0RJUn0vZ3Rl
c3QiKQogCi1hZGRfbGlicmFyeShndGVzdCBTSEFSRUQKK3NldChHVEVTVF9JTkNMVURFX0RJUkVD
VE9SSUVTCisgICAgIiR7R1RFU1RfRElSfSIKKyAgICAiJHtHVEVTVF9ESVJ9L2luY2x1ZGUiCisg
ICAgIiR7SkFWQVNDUklQVENPUkVfRElSfSIKKyAgICAiJHtERVJJVkVEX1NPVVJDRVNfSkFWQVND
UklQVENPUkVfRElSfSIKKyAgICAiJHtXVEZfRElSfSIKKykKKworc2V0KEdURVNUX1NPVVJDRVMK
ICAgICAke0dURVNUX0RJUn0vc3JjL2d0ZXN0LmNjCiAgICAgJHtHVEVTVF9ESVJ9L3NyYy9ndGVz
dC1kZWF0aC10ZXN0LmNjCiAgICAgJHtHVEVTVF9ESVJ9L3NyYy9ndGVzdC1maWxlcGF0aC5jYwpA
QCAtMjIsNiArMjMsOCBAQCBhZGRfbGlicmFyeShndGVzdCBTSEFSRUQKICAgICAke0dURVNUX0RJ
Un0vc3JjL2d0ZXN0LXR5cGVkLXRlc3QuY2MKICkKIAorYWRkX2xpYnJhcnkoZ3Rlc3QgU0hBUkVE
ICR7R1RFU1RfU09VUkNFU30pCitpbmNsdWRlX2RpcmVjdG9yaWVzKCR7R1RFU1RfSU5DTFVERV9E
SVJFQ1RPUklFU30pCiBhZGRfZGVmaW5pdGlvbnMoLURHVEVTVF9DUkVBVEVfU0hBUkVEX0xJQlJB
Ulk9MSAtREdURVNUX0hBU19SVFRJPTApCiAKICMgRklYTUU6IFRoaXMgd29ya3MgYXJvdW5kIGNv
bXBhdGliaWxpdHkgcHJvYmxlbXMgaW4gdGhlIG9sZCB2ZXJzaW9uIG9mIHRoZSB0aGlyZC1wYXJ5
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>