143289 2015-03-31 20:09:55 -0700 [iOS] Include Add to Reading List link action only where supported 2015-03-31 21:08:20 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz sam thorton oldest_to_newest 1081868 0 mitz 2015-03-31 20:09:55 -0700 <rdar://problem/20365675> The Add to Reading List link action should only be included in a link’s actions when the functionality is supported. 1081872 1 249883 mitz 2015-03-31 20:52:52 -0700 Created attachment 249883 Define and use HAVE_READING_LIST 1081873 2 249883 thorton 2015-03-31 21:02:05 -0700 Comment on attachment 249883 Define and use HAVE_READING_LIST View in context: https://bugs.webkit.org/attachment.cgi?id=249883&action=review > Source/WebKit2/config.h:94 > +#define HAVE_READING_LIST 1 Should it not be HAVE_SAFARI_READING_LIST? This is very specifically about the Safari feature, yes? 1081874 3 mitz 2015-03-31 21:03:34 -0700 (In reply to comment #2) > Comment on attachment 249883 [details] > Define and use HAVE_READING_LIST > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249883&action=review > > > Source/WebKit2/config.h:94 > > +#define HAVE_READING_LIST 1 > > Should it not be HAVE_SAFARI_READING_LIST? This is very specifically about > the Safari feature, yes? Going to go with HAVE_SAFARI_SERVICES_FRAMEWORK. Thanks for the review! 1081875 4 mitz 2015-03-31 21:08:20 -0700 Fixed in <http://trac.webkit.org/r182219>. 249883 2015-03-31 20:52:52 -0700 2015-03-31 21:02:05 -0700 Define and use HAVE_READING_LIST bug-143289-20150331205209.patch text/plain 6750 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjIxOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAzLTMxICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwMzY1 Njc1PiBbaU9TXSBJbmNsdWRlIEFkZCB0byBSZWFkaW5nIExpc3QgbGluayBhY3Rpb24gb25seSB3 aGVyZSBzdXBwb3J0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0MzI4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLmg6IEV4Y2x1ZGVk IF9XS0VsZW1lbnRBY3Rpb25UeXBlQWRkVG9SZWFkaW5nTGlzdCBmcm9tCisgICAgICAgIHRoZSBf V0tFbGVtZW50QWN0aW9uVHlwZSBlbnVtIHdoZW4gUmVhZGluZyBMaXN0IGlzIG5vdCBzdXBwb3J0 ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rpb24ubW06 CisgICAgICAgICgrW19XS0VsZW1lbnRBY3Rpb24gZWxlbWVudEFjdGlvbldpdGhUeXBlOmN1c3Rv bVRpdGxlOl0pOiBNYWRlIEFkZCB0byBSZWFkaW5nIExpc3QgY29kZQorICAgICAgICBjb25kaXRp b25hbCBvbiBIQVZFKFJFQURJTkdfTElTVCkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dL QWN0aW9uU2hlZXRBc3Npc3RhbnQubW06CisgICAgICAgICgtW1dLQWN0aW9uU2hlZXRBc3Npc3Rh bnQgc2hvd0ltYWdlU2hlZXRdKTogRGl0dG8uCisgICAgICAgICgtW1dLQWN0aW9uU2hlZXRBc3Np c3RhbnQgc2hvd0xpbmtTaGVldF0pOiBEaXR0by4KKworICAgICAgICAqIGNvbmZpZy5oOiBEZWZp bmVkIEhBVkVfUkVBRElOR19MSVNULgorCiAyMDE1LTAzLTMxICBUaW1vdGh5IEhvcnRvbiAgPHRp bW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBUZXh0SW5kaWNhdG9yIGZvciA8c3Bh bj4gaW5zaWRlIGFuIDxhPiBvbmx5IGhpZ2hsaWdodHMgdGhlIDxzcGFuPiwgc2hvdWxkIGhpZ2hs aWdodCB0aGUgd2hvbGUgPGE+CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9jb25maWcuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9jb25maWcuaAkocmV2aXNpb24gMTgyMTk0KQorKysgU291 cmNlL1dlYktpdDIvY29uZmlnLmgJKHdvcmtpbmcgY29weSkKQEAgLTg4LDMgKzg4LDExIEBACiAj ZGVmaW5lIEVOQUJMRV9ORVRXT1JLX0NBQ0hFIDAKICNlbmRpZgogI2VuZGlmCisKKyNpZm5kZWYg SEFWRV9SRUFESU5HX0xJU1QKKyNpZiBQTEFURk9STShJT1MpICYmICghZGVmaW5lZCBUQVJHRVRf T1NfSU9TIHx8IFRBUkdFVF9PU19JT1MpCisjZGVmaW5lIEhBVkVfUkVBRElOR19MSVNUIDEKKyNl bHNlCisjZGVmaW5lIEhBVkVfUkVBRElOR19MSVNUIDAKKyNlbmRpZgorI2VuZGlmCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rpb24uaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRB Y3Rpb24uaAkocmV2aXNpb24gMTgyMTk0KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTM5LDcgKzM5LDkg QEAgdHlwZWRlZiBOU19FTlVNKE5TSW50ZWdlciwgX1dLRWxlbWVudEFjdAogICAgIF9XS0VsZW1l bnRBY3Rpb25UeXBlT3BlbiwKICAgICBfV0tFbGVtZW50QWN0aW9uVHlwZUNvcHksCiAgICAgX1dL RWxlbWVudEFjdGlvblR5cGVTYXZlSW1hZ2UsCisjaWYgIWRlZmluZWQoVEFSR0VUX09TX0lPUykg fHwgVEFSR0VUX09TX0lPUwogICAgIF9XS0VsZW1lbnRBY3Rpb25UeXBlQWRkVG9SZWFkaW5nTGlz dCwKKyNlbmRpZgogfSBXS19FTlVNX0FWQUlMQUJMRSgxMF8xMCwgOF8wKTsKIAogV0tfQ0xBU1Nf QVZBSUxBQkxFKDEwXzEwLCA4XzApCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL19XS0VsZW1lbnRBY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCShyZXZpc2lvbiAxODIxOTQp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rpb24u bW0JKHdvcmtpbmcgY29weSkKQEAgLTM0LDE0ICszNCwxNiBAQAogI2ltcG9ydCAiV0tBY3Rpb25T aGVldEFzc2lzdGFudC5oIgogI2ltcG9ydCAiV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLmgiCiAj aW1wb3J0ICJfV0tBY3RpdmF0ZWRFbGVtZW50SW5mb0ludGVybmFsLmgiCi0jaW1wb3J0IDxTYWZh cmlTZXJ2aWNlcy9TU1JlYWRpbmdMaXN0Lmg+CiAjaW1wb3J0IDxXZWJDb3JlL0xvY2FsaXplZFN0 cmluZ3MuaD4KICNpbXBvcnQgPFdlYkNvcmUvU29mdExpbmtpbmcuaD4KICNpbXBvcnQgPHd0Zi9S ZXRhaW5QdHIuaD4KICNpbXBvcnQgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCisjaWYgSEFWRShS RUFESU5HX0xJU1QpCisjaW1wb3J0IDxTYWZhcmlTZXJ2aWNlcy9TU1JlYWRpbmdMaXN0Lmg+CiBT T0ZUX0xJTktfRlJBTUVXT1JLKFNhZmFyaVNlcnZpY2VzKTsKIFNPRlRfTElOS19DTEFTUyhTYWZh cmlTZXJ2aWNlcywgU1NSZWFkaW5nTGlzdCk7CisjZW5kaWYKIAogdHlwZWRlZiB2b2lkICheV0tF bGVtZW50QWN0aW9uSGFuZGxlckludGVybmFsKShXS0FjdGlvblNoZWV0QXNzaXN0YW50ICosIF9X S0FjdGl2YXRlZEVsZW1lbnRJbmZvICopOwogCkBAIC03Niw2ICs3OCw3IEBAICsgKGluc3RhbmNl dHlwZSllbGVtZW50QWN0aW9uV2l0aFRpdGxlOigKICAgICAgICB0eXBlOl9XS0VsZW1lbnRBY3Rp b25UeXBlQ3VzdG9tXSBhdXRvcmVsZWFzZV07CiB9CiAKKyNpZiBIQVZFKFJFQURJTkdfTElTVCkK IHN0YXRpYyB2b2lkIGFkZFRvUmVhZGluZ0xpc3QoTlNVUkwgKnRhcmdldFVSTCwgTlNTdHJpbmcg KnRpdGxlKQogewogICAgIGlmICghdGl0bGUgfHwgW3RpdGxlIGxlbmd0aF0gPT0gMCkKQEAgLTgz LDYgKzg2LDcgQEAgc3RhdGljIHZvaWQgYWRkVG9SZWFkaW5nTGlzdChOU1VSTCAqdGFyZwogCiAg ICAgW1tnZXRTU1JlYWRpbmdMaXN0Q2xhc3MoKSBkZWZhdWx0UmVhZGluZ0xpc3RdIGFkZFJlYWRp bmdMaXN0SXRlbVdpdGhVUkw6dGFyZ2V0VVJMIHRpdGxlOnRpdGxlIHByZXZpZXdUZXh0Om5pbCBl cnJvcjpuaWxdOwogfQorI2VuZGlmCiAKICsgKGluc3RhbmNldHlwZSllbGVtZW50QWN0aW9uV2l0 aFR5cGU6KF9XS0VsZW1lbnRBY3Rpb25UeXBlKXR5cGUgY3VzdG9tVGl0bGU6KE5TU3RyaW5nICop Y3VzdG9tVGl0bGUKIHsKQEAgLTEwNywxMiArMTExLDE0IEBAICsgKGluc3RhbmNldHlwZSllbGVt ZW50QWN0aW9uV2l0aFR5cGU6KF8KICAgICAgICAgICAgIFthc3Npc3RhbnQuZGVsZWdhdGUgYWN0 aW9uU2hlZXRBc3Npc3RhbnQ6YXNzaXN0YW50IHBlcmZvcm1BY3Rpb246V2ViS2l0OjpTaGVldEFj dGlvbjo6U2F2ZUltYWdlXTsKICAgICAgICAgfTsKICAgICAgICAgYnJlYWs7CisjaWYgSEFWRShS RUFESU5HX0xJU1QpCiAgICAgY2FzZSBfV0tFbGVtZW50QWN0aW9uVHlwZUFkZFRvUmVhZGluZ0xp c3Q6CiAgICAgICAgIHRpdGxlID0gV0VCX1VJX1NUUklORygiQWRkIHRvIFJlYWRpbmcgTGlzdCIs ICJUaXRsZSBmb3IgQWRkIHRvIFJlYWRpbmcgTGlzdCBhY3Rpb24gYnV0dG9uIik7CiAgICAgICAg IGhhbmRsZXIgPSBeKFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgKiwgX1dLQWN0aXZhdGVkRWxlbWVu dEluZm8gKmFjdGlvbkluZm8pIHsKICAgICAgICAgICAgIGFkZFRvUmVhZGluZ0xpc3QoYWN0aW9u SW5mby5VUkwsIGFjdGlvbkluZm8udGl0bGUpOwogICAgICAgICB9OwogICAgICAgICBicmVhazsK KyNlbmRpZgogICAgIGRlZmF1bHQ6CiAgICAgICAgIFtOU0V4Y2VwdGlvbiByYWlzZTpOU0ludmFs aWRBcmd1bWVudEV4Y2VwdGlvbiBmb3JtYXQ6QCJUaGVyZSBpcyBubyBzdGFuZGFyZCB3ZWIgZWxl bWVudCBhY3Rpb24gb2YgdHlwZSAlbGQuIiwgKGxvbmcpdHlwZV07CiAgICAgICAgIHJldHVybiBu aWw7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Np c3RhbnQubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0Fj dGlvblNoZWV0QXNzaXN0YW50Lm1tCShyZXZpc2lvbiAxODIxOTQpCisrKyBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW0JKHdvcmtpbmcgY29weSkK QEAgLTM3LDE1ICszNywxNyBAQAogI2ltcG9ydCAiV2ViUGFnZVByb3h5LmgiCiAjaW1wb3J0ICJf V0tBY3RpdmF0ZWRFbGVtZW50SW5mb0ludGVybmFsLmgiCiAjaW1wb3J0ICJfV0tFbGVtZW50QWN0 aW9uSW50ZXJuYWwuaCIKLSNpbXBvcnQgPFNhZmFyaVNlcnZpY2VzL1NTUmVhZGluZ0xpc3QuaD4K ICNpbXBvcnQgPFVJS2l0L1VJVmlldy5oPgogI2ltcG9ydCA8V2ViQ29yZS9Mb2NhbGl6ZWRTdHJp bmdzLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1NvZnRMaW5raW5nLmg+CiAjaW1wb3J0IDxXZWJDb3Jl L1dlYkNvcmVOU1VSTEV4dHJhcy5oPgogI2ltcG9ydCA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAK KyNpZiBIQVZFKFJFQURJTkdfTElTVCkKKyNpbXBvcnQgPFNhZmFyaVNlcnZpY2VzL1NTUmVhZGlu Z0xpc3QuaD4KIFNPRlRfTElOS19GUkFNRVdPUksoU2FmYXJpU2VydmljZXMpCiBTT0ZUX0xJTktf Q0xBU1MoU2FmYXJpU2VydmljZXMsIFNTUmVhZGluZ0xpc3QpCisjZW5kaWYKIAogU09GVF9MSU5L X1BSSVZBVEVfRlJBTUVXT1JLKFRDQykKIFNPRlRfTElOSyhUQ0MsIFRDQ0FjY2Vzc1ByZWZsaWdo dCwgVENDQWNjZXNzUHJlZmxpZ2h0UmVzdWx0LCAoQ0ZTdHJpbmdSZWYgc2VydmljZSwgQ0ZEaWN0 aW9uYXJ5UmVmIG9wdGlvbnMpLCAoc2VydmljZSwgb3B0aW9ucykpCkBAIC0yNDYsOCArMjQ4LDEw IEBAIC0gKHZvaWQpc2hvd0ltYWdlU2hlZXQKICAgICBhdXRvIGRlZmF1bHRBY3Rpb25zID0gYWRv cHROUyhbW05TTXV0YWJsZUFycmF5IGFsbG9jXSBpbml0XSk7CiAgICAgaWYgKCFwb3NpdGlvbklu Zm9ybWF0aW9uLnVybC5pc0VtcHR5KCkpCiAgICAgICAgIFtkZWZhdWx0QWN0aW9ucyBhZGRPYmpl Y3Q6W19XS0VsZW1lbnRBY3Rpb24gZWxlbWVudEFjdGlvbldpdGhUeXBlOl9XS0VsZW1lbnRBY3Rp b25UeXBlT3Blbl1dOworI2lmIEhBVkUoUkVBRElOR19MSVNUKQogICAgIGlmIChbZ2V0U1NSZWFk aW5nTGlzdENsYXNzKCkgc3VwcG9ydHNVUkw6dGFyZ2V0VVJMXSkKICAgICAgICAgW2RlZmF1bHRB Y3Rpb25zIGFkZE9iamVjdDpbX1dLRWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6 X1dLRWxlbWVudEFjdGlvblR5cGVBZGRUb1JlYWRpbmdMaXN0XV07CisjZW5kaWYKICAgICBpZiAo VENDQWNjZXNzUHJlZmxpZ2h0KGdldGtUQ0NTZXJ2aWNlUGhvdG9zKCksIE5VTEwpICE9IGtUQ0NB Y2Nlc3NQcmVmbGlnaHREZW5pZWQpCiAgICAgICAgIFtkZWZhdWx0QWN0aW9ucyBhZGRPYmplY3Q6 W19XS0VsZW1lbnRBY3Rpb24gZWxlbWVudEFjdGlvbldpdGhUeXBlOl9XS0VsZW1lbnRBY3Rpb25U eXBlU2F2ZUltYWdlXV07CiAgICAgaWYgKCF0YXJnZXRVUkwuc2NoZW1lLmxlbmd0aCB8fCBbdGFy Z2V0VVJMLnNjaGVtZSBjYXNlSW5zZW5zaXRpdmVDb21wYXJlOkAiamF2YXNjcmlwdCJdICE9IE5T T3JkZXJlZFNhbWUpCkBAIC0yODgsOCArMjkyLDEwIEBAIC0gKHZvaWQpc2hvd0xpbmtTaGVldAog CiAgICAgYXV0byBkZWZhdWx0QWN0aW9ucyA9IGFkb3B0TlMoW1tOU011dGFibGVBcnJheSBhbGxv Y10gaW5pdF0pOwogICAgIFtkZWZhdWx0QWN0aW9ucyBhZGRPYmplY3Q6W19XS0VsZW1lbnRBY3Rp b24gZWxlbWVudEFjdGlvbldpdGhUeXBlOl9XS0VsZW1lbnRBY3Rpb25UeXBlT3Blbl1dOworI2lm IEhBVkUoUkVBRElOR19MSVNUKQogICAgIGlmIChbZ2V0U1NSZWFkaW5nTGlzdENsYXNzKCkgc3Vw cG9ydHNVUkw6dGFyZ2V0VVJMXSkKICAgICAgICAgW2RlZmF1bHRBY3Rpb25zIGFkZE9iamVjdDpb X1dLRWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6X1dLRWxlbWVudEFjdGlvblR5 cGVBZGRUb1JlYWRpbmdMaXN0XV07CisjZW5kaWYKICAgICBpZiAoIVtbdGFyZ2V0VVJMIHNjaGVt ZV0gbGVuZ3RoXSB8fCBbW3RhcmdldFVSTCBzY2hlbWVdIGNhc2VJbnNlbnNpdGl2ZUNvbXBhcmU6 QCJqYXZhc2NyaXB0Il0gIT0gTlNPcmRlcmVkU2FtZSkKICAgICAgICAgW2RlZmF1bHRBY3Rpb25z IGFkZE9iamVjdDpbX1dLRWxlbWVudEFjdGlvbiBlbGVtZW50QWN0aW9uV2l0aFR5cGU6X1dLRWxl bWVudEFjdGlvblR5cGVDb3B5XV07CiAK