143287 2015-03-31 18:12:21 -0700 TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a> 2015-03-31 19:06:43 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton andersca bdakin dino mitz sam simon.fraser oldest_to_newest 1081850 0 thorton 2015-03-31 18:12:21 -0700 TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a> 1081851 1 thorton 2015-03-31 18:13:12 -0700 <rdar://problem/20318342> 1081852 2 249877 thorton 2015-03-31 18:14:41 -0700 Created attachment 249877 Patch 1081862 3 249877 bdakin 2015-03-31 19:04:04 -0700 Comment on attachment 249877 Patch Bonus points for remembering WK1! 1081863 4 thorton 2015-03-31 19:05:30 -0700 (In reply to comment #3) > Comment on attachment 249877 [details] > Patch > > Bonus points for remembering WK1! It will come as no surprise to you that I had the patch ready to go without any WebKit1 changes and remembered as I was uploading it :P 1081864 5 thorton 2015-03-31 19:06:43 -0700 http://trac.webkit.org/changeset/182217 249877 2015-03-31 18:14:41 -0700 2015-03-31 19:04:04 -0700 Patch bug-143287-20150331181358.patch text/plain 4233 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMjE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNzU3ZWE0OWQw YTMwZjk0ZDU2MjJiODM1MzVjMWJlYmQwNDMxZTk1Ni4uZWNjNDU1OWM5ZWJmNjcwYjVkMDY1NDJm NjllZDFkMGIzNzJjNmZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1 LTAzLTMxICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAg ICAgICBUZXh0SW5kaWNhdG9yIGZvciA8c3Bhbj4gaW5zaWRlIGFuIDxhPiBvbmx5IGhpZ2hsaWdo dHMgdGhlIDxzcGFuPiwgc2hvdWxkIGhpZ2hsaWdodCB0aGUgd2hvbGUgPGE+CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMyODcKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzIwMzE4MzQyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogV2ViVmlldy9XZWJJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyLm1t OgorICAgICAgICAoLVtXZWJJbW1lZGlhdGVBY3Rpb25Db250cm9sbGVyIF9kZWZhdWx0QW5pbWF0 aW9uQ29udHJvbGxlcl0pOgorICAgICAgICBJbnN0ZWFkIG9mIGp1c3QgaGlnaGxpZ2h0aW5nIHRo ZSBoaXQgZWxlbWVudCwgaGlnaGxpZ2h0IHRoZSB3aG9sZQorICAgICAgICBlbGVtZW50IHRoYXQg dGhlIGxpbmsgVVJMIGNvbWVzIGZyb20uCisKIDIwMTUtMDMtMzEgIFl1c3VrZSBTdXp1a2kgIDx1 dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgSWRlbnRpZmllciBmYWN0 b3JpZXMgdG8gY2xhcmlmeSB0aGUgbWVhbmluZyBvZiBTdHJpbmdJbXBsKgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4 IGE4ZTdlMmJkMmE0ZDRkYTU1YjVkMTExY2NhNzI4YjBjNWMzNGIzMTMuLjk3MzkwMGMwZTdlZjEz MmMyYjZlYWRkZWZmODU1ZGQ2OTU5MjZmZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAog MjAxNS0wMy0zMSAgVGltb3RoeSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgVGV4dEluZGljYXRvciBmb3IgPHNwYW4+IGluc2lkZSBhbiA8YT4gb25seSBoaWdo bGlnaHRzIHRoZSA8c3Bhbj4sIHNob3VsZCBoaWdobGlnaHQgdGhlIHdob2xlIDxhPgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMjg3CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8yMDMxODM0Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5t bToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6cGVyZm9ybUFjdGlvbk1lbnVIaXRUZXN0QXRM b2NhdGlvbik6CisgICAgICAgIEluc3RlYWQgb2YganVzdCBoaWdobGlnaHRpbmcgdGhlIGhpdCBl bGVtZW50LCBoaWdobGlnaHQgdGhlIHdob2xlCisgICAgICAgIGVsZW1lbnQgdGhhdCB0aGUgbGlu ayBVUkwgY29tZXMgZnJvbS4KKworMjAxNS0wMy0zMSAgVGltb3RoeSBIb3J0b24gIDx0aW1vdGh5 X2hvcnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgU3dpcGVzIG9jY3VyIGluIHRoZSB3cm9uZyBk aXJlY3Rpb24gaW4gUlRMCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDMyNTcKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwMzAwODYyPgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJJbW1lZGlhdGVBY3Rpb25Db250cm9s bGVyLm1tIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJJbW1lZGlhdGVBY3Rpb25Db250 cm9sbGVyLm1tCmluZGV4IGUzNzM0MmVlZmRiYmQyY2NmYWI0ODNiOTFkYzZkNzI2N2Y2Mzk2NDUu LjFiM2QxNzk0Y2IyOWU5MjczNzkzNWIxZmRiMGUwZDMyMjBlNTk4MjcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkltbWVkaWF0ZUFjdGlvbkNvbnRyb2xs ZXIubW0KQEAgLTIxMywxMCArMjEzLDEwIEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogewog ICAgIE5TVVJMICp1cmwgPSBfaGl0VGVzdFJlc3VsdC5hYnNvbHV0ZUxpbmtVUkwoKTsKICAgICBO U1N0cmluZyAqYWJzb2x1dGVVUkxTdHJpbmcgPSBbdXJsIGFic29sdXRlU3RyaW5nXTsKLSAgICBp ZiAodXJsICYmIFdlYkNvcmU6OnByb3RvY29sSXNJbkhUVFBGYW1pbHkoYWJzb2x1dGVVUkxTdHJp bmcpICYmIF9oaXRUZXN0UmVzdWx0LmlubmVyTm9kZSgpKSB7CisgICAgaWYgKHVybCAmJiBXZWJD b3JlOjpwcm90b2NvbElzSW5IVFRQRmFtaWx5KGFic29sdXRlVVJMU3RyaW5nKSAmJiBfaGl0VGVz dFJlc3VsdC5VUkxFbGVtZW50KCkpIHsKICAgICAgICAgX3R5cGUgPSBXZWJJbW1lZGlhdGVBY3Rp b25MaW5rUHJldmlldzsKIAotICAgICAgICBSZWZQdHI8UmFuZ2U+IGxpbmtSYW5nZSA9IHJhbmdl T2ZDb250ZW50cygqX2hpdFRlc3RSZXN1bHQuaW5uZXJOb2RlKCkpOworICAgICAgICBSZWZQdHI8 UmFuZ2U+IGxpbmtSYW5nZSA9IHJhbmdlT2ZDb250ZW50cygqX2hpdFRlc3RSZXN1bHQuVVJMRWxl bWVudCgpKTsKICAgICAgICAgUmVmUHRyPFRleHRJbmRpY2F0b3I+IGxpbmtUZXh0SW5kaWNhdG9y ID0gVGV4dEluZGljYXRvcjo6Y3JlYXRlV2l0aFJhbmdlKCpsaW5rUmFuZ2UsIFRleHRJbmRpY2F0 b3JQcmVzZW50YXRpb25UcmFuc2l0aW9uOjpGYWRlSW4pOwogICAgICAgICBbX3dlYlZpZXcgX3Nl dFRleHRJbmRpY2F0b3I6bGlua1RleHRJbmRpY2F0b3IuZ2V0KCkgZmFkZU91dDpOT107CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1h Yy5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5t bQppbmRleCBlNzczMGVhNWRkMTkzMTc0YmM2MzdkMWIxOTg0OGIxOTBlOGQ2YjNiLi40ZjgyMWRh M2M3NmU0YjJjNjMyMmNkN2Q0N2I2ZWM3YjBmYTA3OTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dlYlBhZ2VNYWMubW0KKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tCkBAIC0xMDQxLDkgKzEw NDEsOSBAQCB2b2lkIFdlYlBhZ2U6OnBlcmZvcm1BY3Rpb25NZW51SGl0VGVzdEF0TG9jYXRpb24o V2ViQ29yZTo6RmxvYXRQb2ludCBsb2NhdGlvbkluVgogICAgIFJlZlB0cjxSYW5nZT4gc2VsZWN0 aW9uUmFuZ2UgPSBjb3JlUGFnZSgpLT5mb2N1c0NvbnRyb2xsZXIoKS5mb2N1c2VkT3JNYWluRnJh bWUoKS5zZWxlY3Rpb24oKS5zZWxlY3Rpb24oKS5maXJzdFJhbmdlKCk7CiAKICAgICBVUkwgYWJz b2x1dGVMaW5rVVJMID0gaGl0VGVzdFJlc3VsdC5hYnNvbHV0ZUxpbmtVUkwoKTsKLSAgICBOb2Rl ICppbm5lck5vZGUgPSBoaXRUZXN0UmVzdWx0LmlubmVyTm9kZSgpOwotICAgIGlmICghYWJzb2x1 dGVMaW5rVVJMLmlzRW1wdHkoKSAmJiBpbm5lck5vZGUpIHsKLSAgICAgICAgUmVmUHRyPFJhbmdl PiBsaW5rUmFuZ2UgPSByYW5nZU9mQ29udGVudHMoKmlubmVyTm9kZSk7CisgICAgRWxlbWVudCAq VVJMRWxlbWVudCA9IGhpdFRlc3RSZXN1bHQuVVJMRWxlbWVudCgpOworICAgIGlmICghYWJzb2x1 dGVMaW5rVVJMLmlzRW1wdHkoKSAmJiBVUkxFbGVtZW50KSB7CisgICAgICAgIFJlZlB0cjxSYW5n ZT4gbGlua1JhbmdlID0gcmFuZ2VPZkNvbnRlbnRzKCpVUkxFbGVtZW50KTsKICAgICAgICAgYWN0 aW9uTWVudVJlc3VsdC5saW5rVGV4dEluZGljYXRvciA9IFRleHRJbmRpY2F0b3I6OmNyZWF0ZVdp dGhSYW5nZSgqbGlua1JhbmdlLCB0ZXh0SW5kaWNhdG9yVHJhbnNpdGlvbkZvckFjdGlvbk1lbnUo c2VsZWN0aW9uUmFuZ2UuZ2V0KCksICpsaW5rUmFuZ2UsIGZvckltbWVkaWF0ZUFjdGlvbiwgZmFs c2UpKTsKICAgICB9CiAK