14327 2007-06-22 20:41:10 -0700 REGRESSION (r21367): dialogArguments not set in window generated by showModalDialog 2007-07-13 15:22:49 -0700 1 1 1 Unclassified WebKit DOM 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED javascript:showModalDialog("data:text/html,<script>alert(dialogArguments)</script>", "PASS") HasReduction, InRadar, Regression P1 Major --- 1 dmkash webkit-unassigned ddkilzer mitz oldest_to_newest 6649 0 dmkash 2007-06-22 20:41:10 -0700 When I call showModalDialog, window.dialogArguments is always undefined in the resulting window, even though I am passing in an object. This seems to be a regression because it works fine in Safari 419.3. 6561 1 ddkilzer 2007-06-23 11:23:41 -0700 Thanks for the bug report, Dana! Could you provide a small test case demonstrating the issue? (A zip file containing two HTML files is fine.) 6562 2 ddkilzer 2007-06-23 11:27:44 -0700 This URL seems to work for me: javascript:showModalDialog('javascript:alert(window.dialogArguments)', new Object()) I'm using Safari 3.0 (522.12) with a local debug build of WebKit r23737 on Mac OS X 10.4.10 (8R218). 6439 3 15208 dmkash 2007-06-24 13:10:05 -0700 Created attachment 15208 Test case There are three files in the attached zip archive. DialogTest.html is the page to load in your browser with a "Click Me" button, which will load dialog.html in a modal window. The dialog.js file contains scripts run by dialog.html. 6438 4 dmkash 2007-06-24 13:11:48 -0700 Strangely, that URL works for me as well! What's different? 6420 5 ddkilzer 2007-06-24 16:31:06 -0700 Verified the attached test case (Attachment 15208) is a regression from Safari 2.0.4 (419.3) using Safari 3.0 (522.12) with a local debug build of WebKit r23748 on Mac OS X 10.4.10 (8R218). The test case needs further reduction to determine what's the difference between it and the one-liner in Comment #2. 6422 6 ddkilzer 2007-06-24 16:37:10 -0700 <rdar://problem/5291173> 5530 7 mitz 2007-07-05 07:26:54 -0700 Regressed in <http://trac.webkit.org/projects/webkit/changeset/21367>. Dave's test case doesn't fail because it uses a javascript: URL so it doesn't load a new document into the newly-opened window. Here is a minimal failing test case: javascript:showModalDialog("data:text/html,<script>alert(dialogArguments)</script>", "PASS") I think the window's dialogArguments property is cleared as when the new document is loaded, now that every window starts out with an empty document. 4856 8 andersca 2007-07-13 15:22:49 -0700 Committed revision 24276. 15208 2007-06-24 13:10:05 -0700 2007-06-24 13:10:05 -0700 Test case BugSubmission.zip application/zip 3139 dmkash UEsDBAoAAAAAAJh62DYAAAAAAAAAAAAAAAAOABAAQnVnU3VibWlzc2lvbi9VWAwAJcd+RhDEfkb2 ARQAUEsDBBQACAAIACZ/2DYAAAAAAAAAAAAAAAAZABAAQnVnU3VibWlzc2lvbi9kaWFsb2cuaHRt bFVYDADjzn5GmMx+RvYBFAB9kU9TwjAQxc/0U8Q96aGNyEWk6cHCjM4gOlr/cAxNLNGQYLOl8O1t CKMeGE/ZfS/vt5tJejK+z4v5w4QscaXJw/P19DYnEFP6OsgpHRdj8nZT3E1JPzknT1irEimdzCDq wRJxfUVp27ZJO0hsXdHikW49pu9zhzJ2+1AiUEAWRel+zHaljWNHCP3hcBiC4C9daW4qBtIA+amy jiG5yKJeupLIiYfE8qtRGwa5NSgNxsVuLYGUoWOAcovUQ0ekXPLaSWQNvseXQD0FFWqZoXQ4Vlzb KqVB6SxX1mqNxNUlA7E3kw8HBDv8gfrBNzzcgh82BHiW0uB0pCilYekoXVixI0owWFnBdRgJfphQ m6BL53glfb6T/jqLBtEa1zmh+iP2gVhTalV+MmiVEbZNaolNbV64biTDupGjg15q6+Tp2Qiy+eQp pSF/BHnxP/Kda3eEObv/RYb9u757sj/9F2TRN1BLBwhc1KqcYQEAAHMCAABQSwMEFAAIAAgAyoDY NgAAAAAAAAAAAAAAABcAEABCdWdTdWJtaXNzaW9uL2RpYWxvZy5qc1VYDADjzn5Gu85+RvYBFACF Vm1PIkkQ/jzzK0piFnBxUC+5y+GZnC5m12TVRLlsLsYPzUwBfTbdZLoHbm7jf7+qmheBNVnCh2a6 6qmX56kahkdxdLH7gfH9p79ur+8m8OXmcXL/8DfsGcRx9FX5ALcu0zON2SiKDscq4AjOTk5+G578 Ojw7pePol99HJ2dwGEeNIVyVbHtZhIXLR5AtX5RfsMGnIs/RBhi7lA0ecK29dnYEp8lpcpacks0P af70Ex8N43h4dBDDEfw5K2waCBK01YHyUeabtnJj1RL9SqUIDw+PSaaVcXO5yLRPC895wGShPbQQ G22M4JCt/g8hLBBWao6gPChYMjhUOFB4bedisFamQE9u8mujbeY2dbTLfF4sqXwPq9ytMA9lAnAT JM6IUomiY/iMgbHRew4UHJmi55bRkQELjznMcrcE1PQ7h33onp6BDqA5RR9ySqsP7gezZOnn50Cm tobhul1hswG7EWsBMM/Jr8mE7il0RglLj+h7dz8BX+igpgbJN+d7OD4GZTaqlBLXOsO3YqhAbjcX eRkCLldS05zrtaDyXJXgZlvcJFdFCM6OcQZu+g+mVJvUvV/JlM1YA9uMw0VLY68ff4+jtcqjKOKq SWHDITwGRTW6grsfFpDhTBUmgIBZ6p3NwLo2dXYkSFsYcx5HcaQMsdd7n9w+WUQSg7lkzpoeSvr8 QL0JQXnqKquFI6qMjkF8a7pZbtJzpBTXaFg2sBD9zXAD6cLpFH1lUULqCpMJpmAIat28qkwFXaqk 2+qPlRF2PcWrVs5AYDYLnS5YFGwyFQlm9QjUhVH9pH6JECTTnWYmgkI6X6oXmgxqKwnaV+JuAm4p gLxl5mgAGzYYmagSnDbqALyDDXZ5RufW5TyfKsDK0ShPtdE0XXFECu9BKFfIwHuTQhuwU9XZgX4c 1RzvWVVk/gym6rHAkNYq83cmDg4qDUm49+PJYMbRa1wHFaMtr8qpsysImr65k3HyK0z1rNzihhgu XUGaWRNPKYmF2Qs8w7LKMp1T5oY30XW1CWh6B0xjjtUSIa3QhC8POnGl6m8IOSpjyh1J8PpL6XnA Cf4b7hxNPkMMmEO46Wa8x2aE3oibANwGvkxuv0JQ83ZftouPqdRb87HFtkD4era0tZgzDJF92OvU /p1+0l5Qu6Sn1NJ6YA/p0dt6QNMHJo02BCAVyiwMtIx5RcEB1oTlGIrcNlugva91QVZEb7dSVBc+ fIADwqYEfVA2ZYtLlni/wqISLr0nzptlbaUZ11UCsg3qcMofa78VHqsVFKGhGdpL4GIrAQ7zvQ5V vVWEAaRcmAC9E4T7vRUjc6nIMaH1XKd0Vd5k3CuunNUp8bdC1NVssJaarcrl26ar1PanZ/aP+HXR A00PTgZgkNc1moQO87Cg1xL8wQ/p8PFj1S0J0uI8NYfa45nc+b1RBG2SsVty1pTqk36WbCldIeut gdiO9mvEuuD0s0z05GxqdPrS7N+mEV0PU5eVjYKcNU5lFJYg3t4zIiPRRNs/dkp0JktC/jCMZdw7 /Z3/Jz0u8vX8f1BLBwiRRBDQfwQAAKQJAABQSwMEFAAIAAgAWH/YNgAAAAAAAAAAAAAAAB0AEABC dWdTdWJtaXNzaW9uL0RpYWxvZ1Rlc3QuaHRtbFVYDADjzn5G+Mx+RvYBFADFVW1v2zYQ/mz/ihs3 wDZgS/WCAovfhs4u0GJNU6zusgL9QotniylFqiRlxRv633ekZDfxEqDfFsAKRd09z/Ge493sh9X1 cv3x3UvIfaHg3Yff3rxeAhul6c3FMk1X6xX89Wp99QbGyTN4763MfJq+fMu6HZZ7X07StK7rpL5I jN2l6z/SuwAzDn7tcuSiUyK8YItudxZp7gql3fwRhPHl5WXjyILRRHG9mzPUDE6rBWEgF4tuZ1ag 5xBARvilkvs5WxrtUfvR+lAig6x5mzOPdz4NoFPIcm4d+nnlt6NfWEoohOP8QSF4cmptM+cYFCgk nzOXWYy0nc6PBTrHd7iSe3r7h36dLXFMQHquZAba2IIr2BglYIxFOk6eYwEvrORqCI5rN3Jo5XZK jl+JNo284SDEIUsPzmZzRqTK7JJbiuBeRLd8zxsrdjoDaw6xIKD4hdJ7gvpOV4pkzy1Y9JXVKP7k qkKYA9NccBbi3FY689JoqLR8n5v6ygiuVjHE/gCOWSAMejpT4Au7c8GvE35pCq+34B66gXTgqrI0 1qMYgs9RQ409paByJELOfRJ85Rb6UEstTJ2cIwyCQSQOFEuL3CNwDWZzixmd3UAeJCBo4HZXFVQE bgKmstAKSMYCQriwqbw32kXK0wEoAxpruI5w/cH0wcekcDsy6H00FeR8j1BwgSGxeocucAdaqbeh FmLmaEV7dGqeZabSPgEIvhkFjJKMLZUGwZCVkC7jVsAhhHpE3CABEIvZS70Do5PZxkK6aJ43plLR HpT8jIE9Yt0H+LXXxH9M1wfKcvhcWhxtKqk8QVNqoak78FiUivI5paKm/J9kQTgCnFIa6AJCk+n2 trlodl5QZwr2j1Ueb/rwmNohywgB7eSAbtpYvEK5y/3k5+fPyrt260YKn08u4o5FJ//mG4XRJUdV TrSZOs995cKKNeJ9DQ9UDr8VznmEFP5W2qLP/jddP+lPmq5LELOOsj4p6RAyajefY0S96997bRU/ jfBYAA9AllxnqE5A99PWXuSlQmoUpvLRob1HUew6l9Q9+/BTn33rj2yQUDqdX+ahPuKF7ZwbWKTD Y7ToP+08OLWT2BLOdJuDt/Q/EgD9nePwskQtGg5hsli4SRY7xpqa41sjMEpuH0ib86APNaaQesEG TQzHAvrPQb6f5Ch+LLDI0EqDImlpmslwbOj04qWnKdFcnDU6P0ubHRpds7QZhd3ZxohDmCRC7kGK +f34aD7QbjPpGn2p2qL2NAYe6epTtljGyrjCWdo4hEBoHTlmcZIuuv8CUEsHCM0hOz7HAwAAOggA AFBLAQIVAwoAAAAAAJh62DYAAAAAAAAAAAAAAAAOAAwAAAAAAAAAAEDtQQAAAABCdWdTdWJtaXNz aW9uL1VYCAAlx35GEMR+RlBLAQIVAxQACAAIACZ/2DZc1KqcYQEAAHMCAAAZAAwAAAAAAAAAAECk gTwAAABCdWdTdWJtaXNzaW9uL2RpYWxvZy5odG1sVVgIAOPOfkaYzH5GUEsBAhUDFAAIAAgAyoDY NpFEENB/BAAApAkAABcADAAAAAAAAAAAQLSB9AEAAEJ1Z1N1Ym1pc3Npb24vZGlhbG9nLmpzVVgI AOPOfka7zn5GUEsBAhUDFAAIAAgAWH/YNs0hOz7HAwAAOggAAB0ADAAAAAAAAAAAQKSByAYAAEJ1 Z1N1Ym1pc3Npb24vRGlhbG9nVGVzdC5odG1sVVgIAOPOfkb4zH5GUEsFBgAAAAAEAAQAQwEAAOoK AAAAAA==