143266 2015-03-31 09:30:36 -0700 Avoid applying invalid media attribute 2015-03-31 12:37:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 143262 P2 Normal --- 1 yoav webkit-unassigned cdumez oldest_to_newest 1081642 0 yoav 2015-03-31 09:30:36 -0700 Avoid applying invalid media attribute 1081645 1 249825 yoav 2015-03-31 09:37:31 -0700 Created attachment 249825 Patch 1081646 2 yoav 2015-03-31 09:39:09 -0700 When <link rel=stylesheet> with an invalid media attribute was part of the HTML, I saw that it resulted in a non-empty MediaQuerySet, containing a single query with no expressions. (which didn't have its m_ignored flag on) Therefore I added an extra check that makes sure that the queries handled by MediaQueryEvaluator::eval have expressions, and if not, they are treated as ignored. 1081648 3 yoav 2015-03-31 09:51:31 -0700 I accidentally filed that as a separate issue, when I should have added a patch on the original bug. *** This bug has been marked as a duplicate of bug 143262 *** 249825 2015-03-31 09:37:31 -0700 2015-03-31 12:37:05 -0700 Patch bug-143266-20150331183647.patch text/plain 3935 yoav U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzM1MzZiYzYyNGNjYThh YTgwNjJlMjY0MjM5Y2ViYWIwNTIyMzViMy4uMGQ0ZGRmZWZjZjQ4YzY2YjJlZWYwYTI3Y2JmNDM1 M2VmN2UzM2NiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE1LTAzLTMxICBZb2F2 IFdlaXNzICA8eW9hdkB5b2F2LndzPgorCisgICAgICAgIEF2b2lkIGFwcGx5aW5nIGludmFsaWQg bWVkaWEgYXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDMyNjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGVuIDxsaW5rIHJlbD1zdHlsZXNoZWV0PiB3aXRoIGFuIGludmFsaWQgbWVkaWEg YXR0cmlidXRlIHdhcyBwYXJ0CisgICAgICAgIG9mIHRoZSBIVE1MLCBJIHNhdyB0aGF0IGl0IHJl c3VsdGVkIGluIGEgbm9uLWVtcHR5IE1lZGlhUXVlcnlTZXQsCisgICAgICAgIGNvbnRhaW5pbmcg YSBzaW5nbGUgcXVlcnkgd2l0aCBubyBleHByZXNzaW9ucy4gKHdoaWNoIGRpZG4ndCBoYXZlIGl0 cworICAgICAgICBtX2lnbm9yZWQgZmxhZyBvbikKKworICAgICAgICBUaGVyZWZvcmUgSSBhZGRl ZCBhbiBleHRyYSBjaGVjayB0aGF0IG1ha2VzIHN1cmUgdGhhdCB0aGUgcXVlcmllcyBoYW5kbGVk CisgICAgICAgIGJ5IE1lZGlhUXVlcnlFdmFsdWF0b3I6OmV2YWwgaGF2ZSBleHByZXNzaW9ucywg YW5kIGlmIG5vdCwKKyAgICAgICAgdGhleSBhcmUgdHJlYXRlZCBhcyBpZ25vcmVkLgorCisgICAg ICAgIFRlc3Q6IGZhc3QvZG9tL0hUTUxMaW5rRWxlbWVudC9saW5rLXN0eWxlc2hlZXQtaW52YWxp ZC1tZWRpYS5odG1sCisKKyAgICAgICAgKiBjc3MvTWVkaWFRdWVyeUV2YWx1YXRvci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVF1ZXJ5RXZhbHVhdG9yOjpldmFsKToKKwogMjAxNS0wMy0y NSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE4MTkzMi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9NZWRpYVF1ZXJ5RXZhbHVhdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYVF1 ZXJ5RXZhbHVhdG9yLmNwcAppbmRleCAyYTAwODFjZTllMTE2Mjg0NzI4NTQyODlkNjRmNDFiZmU2 MzM4NTY2Li5hMTkwM2I3NzkzNmIwOWJhNzc1NmE0MTg2MmI5ZDAzYmIwZmQ5ZDFlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFRdWVyeUV2YWx1YXRvci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvY3NzL01lZGlhUXVlcnlFdmFsdWF0b3IuY3BwCkBAIC0xNDQsNyArMTQ0LDcg QEAgYm9vbCBNZWRpYVF1ZXJ5RXZhbHVhdG9yOjpldmFsKGNvbnN0IE1lZGlhUXVlcnlTZXQqIHF1 ZXJ5U2V0LCBTdHlsZVJlc29sdmVyKiBzdHkKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHF1 ZXJpZXMuc2l6ZSgpICYmICFyZXN1bHQ7ICsraSkgewogICAgICAgICBNZWRpYVF1ZXJ5KiBxdWVy eSA9IHF1ZXJpZXNbaV0uZ2V0KCk7CiAKLSAgICAgICAgaWYgKHF1ZXJ5LT5pZ25vcmVkKCkpCisg ICAgICAgIGlmIChxdWVyeS0+aWdub3JlZCgpIHx8ICFxdWVyeS0+ZXhwcmVzc2lvbnMoKS5zaXpl KCkpCiAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICBpZiAobWVkaWFUeXBlTWF0Y2go cXVlcnktPm1lZGlhVHlwZSgpKSkgewpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGE5MmU3NjI0NDI3ZDJkNTQ5OWFjOTQ4Y2Zi NjRiZDE0MzEzYTc0ZjcuLmRlN2VlMmU0OGU2ZTE1NzJmMDgxODEwYTBlZjc5YzhlNDdlOWUxZTIg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNS0wMy0zMSAgWW9hdiBXZWlzcyAgPHlvYXZAeW9h di53cz4KKworICAgICAgICBBdm9pZCBhcHBseWluZyBpbnZhbGlkIG1lZGlhIGF0dHJpYnV0ZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMjY2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlc2UgdGVz dHMgbWFrZSBzdXJlIHRoYXQgd2hlbiA8bGluayByZWw9c3R5bGVzaGVldD4gaXMgcHJlc2VudCB3 aXRoIGFuIGludmFsaWQKKyAgICAgICAgbWVkaWEgYXR0cmlidXRlLCB0aGUgc3R5bGVzIGFyZSBu b3QgYmVpbmcgYXBwbGllZC4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxMaW5rRWxlbWVudC9s aW5rLXN0eWxlc2hlZXQtaW52YWxpZC1tZWRpYS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZG9tL0hUTUxMaW5rRWxlbWVudC9saW5rLXN0eWxlc2hlZXQtaW52YWxpZC1tZWRp YS5odG1sOiBBZGRlZC4KKwogMjAxNS0wMy0yNSAgTWFyY29zIENoYXZhcnLDrWEgVGVpamVpcm8g IDxjaGF2YXJyaWExOTkxQGdtYWlsLmNvbT4KIAogICAgICAgICBHVEsrIEdhcmRlbmluZyAyNHRo IE1hcmNoCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MTGlua0VsZW1lbnQv bGluay1zdHlsZXNoZWV0LWludmFsaWQtbWVkaWEtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9kb20vSFRNTExpbmtFbGVtZW50L2xpbmstc3R5bGVzaGVldC1pbnZhbGlkLW1lZGlhLWV4 cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40OGU4ZjBmNjQ4ZmUyNDYzNGRkNmE2OTU1OTFkZTdjMGZl YjI3ODMyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTExpbmtF bGVtZW50L2xpbmstc3R5bGVzaGVldC1pbnZhbGlkLW1lZGlhLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDIgQEAKK1NVQ0NFU1MKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRN TExpbmtFbGVtZW50L2xpbmstc3R5bGVzaGVldC1pbnZhbGlkLW1lZGlhLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9IVE1MTGlua0VsZW1lbnQvbGluay1zdHlsZXNoZWV0LWludmFsaWQtbWVk aWEuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi5jMGNlMmRhMDVjYzc2ZTM5NDg3ZWZiOWM0ZTIwNGJjYjg2ZGRl ZTc3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTExpbmtFbGVt ZW50L2xpbmstc3R5bGVzaGVldC1pbnZhbGlkLW1lZGlhLmh0bWwKQEAgLTAsMCArMSwxNCBAQAor PCFET0NUWVBFIGh0bWw+Cis8bGluayByZWw9c3R5bGVzaGVldCBocmVmPSJkYXRhOnRleHQvY3Nz LCN0ZXN0IHsgd2lkdGg6IDEwMHB4IH0iIG1lZGlhPSIod2lkdGggaW52YWxpZCkiPgorPGRpdiBp ZD1yZXN1bHQ+PC9kaXY+Cis8ZGl2IGlkPXRlc3Q+PC9kaXY+Cis8c2NyaXB0PgorICAgIGlmICh3 aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAg dmFyIHRlc3QgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdCIpOworICAgIHZhciByZXN1 bHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0Iik7CisgICAgaWYgKHRlc3Qub2Zm c2V0V2lkdGggPT0gMTAwKQorICAgICAgICByZXN1bHQuaW5uZXJIVE1MID0gIkZBSUxVUkUiOwor ICAgIGVsc2UKKyAgICAgICAgcmVzdWx0LmlubmVySFRNTCA9ICJTVUNDRVNTIjsKKzwvc2NyaXB0 Pgo=