<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>143264</bug_id>
          
          <creation_ts>2015-03-31 08:04:02 -0700</creation_ts>
          <short_desc>Fix the build on the WinCairo bot due to missing CoreFoundation.lib</short_desc>
          <delta_ts>2015-04-29 23:48:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Csaba Osztrogonác">ossy</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>ossy</cc>
    
    <cc>peavo</cc>
    
    <cc>roger_fong</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1081636</commentid>
    <comment_count>0</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2015-03-31 08:04:02 -0700</bug_when>
    <thetext>LINK : fatal error LNK1181: cannot open input file &apos;CoreFoundation.lib&apos; [C:\cygwin\home\webkitbot\win-cairo-release\build\Source\WTF\WTF.vcxproj\WTF.vcxproj]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1081638</commentid>
    <comment_count>1</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-03-31 08:45:08 -0700</bug_when>
    <thetext>WinCairo shouldn&apos;t be trying to link to CoreFoundation.lib. It should be using CFLite.lib.

This seems like one of the build targets for WinCairo is using the Apple Windows variation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1081974</commentid>
    <comment_count>2</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2015-04-01 05:34:30 -0700</bug_when>
    <thetext>Is there any plan to fix the WinCairo bot? It is still broken for a week.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1081988</commentid>
    <comment_count>3</comment_count>
    <who name="">peavo</who>
    <bug_when>2015-04-01 06:42:42 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Is there any plan to fix the WinCairo bot? It is still broken for a week.

It is strange that I don&apos;t see this error when compiling locally.
It is also strange that the log indicates that no WTF files are compiled, as if they are up to date, it seems to go straight to linking.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1082037</commentid>
    <comment_count>4</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-04-01 10:24:24 -0700</bug_when>
    <thetext>I took it down.  It&apos;s not uploading any useful information.  I&apos;ll fix it in the next few days.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1084746</commentid>
    <comment_count>5</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2015-04-13 00:46:42 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; I took it down.  It&apos;s not uploading any useful information.  I&apos;ll fix it in
&gt; the next few days.

The bot is still down. It was green on 25th Mar last time. (~3 weeks before)
Is there anybody maintain the WinCairo bot and/or the port?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1084776</commentid>
    <comment_count>6</comment_count>
    <who name="">peavo</who>
    <bug_when>2015-04-13 06:08:19 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; I took it down.  It&apos;s not uploading any useful information.  I&apos;ll fix it in
&gt; &gt; the next few days.
&gt; 
&gt; The bot is still down. It was green on 25th Mar last time. (~3 weeks before)
&gt; Is there anybody maintain the WinCairo bot and/or the port?

Yes, WinCairo is being maintained :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1084871</commentid>
    <comment_count>7</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-04-13 10:47:17 -0700</bug_when>
    <thetext>And I intend to get a bot up and running this week.  Sorry it&apos;s taken so long.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089461</commentid>
    <comment_count>8</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2015-04-28 04:06:25 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; And I intend to get a bot up and running this week.  Sorry it&apos;s taken so
&gt; long.

The bot is still down, the latest green build was more than 5 weeks 
before, so I think we can consider the WinCairo bot unmaintained.

It&apos;s hard to take a port seriously, which doesn&apos;t have 
enough resource to maintain a buildbot on a _daily_ basis.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089745</commentid>
    <comment_count>9</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-04-28 14:37:34 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; (In reply to comment #7)
&gt; &gt; And I intend to get a bot up and running this week.  Sorry it&apos;s taken so
&gt; &gt; long.
&gt; 
&gt; The bot is still down, the latest green build was more than 5 weeks 
&gt; before, so I think we can consider the WinCairo bot unmaintained.
Sorry, I did not stick to my schedule.  I&apos;m installing things on a Windows machine right now, which is unfortunately no trivial task.
&gt; 
&gt; It&apos;s hard to take a port seriously, which doesn&apos;t have 
&gt; enough resource to maintain a buildbot on a _daily_ basis.
The way I see it, this is only a nuisance to those who are actively developing the WinCairo port.  I want these people to continue easily and I like to hack on WinCairo to compare with the AppleWin port and I want non-Apple companies to be able to use WebKit on Windows, so I maintain a buildbot, but unfortunately I&apos;ve had some more urgent things recently.  I&apos;ll step it up a bit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1089812</commentid>
    <comment_count>10</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-04-28 18:00:08 -0700</bug_when>
    <thetext>After http://trac.webkit.org/changeset/183521 I have a WinCairo bot that builds successfully.  I left the buildslave password and stuff at home, so it&apos;ll be up soon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1090114</commentid>
    <comment_count>11</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-04-29 12:24:54 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/183566 should have fixed this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1090169</commentid>
    <comment_count>12</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-04-29 15:09:48 -0700</bug_when>
    <thetext>Now I&apos;m seeing some errors like this:

Traceback (most recent call last):
    File &quot;C:/Users/Alex/Documents/WinCairoBot/win-cairo-release/build/Source/JavaScriptCore/generate-js-builtins&quot;, line 283, in &lt;module&gt;
      os.rename(output_base + &quot;.h.tmp&quot;, output_base + &quot;.h&quot;)
  WindowsError: [Error 183] Cannot create a file when that file already exists

I&apos;m uploading a fix for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1090172</commentid>
    <comment_count>13</comment_count>
      <attachid>251991</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-04-29 15:11:10 -0700</bug_when>
    <thetext>Created attachment 251991
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1090175</commentid>
    <comment_count>14</comment_count>
      <attachid>251991</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2015-04-29 15:13:02 -0700</bug_when>
    <thetext>Comment on attachment 251991
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1090200</commentid>
    <comment_count>15</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2015-04-29 16:03:10 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/183581

There are still a few places in the tests that try to call /usr/bin/env or similar commands, but it builds pretty reliably.  We&apos;ll get the tests to not require cygwin pretty soon, but it&apos;s already showing useful information about whether WinCairo builds or not.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1090375</commentid>
    <comment_count>16</comment_count>
    <who name="">peavo</who>
    <bug_when>2015-04-29 23:48:00 -0700</bug_when>
    <thetext>Thanks!</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>251991</attachid>
            <date>2015-04-29 15:11:10 -0700</date>
            <delta_ts>2015-04-29 15:13:02 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-143264-20150429150959.patch</filename>
            <type>text/plain</type>
            <size>1669</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgzNTgwKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA
CisyMDE1LTA0LTI5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+
CisKKyAgICAgICAgRml4IG5vbi1jeWd3aW4gaW5jcmVtZW50YWwgYnVpbGRzIG9uIFdpbmRvd3Mu
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMyNjQK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGdlbmVy
YXRlLWpzLWJ1aWx0aW5zOgorICAgICAgICBSZW1vdmUgc3RhbGUgaGVhZGVycyBiZWZvcmUgY2Fs
bGluZyBvcy5yZW5hbWUgdG8gcmVwbGFjZSB0aGVtLgorCiAyMDE1LTA0LTI5ICBGaWxpcCBQaXps
byAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgSlNUeXBlSW5mbyBzaG91bGQgaGF2ZSBh
biBpbmxpbmUgdHlwZSBmbGFnIHRvIGluZGljYXRlIG9mIGdldENhbGxEYXRhKCkgaGFzIGJlZW4g
b3ZlcnJpZGRlbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2dlbmVyYXRlLWpzLWJ1aWx0
aW5zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9nZW5lcmF0ZS1qcy1idWls
dGlucwkocmV2aXNpb24gMTgzNTU2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2dlbmVyYXRl
LWpzLWJ1aWx0aW5zCSh3b3JraW5nIGNvcHkpCkBAIC0yODAsMTEgKzI4MCwxNSBAQCBidWlsdGlu
c0hlYWRlci5jbG9zZSgpCiBidWlsdGluc0ltcGxlbWVudGF0aW9uLmNsb3NlKCkKIAogaWYgKG5v
dCBvcy5wYXRoLmV4aXN0cyhvdXRwdXRfYmFzZSArICIuaCIpKSBvciAobm90IGZpbGVjbXAuY21w
KG91dHB1dF9iYXNlICsgIi5oLnRtcCIsIG91dHB1dF9iYXNlICsgIi5oIiwgc2hhbGxvdz1GYWxz
ZSkpOgorICAgIGlmIChvcy5wYXRoLmV4aXN0cyhvdXRwdXRfYmFzZSArICIuaCIpKToKKyAgICAg
ICAgb3MucmVtb3ZlKG91dHB1dF9iYXNlICsgIi5oIikKICAgICBvcy5yZW5hbWUob3V0cHV0X2Jh
c2UgKyAiLmgudG1wIiwgb3V0cHV0X2Jhc2UgKyAiLmgiKQogZWxzZToKICAgICBvcy5yZW1vdmUo
b3V0cHV0X2Jhc2UgKyAiLmgudG1wIikKIAogaWYgKG5vdCBvcy5wYXRoLmV4aXN0cyhvdXRwdXRf
YmFzZSArICIuY3BwIikpIG9yIChub3QgZmlsZWNtcC5jbXAob3V0cHV0X2Jhc2UgKyAiLmNwcC50
bXAiLCBvdXRwdXRfYmFzZSArICIuY3BwIiwgc2hhbGxvdz1GYWxzZSkpOgorICAgIGlmIChvcy5w
YXRoLmV4aXN0cyhvdXRwdXRfYmFzZSArICIuY3BwIikpOgorICAgICAgICBvcy5yZW1vdmUob3V0
cHV0X2Jhc2UgKyAiLmNwcCIpCiAgICAgb3MucmVuYW1lKG91dHB1dF9iYXNlICsgIi5jcHAudG1w
Iiwgb3V0cHV0X2Jhc2UgKyAiLmNwcCIpCiBlbHNlOgogICAgIG9zLnJlbW92ZShvdXRwdXRfYmFz
ZSArICIuY3BwLnRtcCIpCg==
</data>
<flag name="review"
          id="276812"
          type_id="1"
          status="+"
          setter="bfulgham"
    />
          </attachment>
      

    </bug>

</bugzilla>