143259 2015-03-31 03:53:03 -0700 [iOS] Rotating PDF in Safari scrolls to the wrong position 2015-03-31 13:51:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca mitz sam simon.fraser oldest_to_newest 1081605 0 thorton 2015-03-31 03:53:03 -0700 [iOS] Rotating PDF in Safari scrolls to the wrong position 1081606 1 249816 thorton 2015-03-31 03:53:31 -0700 Created attachment 249816 Patch 1081630 2 mitz 2015-03-31 07:32:45 -0700 <rdar://problem/19872693> 1081633 3 249816 mitz 2015-03-31 07:35:14 -0700 Comment on attachment 249816 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249816&action=review > Source/WebKit2/UIProcess/ios/WKPDFView.mm:177 > + CGFloat oldDocumentLeftPercentage = 0; > + CGFloat oldDocumentTopPercentage = 0; These are clearly not percentages. They are fractions. 1081768 4 thorton 2015-03-31 13:51:11 -0700 http://trac.webkit.org/changeset/182202 249816 2015-03-31 03:53:31 -0700 2015-03-31 07:35:14 -0700 Patch bug-143259-20150331035249.patch text/plain 2595 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTUzNDNkNzliMzBkZGZj ZDIxNmVhMzZkYmFhOGIxMTg1MDA2NjRhMS4uZGRmN2IyY2FjNTJlMmQ1NjdjMjhiNGEyOTViYmE5 M2E2MmM5OGU4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTMxICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBS b3RhdGluZyBQREYgaW4gU2FmYXJpIHNjcm9sbHMgdG8gdGhlIHdyb25nIHBvc2l0aW9uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMyNTkKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE5ODcyNjkzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW06CisgICAg ICAgICgtW1dLUERGVmlldyB3ZWJfc2V0TWluaW11bVNpemU6XSk6CisgICAgICAgIE1haW50YW4g dGhlIHJlbGF0aXZlIHRvcC9sZWZ0IHdpdGhpbiB0aGUgcmVzY2FsZWQgZG9jdW1lbnQuCisKIDIw MTUtMDMtMzAgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBb aU9TXSBXZWJDb250ZW50IGNyYXNoaW5nIGF0IFdlYkNvcmU6IFdlYkNvcmU6OlJhbmdlOjpjb2xs ZWN0U2VsZWN0aW9uUmVjdHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dLUERGVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tQREZWaWV3 Lm1tCmluZGV4IDA0MzQ5MmMxNWU0MGFlNjU5NjUxNTIxZDdlNGMzODhiNmEzNjM1ZmMuLjMxOTdi OTJkOTQ4NGYxNzFhZTdlYTIzMjhmNjYwMGQ0ZDUxZjI1MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tCkBAIC0xNzMsOCArMTczLDI4IEBAIHR5cGVkZWYgc3Ry dWN0IHsKIHsKICAgICBfbWluaW11bVNpemUgPSBzaXplOwogCisgICAgQ0dGbG9hdCBvbGREb2N1 bWVudExlZnRQZXJjZW50YWdlID0gMDsKKyAgICBDR0Zsb2F0IG9sZERvY3VtZW50VG9wUGVyY2Vu dGFnZSA9IDA7CisgICAgQ0dTaXplIGNvbnRlbnRTaXplID0gX3Njcm9sbFZpZXcuY29udGVudFNp emU7CisgICAgaWYgKGNvbnRlbnRTaXplLndpZHRoICYmIGNvbnRlbnRTaXplLmhlaWdodCkgewor ICAgICAgICBDR1BvaW50IGNvbnRlbnRPZmZzZXQgPSBfc2Nyb2xsVmlldy5jb250ZW50T2Zmc2V0 OworICAgICAgICBVSUVkZ2VJbnNldHMgY29udGVudEluc2V0ID0gX3Njcm9sbFZpZXcuY29udGVu dEluc2V0OworICAgICAgICBvbGREb2N1bWVudExlZnRQZXJjZW50YWdlID0gKGNvbnRlbnRPZmZz ZXQueCArIGNvbnRlbnRJbnNldC5sZWZ0KSAvIGNvbnRlbnRTaXplLndpZHRoOworICAgICAgICBv bGREb2N1bWVudFRvcFBlcmNlbnRhZ2UgPSAoY29udGVudE9mZnNldC55ICsgY29udGVudEluc2V0 LnRvcCkgLyBjb250ZW50U2l6ZS5oZWlnaHQ7CisgICAgfQorCiAgICAgW3NlbGYgX2NvbXB1dGVQ YWdlQW5kRG9jdW1lbnRGcmFtZXNdOwotICAgIFtzZWxmIF9yZXZhbGlkYXRlVmlld3NdOworCisg ICAgLy8gRklYTUU6IFRoaXMgZGlzcGF0Y2hfYXN5bmMgaXMgdW5uZWNlc3NhcnkgZXhjZXB0IHRv IHdvcmsgYXJvdW5kIHJkYXI6Ly9wcm9ibGVtLzE1MDM1NjIwLgorICAgIC8vIE9uY2UgdGhhdCBp cyByZXNvbHZlZCwgd2Ugc2hvdWxkIGRvIHRoZSBzZXRDb250ZW50T2Zmc2V0IHdpdGhvdXQgdGhl IGRpc3BhdGNoX2FzeW5jLgorICAgIFJldGFpblB0cjxXS1BERlZpZXc+IHJldGFpbmVkU2VsZiA9 IHNlbGY7CisgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUoKSwgW3Jl dGFpbmVkU2VsZiwgb2xkRG9jdW1lbnRMZWZ0UGVyY2VudGFnZSwgb2xkRG9jdW1lbnRUb3BQZXJj ZW50YWdlXSB7CisgICAgICAgIENHU2l6ZSBjb250ZW50U2l6ZSA9IHJldGFpbmVkU2VsZi0+X3Nj cm9sbFZpZXcuY29udGVudFNpemU7CisgICAgICAgIFVJRWRnZUluc2V0cyBjb250ZW50SW5zZXQg PSByZXRhaW5lZFNlbGYtPl9zY3JvbGxWaWV3LmNvbnRlbnRJbnNldDsKKyAgICAgICAgW3JldGFp bmVkU2VsZi0+X3Njcm9sbFZpZXcgc2V0Q29udGVudE9mZnNldDpDR1BvaW50TWFrZSgob2xkRG9j dW1lbnRMZWZ0UGVyY2VudGFnZSAqIGNvbnRlbnRTaXplLndpZHRoKSAtIGNvbnRlbnRJbnNldC5s ZWZ0LCAob2xkRG9jdW1lbnRUb3BQZXJjZW50YWdlICogY29udGVudFNpemUuaGVpZ2h0KSAtIGNv bnRlbnRJbnNldC50b3ApIGFuaW1hdGVkOk5PXTsKKworICAgICAgICBbcmV0YWluZWRTZWxmIF9y ZXZhbGlkYXRlVmlld3NdOworICAgIH0pOwogfQogCiAtICh2b2lkKXNjcm9sbFZpZXdEaWRTY3Jv bGw6KFVJU2Nyb2xsVmlldyAqKXNjcm9sbFZpZXcK