143240 2015-03-30 16:10:10 -0700 When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures 2015-04-01 23:29:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue dbates ddkilzer glenn msaboff thorton oldest_to_newest 1081361 0 ap 2015-03-30 16:10:10 -0700 I've seen a machine where LayoutTestHelper crashes on launch because of some color profile misconfiguration. But we still run the tests, and fail some, because LayoutTestHelper couldn't set a proper color profile. 1081368 1 249780 ap 2015-03-30 16:17:46 -0700 Created attachment 249780 proposed fix 1081369 2 ap 2015-03-30 16:17:57 -0700 rdar://problem/19990425 1082178 3 249780 commit-queue 2015-04-01 23:29:14 -0700 Comment on attachment 249780 proposed fix Clearing flags on attachment: 249780 Committed r182268: <http://trac.webkit.org/changeset/182268> 1082179 4 commit-queue 2015-04-01 23:29:19 -0700 All reviewed patches have been landed. Closing bug. 249780 2015-03-30 16:17:46 -0700 2015-04-01 23:29:14 -0700 proposed fix LayoutTestHelper.txt text/plain 5511 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MjE2MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI0IEBACisyMDE1LTAzLTMwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFdoZW4gTGF5b3V0VGVzdEhlbHBlciBmYWlscyB0byBzdGFydCwgd2UgY29u dGludWUgdG8gcnVuIHRoZSB0ZXN0cywgZW5kaW5nIHVwIHdpdGggbXlzdGVyaW91cyBmYWlsdXJl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMjQw CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzE5OTkwNDI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVz dEhlbHBlci5tOgorICAgICAgICAoY29sb3JQcm9maWxlVVJMRm9yRGlzcGxheSk6CisgICAgICAg IChzYXZlRGlzcGxheUNvbG9yUHJvZmlsZXMpOgorICAgICAgICBHcmFjZWZ1bGx5IGhhbmRsZSBp dCB3aGVuIHRoZSBjdXJyZW50IHByb2ZpbGUgY2Fubm90IGJlIHJldHJpZXZlZCwgZml4aW5nIGF0 CisgICAgICAgIGxlYXN0IG9uZSBjYXNlIHdoZW4gTGF5b3V0VGVzdEhlbHBlciBjb3VsZG4ndCBz dGFydC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xs ZXJzL21hbmFnZXIucHk6CisgICAgICAgIChNYW5hZ2VyLl9zZXRfdXBfcnVuKToKKyAgICAgICAg KE1hbmFnZXIuX2ZvcmNlX3BpeGVsX3Rlc3RzX2lmX25lZWRlZCk6CisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9wb3J0L2Jhc2UucHk6IChQb3J0LnRvLnN0YXJ0X2hlbHBlcik6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5weTogKE1hY1BvcnQuc3RhcnRfaGVscGVyKToK KyAgICAgICAgUmV0dXJuIGFuZCBjaGVjayBhbiBlcnJvciBmcm9tIHN0YXJ0X2hlbHBlcigpLgor CiAyMDE1LTAzLTMwICBNYXJjb3MgQ2hhdmFycsOtYSBUZWlqZWlybyAgPGNoYXZhcnJpYTE5OTFA Z21haWwuY29tPgogCiAgICAgICAgIFVwZGF0ZSBpbnN0YWxsLWRlcGVuZGVuY2llcyBGZWRvcmEg cGFja2FnZXMgYWZ0ZXIgcjE4MTYyNApJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0xh eW91dFRlc3RIZWxwZXIubQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMv TGF5b3V0VGVzdEhlbHBlci5tCShyZXZpc2lvbiAxODE5NjYpCisrKyBUb29scy9EdW1wUmVuZGVy VHJlZS9tYWMvTGF5b3V0VGVzdEhlbHBlci5tCSh3b3JraW5nIGNvcHkpCkBAIC03Myw3ICs3Mywx MiBAQCBzdGF0aWMgTlNVUkwgKmNvbG9yUHJvZmlsZVVSTEZvckRpc3BsYXkoCiAgICAgICAgIHBy b2ZpbGVVUkwgPSAoQ0ZVUkxSZWYpQ0ZEaWN0aW9uYXJ5R2V0VmFsdWUoZmFjdG9yeVByb2ZpbGUs IGtDb2xvclN5bmNEZXZpY2VQcm9maWxlVVJMKTsKICAgICB9CiAgICAgCi0gICAgCisgICAgaWYg KCFwcm9maWxlVVJMKSB7CisgICAgICAgIE5TTG9nKEAiQ291bGQgbm90IGRldGVybWluZSBjdXJy ZW50IGNvbG9yIHByb2ZpbGUsIHNvIGl0IHdpbGwgbm90IGJlIHJlc2V0IGFmdGVyIHJ1bm5pbmcg dGhlIHRlc3RzLiIpOworICAgICAgICBDRlJlbGVhc2UoZGV2aWNlSW5mbyk7CisgICAgICAgIHJl dHVybiBuaWw7CisgICAgfQorCiAgICAgTlNVUkwgKnVybCA9IChOU1VSTCAqKUNGQXV0b3JlbGVh c2UoQ0ZSZXRhaW4ocHJvZmlsZVVSTCkpOwogICAgIENGUmVsZWFzZShkZXZpY2VJbmZvKTsKICAg ICByZXR1cm4gdXJsOwpAQCAtMTE2LDYgKzEyMSw5IEBAIHN0YXRpYyB2b2lkIHNhdmVEaXNwbGF5 Q29sb3JQcm9maWxlcyhOU0EKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAKICAgICAg ICAgTlNVUkwgKmNvbG9yUHJvZmlsZVVSTCA9IGNvbG9yUHJvZmlsZVVSTEZvckRpc3BsYXkoVVVJ RFN0cmluZyk7CisgICAgICAgIGlmICghY29sb3JQcm9maWxlVVJMKQorICAgICAgICAgICAgY29u dGludWU7CisKICAgICAgICAgW3VzZXJDb2xvclByb2ZpbGVzIHNldE9iamVjdDpjb2xvclByb2Zp bGVVUkwgZm9yS2V5OlVVSURTdHJpbmddOwogICAgIH0KIH0KSW5kZXg6IFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdl ci5weQkocmV2aXNpb24gMTgxOTY2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQkod29ya2luZyBjb3B5KQpAQCAtMTQyLDcgKzE0 Miw4IEBAIGNsYXNzIE1hbmFnZXIob2JqZWN0KToKICAgICAgICAgIyBUaGlzIG11c3QgYmUgc3Rh cnRlZCBiZWZvcmUgd2UgY2hlY2sgdGhlIHN5c3RlbSBkZXBlbmRlbmNpZXMsCiAgICAgICAgICMg c2luY2UgdGhlIGhlbHBlciBtYXkgZG8gdGhpbmdzIHRvIG1ha2UgdGhlIHNldHVwIGNvcnJlY3Qu CiAgICAgICAgIHNlbGYuX3ByaW50ZXIud3JpdGVfdXBkYXRlKCJTdGFydGluZyBoZWxwZXIgLi4u IikKLSAgICAgICAgc2VsZi5fcG9ydC5zdGFydF9oZWxwZXIoc2VsZi5fb3B0aW9ucy5waXhlbF90 ZXN0cykKKyAgICAgICAgaWYgbm90IHNlbGYuX3BvcnQuc3RhcnRfaGVscGVyKHNlbGYuX29wdGlv bnMucGl4ZWxfdGVzdHMpOgorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCiAKICAgICAgICAgc2Vs Zi5fcG9ydC5yZXNldF9wcmVmZXJlbmNlcygpCiAKQEAgLTI2Nyw5ICsyNjgsNyBAQCBjbGFzcyBN YW5hZ2VyKG9iamVjdCk6CiAgICAgICAgIF9sb2cuZGVidWcoIlJlc3RhcnRpbmcgaGVscGVyIikK ICAgICAgICAgc2VsZi5fcG9ydC5zdG9wX2hlbHBlcigpCiAgICAgICAgIHNlbGYuX29wdGlvbnMu cGl4ZWxfdGVzdHMgPSBUcnVlCi0gICAgICAgIHNlbGYuX3BvcnQuc3RhcnRfaGVscGVyKCkKLQot ICAgICAgICByZXR1cm4gVHJ1ZQorICAgICAgICByZXR1cm4gc2VsZi5fcG9ydC5zdGFydF9oZWxw ZXIoKQogCiAgICAgZGVmIF9sb29rX2Zvcl9uZXdfY3Jhc2hfbG9ncyhzZWxmLCBydW5fcmVzdWx0 cywgc3RhcnRfdGltZSk6CiAgICAgICAgICIiIlNpbmNlIGNyYXNoIGxvZ3MgY2FuIHRha2UgYSBs b25nIHRpbWUgdG8gYmUgd3JpdHRlbiBvdXQgaWYgdGhlIHN5c3RlbSBpcwpJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L2Jhc2UucHkJKHJldmlzaW9uIDE4MTk2NikKKysrIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5CSh3b3JraW5nIGNvcHkpCkBAIC04NjYsNyArODY2LDcg QEAgY2xhc3MgUG9ydChvYmplY3QpOgogICAgICAgICAiIiJJZiBhIHBvcnQgbmVlZHMgdG8gcmVj b25maWd1cmUgZ3JhcGhpY3Mgc2V0dGluZ3Mgb3IgZG8gb3RoZXIKICAgICAgICAgdGhpbmdzIHRv IGVuc3VyZSBhIGtub3duIHRlc3QgY29uZmlndXJhdGlvbiwgaXQgc2hvdWxkIG92ZXJyaWRlIHRo aXMKICAgICAgICAgbWV0aG9kLiIiIgotICAgICAgICBwYXNzCisgICAgICAgIHJldHVybiBUcnVl CiAKICAgICBkZWYgcmVzZXRfcHJlZmVyZW5jZXMoc2VsZik6CiAgICAgICAgICIiIklmIGEgcG9y dCBuZWVkcyB0byByZXNldCBwbGF0Zm9ybS1zcGVjaWZpYyBwZXJzaXN0ZW50IHByZWZlcmVuY2UK SW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9tYWMucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5weQkocmV2aXNpb24gMTgxOTY2KQorKysg VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5weQkod29ya2luZyBjb3B5KQpAQCAtMjU4 LDE0ICsyNTgsMTggQEAgY2xhc3MgTWFjUG9ydChBcHBsZVBvcnQpOgogCiAgICAgZGVmIHN0YXJ0 X2hlbHBlcihzZWxmLCBwaXhlbF90ZXN0cz1GYWxzZSk6CiAgICAgICAgIGhlbHBlcl9wYXRoID0g c2VsZi5fcGF0aF90b19oZWxwZXIoKQotICAgICAgICBpZiBoZWxwZXJfcGF0aDoKLSAgICAgICAg ICAgIF9sb2cuZGVidWcoIlN0YXJ0aW5nIGxheW91dCBoZWxwZXIgJXMiICUgaGVscGVyX3BhdGgp Ci0gICAgICAgICAgICBhcmd1bWVudHMgPSBbaGVscGVyX3BhdGgsICctLWluc3RhbGwtY29sb3It cHJvZmlsZSddCi0gICAgICAgICAgICBzZWxmLl9oZWxwZXIgPSBzZWxmLl9leGVjdXRpdmUucG9w ZW4oYXJndW1lbnRzLAotICAgICAgICAgICAgICAgIHN0ZGluPXNlbGYuX2V4ZWN1dGl2ZS5QSVBF LCBzdGRvdXQ9c2VsZi5fZXhlY3V0aXZlLlBJUEUsIHN0ZGVycj1Ob25lKQotICAgICAgICAgICAg aXNfcmVhZHkgPSBzZWxmLl9oZWxwZXIuc3Rkb3V0LnJlYWRsaW5lKCkKLSAgICAgICAgICAgIGlm IG5vdCBpc19yZWFkeS5zdGFydHN3aXRoKCdyZWFkeScpOgotICAgICAgICAgICAgICAgIF9sb2cu ZXJyb3IoIkxheW91dFRlc3RIZWxwZXIgZmFpbGVkIHRvIGJlIHJlYWR5IikKKyAgICAgICAgaWYg bm90IGhlbHBlcl9wYXRoOgorICAgICAgICAgICAgX2xvZy5lcnJvcigiTm8gcGF0aCB0byBMYXlv dXRUZXN0SGVscGVyIGJpbmFyeSIpCisgICAgICAgICAgICByZXR1cm4gRmFsc2UKKyAgICAgICAg X2xvZy5kZWJ1ZygiU3RhcnRpbmcgbGF5b3V0IGhlbHBlciAlcyIgJSBoZWxwZXJfcGF0aCkKKyAg ICAgICAgYXJndW1lbnRzID0gW2hlbHBlcl9wYXRoLCAnLS1pbnN0YWxsLWNvbG9yLXByb2ZpbGUn XQorICAgICAgICBzZWxmLl9oZWxwZXIgPSBzZWxmLl9leGVjdXRpdmUucG9wZW4oYXJndW1lbnRz LAorICAgICAgICAgICAgc3RkaW49c2VsZi5fZXhlY3V0aXZlLlBJUEUsIHN0ZG91dD1zZWxmLl9l eGVjdXRpdmUuUElQRSwgc3RkZXJyPU5vbmUpCisgICAgICAgIGlzX3JlYWR5ID0gc2VsZi5faGVs cGVyLnN0ZG91dC5yZWFkbGluZSgpCisgICAgICAgIGlmIG5vdCBpc19yZWFkeS5zdGFydHN3aXRo KCdyZWFkeScpOgorICAgICAgICAgICAgX2xvZy5lcnJvcigiTGF5b3V0VGVzdEhlbHBlciBjb3Vs ZCBub3Qgc3RhcnQiKQorICAgICAgICAgICAgcmV0dXJuIEZhbHNlCisgICAgICAgIHJldHVybiBU cnVlCiAKICAgICBkZWYgcmVzZXRfcHJlZmVyZW5jZXMoc2VsZik6CiAgICAgICAgIF9sb2cuZGVi dWcoIlJlc2V0dGluZyBwZXJzaXN0ZW50IHByZWZlcmVuY2VzIikK