143237 2015-03-30 14:32:53 -0700 [Mac][WK2] Fullscreen animation incorrect when initiated on non-primary monitor 2015-04-02 15:51:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue webkit-bug-importer oldest_to_newest 1081301 0 jer.noble 2015-03-30 14:32:53 -0700 [Mac][WK2] Fullscreen animation incorrect when initiated on non-primary monitor 1081303 1 249763 jer.noble 2015-03-30 14:34:39 -0700 Created attachment 249763 Patch 1082368 2 249763 bfulgham 2015-04-02 15:34:47 -0700 Comment on attachment 249763 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249763&action=review No test? :-( r=me. > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:517 > + CGAffineTransform resetOriginTransform = CGAffineTransformMakeTranslation(screenFrame.x() - finalFrame.x(), screenFrame.y() - finalFrame.y()); Interesting! I hadn't thought about the case where the screens might be oriented vertically with respect to each other, but of course that's entirely possible. 1082369 3 jer.noble 2015-04-02 15:39:07 -0700 (In reply to comment #2) > Comment on attachment 249763 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249763&action=review > > No test? :-( I couldn't figure out a way to artificially create a NSScreen and place the NSWindow into it. :( > r=me. Thanks! 1082373 4 jer.noble 2015-04-02 15:41:47 -0700 rdar://problem/20347504 1082377 5 249763 commit-queue 2015-04-02 15:51:30 -0700 Comment on attachment 249763 Patch Clearing flags on attachment: 249763 Committed r182295: <http://trac.webkit.org/changeset/182295> 1082378 6 commit-queue 2015-04-02 15:51:33 -0700 All reviewed patches have been landed. Closing bug. 249763 2015-03-30 14:34:39 -0700 2015-04-02 15:51:30 -0700 Patch bug-143237-20150330143357.patch text/plain 6492 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjNlN2RlNTczMzlhOGMz M2EwN2Y2YmM1ZDgxYzVkYmQ0OTNjNjQ2Ny4uZGVlNTVlZjgwODE3ODIzNTEyNWI2ZjI2MjcwMGQy ODIxMDM2ZDkxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTAzLTMwICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtNYWNdW1dLMl0gRnVsbHNj cmVlbiBhbmltYXRpb24gaW5jb3JyZWN0IHdoZW4gaW5pdGlhdGVkIG9uIG5vbi1wcmltYXJ5IG1v bml0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 MzIzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBhbmltYXRpb24gY2FsY3VsYXRpb25zIGhhdmUgYW4gaW1wbGljaXQgYXNzdW1wdGlvbnMgb2Yg YSBzY3JlZW4gd2hvc2Ugb3JpZ2luIGlzIDAsMC4gQWNjb3VudAorICAgICAgICBmb3IgdGhlIHNj cmVlbiBvcmlnaW4gYnkgcGFzc2luZyB0aGUgd2luZG93J3Mgc2NyZWVuJ3MgZnJhbWUgaW50byB0 aGUgem9vbUFuaW1hdGlvbigpIGFuZCBtYXNrQW5pbWF0aW9uKCkKKyAgICAgICAgbWV0aG9kcy4K KworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5t bToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBpbml0V2l0aFdpbmRv dzp3ZWJWaWV3Ol0pOgorICAgICAgICAoem9vbUFuaW1hdGlvbik6CisgICAgICAgIChtYXNrQW5p bWF0aW9uKToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBfc3RhcnRF bnRlckZ1bGxTY3JlZW5BbmltYXRpb25XaXRoRHVyYXRpb246XSk6CisgICAgICAgICgtW1dLRnVs bFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgX3N0YXJ0RXhpdEZ1bGxTY3JlZW5BbmltYXRpb25XaXRo RHVyYXRpb246XSk6CisKIDIwMTQtMTEtMDYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5j b20+CiAKICAgICAgICAgW0VNRV1bV0syXSBTaW1wbGlmeSB0aGUgTWVkaWFLZXlzIG9yaWdpbiBk ZWxldGlvbiBjb2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9X S0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCmluZGV4IDE5MmM5ZmU3M2RkOTcy MDNlZTYxYjQ4NjlhM2IyMTc5NjZjZmNkMmUuLjY4NjQzYmMwYjg1OGU1OTdjYTY3ZWY1ZDM0NWUw MzU1YjJiMjEzZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tG dWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0KQEAgLTEwNiw2ICsxMDYsNyBA QCBzdGF0aWMgdm9pZCBtYWtlUmVzcG9uZGVyRmlyc3RSZXNwb25kZXJJZkRlc2NlbmRhbnRPZlZp ZXcoTlNXaW5kb3cgKndpbmRvdywgTlNSZQogICAgIG1hc2tMYXllci5hbmNob3JQb2ludCA9IENH UG9pbnRaZXJvOwogICAgIG1hc2tMYXllci5mcmFtZSA9IE5TUmVjdFRvQ0dSZWN0KGNvbnRlbnRW aWV3LmJvdW5kcyk7CiAgICAgbWFza0xheWVyLmJhY2tncm91bmRDb2xvciA9IENHQ29sb3JHZXRD b25zdGFudENvbG9yKGtDR0NvbG9yQmxhY2spOworICAgIG1hc2tMYXllci5hdXRvcmVzaXppbmdN YXNrID0gKE5TVmlld1dpZHRoU2l6YWJsZSB8IE5TVmlld0hlaWdodFNpemFibGUpOwogICAgIFtf Y2xpcFZpZXcgbGF5ZXJdLm1hc2sgPSBtYXNrTGF5ZXI7CiAgICAgW2NvbnRlbnRWaWV3IGFkZFN1 YnZpZXc6X2NsaXBWaWV3LmdldCgpXTsKIApAQCAtNTA5LDEzICs1MTAsMTMgQEAgc3RhdGljIFJl dGFpblB0cjxDR0ltYWdlUmVmPiBjcmVhdGVJbWFnZVdpdGhDb3BpZWREYXRhKENHSW1hZ2VSZWYg c291cmNlSW1hZ2UpCiB9CiAKIGVudW0gQW5pbWF0aW9uRGlyZWN0aW9uIHsgQW5pbWF0ZUluLCBB bmltYXRlT3V0IH07Ci1zdGF0aWMgQ0FBbmltYXRpb24gKnpvb21BbmltYXRpb24oY29uc3QgRmxv YXRSZWN0JiBpbml0aWFsRnJhbWUsIGNvbnN0IEZsb2F0UmVjdCYgZmluYWxGcmFtZSwgQ0ZUaW1l SW50ZXJ2YWwgZHVyYXRpb24sIEFuaW1hdGlvbkRpcmVjdGlvbiBkaXJlY3Rpb24pCitzdGF0aWMg Q0FBbmltYXRpb24gKnpvb21BbmltYXRpb24oY29uc3QgRmxvYXRSZWN0JiBpbml0aWFsRnJhbWUs IGNvbnN0IEZsb2F0UmVjdCYgZmluYWxGcmFtZSwgY29uc3QgRmxvYXRSZWN0JiBzY3JlZW5GcmFt ZSwgQ0ZUaW1lSW50ZXJ2YWwgZHVyYXRpb24sIEFuaW1hdGlvbkRpcmVjdGlvbiBkaXJlY3Rpb24p CiB7CiAgICAgQ0FCYXNpY0FuaW1hdGlvbiAqc2NhbGVBbmltYXRpb24gPSBbQ0FCYXNpY0FuaW1h dGlvbiBhbmltYXRpb25XaXRoS2V5UGF0aDpAInRyYW5zZm9ybSJdOwogICAgIEZsb2F0UmVjdCBz Y2FsZVJlY3QgPSBzbWFsbGVzdFJlY3RXaXRoQXNwZWN0UmF0aW9Bcm91bmRSZWN0KGZpbmFsRnJh bWUuc2l6ZSgpLmFzcGVjdFJhdGlvKCksIGluaXRpYWxGcmFtZSk7Ci0gICAgQ0dBZmZpbmVUcmFu c2Zvcm0gcmVzZXRPcmlnaW5UcmFuc2Zvcm0gPSBDR0FmZmluZVRyYW5zZm9ybU1ha2VUcmFuc2xh dGlvbigtZmluYWxGcmFtZS54KCksIC1maW5hbEZyYW1lLnkoKSk7CisgICAgQ0dBZmZpbmVUcmFu c2Zvcm0gcmVzZXRPcmlnaW5UcmFuc2Zvcm0gPSBDR0FmZmluZVRyYW5zZm9ybU1ha2VUcmFuc2xh dGlvbihzY3JlZW5GcmFtZS54KCkgLSBmaW5hbEZyYW1lLngoKSwgc2NyZWVuRnJhbWUueSgpIC0g ZmluYWxGcmFtZS55KCkpOwogICAgIENHQWZmaW5lVHJhbnNmb3JtIHNjYWxlVHJhbnNmb3JtID0g Q0dBZmZpbmVUcmFuc2Zvcm1NYWtlU2NhbGUoc2NhbGVSZWN0LndpZHRoKCkgLyBmaW5hbEZyYW1l LndpZHRoKCksIHNjYWxlUmVjdC5oZWlnaHQoKSAvIGZpbmFsRnJhbWUuaGVpZ2h0KCkpOwotICAg IENHQWZmaW5lVHJhbnNmb3JtIHRyYW5zbGF0ZVRyYW5zZm9ybSA9IENHQWZmaW5lVHJhbnNmb3Jt TWFrZVRyYW5zbGF0aW9uKHNjYWxlUmVjdC54KCksIHNjYWxlUmVjdC55KCkpOworICAgIENHQWZm aW5lVHJhbnNmb3JtIHRyYW5zbGF0ZVRyYW5zZm9ybSA9IENHQWZmaW5lVHJhbnNmb3JtTWFrZVRy YW5zbGF0aW9uKHNjYWxlUmVjdC54KCkgLSBzY3JlZW5GcmFtZS54KCksIHNjYWxlUmVjdC55KCkg LSBzY3JlZW5GcmFtZS55KCkpOwogCiAgICAgQ0dBZmZpbmVUcmFuc2Zvcm0gZmluYWxUcmFuc2Zv cm0gPSBDR0FmZmluZVRyYW5zZm9ybUNvbmNhdChDR0FmZmluZVRyYW5zZm9ybUNvbmNhdChyZXNl dE9yaWdpblRyYW5zZm9ybSwgc2NhbGVUcmFuc2Zvcm0pLCB0cmFuc2xhdGVUcmFuc2Zvcm0pOwog ICAgIE5TVmFsdWUgKnNjYWxlVmFsdWUgPSBbTlNWYWx1ZSB2YWx1ZVdpdGhDQVRyYW5zZm9ybTNE OkNBVHJhbnNmb3JtM0RNYWtlQWZmaW5lVHJhbnNmb3JtKGZpbmFsVHJhbnNmb3JtKV07CkBAIC01 MzEsNyArNTMyLDcgQEAgc3RhdGljIENBQW5pbWF0aW9uICp6b29tQW5pbWF0aW9uKGNvbnN0IEZs b2F0UmVjdCYgaW5pdGlhbEZyYW1lLCBjb25zdCBGbG9hdFJlY3QKICAgICByZXR1cm4gc2NhbGVB bmltYXRpb247CiB9CiAKLXN0YXRpYyBDQUFuaW1hdGlvbiAqbWFza0FuaW1hdGlvbihjb25zdCBG bG9hdFJlY3QmIGluaXRpYWxGcmFtZSwgY29uc3QgRmxvYXRSZWN0JiBmaW5hbEZyYW1lLCBDRlRp bWVJbnRlcnZhbCBkdXJhdGlvbiwgQW5pbWF0aW9uRGlyZWN0aW9uIGRpcmVjdGlvbikKK3N0YXRp YyBDQUFuaW1hdGlvbiAqbWFza0FuaW1hdGlvbihjb25zdCBGbG9hdFJlY3QmIGluaXRpYWxGcmFt ZSwgY29uc3QgRmxvYXRSZWN0JiBmaW5hbEZyYW1lLCBjb25zdCBGbG9hdFJlY3QmIHNjcmVlbkZy YW1lLCBDRlRpbWVJbnRlcnZhbCBkdXJhdGlvbiwgQW5pbWF0aW9uRGlyZWN0aW9uIGRpcmVjdGlv bikKIHsKICAgICBDQUJhc2ljQW5pbWF0aW9uICpib3VuZHNBbmltYXRpb24gPSBbQ0FCYXNpY0Fu aW1hdGlvbiBhbmltYXRpb25XaXRoS2V5UGF0aDpAImJvdW5kcyJdOwogICAgIEZsb2F0UmVjdCBi b3VuZHNSZWN0ID0gbGFyZ2VzdFJlY3RXaXRoQXNwZWN0UmF0aW9JbnNpZGVSZWN0KGluaXRpYWxG cmFtZS5zaXplKCkuYXNwZWN0UmF0aW8oKSwgZmluYWxGcmFtZSk7CkBAIC01NDIsNyArNTQzLDcg QEAgc3RhdGljIENBQW5pbWF0aW9uICptYXNrQW5pbWF0aW9uKGNvbnN0IEZsb2F0UmVjdCYgaW5p dGlhbEZyYW1lLCBjb25zdCBGbG9hdFJlY3QKICAgICAgICAgYm91bmRzQW5pbWF0aW9uLnRvVmFs dWUgPSBib3VuZHNWYWx1ZTsKIAogICAgIENBQmFzaWNBbmltYXRpb24gKnBvc2l0aW9uQW5pbWF0 aW9uID0gW0NBQmFzaWNBbmltYXRpb24gYW5pbWF0aW9uV2l0aEtleVBhdGg6QCJwb3NpdGlvbiJd OwotICAgIE5TVmFsdWUgKnBvc2l0aW9uVmFsdWUgPSBbTlNWYWx1ZSB2YWx1ZVdpdGhQb2ludDpi b3VuZHNSZWN0LmxvY2F0aW9uKCldOworICAgIE5TVmFsdWUgKnBvc2l0aW9uVmFsdWUgPSBbTlNW YWx1ZSB2YWx1ZVdpdGhQb2ludDpGbG9hdFBvaW50KGJvdW5kc1JlY3QubG9jYXRpb24oKSAtIHNj cmVlbkZyYW1lLmxvY2F0aW9uKCkpXTsKICAgICBpZiAoZGlyZWN0aW9uID09IEFuaW1hdGVJbikK ICAgICAgICAgcG9zaXRpb25BbmltYXRpb24uZnJvbVZhbHVlID0gcG9zaXRpb25WYWx1ZTsKICAg ICBlbHNlCkBAIC01NzMsOCArNTc0LDggQEAgc3RhdGljIENBQW5pbWF0aW9uICpmYWRlQW5pbWF0 aW9uKENGVGltZUludGVydmFsIGR1cmF0aW9uLCBBbmltYXRpb25EaXJlY3Rpb24gZGkKIAogLSAo dm9pZClfc3RhcnRFbnRlckZ1bGxTY3JlZW5BbmltYXRpb25XaXRoRHVyYXRpb246KE5TVGltZUlu dGVydmFsKWR1cmF0aW9uCiB7Ci0gICAgW1tfY2xpcFZpZXcgbGF5ZXJdIGFkZEFuaW1hdGlvbjp6 b29tQW5pbWF0aW9uKF9pbml0aWFsRnJhbWUsIF9maW5hbEZyYW1lLCBkdXJhdGlvbiwgQW5pbWF0 ZUluKSBmb3JLZXk6QCJmdWxsc2NyZWVuIl07Ci0gICAgW1tfY2xpcFZpZXcgbGF5ZXJdLm1hc2sg YWRkQW5pbWF0aW9uOm1hc2tBbmltYXRpb24oX2luaXRpYWxGcmFtZSwgX2ZpbmFsRnJhbWUsIGR1 cmF0aW9uLCBBbmltYXRlSW4pIGZvcktleTpAImZ1bGxzY3JlZW4iXTsKKyAgICBbW19jbGlwVmll dyBsYXllcl0gYWRkQW5pbWF0aW9uOnpvb21BbmltYXRpb24oX2luaXRpYWxGcmFtZSwgX2ZpbmFs RnJhbWUsIHNlbGYud2luZG93LnNjcmVlbi5mcmFtZSwgZHVyYXRpb24sIEFuaW1hdGVJbikgZm9y S2V5OkAiZnVsbHNjcmVlbiJdOworICAgIFtbX2NsaXBWaWV3IGxheWVyXS5tYXNrIGFkZEFuaW1h dGlvbjptYXNrQW5pbWF0aW9uKF9pbml0aWFsRnJhbWUsIF9maW5hbEZyYW1lLCBzZWxmLndpbmRv dy5zY3JlZW4uZnJhbWUsIGR1cmF0aW9uLCBBbmltYXRlSW4pIGZvcktleTpAImZ1bGxzY3JlZW4i XTsKIAogICAgIE5TVmlldyogY29udGVudFZpZXcgPSBbW3NlbGYgd2luZG93XSBjb250ZW50Vmll d107CiAgICAgY29udGVudFZpZXcubGF5ZXIuaGlkZGVuID0gTk87CkBAIC02MDIsOCArNjAzLDgg QEAgc3RhdGljIENBQW5pbWF0aW9uICpmYWRlQW5pbWF0aW9uKENGVGltZUludGVydmFsIGR1cmF0 aW9uLCBBbmltYXRpb25EaXJlY3Rpb24gZGkKICAgICAgICAgX2Z1bGxTY3JlZW5TdGF0ZSA9IEV4 aXRpbmdGdWxsU2NyZWVuOwogICAgIH0KIAotICAgIFtbX2NsaXBWaWV3IGxheWVyXSBhZGRBbmlt YXRpb246em9vbUFuaW1hdGlvbihfaW5pdGlhbEZyYW1lLCBfZmluYWxGcmFtZSwgZHVyYXRpb24s IEFuaW1hdGVPdXQpIGZvcktleTpAImZ1bGxzY3JlZW4iXTsKLSAgICBbW19jbGlwVmlldyBsYXll cl0ubWFzayBhZGRBbmltYXRpb246bWFza0FuaW1hdGlvbihfaW5pdGlhbEZyYW1lLCBfZmluYWxG cmFtZSwgZHVyYXRpb24sIEFuaW1hdGVPdXQpIGZvcktleTpAImZ1bGxzY3JlZW4iXTsKKyAgICBb W19jbGlwVmlldyBsYXllcl0gYWRkQW5pbWF0aW9uOnpvb21BbmltYXRpb24oX2luaXRpYWxGcmFt ZSwgX2ZpbmFsRnJhbWUsIHNlbGYud2luZG93LnNjcmVlbi5mcmFtZSwgZHVyYXRpb24sIEFuaW1h dGVPdXQpIGZvcktleTpAImZ1bGxzY3JlZW4iXTsKKyAgICBbW19jbGlwVmlldyBsYXllcl0ubWFz ayBhZGRBbmltYXRpb246bWFza0FuaW1hdGlvbihfaW5pdGlhbEZyYW1lLCBfZmluYWxGcmFtZSwg c2VsZi53aW5kb3cuc2NyZWVuLmZyYW1lLCBkdXJhdGlvbiwgQW5pbWF0ZU91dCkgZm9yS2V5OkAi ZnVsbHNjcmVlbiJdOwogCiAgICAgTlNWaWV3KiBjb250ZW50VmlldyA9IFtbc2VsZiB3aW5kb3dd IGNvbnRlbnRWaWV3XTsKICAgICBjb250ZW50Vmlldy5sYXllci5oaWRkZW4gPSBOTzsK