143234 2015-03-30 12:17:44 -0700 [iOS] WebContent crashing at WebCore: WebCore::Range::collectSelectionRects 2015-03-30 16:26:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified iOS 8.2 RESOLVED FIXED P2 Normal --- 1 enrica enrica thorton oldest_to_newest 1081270 0 enrica 2015-03-30 12:17:44 -0700 rdar://problem/18571345 1081271 1 249754 enrica 2015-03-30 12:22:34 -0700 Created attachment 249754 Patch 1081276 2 249754 thorton 2015-03-30 12:27:28 -0700 Comment on attachment 249754 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249754&action=review > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:137 > + if (compositionRange) Maybe we should pull this code into its own function so we can early return if !compositionRange (and then later if compositionRects.isEmpty()?) > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:141 > if (compositionRects.size() > 1) Will the plainTextReplacingNoBreakSpace a few lines below here handle a null compositionRange correctly? 1081333 3 enrica 2015-03-30 15:29:11 -0700 (In reply to comment #2) > Comment on attachment 249754 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249754&action=review > > > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:137 > > + if (compositionRange) > > Maybe we should pull this code into its own function so we can early return > if !compositionRange (and then later if compositionRects.isEmpty()?) > > > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:141 > > if (compositionRects.size() > 1) > > Will the plainTextReplacingNoBreakSpace a few lines below here handle a null > compositionRange correctly? Yes it does. But I agree that there is no need to do any of the rest of the composition code if compositionRange is null. 1081378 4 enrica 2015-03-30 16:26:43 -0700 Committed revision 182162. 249754 2015-03-30 12:22:34 -0700 2015-03-30 12:27:28 -0700 Patch collectSelectionRects-crash.txt text/plain 3473 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjE1MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAzLTMwICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gV2ViQ29udGVudCBj cmFzaGluZyBhdCBXZWJDb3JlOiBXZWJDb3JlOjpSYW5nZTo6Y29sbGVjdFNlbGVjdGlvblJlY3Rz LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMjM0 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xODU3MTM0NT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgc3BlY3VsYXRpdmUgZml4IHRo YXQgYWRkcyBhIG51bGwgY2hlY2sgYmVmb3JlIHJlZmVyZW5jaW5nIHRoZSByYW5nZS4KKyAgICAg ICAgSW4gYm90aCBwbGFjZXMgd2hlcmUgdGhlIGNoZWNrIGhhcyBiZWVuIGFkZGVkIHRoZSByYW5n ZSByZXR1cm5lZCBieSB0aGUgY2FsbAorICAgICAgICB0aGF0IHNob3VsZCBjcmVhdGUgaXQgY291 bGQgYmUgbnVsbC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlP Uy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6cGxhdGZvcm1FZGl0b3JTdGF0ZSk6CisK IDIwMTUtMDMtMzAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgU3dpcGUgc25hcHNob3QgcmVtb3ZlZCB0b28gZWFybHkgKGp1bXBzIGFyb3VuZCkgb24g YXJzdGVjaG5pY2EgYW5kIE5ZVApJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL2lvcy9XZWJQYWdlSU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQkocmV2aXNpb24gMTgyMTQ1KQorKysgU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCSh3b3JraW5n IGNvcHkpCkBAIC0xMzQsNyArMTM0LDggQEAgdm9pZCBXZWJQYWdlOjpwbGF0Zm9ybUVkaXRvclN0 YXRlKEZyYW1lJgogICAgIGlmIChmcmFtZS5lZGl0b3IoKS5oYXNDb21wb3NpdGlvbigpKSB7CiAg ICAgICAgIFJlZlB0cjxSYW5nZT4gY29tcG9zaXRpb25SYW5nZSA9IGZyYW1lLmVkaXRvcigpLmNv bXBvc2l0aW9uUmFuZ2UoKTsKICAgICAgICAgVmVjdG9yPFdlYkNvcmU6OlNlbGVjdGlvblJlY3Q+ IGNvbXBvc2l0aW9uUmVjdHM7Ci0gICAgICAgIGNvbXBvc2l0aW9uUmFuZ2UtPmNvbGxlY3RTZWxl Y3Rpb25SZWN0cyhjb21wb3NpdGlvblJlY3RzKTsKKyAgICAgICAgaWYgKGNvbXBvc2l0aW9uUmFu Z2UpCisgICAgICAgICAgICBjb21wb3NpdGlvblJhbmdlLT5jb2xsZWN0U2VsZWN0aW9uUmVjdHMo Y29tcG9zaXRpb25SZWN0cyk7CiAgICAgICAgIGlmIChjb21wb3NpdGlvblJlY3RzLnNpemUoKSkK ICAgICAgICAgICAgIHJlc3VsdC5maXJzdE1hcmtlZFJlY3QgPSBjb21wb3NpdGlvblJlY3RzWzBd LnJlY3QoKTsKICAgICAgICAgaWYgKGNvbXBvc2l0aW9uUmVjdHMuc2l6ZSgpID4gMSkKQEAgLTE1 OSwxNSArMTYwLDE4IEBAIHZvaWQgV2ViUGFnZTo6cGxhdGZvcm1FZGl0b3JTdGF0ZShGcmFtZSYK ICAgICAgICAgcmVzdWx0LmNhcmV0UmVjdEF0U3RhcnQgPSB2aWV3LT5jb250ZW50c1RvUm9vdFZp ZXcoVmlzaWJsZVBvc2l0aW9uKHNlbGVjdGlvbi5zdGFydCgpKS5hYnNvbHV0ZUNhcmV0Qm91bmRz KCkpOwogICAgICAgICByZXN1bHQuY2FyZXRSZWN0QXRFbmQgPSB2aWV3LT5jb250ZW50c1RvUm9v dFZpZXcoVmlzaWJsZVBvc2l0aW9uKHNlbGVjdGlvbi5lbmQoKSkuYWJzb2x1dGVDYXJldEJvdW5k cygpKTsKICAgICAgICAgUmVmUHRyPFJhbmdlPiBzZWxlY3RlZFJhbmdlID0gc2VsZWN0aW9uLnRv Tm9ybWFsaXplZFJhbmdlKCk7Ci0gICAgICAgIHNlbGVjdGVkUmFuZ2UtPmNvbGxlY3RTZWxlY3Rp b25SZWN0cyhyZXN1bHQuc2VsZWN0aW9uUmVjdHMpOwotICAgICAgICBjb252ZXJ0U2VsZWN0aW9u UmVjdHNUb1Jvb3RWaWV3KHZpZXcsIHJlc3VsdC5zZWxlY3Rpb25SZWN0cyk7Ci0gICAgICAgIFN0 cmluZyBzZWxlY3RlZFRleHQgPSBwbGFpblRleHRSZXBsYWNpbmdOb0JyZWFrU3BhY2Uoc2VsZWN0 ZWRSYW5nZS5nZXQoKSwgVGV4dEl0ZXJhdG9yRGVmYXVsdEJlaGF2aW9yLCB0cnVlKTsKKyAgICAg ICAgU3RyaW5nIHNlbGVjdGVkVGV4dDsKKyAgICAgICAgaWYgKHNlbGVjdGVkUmFuZ2UpIHsKKyAg ICAgICAgICAgIHNlbGVjdGVkUmFuZ2UtPmNvbGxlY3RTZWxlY3Rpb25SZWN0cyhyZXN1bHQuc2Vs ZWN0aW9uUmVjdHMpOworICAgICAgICAgICAgY29udmVydFNlbGVjdGlvblJlY3RzVG9Sb290Vmll dyh2aWV3LCByZXN1bHQuc2VsZWN0aW9uUmVjdHMpOworICAgICAgICAgICAgc2VsZWN0ZWRUZXh0 ID0gcGxhaW5UZXh0UmVwbGFjaW5nTm9CcmVha1NwYWNlKHNlbGVjdGVkUmFuZ2UuZ2V0KCksIFRl eHRJdGVyYXRvckRlZmF1bHRCZWhhdmlvciwgdHJ1ZSk7CisgICAgICAgICAgICByZXN1bHQuc2Vs ZWN0ZWRUZXh0TGVuZ3RoID0gc2VsZWN0ZWRUZXh0Lmxlbmd0aCgpOworICAgICAgICAgICAgY29u c3QgaW50IG1heFNlbGVjdGVkVGV4dExlbmd0aCA9IDIwMDsKKyAgICAgICAgICAgIGlmIChzZWxl Y3RlZFRleHQubGVuZ3RoKCkgPD0gbWF4U2VsZWN0ZWRUZXh0TGVuZ3RoKQorICAgICAgICAgICAg ICAgIHJlc3VsdC53b3JkQXRTZWxlY3Rpb24gPSBzZWxlY3RlZFRleHQ7CisgICAgICAgIH0KICAg ICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBkaXNhbGxvdyByZXBsYWNlIHdoZW4gdGhlIHN0cmlu ZyBjb250YWlucyBvbmx5IENKIGNoYXJhY3RlcnMuCiAgICAgICAgIHJlc3VsdC5pc1JlcGxhY2VB bGxvd2VkID0gcmVzdWx0LmlzQ29udGVudEVkaXRhYmxlICYmICFyZXN1bHQuaXNJblBhc3N3b3Jk RmllbGQgJiYgIXNlbGVjdGVkVGV4dC5jb250YWluc09ubHlXaGl0ZXNwYWNlKCk7Ci0gICAgICAg IHJlc3VsdC5zZWxlY3RlZFRleHRMZW5ndGggPSBzZWxlY3RlZFRleHQubGVuZ3RoKCk7Ci0gICAg ICAgIGNvbnN0IGludCBtYXhTZWxlY3RlZFRleHRMZW5ndGggPSAyMDA7Ci0gICAgICAgIGlmIChz ZWxlY3RlZFRleHQubGVuZ3RoKCkgPD0gbWF4U2VsZWN0ZWRUZXh0TGVuZ3RoKQotICAgICAgICAg ICAgcmVzdWx0LndvcmRBdFNlbGVjdGlvbiA9IHNlbGVjdGVkVGV4dDsKICAgICB9CiAgICAgaWYg KCFzZWxlY3Rpb24uaXNOb25lKCkpIHsKICAgICAgICAgTm9kZSogbm9kZVRvUmVtb3ZlOwo=