143231 2015-03-30 11:11:41 -0700 WebBackForwardList doesn't need to manually clear the snapshot of an entry when removing it. 2015-03-30 20:24:21 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 143250 1 kling kling andersca commit-queue kling mitz thorton oldest_to_newest 1081238 0 kling 2015-03-30 11:11:41 -0700 No need to setSnapshot(nullptr) when removing an item from the WebBackForwardList now that items actually get destroyed right after. 1081239 1 249748 kling 2015-03-30 11:12:06 -0700 Created attachment 249748 Patch 1081543 2 249748 commit-queue 2015-03-30 20:03:29 -0700 Comment on attachment 249748 Patch Clearing flags on attachment: 249748 Committed r182172: <http://trac.webkit.org/changeset/182172> 1081544 3 commit-queue 2015-03-30 20:03:33 -0700 All reviewed patches have been landed. Closing bug. 1081545 4 mitz 2015-03-30 20:09:36 -0700 Isn’t WebBackForwardListItem an API object? A client may hold on to arbitrarily many instances but will have no way to get to the snapshots. This suggests that dropping the reference to the snapshot once the item is not in the list could still be beneficial. 1081546 5 kling 2015-03-30 20:21:07 -0700 (In reply to comment #4) > Isn’t WebBackForwardListItem an API object? A client may hold on to > arbitrarily many instances but will have no way to get to the snapshots. > This suggests that dropping the reference to the snapshot once the item is > not in the list could still be beneficial. Oh! I did not realize that WebBackForwardListItem was exposed through the modern WebKit API. Rolling this out. 1081548 6 commit-queue 2015-03-30 20:24:21 -0700 Re-opened since this is blocked by bug 143250 249748 2015-03-30 11:12:06 -0700 2015-03-30 20:03:29 -0700 Patch bug-143231.diff text/plain 1497 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4MzZlZWU3Li5lMzllODM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTUtMDMtMzAgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFdlYkJhY2tGb3J3YXJkTGlzdCBkb2Vzbid0IG5lZWQgdG8gbWFudWFsbHkgY2xlYXIgdGhl IHNuYXBzaG90IG9mIGFuIGVudHJ5IHdoZW4gcmVtb3ZpbmcgaXQuCisgICAgICAgIDxodHRwczov L3dlYmtpdC5vcmcvYi8xNDMyMzE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTm93IHRoYXQgd2UgZG9uJ3Qga2VlcCBXZWJCYWNrRm9yd2FyZExpc3RJ dGVtIG9iamVjdHMgYWxpdmUgZm9yZXZlciwgaXQncyBub3QgbmVjZXNzYXJ5CisgICAgICAgIHRv IGNsZWFyIHRoZSBzbmFwc2hvdCB3aGVuIHJlbW92aW5nIHRoZW0gZnJvbSB0aGUgV2ViQmFja0Zv cndhcmRMaXN0LCBzaW5jZSB0aGUgZW50aXJlCisgICAgICAgIG9iamVjdCB3aWxsIGJlIGRlbGV0 ZWQgc2hvcnRseSBhZnRlciB0aGF0IGFueXdheS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJC YWNrRm9yd2FyZExpc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJCYWNrRm9yd2FyZExpc3Q6 OmRpZFJlbW92ZUl0ZW0pOgorCiAyMDE1LTAzLTMwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgW1dLMl1bTmV0d29ya0NhY2hlXSBBZGQgc3VwcG9ydCBmb3IgIkNh Y2hlLUNvbnRyb2w6IG1heC1zdGFsZSIgcmVxdWVzdCBoZWFkZXIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlzdC5jcHAKaW5kZXggZDM1NzBkYi4uMjY0ZmYz ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlz dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlzdC5j cHAKQEAgLTQzNywxMCArNDM3LDYgQEAgVmVjdG9yPEJhY2tGb3J3YXJkTGlzdEl0ZW1TdGF0ZT4g V2ViQmFja0ZvcndhcmRMaXN0OjppdGVtU3RhdGVzKCkgY29uc3QKIHZvaWQgV2ViQmFja0Zvcndh cmRMaXN0OjpkaWRSZW1vdmVJdGVtKFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0mIGJhY2tGb3J3YXJk TGlzdEl0ZW0pCiB7CiAgICAgbV9wYWdlLT5iYWNrRm9yd2FyZFJlbW92ZWRJdGVtKGJhY2tGb3J3 YXJkTGlzdEl0ZW0uaXRlbUlEKCkpOwotCi0jaWYgUExBVEZPUk0oQ09DT0EpCi0gICAgYmFja0Zv cndhcmRMaXN0SXRlbS5zZXRTbmFwc2hvdChudWxscHRyKTsKLSNlbmRpZgogfQogCiB9IC8vIG5h bWVzcGFjZSBXZWJLaXQK