143229 2015-03-30 10:32:09 -0700 [GTK] Layout Test accessibility/aria-toggle-button-with-title.html is failing 2015-04-13 03:23:12 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 chavarria1991 webkit-unassigned aboxhall apinheiro cfleizach chavarria1991 clopez commit-queue dmazzoni jcraig jdiggs mario ossy samuel_white webkit-bug-importer oldest_to_newest 1081213 0 chavarria1991 2015-03-30 10:32:09 -0700 The accessibility/aria-toggle-button-with-title.html layout test is failing on GTK+ since r182012 (https://trac.webkit.org/changeset/182012). This revision updates the way a role=button + aria-pressed object should be exposed as AXCheckbox on Mac. The diff is the following: --- /home/ch01/jhbuild/src/WebKit/WebKitBuild/Release/layout-test-results/accessibility/aria-toggle-button-with-title-expected.txt +++ /home/ch01/jhbuild/src/WebKit/WebKitBuild/Release/layout-test-results/accessibility/aria-toggle-button-with-title-actual.txt @@ -8,7 +8,7 @@ PASS successfullyParsed is true TEST COMPLETE -Role: AXRole: AXCheckBox +Role: AXRole: AXToggleButton PASS tbutton1.title is 'AXTitle: Toggle button' Role: AXRole: AXButton PASS button.title is 'AXTitle: Button title' 1081214 1 webkit-bug-importer 2015-03-30 10:32:33 -0700 <rdar://problem/20348058> 1081216 2 webkit-bug-importer 2015-03-30 10:33:23 -0700 <rdar://problem/20348078> 1081233 3 cfleizach 2015-03-30 11:02:11 -0700 Can you post the whole new actual file that you get. i can post that as the new expected results for GTK 1081236 4 249747 chavarria1991 2015-03-30 11:10:18 -0700 Created attachment 249747 Patch 1081237 5 249747 cfleizach 2015-03-30 11:11:04 -0700 Comment on attachment 249747 Patch i think this may fail because you've put unreviewed in there, lets' see 1081241 6 chavarria1991 2015-03-30 11:13:56 -0700 (In reply to comment #5) > Comment on attachment 249747 [details] > Patch > > i think this may fail because you've put unreviewed in there, lets' see The thing is that being a gardening patch it doesn't need revision but I forget to add the --no-review flag when I call to upload the patch. Thanks! :) 1081263 7 249747 commit-queue 2015-03-30 11:59:11 -0700 Comment on attachment 249747 Patch Clearing flags on attachment: 249747 Committed r182149: <http://trac.webkit.org/changeset/182149> 1081264 8 commit-queue 2015-03-30 11:59:15 -0700 All reviewed patches have been landed. Closing bug. 1084760 9 ossy 2015-04-13 03:23:12 -0700 EFL had similar difference - fixed in http://trac.webkit.org/changeset/182699 249747 2015-03-30 11:10:18 -0700 2015-03-30 11:59:11 -0700 Patch bug-143229-20150330200935.patch text/plain 1746 chavarria1991 U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMTM1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGJhNzMzMTE2N2M3ZmU0MWVkMGI2 NjU2MmRhZDI5NDhlMzAxMDc4Mi4uZTAxNzQ3NGEyZGZiZWEzZWIxOTBmNDQ5Y2U5OTc0Y2RhZmNk YjQ0NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTAzLTMwICBNYXJjb3MgQ2hhdmFycsOt YSBUZWlqZWlybyAgPGNoYXZhcnJpYTE5OTFAZ21haWwuY29tPgorCisgICAgICAgIFJlYmFzZWxp bmUgYWNjZXNzaWJpbGl0eS9hcmlhLXRvZ2dsZS1idXR0b24td2l0aC10aXRsZS5odG1sCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMyMjkKKworICAg ICAgICBVbnJldmlld2VkLgorCisgICAgICAgIFJldmlzaW9uIHIxODIwMTIgdXBkYXRlcyB0aGUg d2F5IGEgcm9sZT1idXR0b24gKyBhcmlhLXByZXNzZWQgb2JqZWN0IHNob3VsZCBiZSBleHBvc2Vk IGFzIEFYQ2hlY2tib3guIFdlIG5lZWQgdG8gY3JlYXRlIGEgbmV3IGJhc2VsaW5lLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvYXJpYS10b2dnbGUtYnV0dG9uLXdpdGgt dGl0bGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKwogMjAxNS0wMy0yOSAgQmVuamFtaW4gUG91bGFp biAgPGJlbmphbWluQHdlYmtpdC5vcmc+CiAKICAgICAgICAgYGN1cnJlbnRDb2xvcmAgY29tcHV0 ZXMgdG8gdGhlIHNhbWUgY29sb3VyIG9uIGFsbCBlbGVtZW50cywgZXZlbiBpZiAnY29sb3InIGlz IGluaGVyaXRlZCBkaWZmZXJlbnRseQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL2FjY2Vzc2liaWxpdHkvYXJpYS10b2dnbGUtYnV0dG9uLXdpdGgtdGl0bGUtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvYXJpYS10b2dnbGUt YnV0dG9uLXdpdGgtdGl0bGUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjUzZjRhNGExMDFjMjJm Y2FhYjFmNGFhMjAxNWVjNWI5YTcxMzg3YWIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9hcmlhLXRvZ2dsZS1idXR0b24td2l0aC10aXRs ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxNSBAQAorVG9nZ2xlIGJ1dHRvbgorQnV0dG9uIHRp dGxlCitUaGlzIHRlc3RzIHRoYXQgYSB0b2dnbGUgYnV0dG9uIHByb3Blcmx5IGV4cG9zZXMgdGhl IHRpdGxlIHdoZW4gdGhlcmUgaXNuJ3QgYSBkaXJlY3QgcmVsYXRpb24gYW5kIHRleHRVbmRlckVs ZW1lbnQgaXMgcmVxdWlyZWQgdG8gYmUgdXNlZC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2Vl IGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUi LgorCisKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor Um9sZTogQVhSb2xlOiBBWFRvZ2dsZUJ1dHRvbgorUEFTUyB0YnV0dG9uMS50aXRsZSBpcyAnQVhU aXRsZTogVG9nZ2xlIGJ1dHRvbicKK1JvbGU6IEFYUm9sZTogQVhCdXR0b24KK1BBU1MgYnV0dG9u LnRpdGxlIGlzICdBWFRpdGxlOiBCdXR0b24gdGl0bGUnCisK