143216 2015-03-30 05:13:42 -0700 [GStreamer] More GL shared context fixes 2015-03-30 08:23:23 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned cgarcia mrobinson pnormand vjaquez oldest_to_newest 1081132 0 pnormand 2015-03-30 05:13:42 -0700 The patch from Bug 143049 has various incorrect changes. 1081133 1 249721 pnormand 2015-03-30 05:20:36 -0700 Created attachment 249721 patch 1081157 2 249721 mrobinson 2015-03-30 08:17:05 -0700 Comment on attachment 249721 patch View in context: https://bugs.webkit.org/attachment.cgi?id=249721&action=review Looks good apart from the a naming nit: > Source/WebCore/platform/graphics/glx/GLContextGLX.h:52 > + virtual bool isEGLCompliant() const { return false; } A context isn't really "EGL compliant" it's either an EGL context or something else. I recommend just calling this method "isEGLContext." 1081158 3 pnormand 2015-03-30 08:23:23 -0700 Committed r182139: <http://trac.webkit.org/changeset/182139> 249721 2015-03-30 05:20:36 -0700 2015-03-30 05:26:43 -0700 patch patch.patch text/plain 4936 pnormand RnJvbSBmYTA0YzdlZTkyMmNiNzViMTU5ZWMyNWFkYTAyOTY3NTFjZmJlY2E5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDMwIE1hciAyMDE1IDE0OjE5OjA2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAyMiArKysrKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0dMQ29udGV4dC5oICAgICAgIHwgIDIgKysKIC4uLi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuaCAgIHwgIDEgKwogLi4uL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ2x4L0dMQ29udGV4dEdMWC5oICAgfCAgMSArCiAuLi4vZ3N0cmVhbWVyL01l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICAgICB8IDIzICsrKysrKysrKysrKy0tLS0t LS0tLS0KIDUgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDQwZGM4NDkuLjY3NWRjODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy NSBAQAorMjAxNS0wMy0zMCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dTdHJlYW1lcl0gTW9yZSBHTCBzaGFyZWQgY29udGV4dCBmaXhlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMjE2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZWQgdGhlIEdM WC9FR0wgY29udGV4dCB0ZXN0cyB0byBiZSBkb25lIGF0IHJ1bnRpbWUgcmF0aGVyIHRoYW4KKyAg ICAgICAgdXNpbmcgYnVpbGQtdGltZSBtYWNyb3MgYmVjYXVzZSBpbiB0aGUgR1RLIHBvcnQgYXQg bGVhc3QsIGJvdGggRUdMCisgICAgICAgIGFuZCBHTFggc3VwcG9ydCBhcmUgbXV0dWFsbHkgZXhj bHVzaXZlLiBBbHNvIGZpeGVkIGEgY291cGxlIHdyb25nCisgICAgICAgIGRlZmluZXMgKFVTRShH TEVTMikgZG9lc24ndCBleGlzdCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HTENv bnRleHQuaDogU2ltcGxlIHV0aWxpdHkgbWV0aG9kIHRvIGNoZWNrIGlmCisgICAgICAgIHRoZSBw bGF0Zm9ybSBjb250ZXh0IGlzIGNvbXBhdGlibGUgd2l0aCBFR0wgQVBJcyBvciBub3QuCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5oOgorICAgICAgICAoV2Vi Q29yZTo6R0xDb250ZXh0RUdMOjppc0VHTENvbXBsaWFudCk6IFRydWx5IEVHTCBjb21wYXRpYmxl LgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dseC9HTENvbnRleHRHTFguaDoKKyAgICAg ICAgKFdlYkNvcmU6OkdMQ29udGV4dEdMWDo6aXNFR0xDb21wbGlhbnQpOiBUaGUgR0xYIGNvbnRl eHQgaXNuJ3QgRUdMIGNvbXBhdGlibGUuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmVuc3VyZUdzdEdMQ29udGV4dCk6IERvCisg ICAgICAgIHJ1bnRpbWUgY2hlY2tzIGFuZCBwcm9wZXJseSBlbnN1cmUgR0xFUzIvR0wgQVBJIHVz YWdlLgorCiAyMDE1LTAzLTMwICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBTdGFydCB0aGUgZmVhdHVyZXMuanNvbiBmaWxlcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR0xDb250ZXh0LmggYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HTENvbnRleHQuaAppbmRleCAwNDY1M2I2Li4zMGQyNTQx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HTENvbnRleHQu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HTENvbnRleHQuaApAQCAt NTcsNiArNTcsOCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIGNhblJlbmRlclRvRGVmYXVs dEZyYW1lYnVmZmVyKCkgPSAwOwogICAgIHZpcnR1YWwgSW50U2l6ZSBkZWZhdWx0RnJhbWVCdWZm ZXJTaXplKCkgPSAwOwogCisgICAgdmlydHVhbCBib29sIGlzRUdMQ29tcGxpYW50KCkgY29uc3Qg PSAwOworCiAjaWYgVVNFKENBSVJPKQogICAgIHZpcnR1YWwgY2Fpcm9fZGV2aWNlX3QqIGNhaXJv RGV2aWNlKCkgPSAwOwogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmgKaW5kZXggNGQ4ZDhlNC4uY2M5NzdiNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wu aApAQCAtNDUsNiArNDUsNyBAQCBwdWJsaWM6CiAjaWYgVVNFKENBSVJPKQogICAgIHZpcnR1YWwg Y2Fpcm9fZGV2aWNlX3QqIGNhaXJvRGV2aWNlKCk7CiAjZW5kaWYKKyAgICB2aXJ0dWFsIGJvb2wg aXNFR0xDb21wbGlhbnQoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAKICNpZiBVU0UoM0RfR1JB UEhJQ1MpCiAgICAgdmlydHVhbCBQbGF0Zm9ybUdyYXBoaWNzQ29udGV4dDNEIHBsYXRmb3JtQ29u dGV4dCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ2x4 L0dMQ29udGV4dEdMWC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ2x4L0dM Q29udGV4dEdMWC5oCmluZGV4IDNlZjRjZWQuLjgxNDM3NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dseC9HTENvbnRleHRHTFguaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nbHgvR0xDb250ZXh0R0xYLmgKQEAgLTQ5LDYgKzQ5 LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBjYW5SZW5kZXJUb0RlZmF1bHRGcmFtZWJ1 ZmZlcigpOwogICAgIHZpcnR1YWwgSW50U2l6ZSBkZWZhdWx0RnJhbWVCdWZmZXJTaXplKCk7CiAg ICAgdmlydHVhbCBjYWlyb19kZXZpY2VfdCogY2Fpcm9EZXZpY2UoKTsKKyAgICB2aXJ0dWFsIGJv b2wgaXNFR0xDb21wbGlhbnQoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogCiAjaWYgVVNFKDNE X0dSQVBISUNTKQogICAgIHZpcnR1YWwgUGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCBwbGF0Zm9y bUNvbnRleHQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ci5jcHAKaW5kZXggN2IzZmUwYi4uZDgxYmVjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTk4MCwxOSArOTgwLDIyIEBAIGJvb2wgTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjplbnN1cmVHc3RHTENvbnRleHQoKQogI2VuZGlmCiAg ICAgfQogCi0gICAgUGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCBjb250ZXh0SGFuZGxlID0gR0xD b250ZXh0OjpzaGFyaW5nQ29udGV4dCgpLT5wbGF0Zm9ybUNvbnRleHQoKTsKLSAgICBpZiAoIWNv bnRleHRIYW5kbGUpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSNpZiBVU0UoRUdMKQotICAgIEdz dEdMUGxhdGZvcm0gZ2xQbGF0Zm9ybSA9IEdTVF9HTF9QTEFURk9STV9FR0w7Ci0jZWxzZQotICAg IEdzdEdMUGxhdGZvcm0gZ2xQbGF0Zm9ybSA9IEdTVF9HTF9QTEFURk9STV9HTFg7Ci0jZW5kaWYK LSNpZiBVU0UoR0xFUzIpCisgICAgR0xDb250ZXh0KiB3ZWJraXRDb250ZXh0ID0gR0xDb250ZXh0 OjpzaGFyaW5nQ29udGV4dCgpOworICAgIC8vIEVHTCBhbmQgR0xYIGFyZSBtdXR1YWxseSBleGNs dXNpdmUsIG5vIG5lZWQgZm9yIGlmZGVmcyBoZXJlLgorICAgIEdzdEdMUGxhdGZvcm0gZ2xQbGF0 Zm9ybSA9IHdlYmtpdENvbnRleHQtPmlzRUdMQ29tcGxpYW50KCkgPyBHU1RfR0xfUExBVEZPUk1f RUdMIDogR1NUX0dMX1BMQVRGT1JNX0dMWDsKKworI2lmIFVTRShPUEVOR0xfRVNfMikKICAgICBH c3RHTEFQSSBnbEFQSSA9IEdTVF9HTF9BUElfR0xFUzI7Ci0jZWxzZQorI2VsaWYgVVNFKE9QRU5H TCkKICAgICBHc3RHTEFQSSBnbEFQSSA9IEdTVF9HTF9BUElfT1BFTkdMOworI2Vsc2UKKyAgICBB U1NFUlRfTk9UX1JFQUNIRUQoKTsKICNlbmRpZgorCisgICAgUGxhdGZvcm1HcmFwaGljc0NvbnRl eHQzRCBjb250ZXh0SGFuZGxlID0gd2Via2l0Q29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCk7Cisg ICAgaWYgKCFjb250ZXh0SGFuZGxlKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICBtX2ds Q29udGV4dCA9IGdzdF9nbF9jb250ZXh0X25ld193cmFwcGVkKG1fZ2xEaXNwbGF5LmdldCgpLCBy ZWludGVycHJldF9jYXN0PGd1aW50cHRyPihjb250ZXh0SGFuZGxlKSwgZ2xQbGF0Zm9ybSwgZ2xB UEkpOwogCiAgICAgcmV0dXJuIHRydWU7Ci0tIAoyLjEuNA==