143177 2015-03-28 00:02:52 -0700 Clean up JavaScriptCore/builtins 2015-03-28 23:59:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue dino ggaren joepeck oliver rniwa ysuzuki oldest_to_newest 1080904 0 joepeck 2015-03-28 00:02:52 -0700 * SUMMARY Clean up built-ins. Some style inconsistencies, grammar improvements, and possible simplifications. 1080905 1 249649 joepeck 2015-03-28 00:05:42 -0700 Created attachment 249649 [PATCH] Proposed Fix 1080995 2 249649 commit-queue 2015-03-28 23:59:12 -0700 Comment on attachment 249649 [PATCH] Proposed Fix Clearing flags on attachment: 249649 Committed r182118: <http://trac.webkit.org/changeset/182118> 1080996 3 commit-queue 2015-03-28 23:59:16 -0700 All reviewed patches have been landed. Closing bug. 249649 2015-03-28 00:05:42 -0700 2015-03-28 23:59:12 -0700 [PATCH] Proposed Fix builtins.patch text/plain 6878 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGMwM2IwNjcuLjBiYjY0MmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE1LTAzLTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAgSmF2YVNjcmlwdENv cmUvYnVpbHRpbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0MzE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogYnVpbHRpbnMvQXJyYXlDb25zdHJ1Y3Rvci5qczoKKyAgICAgICAgKGZyb20pOgorICAg ICAgICAtIFdlIGNhbiBjb21wYXJlIHRvIHVuZGVmaW5lZCBpbnN0ZWFkIG9mIHVzaW5nIGEgdHlw ZW9mIHVuZGVmaW5lZCBjaGVjay4KKyAgICAgICAgLSBDb252ZXJnZSBvbiBkb3VibGUgcXVvdGVk IHN0cmluZ3MgZXZlcnl3aGVyZS4KKworICAgICAgICAqIGJ1aWx0aW5zL0FycmF5SXRlcmF0b3Iu cHJvdG90eXBlLmpzOgorICAgICAgICAobmV4dCk6CisgICAgICAgICogYnVpbHRpbnMvU3RyaW5n SXRlcmF0b3IucHJvdG90eXBlLmpzOgorICAgICAgICAobmV4dCk6CisgICAgICAgIC0gVXNlIHNo b3J0aGFuZCBvYmplY3QgY29uc3RydWN0aW9uIHRvIGF2b2lkIGR1cGxpY2F0aW9uLgorICAgICAg ICAtIEltcHJvdmUgZ3JhbW1hciBpbiBlcnJvciBtZXNzYWdlcy4KKworICAgICAgICAqIHRlc3Rz L3N0cmVzcy9hcnJheS1pdGVyYXRvcnMtbmV4dC13aXRoLWNhbGwuanM6CisgICAgICAgICogdGVz dHMvc3RyZXNzL3N0cmluZy1pdGVyYXRvcnMuanM6CisgICAgICAgIC0gVXBkYXRlIGZvciBuZXcg ZXJyb3IgbWVzc2FnZSBzdHJpbmdzLgorCiAyMDE1LTAzLTI3ICBTYWFtIEJhcmF0aSAgPHNhYW1i YXJhdGkxQGdtYWlsLmNvbT4KIAogICAgICAgICBEZWNvbnN0cnVjdGlvbiBwYXJhbWV0ZXJzIGFy ZSBib3VuZCB0b28gbGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0 aW5zL0FycmF5Q29uc3RydWN0b3IuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMv QXJyYXlDb25zdHJ1Y3Rvci5qcwppbmRleCBkYTQxNzFmLi41NTc1Yjc1IDEwMDY0NAotLS0gYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXJyYXlDb25zdHJ1Y3Rvci5qcworKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXJyYXlDb25zdHJ1Y3Rvci5qcwpAQCAtMjQs MTEgKzI0LDEwIEBACiAgKi8KIAogZnVuY3Rpb24gZnJvbShhcnJheUxpa2UgLyosIG1hcEZuLCB0 aGlzQXJnICovKSB7Ci0KICAgICAidXNlIHN0cmljdCI7CiAKICAgICBpZiAoYXJyYXlMaWtlID09 IG51bGwpCi0gICAgICAgICB0aHJvdyBuZXcgQFR5cGVFcnJvcigiQXJyYXkuZnJvbSByZXF1aXJl cyBhbiBhcnJheS1saWtlIG9iamVjdCAtIG5vdCBudWxsIG9yIHVuZGVmaW5lZCIpOworICAgICAg ICB0aHJvdyBuZXcgQFR5cGVFcnJvcigiQXJyYXkuZnJvbSByZXF1aXJlcyBhbiBhcnJheS1saWtl IG9iamVjdCAtIG5vdCBudWxsIG9yIHVuZGVmaW5lZCIpOwogCiAgICAgdmFyIHRoaXNPYmogPSB0 aGlzOwogCkBAIC0zNyw4ICszNiw4IEBAIGZ1bmN0aW9uIGZyb20oYXJyYXlMaWtlIC8qLCBtYXBG biwgdGhpc0FyZyAqLykgewogCiAgICAgdmFyIHRoaXNBcmc7CiAKLSAgICBpZiAodHlwZW9mIG1h cEZuICE9PSAidW5kZWZpbmVkIikgewotICAgICAgICBpZiAodHlwZW9mIG1hcEZuICE9PSAnZnVu Y3Rpb24nKQorICAgIGlmIChtYXBGbiAhPT0gdW5kZWZpbmVkKSB7CisgICAgICAgIGlmICh0eXBl b2YgbWFwRm4gIT09ICJmdW5jdGlvbiIpCiAgICAgICAgICAgICB0aHJvdyBuZXcgQFR5cGVFcnJv cigiQXJyYXkuZnJvbSByZXF1aXJlcyB0aGF0IHRoZSBzZWNvbmQgYXJndW1lbnQsIHdoZW4gcHJv dmlkZWQsIGJlIGEgZnVuY3Rpb24iKTsKIAogICAgICAgICBpZiAoYXJndW1lbnRzLmxlbmd0aCA+ IDIpCkBAIC01OCw3ICs1Nyw3IEBAIGZ1bmN0aW9uIGZyb20oYXJyYXlMaWtlIC8qLCBtYXBGbiwg dGhpc0FyZyAqLykgewogICAgIC8vIG9yaWdpbmFsbHkgTWF0aC5taW4oTWF0aC5tYXgobGVuZ3Ro LCAwKSwgbWF4U2FmZUludGVnZXIpKTsKICAgICB2YXIgaXRlbXNMZW5ndGggPSBsZW5ndGhWYWx1 ZSA+IDAgPyAobGVuZ3RoVmFsdWUgPCBtYXhTYWZlSW50ZWdlciA/IGxlbmd0aFZhbHVlIDogbWF4 U2FmZUludGVnZXIpIDogMDsKIAotICAgIHZhciByZXN1bHQgPSAodHlwZW9mIHRoaXNPYmogPT09 ICdmdW5jdGlvbicpID8gQE9iamVjdChuZXcgdGhpc09iaihpdGVtc0xlbmd0aCkpIDogbmV3IEBB cnJheShpdGVtc0xlbmd0aCk7CisgICAgdmFyIHJlc3VsdCA9ICh0eXBlb2YgdGhpc09iaiA9PT0g ImZ1bmN0aW9uIikgPyBAT2JqZWN0KG5ldyB0aGlzT2JqKGl0ZW1zTGVuZ3RoKSkgOiBuZXcgQEFy cmF5KGl0ZW1zTGVuZ3RoKTsKIAogICAgIHZhciBrID0gMDsKICAgICB3aGlsZSAoayA8IGl0ZW1z TGVuZ3RoKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQXJy YXlJdGVyYXRvci5wcm90b3R5cGUuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMv QXJyYXlJdGVyYXRvci5wcm90b3R5cGUuanMKaW5kZXggOTc2YmNiMi4uODJkZjUyOCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL0FycmF5SXRlcmF0b3IucHJvdG90 eXBlLmpzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9BcnJheUl0ZXJhdG9y LnByb3RvdHlwZS5qcwpAQCAtMzEsNyArMzEsNyBAQCBmdW5jdGlvbiBuZXh0KCkgewogCiAgICAg dmFyIGl0ZW1LaW5kID0gdGhpcy5AYXJyYXlJdGVyYXRpb25LaW5kOwogICAgIGlmIChpdGVtS2lu ZCA9PT0gdW5kZWZpbmVkKQotICAgICAgICB0aHJvdyBuZXcgQFR5cGVFcnJvcigiJUFycmF5SXRl cmF0b3JQcm90b3R5cGUlLm5leHQgcmVxdWlyZXMgdGhhdCB8dGhpc3wgYmUgQXJyYXkgSXRlcmF0 b3IgSW5zdGFuY2UiKTsKKyAgICAgICAgdGhyb3cgbmV3IEBUeXBlRXJyb3IoIiVBcnJheUl0ZXJh dG9yUHJvdG90eXBlJS5uZXh0IHJlcXVpcmVzIHRoYXQgfHRoaXN8IGJlIGFuIEFycmF5IEl0ZXJh dG9yIGluc3RhbmNlIik7CiAKICAgICB2YXIgZG9uZSA9IHRydWU7CiAgICAgdmFyIHZhbHVlID0g dW5kZWZpbmVkOwpAQCAtNTUsOCArNTUsNSBAQCBmdW5jdGlvbiBuZXh0KCkgewogICAgICAgICB9 CiAgICAgfQogCi0gICAgcmV0dXJuIHsKLSAgICAgICAgZG9uZTogZG9uZSwKLSAgICAgICAgdmFs dWU6IHZhbHVlCi0gICAgfTsKKyAgICByZXR1cm4ge2RvbmUsIHZhbHVlfTsKIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9TdHJpbmdJdGVyYXRvci5wcm90b3R5 cGUuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvU3RyaW5nSXRlcmF0b3IucHJv dG90eXBlLmpzCmluZGV4IDIwN2ViYmMuLjhlNGJiNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9idWlsdGlucy9TdHJpbmdJdGVyYXRvci5wcm90b3R5cGUuanMKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL1N0cmluZ0l0ZXJhdG9yLnByb3RvdHlwZS5qcwpA QCAtMzEsNyArMzEsNyBAQCBmdW5jdGlvbiBuZXh0KCkgewogCiAgICAgdmFyIHBvc2l0aW9uID0g dGhpcy5Ac3RyaW5nSXRlcmF0b3JOZXh0SW5kZXg7CiAgICAgaWYgKHBvc2l0aW9uID09PSB1bmRl ZmluZWQpCi0gICAgICAgIHRocm93IG5ldyBAVHlwZUVycm9yKCIlU3RyaW5nSXRlcmF0b3JQcm90 b3R5cGUlLm5leHQgcmVxdWlyZXMgdGhhdCB8dGhpc3wgYmUgU3RyaW5nIEl0ZXJhdG9yIEluc3Rh bmNlIik7CisgICAgICAgIHRocm93IG5ldyBAVHlwZUVycm9yKCIlU3RyaW5nSXRlcmF0b3JQcm90 b3R5cGUlLm5leHQgcmVxdWlyZXMgdGhhdCB8dGhpc3wgYmUgYSBTdHJpbmcgSXRlcmF0b3IgaW5z dGFuY2UiKTsKIAogICAgIHZhciBkb25lID0gdHJ1ZTsKICAgICB2YXIgdmFsdWUgPSB1bmRlZmlu ZWQ7CkBAIC01OSw4ICs1OSw1IEBAIGZ1bmN0aW9uIG5leHQoKSB7CiAgICAgICAgIH0KICAgICB9 CiAKLSAgICByZXR1cm4gewotICAgICAgICBkb25lOiBkb25lLAotICAgICAgICB2YWx1ZTogdmFs dWUKLSAgICB9OworICAgIHJldHVybiB7ZG9uZSwgdmFsdWV9OwogfQpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9hcnJheS1pdGVyYXRvcnMtbmV4dC13aXRo LWNhbGwuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2FycmF5LWl0ZXJh dG9ycy1uZXh0LXdpdGgtY2FsbC5qcwppbmRleCBlNTc1ZGRlLi5lZjI1ZGU2IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2FycmF5LWl0ZXJhdG9ycy1uZXh0 LXdpdGgtY2FsbC5qcworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2Fy cmF5LWl0ZXJhdG9ycy1uZXh0LXdpdGgtY2FsbC5qcwpAQCAtODMsNyArODMsNyBAQCBmb3IgKHZh ciBwcmltaXRpdmUgb2YgcHJpbWl0aXZlcykgewogICAgIH0KICAgICBpZiAoIWRpZFRocm93KQog ICAgICAgICB0aHJvdyAiRXJyb3I6IG5vIGVycm9yIHRocm93biI7Ci0gICAgdmFyIGV4cGVjdGVk TWVzc2FnZSA9ICdUeXBlRXJyb3I6ICVBcnJheUl0ZXJhdG9yUHJvdG90eXBlJS5uZXh0IHJlcXVp cmVzIHRoYXQgfHRoaXN8IGJlIEFycmF5IEl0ZXJhdG9yIEluc3RhbmNlJzsKKyAgICB2YXIgZXhw ZWN0ZWRNZXNzYWdlID0gJ1R5cGVFcnJvcjogJUFycmF5SXRlcmF0b3JQcm90b3R5cGUlLm5leHQg cmVxdWlyZXMgdGhhdCB8dGhpc3wgYmUgYW4gQXJyYXkgSXRlcmF0b3IgaW5zdGFuY2UnOwogICAg IGlmIChwcmltaXRpdmUgPT0gbnVsbCkKICAgICAgICAgZXhwZWN0ZWRNZXNzYWdlID0gJ1R5cGVF cnJvcjogJUFycmF5SXRlcmF0b3JQcm90b3R5cGUlLm5leHQgcmVxdWlyZXMgdGhhdCB8dGhpc3wg bm90IGJlIG51bGwgb3IgdW5kZWZpbmVkJzsKICAgICBpZiAoU3RyaW5nKGRpZFRocm93KSAhPT0g ZXhwZWN0ZWRNZXNzYWdlKQpAQCAtMTEwLDYgKzExMCw2IEBAIGZvciAodmFyIG9iamVjdCBvZiBu b25SZWxhdGVkT2JqZWN0cykgewogICAgIH0KICAgICBpZiAoIWRpZFRocm93KQogICAgICAgICB0 aHJvdyAiRXJyb3I6IG5vIGVycm9yIHRocm93biI7Ci0gICAgaWYgKFN0cmluZyhkaWRUaHJvdykg IT09ICdUeXBlRXJyb3I6ICVBcnJheUl0ZXJhdG9yUHJvdG90eXBlJS5uZXh0IHJlcXVpcmVzIHRo YXQgfHRoaXN8IGJlIEFycmF5IEl0ZXJhdG9yIEluc3RhbmNlJykKKyAgICBpZiAoU3RyaW5nKGRp ZFRocm93KSAhPT0gJ1R5cGVFcnJvcjogJUFycmF5SXRlcmF0b3JQcm90b3R5cGUlLm5leHQgcmVx dWlyZXMgdGhhdCB8dGhpc3wgYmUgYW4gQXJyYXkgSXRlcmF0b3IgaW5zdGFuY2UnKQogICAgICAg ICB0aHJvdyAiRXJyb3I6IGJhZCBlcnJvciB0aHJvd246ICIgKyBkaWRUaHJvdzsKIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvc3RyaW5nLWl0ZXJhdG9y cy5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvc3RyaW5nLWl0ZXJhdG9y cy5qcwppbmRleCBkNmMwNTdkLi44MTJlYWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvdGVzdHMvc3RyZXNzL3N0cmluZy1pdGVyYXRvcnMuanMKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9zdHJpbmctaXRlcmF0b3JzLmpzCkBAIC0xODAsNyArMTgw LDcgQEAgZm9yICh2YXIgcHJpbWl0aXZlIG9mIHByaW1pdGl2ZXMpIHsKICAgICB9CiAgICAgaWYg KCFkaWRUaHJvdykKICAgICAgICAgdGhyb3cgIkVycm9yOiBubyBlcnJvciB0aHJvd24iOwotICAg IHZhciBtZXNzYWdlID0gJ1R5cGVFcnJvcjogJVN0cmluZ0l0ZXJhdG9yUHJvdG90eXBlJS5uZXh0 IHJlcXVpcmVzIHRoYXQgfHRoaXN8IGJlIFN0cmluZyBJdGVyYXRvciBJbnN0YW5jZSc7CisgICAg dmFyIG1lc3NhZ2UgPSAnVHlwZUVycm9yOiAlU3RyaW5nSXRlcmF0b3JQcm90b3R5cGUlLm5leHQg cmVxdWlyZXMgdGhhdCB8dGhpc3wgYmUgYSBTdHJpbmcgSXRlcmF0b3IgaW5zdGFuY2UnOwogICAg IGlmIChwcmltaXRpdmUgPT0gbnVsbCkKICAgICAgICAgbWVzc2FnZSA9ICdUeXBlRXJyb3I6ICVT dHJpbmdJdGVyYXRvclByb3RvdHlwZSUubmV4dCByZXF1aXJlcyB0aGF0IHx0aGlzfCBiZSBub3Qg bnVsbCBvciB1bmRlZmluZWQnCiAgICAgaWYgKFN0cmluZyhkaWRUaHJvdykgIT09IG1lc3NhZ2Up CkBAIC0yMDcsNiArMjA3LDYgQEAgZm9yICh2YXIgb2JqZWN0IG9mIG5vblJlbGF0ZWRPYmplY3Rz KSB7CiAgICAgfQogICAgIGlmICghZGlkVGhyb3cpCiAgICAgICAgIHRocm93ICJFcnJvcjogbm8g ZXJyb3IgdGhyb3duIjsKLSAgICBpZiAoU3RyaW5nKGRpZFRocm93KSAhPT0gJ1R5cGVFcnJvcjog JVN0cmluZ0l0ZXJhdG9yUHJvdG90eXBlJS5uZXh0IHJlcXVpcmVzIHRoYXQgfHRoaXN8IGJlIFN0 cmluZyBJdGVyYXRvciBJbnN0YW5jZScpCisgICAgaWYgKFN0cmluZyhkaWRUaHJvdykgIT09ICdU eXBlRXJyb3I6ICVTdHJpbmdJdGVyYXRvclByb3RvdHlwZSUubmV4dCByZXF1aXJlcyB0aGF0IHx0 aGlzfCBiZSBhIFN0cmluZyBJdGVyYXRvciBpbnN0YW5jZScpCiAgICAgICAgIHRocm93ICJFcnJv cjogYmFkIGVycm9yIHRocm93bjogIiArIGRpZFRocm93OwogfQo=