143173 2015-03-27 20:00:51 -0700 [GTK] Web Inspector: New Images for ObjectTreeView - Setter 2015-04-30 11:02:15 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck agomez agomez cgarcia commit-queue graouts gustavo joepeck jonowells mattbaker mrobinson nvasilyev timothy webkit-bug-importer oldest_to_newest 1080867 0 joepeck 2015-03-27 20:00:51 -0700 * SUMMARY New Images for ObjectTreeView - Setter. "Pencil.svg". Added in <http://trac.webkit.org/changeset/182099> * TEST Foo = class Foo { constructor() { this.value = 1; } get getterOnly() {} get getterAndSetter() {} set getterAndSetter(x) {} set setterOnly(x) {} } foo = new Foo; Object.defineProperty(foo, 'value', { value: 1 }); Object.defineProperty(foo, 'getterOnly', { get: function(){ return 2; } }); Object.defineProperty(foo, 'getterAndSetter', { get: function(){ return 2; }, set(x){} }); Object.defineProperty(foo, 'setterOnly', { set(x){} }); foo; * STEPS TO REPRODUCE 1. Evaluate the test in the console 2. Expand the object => "setterOnly" fields should have icons 1080869 1 webkit-bug-importer 2015-03-27 20:01:22 -0700 <rdar://problem/20336142> 1080870 2 joepeck 2015-03-27 20:01:52 -0700 See: <https://webkit.org/b/143129> Web Inspector: Add Setter Icon for ObjectTreeView 1083284 3 agomez 2015-04-07 04:22:05 -0700 Getting. Thanks for the report! 1090465 4 252067 agomez 2015-04-30 10:09:31 -0700 Created attachment 252067 Patch 1090488 5 252067 commit-queue 2015-04-30 11:02:07 -0700 Comment on attachment 252067 Patch Clearing flags on attachment: 252067 Committed r183633: <http://trac.webkit.org/changeset/183633> 1090489 6 commit-queue 2015-04-30 11:02:15 -0700 All reviewed patches have been landed. Closing bug. 252067 2015-04-30 10:09:31 -0700 2015-04-30 11:02:07 -0700 Patch bug-143173-20150430200819.patch text/plain 1852 agomez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzNjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAy MjNlZjZkMzcyNDFmOGZhY2E1MzMyNTFmOTc4NWRiMTBlZjIxNmJlLi5hMjE4OTUwYjRkYjM3N2Nl OTMyYTRlYjkxZWMxYTUwMzkyMDhmNzU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0wNC0zMCAgQW5kcmVzIEdvbWV6ICA8YWdvbWV6QGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gV2ViIEluc3BlY3RvcjogTmV3IEltYWdlcyBmb3IgT2JqZWN0VHJl ZVZpZXcgLSBTZXR0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0MzE3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogVXNlckludGVyZmFjZS9JbWFnZXMvZ3RrL1BlbmNpbC5zdmc6IEFkZGVkLgorCiAy MDE1LTA0LTMwICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogQ29weSBub3Qgd29ya2luZyBpbiBDb25zb2xlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9JbWFnZXMvZ3RrL1BlbmNpbC5z dmcgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9JbWFnZXMvZ3RrL1BlbmNp bC5zdmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uNjI4MTMyOThhOWU2YTJiZmIxNGY4MDYyOWZmODJmNGU2Y2M5Y2Ey ZQotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0ltYWdlcy9ndGsvUGVuY2lsLnN2ZwpAQCAtMCwwICsxLDEyIEBACis8P3htbCB2ZXJzaW9uPSIx LjAiIGVuY29kaW5nPSJVVEYtOCIgc3RhbmRhbG9uZT0ibm8iPz4KKzwhLS0gTGljZW5zZWQgdW5k ZXIgdGhlIENyZWF0aXZlIENvbW1vbnMgQXR0cmlidXRpb24tU2hhcmUgQWxpa2UgMy4wIFVuaXRl ZCBTdGF0ZXMgTGljZW5zZSAoaHR0cDovL2NyZWF0aXZlY29tbW9ucy5vcmcvbGljZW5zZXMvYnkt c2EvMy4wLykgLS0+Cis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgdmVy c2lvbj0iMS4xIiB2aWV3Qm94PSIwIDAgMTYgMTYiPgorIDxkZWZzPgorICA8bGluZWFyR3JhZGll bnQgaWQ9ImEiIGdyYWRpZW50VHJhbnNmb3JtPSJtYXRyaXgoLTIuNzM2NiAuNDA0MzQgLS4xODkw OCAtMS40MzM1IC03MTUuNDYgLTM5MDUuMykiPgorICAgPHN0b3Agb2Zmc2V0PSIwIi8+CisgIDwv bGluZWFyR3JhZGllbnQ+CisgPC9kZWZzPgorIDxyZWN0IHJ4PSIwIiByeT0iMCIgaGVpZ2h0PSIx NS45NTEiIHdpZHRoPSIxNiIgeT0iLjA0OTI5MSIgeD0iMCIgZmlsbD0ibm9uZSIvPgorIDxwYXRo IGQ9Im0xMi42NTYgMC41MjM4Ny0xLjg3NSAxLjk5MzhjMS4zMjg3IDAuMDI1ODIgMi42NjUxIDEu MjA3OCAyLjcxODggMi40M2wyLTEuOTkzOGMtMC4wNTUtMS4yNjE1LTEuNDc0LTIuNDgwOC0yLjg0 NC0yLjQzeiIgZmlsbC1ydWxlPSJldmVub2RkIiBmaWxsPSJ1cmwoI2EpIi8+CisgPHBhdGggZD0i bTIuMTMwNCAxMS41MjYgNy41MjAyLTguMDA5OGMxLjM2OTQtMC4wNTA4IDIuNzk0NCAxLjE1OTgg Mi44NDk0IDIuNDIxM2wtNy40OSA3Ljc2OTUtNC41MSAxLjc3MXoiIGZpbGwtcnVsZT0iZXZlbm9k ZCIgZmlsbD0idXJsKCNhKSIvPgorPC9zdmc+Cg==