143172 2015-03-27 19:18:23 -0700 Web Inspector: Uncaught exception while debugging, after performSearch callback line does not exists 2015-03-27 21:42:37 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1080855 0 joepeck 2015-03-27 19:18:23 -0700 * SUMMARY Uncaught exception while debugging, after performSearch callback line does not exists. Not sure exactly how to reproduce, but the issue was that a line did not exist in CodeMirror after the perform search callback triggered. We should fail gracefully in this case. 1080856 1 249636 joepeck 2015-03-27 19:25:15 -0700 Created attachment 249636 [PATCH] Proposed Fix 1080879 2 249636 commit-queue 2015-03-27 21:42:32 -0700 Comment on attachment 249636 [PATCH] Proposed Fix Clearing flags on attachment: 249636 Committed r182104: <http://trac.webkit.org/changeset/182104> 1080880 3 commit-queue 2015-03-27 21:42:37 -0700 All reviewed patches have been landed. Closing bug. 249636 2015-03-27 19:25:15 -0700 2015-03-27 21:42:32 -0700 [PATCH] Proposed Fix fix.patch text/plain 1713 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVkYjRjOTcuLmYxYzBlMzAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTAzLTI3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgZXhjZXB0aW9uIHdoaWxlIGRlYnVnZ2luZywgYWZ0ZXIgcGVyZm9ybVNlYXJjaCBjYWxsYmFj ayBsaW5lIGRvZXMgbm90IGV4aXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQzMTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9y LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRpdG9yLnByb3RvdHlw ZS5jdXN0b21QZXJmb3JtU2VhcmNoLnNlYXJjaFJlc3VsdENhbGxiYWNrKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRvci5wcm90b3R5cGUuY3VzdG9tUGVyZm9ybVNl YXJjaCk6CisgICAgICAgIEdyYWNlZnVsbHkgaGFuZGxlIGlmIHRoZSBsaW5lIGRvZXMgbm90IGV4 aXN0LgorCisyMDE1LTAzLTI3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVHlwZVByb2ZpbGVyIGRvZXNuJ3Qgd29yayBvbiBm aWxlcyB3aXRoIEVTNiBDbGFzcyBTeW50YXgKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE0MzE2OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9y LmpzCmluZGV4IDI4ZGM3MjAuLjE1MDlhMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRp dG9yLmpzCkBAIC0xODcsNiArMTg3LDggQEAgV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRp dG9yID0gY2xhc3MgU291cmNlQ29kZVRleHRFZGl0b3IgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAg ICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgbWF0Y2hlcy5sZW5ndGg7ICsraSkgewogICAgICAg ICAgICAgICAgIHZhciBtYXRjaExpbmVOdW1iZXIgPSBtYXRjaGVzW2ldLmxpbmVOdW1iZXI7CiAg ICAgICAgICAgICAgICAgdmFyIGxpbmUgPSB0aGlzLmxpbmUobWF0Y2hMaW5lTnVtYmVyKTsKKyAg ICAgICAgICAgICAgICBpZiAoIWxpbmUpCisgICAgICAgICAgICAgICAgICAgIHJldHVybjsKIAog ICAgICAgICAgICAgICAgIC8vIFJlc2V0IHRoZSBsYXN0IGluZGV4IHRvIHJldXNlIHRoZSByZWdl eCBvbiBhIG5ldyBsaW5lLgogICAgICAgICAgICAgICAgIHF1ZXJ5UmVnZXgubGFzdEluZGV4ID0g MDsK