143164 2015-03-27 16:56:34 -0700 Web Inspector: REGRESSION(r179286) Editing Style Metrics Values no longer works 2015-05-27 16:22:20 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned burg commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1080810 0 joepeck 2015-03-27 16:56:34 -0700 * SUMMARY Editing Style Metrics Values no longer works. * TEST <div style="width: 100px; background: blue">Text</div> * STEPS TO REPRODUCE 1. Inspect div on test 2. Show Styles details sidebar pane 3. Show Metrics tab 4. Double click width/height 5. Input value and commit (return) => Nothing happens * NOTES - Appears to be because we removed CSSProperty.add and friends which this code was using. r179286 1080811 1 webkit-bug-importer 2015-03-27 16:56:57 -0700 <rdar://problem/20334620> 1097716 2 253801 joepeck 2015-05-27 14:23:19 -0700 Created attachment 253801 [PATCH] Proposed Fix 1097728 3 253801 burg 2015-05-27 15:00:08 -0700 Comment on attachment 253801 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253801&action=review r=me > Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js:425 > + function didToggle() Reading the callback code, this will get called even if there was an error in the backend (passed: error, result, wasThrown). Should it only update if something actually changed? 1097739 4 joepeck 2015-05-27 15:33:19 -0700 (In reply to comment #3) > Comment on attachment 253801 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253801&action=review > > r=me > > > Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js:425 > > + function didToggle() > > Reading the callback code, this will get called even if there was an error > in the backend (passed: error, result, wasThrown). Should it only update if > something actually changed? I thought about doing a "style.getPropertyValue" and seeing if the value changed, but decided against it. Unknown side effects / errors could happen if someone overrides `CSSStyleDeclaration.prototype.setProperty` and ultimately still could have changed the property and so a refresh would still be useful. Always doing a refresh is the safe bet as long as we are using overridable APIs. Technically setProperty can trigger an error naturally if invoked on a readonly style, but I don't think that should ever be the case for us. 1097759 5 253801 commit-queue 2015-05-27 16:22:16 -0700 Comment on attachment 253801 [PATCH] Proposed Fix Clearing flags on attachment: 253801 Committed r184925: <http://trac.webkit.org/changeset/184925> 1097760 6 commit-queue 2015-05-27 16:22:20 -0700 All reviewed patches have been landed. Closing bug. 253801 2015-05-27 14:23:19 -0700 2015-05-27 16:22:16 -0700 [PATCH] Proposed Fix metrics.patch text/plain 3627 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYyNjQ3YjguLjU5ODczMjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTA1LTI3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVT U0lPTihyMTc5Mjg2KSBFZGl0aW5nIFN0eWxlIE1ldHJpY3MgVmFsdWVzIG5vIGxvbmdlciB3b3Jr cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMTY0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL0JveE1vZGVsRGV0YWlsc1NlY3Rpb25Sb3cuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdy5wcm90b3R5cGUuX3VwZGF0ZU1l dHJpY3MuY3JlYXRlRWxlbWVudCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQm94TW9kZWxEZXRh aWxzU2VjdGlvblJvdy5wcm90b3R5cGUuX2FwcGx5VXNlcklucHV0LnJlc29sdmVkTm9kZS50b2dn bGVJbmxpbmVTdHlsZVByb3BlcnR5KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Cb3hNb2RlbERl dGFpbHNTZWN0aW9uUm93LnByb3RvdHlwZS5fYXBwbHlVc2VySW5wdXQucmVzb2x2ZWROb2RlLmRp ZFRvZ2dsZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQm94TW9kZWxEZXRhaWxzU2VjdGlvblJv dy5wcm90b3R5cGUuX2FwcGx5VXNlcklucHV0LnJlc29sdmVkTm9kZSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdy5wcm90b3R5cGUuX2FwcGx5VXNlcklu cHV0KToKKyAgICAgICAgTWFrZSBpdCBzbyBlZGl0aW5nIGluIHRoZSBtZXRyaWNzIHBhbmUganVz dCBldmFsdWF0ZXMgZWxlbS5zdHlsZS5zZXRQcm9wZXJ0eQorICAgICAgICBvbiB0aGUgaW5zcGVj dGVkIHBhZ2UuIFVzZSAiIWltcG9ydGFudCIgdG8gdHJ5IGFuZCBnaXZlIHRoZSBtYXhpbXVtIHBy aW9yaXR5CisgICAgICAgIHBvc3NpYmxlLCB3aGljaCBpcyBhIGNoYW5nZSBmcm9tIG9sZGVyIGJl aGF2aW9yLiBGaW5hbGx5LCByZWZyZXNoIHRoZSBzaWRlYmFyCisgICAgICAgIHRvIHVwZGF0ZSBh bGwgdmFsdWVzLCBhbmQgdXBkYXRlIHRoZSBVSSBpZiBiYWQgaW5wdXQgZGlkbid0IGNoYW5nZSBz dHlsZXMuCisKIDIwMTUtMDUtMjYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBGdW5jdGlvbiBwYXJhbWV0ZXIgc3RyaW5nIHBh cnNpbmcgaW1wcm9wZXJseSBoYW5kbGVzIGVtcHR5IHBhcmFtZXRlciBsaXN0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Cb3hNb2RlbERldGFp bHNTZWN0aW9uUm93LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdy5qcwppbmRleCA4MzhlZmY1Li41MDg4MDU3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Cb3hN b2RlbERldGFpbHNTZWN0aW9uUm93LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0JveE1vZGVsRGV0YWlsc1NlY3Rpb25Sb3cuanMKQEAgLTExNyw4ICsx MTcsNyBAQCBXZWJJbnNwZWN0b3IuQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdyA9IGNsYXNzIEJv eE1vZGVsRGV0YWlsc1NlY3Rpb25Sb3cgZXh0ZW5kcwogICAgICAgICAgICAgZWxlbWVudC50ZXh0 Q29udGVudCA9IHNob3VsZFJvdW5kVmFsdWUgPyAoIn4iICsgTWF0aC5yb3VuZChmbG9hdFZhbHVl ICogMTAwKSAvIDEwMCkgOiB2YWx1ZTsKICAgICAgICAgICAgIGlmIChzaG91bGRSb3VuZFZhbHVl KQogICAgICAgICAgICAgICAgIGVsZW1lbnQudGl0bGUgPSB2YWx1ZTsKLSAgICAgICAgICAgIC8v IEZJWE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQzMTY0PiBXZWIgSW5zcGVjdG9yOiBSRUdS RVNTSU9OKHIxNzkyODYpIEVkaXRpbmcgU3R5bGUgTWV0cmljcyBWYWx1ZXMgbm8gbG9uZ2VyIHdv cmtzCi0gICAgICAgICAgICAvLyBlbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImRibGNsaWNrIiwg dGhpcy5fc3RhcnRFZGl0aW5nLmJpbmQodGhpcywgZWxlbWVudCwgbmFtZSwgcHJvcGVydHlOYW1l LCBzdHlsZSksIGZhbHNlKTsKKyAgICAgICAgICAgIGVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigi ZGJsY2xpY2siLCB0aGlzLl9zdGFydEVkaXRpbmcuYmluZCh0aGlzLCBlbGVtZW50LCBuYW1lLCBw cm9wZXJ0eU5hbWUsIHN0eWxlKSwgZmFsc2UpOwogICAgICAgICAgICAgcmV0dXJuIGVsZW1lbnQ7 CiAgICAgICAgIH0KIApAQCAtNDEzLDggKzQxMiwyNiBAQCBXZWJJbnNwZWN0b3IuQm94TW9kZWxE ZXRhaWxzU2VjdGlvblJvdyA9IGNsYXNzIEJveE1vZGVsRGV0YWlsc1NlY3Rpb25Sb3cgZXh0ZW5k cwogICAgICAgICAgICAgdXNlcklucHV0ID0gdXNlclZhbHVlUHggKyAicHgiOwogICAgICAgICB9 CiAKLSAgICAgICAgdmFyIHByb3BlcnR5ID0gdGhpcy5fbm9kZVN0eWxlcy5pbmxpbmVTdHlsZS5w cm9wZXJ0eUZvck5hbWUoY29udGV4dC5zdHlsZVByb3BlcnR5KTsKLSAgICAgICAgLy8gRklYTUU6 IDxodHRwczovL3dlYmtpdC5vcmcvYi8xNDMxNjQ+IFdlYiBJbnNwZWN0b3I6IFJFR1JFU1NJT04o cjE3OTI4NikgRWRpdGluZyBTdHlsZSBNZXRyaWNzIFZhbHVlcyBubyBsb25nZXIgd29ya3MKKyAg ICAgICAgZnVuY3Rpb24gcmVzb2x2ZWROb2RlKG9iamVjdCkKKyAgICAgICAgeworICAgICAgICAg ICAgaWYgKCFvYmplY3QpCisgICAgICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgICAgICBm dW5jdGlvbiB0b2dnbGVJbmxpbmVTdHlsZVByb3BlcnR5KHByb3BlcnR5LCB2YWx1ZSkKKyAgICAg ICAgICAgIHsKKyAgICAgICAgICAgICAgICB0aGlzLnN0eWxlLnNldFByb3BlcnR5KHByb3BlcnR5 LCB2YWx1ZSwgIiFpbXBvcnRhbnQiKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVu Y3Rpb24gZGlkVG9nZ2xlKCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICB0aGlzLl9u b2RlU3R5bGVzLnJlZnJlc2goKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgb2JqZWN0 LmNhbGxGdW5jdGlvbih0b2dnbGVJbmxpbmVTdHlsZVByb3BlcnR5LCBbc3R5bGVQcm9wZXJ0eSwg dXNlcklucHV0XSwgZmFsc2UsIGRpZFRvZ2dsZS5iaW5kKHRoaXMpKTsKKyAgICAgICAgICAgIG9i amVjdC5yZWxlYXNlKCk7CisgICAgICAgIH0KKworICAgICAgICBXZWJJbnNwZWN0b3IuUmVtb3Rl T2JqZWN0LnJlc29sdmVOb2RlKHRoaXMuX25vZGVTdHlsZXMubm9kZSwgIiIsIHJlc29sdmVkTm9k ZS5iaW5kKHRoaXMpKTsKICAgICB9CiAKICAgICBfZWRpdGluZ0NvbW1pdHRlZChlbGVtZW50LCB1 c2VySW5wdXQsIHByZXZpb3VzQ29udGVudCwgY29udGV4dCkK