143152 2015-03-27 14:15:24 -0700 WebProcessProxy should not retain WebBackForwardListItems forever. 2015-03-27 15:02:40 -0700 1 1 1 Unclassified WebKit History 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Performance P2 Normal --- 1 kling kling andersca kling oldest_to_newest 1080745 0 kling 2015-03-27 14:15:24 -0700 <rdar://problem/19925709> It's silly that WebProcessProxy keeps WebBackForwardListItems around after they get evicted from the back/forward list. We already handle the case where the web process sends an IPC message referencing an invalid back/forward list item anyway. 1080748 1 249607 kling 2015-03-27 14:19:33 -0700 Created attachment 249607 Proposed patch 1080767 2 249607 kling 2015-03-27 15:02:35 -0700 Comment on attachment 249607 Proposed patch Clearing flags on attachment: 249607 Committed r182084: <http://trac.webkit.org/changeset/182084> 1080768 3 kling 2015-03-27 15:02:40 -0700 All reviewed patches have been landed. Closing bug. 249607 2015-03-27 14:19:33 -0700 2015-03-27 15:02:35 -0700 Proposed patch bug-143152.diff text/plain 3649 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhYzg2ZDA1Li4yMzZjM2VhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTUtMDMtMjcgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFdlYlByb2Nlc3NQcm94eSBzaG91bGQgbm90IHJldGFpbiBXZWJCYWNrRm9yd2FyZExpc3RJ dGVtcyBmb3JldmVyLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTQzMTUyPgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTk5MjU3MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSGF2ZSBXZWJQcm9jZXNzUHJveHkgYWN0dWFsbHkgZm9y Z2V0IGFib3V0IGEgV2ViQmFja0ZvcndhcmRMaXN0SXRlbSBhZnRlciBpdCdzIHJlbW92ZWQgZnJv bQorICAgICAgICB0aGUgV2ViQmFja0ZvcndhcmRMaXN0LgorCisgICAgICAgIFRoaXMgZW5zdXJl cyB0aGF0IHdlIGRvbid0IGFjY3VtdWxhdGUgdG9vIG1hbnkgb2YgdGhlc2Ugb2JqZWN0cywgd2hp Y2ggY2FuIGdldCBxdWl0ZSBsYXJnZQorICAgICAgICBkdWUgdG8gdGhlIHNlc3Npb24gc3RhdGUg ZW5jb2RlZCBpbiB0aGVtLgorCisgICAgICAgIFdlIGFscmVhZHkgaGF2ZSBncmFjZWZ1bCBoYW5k bGluZyBvZiB0aGUgY2FzZSB3aGVyZSBhbiBpbmNvbWluZyBJUEMgbWVzc2FnZSByZWZlcmVuY2Vz CisgICAgICAgIGEgcmVtb3ZlZCBiYWNrL2ZvcndhcmQgbGlzdCBpdGVtLgorCisgICAgICAgICog VUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlzdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkJh Y2tGb3J3YXJkTGlzdDo6ZGlkUmVtb3ZlSXRlbSk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6YmFja0ZvcndhcmRS ZW1vdmVkSXRlbSk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQcm94eTo6cmVtb3ZlQmFja0ZvcndhcmRJdGVtKToK KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5Lmg6CisKIDIwMTUtMDMtMjcgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXVtOZXR3b3JrQ2Fj aGVdIFdlIG9ubHkgY2FjaGUgcmVzcG9uc2VzIHdpdGggc3RhdHVzIGNvZGVzIHRoYXQgYXJlIGNh Y2hlYWJsZSBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViQmFja0ZvcndhcmRMaXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJCYWNr Rm9yd2FyZExpc3QuY3BwCmluZGV4IDY1Zjk1ODEuLmQzNTcwZGIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuY3BwCkBAIC00MzYsNyArNDM2LDYg QEAgVmVjdG9yPEJhY2tGb3J3YXJkTGlzdEl0ZW1TdGF0ZT4gV2ViQmFja0ZvcndhcmRMaXN0Ojpp dGVtU3RhdGVzKCkgY29uc3QKIAogdm9pZCBXZWJCYWNrRm9yd2FyZExpc3Q6OmRpZFJlbW92ZUl0 ZW0oV2ViQmFja0ZvcndhcmRMaXN0SXRlbSYgYmFja0ZvcndhcmRMaXN0SXRlbSkKIHsKLSAgICAv LyBGSVhNRTogVGhpcyBzaG91bGQgcmVhbGx5IGFsc28gZGVsZXRlIHRoZSBpdGVtIGZyb20gdGhl IG1hcC4KICAgICBtX3BhZ2UtPmJhY2tGb3J3YXJkUmVtb3ZlZEl0ZW0oYmFja0ZvcndhcmRMaXN0 SXRlbS5pdGVtSUQoKSk7CiAKICNpZiBQTEFURk9STShDT0NPQSkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggYTExZDM2NS4uZWE3MGJlMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTUxMjUsNiArNTEyNSw3IEBA IHZvaWQgV2ViUGFnZVByb3h5OjpkaWRGaW5pc2hMb2FkaW5nRGF0YUZvckN1c3RvbUNvbnRlbnRQ cm92aWRlcihjb25zdCBTdHJpbmcmIHN1CiAKIHZvaWQgV2ViUGFnZVByb3h5OjpiYWNrRm9yd2Fy ZFJlbW92ZWRJdGVtKHVpbnQ2NF90IGl0ZW1JRCkKIHsKKyAgICBtX3Byb2Nlc3MtPnJlbW92ZUJh Y2tGb3J3YXJkSXRlbShpdGVtSUQpOwogICAgIG1fcHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6V2Vi UGFnZTo6RGlkUmVtb3ZlQmFja0ZvcndhcmRJdGVtKGl0ZW1JRCksIG1fcGFnZUlEKTsKIH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcAppbmRleCBhZWQ3 ZDI1Li5lNjE1MDQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJv Y2Vzc1Byb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1By b3h5LmNwcApAQCAtMjkyLDYgKzI5MiwxMSBAQCB2b2lkIFdlYlByb2Nlc3NQcm94eTo6cmVnaXN0 ZXJOZXdXZWJCYWNrRm9yd2FyZExpc3RJdGVtKFdlYkJhY2tGb3J3YXJkTGlzdEl0ZW0qCiAgICAg bV9iYWNrRm9yd2FyZExpc3RJdGVtTWFwLnNldChpdGVtLT5pdGVtSUQoKSwgaXRlbSk7CiB9CiAK K3ZvaWQgV2ViUHJvY2Vzc1Byb3h5OjpyZW1vdmVCYWNrRm9yd2FyZEl0ZW0odWludDY0X3QgaXRl bUlEKQoreworICAgIG1fYmFja0ZvcndhcmRMaXN0SXRlbU1hcC5yZW1vdmUoaXRlbUlEKTsKK30K Kwogdm9pZCBXZWJQcm9jZXNzUHJveHk6OmFzc3VtZVJlYWRBY2Nlc3NUb0Jhc2VVUkwoY29uc3Qg U3RyaW5nJiB1cmxTdHJpbmcpCiB7CiAgICAgVVJMIHVybChVUkwoKSwgdXJsU3RyaW5nKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuaCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuaAppbmRleCAxOWY1OTBmLi4x OTI3NjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1By b3h5LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5oCkBA IC0xMDcsNiArMTA3LDcgQEAgcHVibGljOgogICAgIHZvaWQgdXBkYXRlVGV4dENoZWNrZXJTdGF0 ZSgpOwogCiAgICAgdm9pZCByZWdpc3Rlck5ld1dlYkJhY2tGb3J3YXJkTGlzdEl0ZW0oV2ViQmFj a0ZvcndhcmRMaXN0SXRlbSopOworICAgIHZvaWQgcmVtb3ZlQmFja0ZvcndhcmRJdGVtKHVpbnQ2 NF90KTsKIAogICAgIHZvaWQgd2lsbEFjcXVpcmVVbml2ZXJzYWxGaWxlUmVhZFNhbmRib3hFeHRl bnNpb24oKSB7IG1fbWF5SGF2ZVVuaXZlcnNhbEZpbGVSZWFkU2FuZGJveEV4dGVuc2lvbiA9IHRy dWU7IH0KICAgICB2b2lkIGFzc3VtZVJlYWRBY2Nlc3NUb0Jhc2VVUkwoY29uc3QgU3RyaW5nJik7 Cg==