143148 2015-03-27 13:32:54 -0700 Deconstruction parameters are bound too late 2015-03-27 23:02:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam fpizlo ggaren mark.lam mmirman msaboff oliver oldest_to_newest 1080728 0 saam 2015-03-27 13:32:54 -0700 consider: ``` function test({arg}) { print(arg); function arg(){} } test({}) ``` Should print the function, not undefined. This is a simple fix in BytecodeGenerator::generate 1080788 1 249617 saam 2015-03-27 15:56:38 -0700 Created attachment 249617 WIP Waiting on a build to get tests results populated. 1080853 2 249634 saam 2015-03-27 19:15:37 -0700 Created attachment 249634 patch 1080883 3 249634 fpizlo 2015-03-27 22:03:13 -0700 Comment on attachment 249634 patch R=me. 1080893 4 saam 2015-03-27 23:02:58 -0700 landed in: http://trac.webkit.org/changeset/182109 249617 2015-03-27 15:56:38 -0700 2015-03-27 19:15:37 -0700 WIP clean-backup.diff text/plain 2583 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0 b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIv Qnl0ZWNvZGVHZW5lcmF0b3IuY3BwCShyZXZpc2lvbiAxODIwODApCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjksNyArNjksMTIgQEAgUGFyc2VyRXJyb3IgQnl0ZWNvZGVHZW5lcmF0b3I6OmdlbmVy YXRlKAogICAgIC8vIHBlcmZvcm0gdGhhdCBhc3NpZ25tZW50IG5vdy4KICAgICBpZiAobV9uZWVk VG9Jbml0aWFsaXplQXJndW1lbnRzKQogICAgICAgICBpbml0aWFsaXplVmFyaWFibGUodmFyaWFi bGUocHJvcGVydHlOYW1lcygpLmFyZ3VtZW50cyksIG1fYXJndW1lbnRzUmVnaXN0ZXIpOwotICAg IAorCisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2RlY29uc3RydWN0ZWRQYXJhbWV0ZXJz LnNpemUoKTsgaSsrKSB7CisgICAgICAgIGF1dG8mIGVudHJ5ID0gbV9kZWNvbnN0cnVjdGVkUGFy YW1ldGVyc1tpXTsKKyAgICAgICAgZW50cnkuc2Vjb25kLT5iaW5kVmFsdWUoKnRoaXMsIGVudHJ5 LmZpcnN0LmdldCgpKTsKKyAgICB9CisKICAgICB7CiAgICAgICAgIFJlZlB0cjxSZWdpc3RlcklE PiB0ZW1wID0gbmV3VGVtcG9yYXJ5KCk7CiAgICAgICAgIGZvciAoRnVuY3Rpb25Cb2R5Tm9kZSog ZnVuY3Rpb25Cb2R5IDogbV9mdW5jdGlvbnNUb0luaXRpYWxpemUpIHsKQEAgLTc4LDExICs4Myw2 IEBAIFBhcnNlckVycm9yIEJ5dGVjb2RlR2VuZXJhdG9yOjpnZW5lcmF0ZSgKICAgICAgICAgfQog ICAgIH0KICAgICAKLSAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fZGVjb25zdHJ1Y3RlZFBh cmFtZXRlcnMuc2l6ZSgpOyBpKyspIHsKLSAgICAgICAgYXV0byYgZW50cnkgPSBtX2RlY29uc3Ry dWN0ZWRQYXJhbWV0ZXJzW2ldOwotICAgICAgICBlbnRyeS5zZWNvbmQtPmJpbmRWYWx1ZSgqdGhp cywgZW50cnkuZmlyc3QuZ2V0KCkpOwotICAgIH0KLQogICAgIGJvb2wgY2FsbGluZ0NsYXNzQ29u c3RydWN0b3IgPSBjb25zdHJ1Y3RvcktpbmQoKSAhPSBDb25zdHJ1Y3RvcktpbmQ6Ok5vbmUgJiYg IWlzQ29uc3RydWN0b3IoKTsKICAgICBpZiAoIWNhbGxpbmdDbGFzc0NvbnN0cnVjdG9yKQogICAg ICAgICBtX3Njb3BlTm9kZS0+ZW1pdEJ5dGVjb2RlKCp0aGlzKTsKSW5kZXg6IExheW91dFRlc3Rz L2pzL2RlY29uc3RydWN0aW5nLXBhcmFtZXRlcnMtb3ZlcnJpZGRlbi1ieS1mdW5jdGlvbi5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pzL2RlY29uc3RydWN0aW5nLXBhcmFtZXRlcnMt b3ZlcnJpZGRlbi1ieS1mdW5jdGlvbi5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMv anMvZGVjb25zdHJ1Y3RpbmctcGFyYW1ldGVycy1vdmVycmlkZGVuLWJ5LWZ1bmN0aW9uLmh0bWwJ KHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICIt Ly9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9y ZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8c2Ny aXB0IHNyYz0ic2NyaXB0LXRlc3RzL2RlY29uc3RydWN0aW5nLXBhcmFtZXRlcnMtb3ZlcnJpZGRl bi1ieS1mdW5jdGlvbi5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pz LXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRU ZXN0cy9qcy9zY3JpcHQtdGVzdHMvZGVjb25zdHJ1Y3RpbmctcGFyYW1ldGVycy1vdmVycmlkZGVu LWJ5LWZ1bmN0aW9uLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0 cy9kZWNvbnN0cnVjdGluZy1wYXJhbWV0ZXJzLW92ZXJyaWRkZW4tYnktZnVuY3Rpb24uanMJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvZGVjb25zdHJ1Y3Rpbmct cGFyYW1ldGVycy1vdmVycmlkZGVuLWJ5LWZ1bmN0aW9uLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMTEgQEAKK2Rlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRvIGVuc3VyZSB0aGF0IGZ1bmN0 aW9ucyBvdmVycmlkZSBkZWNvbnN0cnVjdGlvbiBwYXJhbWV0ZXJzLiIpCisKK2Z1bmN0aW9uIGYo KSB7IHJldHVybiA0MDsgfQorZnVuY3Rpb24gdGVzdCh7YXJnfSkgeworICAgIGZ1bmN0aW9uIGFy ZygpIHsgcmV0dXJuIDQxOyB9CisgICAgcmV0dXJuIGFyZzsKK30KK25vSW5saW5lKHRlc3QpCisK K2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDsgaSsrKQorICAgIHNob3VsZEJlKHRlc3Qoe2FyZzog Zn0pKCksIDQxLCB0cnVlKTsK 249634 2015-03-27 19:15:37 -0700 2015-03-27 22:03:13 -0700 patch clean-backup.diff text/plain 4829 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgyMDk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE1LTAzLTI3ICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBEZWNvbnN0cnVjdGlvbiBwYXJhbWV0ZXJzIGFyZSBib3VuZCB0b28gbGF0ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMTQ4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCBhIGRl Y29uc3RydWN0aW9uIHBhdHRlcm4gbmFtZWQgd2l0aCB0aGUgc2FtZQorICAgICAgICBuYW1lIGFz IGEgZnVuY3Rpb24gd2lsbCBzaGFkb3cgdGhlIGZ1bmN0aW9uLiBUaGlzIGlzCisgICAgICAgIHdy b25nLiBJdCBzaG91bGQgYmUgdGhlIG90aGVyIHdheSBhcm91bmQuCisKKyAgICAgICAgKiBieXRl Y29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdl bmVyYXRvcjo6Z2VuZXJhdGUpOgorCiAyMDE1LTAzLTI3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJv ZmZAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBmbGFrZXkgZGZnLWludDhhcnJheS5qcyBhbmQg ZGZnLWludDE2YXJyYXkuanMgdGVzdHMgZm9yIEFSTTY0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAko cmV2aXNpb24gMTgyMDgwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9C eXRlY29kZUdlbmVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY5LDcgKzY5LDEyIEBAIFBh cnNlckVycm9yIEJ5dGVjb2RlR2VuZXJhdG9yOjpnZW5lcmF0ZSgKICAgICAvLyBwZXJmb3JtIHRo YXQgYXNzaWdubWVudCBub3cuCiAgICAgaWYgKG1fbmVlZFRvSW5pdGlhbGl6ZUFyZ3VtZW50cykK ICAgICAgICAgaW5pdGlhbGl6ZVZhcmlhYmxlKHZhcmlhYmxlKHByb3BlcnR5TmFtZXMoKS5hcmd1 bWVudHMpLCBtX2FyZ3VtZW50c1JlZ2lzdGVyKTsKLSAgICAKKworICAgIGZvciAoc2l6ZV90IGkg PSAwOyBpIDwgbV9kZWNvbnN0cnVjdGVkUGFyYW1ldGVycy5zaXplKCk7IGkrKykgeworICAgICAg ICBhdXRvJiBlbnRyeSA9IG1fZGVjb25zdHJ1Y3RlZFBhcmFtZXRlcnNbaV07CisgICAgICAgIGVu dHJ5LnNlY29uZC0+YmluZFZhbHVlKCp0aGlzLCBlbnRyeS5maXJzdC5nZXQoKSk7CisgICAgfQor CiAgICAgewogICAgICAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gdGVtcCA9IG5ld1RlbXBvcmFyeSgp OwogICAgICAgICBmb3IgKEZ1bmN0aW9uQm9keU5vZGUqIGZ1bmN0aW9uQm9keSA6IG1fZnVuY3Rp b25zVG9Jbml0aWFsaXplKSB7CkBAIC03OCwxMSArODMsNiBAQCBQYXJzZXJFcnJvciBCeXRlY29k ZUdlbmVyYXRvcjo6Z2VuZXJhdGUoCiAgICAgICAgIH0KICAgICB9CiAgICAgCi0gICAgZm9yIChz aXplX3QgaSA9IDA7IGkgPCBtX2RlY29uc3RydWN0ZWRQYXJhbWV0ZXJzLnNpemUoKTsgaSsrKSB7 Ci0gICAgICAgIGF1dG8mIGVudHJ5ID0gbV9kZWNvbnN0cnVjdGVkUGFyYW1ldGVyc1tpXTsKLSAg ICAgICAgZW50cnkuc2Vjb25kLT5iaW5kVmFsdWUoKnRoaXMsIGVudHJ5LmZpcnN0LmdldCgpKTsK LSAgICB9Ci0KICAgICBib29sIGNhbGxpbmdDbGFzc0NvbnN0cnVjdG9yID0gY29uc3RydWN0b3JL aW5kKCkgIT0gQ29uc3RydWN0b3JLaW5kOjpOb25lICYmICFpc0NvbnN0cnVjdG9yKCk7CiAgICAg aWYgKCFjYWxsaW5nQ2xhc3NDb25zdHJ1Y3RvcikKICAgICAgICAgbV9zY29wZU5vZGUtPmVtaXRC eXRlY29kZSgqdGhpcyk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODIwOTcpCisrKyBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxNS0wMy0yNyAg U2FhbSBCYXJhdGkgIDxzYWFtYmFyYXRpMUBnbWFpbC5jb20+CisKKyAgICAgICAgRGVjb25zdHJ1 Y3Rpb24gcGFyYW1ldGVycyBhcmUgYm91bmQgdG9vIGxhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzE0OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICoganMvZGVjb25zdHJ1Y3RpbmctcGFyYW1ldGVy cy1vdmVycmlkZGVuLWJ5LWZ1bmN0aW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog anMvZGVjb25zdHJ1Y3RpbmctcGFyYW1ldGVycy1vdmVycmlkZGVuLWJ5LWZ1bmN0aW9uLmh0bWw6 IEFkZGVkLgorICAgICAgICAqIGpzL3NjcmlwdC10ZXN0cy9kZWNvbnN0cnVjdGluZy1wYXJhbWV0 ZXJzLW92ZXJyaWRkZW4tYnktZnVuY3Rpb24uanM6IEFkZGVkLgorICAgICAgICAoZGVzY3JpcHRp b24uZik6CisgICAgICAgICh0ZXN0KToKKyAgICAgICAgKC5hcmcpOgorCiAyMDE1LTAzLTI3ICBN aWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBmbGFrZXkg ZGZnLWludDhhcnJheS5qcyBhbmQgZGZnLWludDE2YXJyYXkuanMgdGVzdHMgZm9yIEFSTTY0Cklu ZGV4OiBMYXlvdXRUZXN0cy9qcy9kZWNvbnN0cnVjdGluZy1wYXJhbWV0ZXJzLW92ZXJyaWRkZW4t YnktZnVuY3Rpb24tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pzL2Rl Y29uc3RydWN0aW5nLXBhcmFtZXRlcnMtb3ZlcnJpZGRlbi1ieS1mdW5jdGlvbi1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9qcy9kZWNvbnN0cnVjdGluZy1wYXJhbWV0 ZXJzLW92ZXJyaWRkZW4tYnktZnVuY3Rpb24tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBA IC0wLDAgKzEsOSBAQAorVGhpcyB0ZXN0cyB0byBlbnN1cmUgdGhhdCBmdW5jdGlvbnMgb3ZlcnJp ZGUgZGVjb25zdHJ1Y3Rpb24gcGFyYW1ldGVycy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2Vl IGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUi LgorCisKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor CkluZGV4OiBMYXlvdXRUZXN0cy9qcy9kZWNvbnN0cnVjdGluZy1wYXJhbWV0ZXJzLW92ZXJyaWRk ZW4tYnktZnVuY3Rpb24uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9qcy9kZWNvbnN0 cnVjdGluZy1wYXJhbWV0ZXJzLW92ZXJyaWRkZW4tYnktZnVuY3Rpb24uaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2pzL2RlY29uc3RydWN0aW5nLXBhcmFtZXRlcnMtb3ZlcnJpZGRl bi1ieS1mdW5jdGlvbi5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAgQEAKKzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+ Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwv aGVhZD4KKzxib2R5PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9kZWNvbnN0cnVjdGluZy1w YXJhbWV0ZXJzLW92ZXJyaWRkZW4tYnktZnVuY3Rpb24uanMiPjwvc2NyaXB0PgorPHNjcmlwdCBz cmM9Ii4uL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9o dG1sPgpJbmRleDogTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2RlY29uc3RydWN0aW5nLXBh cmFtZXRlcnMtb3ZlcnJpZGRlbi1ieS1mdW5jdGlvbi5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9qcy9zY3JpcHQtdGVzdHMvZGVjb25zdHJ1Y3RpbmctcGFyYW1ldGVycy1vdmVycmlkZGVu LWJ5LWZ1bmN0aW9uLmpzCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRl c3RzL2RlY29uc3RydWN0aW5nLXBhcmFtZXRlcnMtb3ZlcnJpZGRlbi1ieS1mdW5jdGlvbi5qcwko d29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDExIEBACitkZXNjcmlwdGlvbigiVGhpcyB0ZXN0cyB0 byBlbnN1cmUgdGhhdCBmdW5jdGlvbnMgb3ZlcnJpZGUgZGVjb25zdHJ1Y3Rpb24gcGFyYW1ldGVy cy4iKQorCitmdW5jdGlvbiBmKCkgeyByZXR1cm4gNDA7IH0KK2Z1bmN0aW9uIHRlc3Qoe2FyZ30p IHsKKyAgICBmdW5jdGlvbiBhcmcoKSB7IHJldHVybiA0MTsgfQorICAgIHJldHVybiBhcmc7Cit9 Citub0lubGluZSh0ZXN0KQorCitmb3IgKHZhciBpID0gMDsgaSA8IDEwMDA7IGkrKykKKyAgICBz aG91bGRCZSgidGVzdCh7YXJnOiBmfSkoKSIsICI0MSIsIHRydWUpOwo=