143139 2015-03-27 11:58:50 -0700 Web Inspector: Uncaught Exception: TypeError: Attempted to assign to readonly - DOMNodeDetailsSidebarPanel.js 2015-03-27 17:52:07 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1080683 0 joepeck 2015-03-27 11:58:50 -0700 * SUMMARY Uncaught Exception: TypeError: Attempted to assign to readonly. [Error] Uncaught exception in inspector page while handling event DOM.attributeModified: TypeError: Attempted to assign to readonly property. _createAttributesDataGrid @ /Views/DOMNodeDetailsSidebarPanel.js:587:17 _refreshAttributes @ /Views/DOMNodeDetailsSidebarPanel.js:122:78 _attributesChanged @ /Views/DOMNodeDetailsSidebarPanel.js:537:32 dispatch @ /Base/Object.js:129:55 dispatchEventToListeners @ /Base/Object.js:136:17 _attributeModified @ /Controllers/DOMTreeManager.js:136:38 attributeModified @ /Protocol/DOMObserver.js:42:55 dispatchEvent @ /Protocol/InspectorBackend.js:353:42 _dispatchEvent @ /Protocol/InspectorBackend.js:233:32 dispatch @ /Protocol/InspectorBackend.js:88:32 dispatchNextQueuedMessageFromBackend @ /Protocol/MessageDispatcher.js:42:34 Not exactly sure how to reproduce, but I was playing with DOM nodes in the console and may have modified an attribute myself. 1080685 1 webkit-bug-importer 2015-03-27 11:59:28 -0700 <rdar://problem/20329695> 1080686 2 joepeck 2015-03-27 12:00:02 -0700 Looks like there are plenty of places that set the selectable state of a DataGridNode: var node = new WebInspector.DataGridNode({name: attribute.name, value: attribute.value || ""}, false); node.selectable = true; But DataGridNode only has a getter for "selectable" not a setter. 1080687 3 joepeck 2015-03-27 12:01:26 -0700 * STEPS TO REPRODUCE 1. Inspect any page with an image 2. Show the Node details sidebar for an image 3. Expand Attributes Section => exceptions in inspector 1080694 4 249593 joepeck 2015-03-27 12:10:34 -0700 Created attachment 249593 [PATCH] Proposed Fix 1080826 5 249593 commit-queue 2015-03-27 17:52:03 -0700 Comment on attachment 249593 [PATCH] Proposed Fix Clearing flags on attachment: 249593 Committed r182092: <http://trac.webkit.org/changeset/182092> 1080827 6 commit-queue 2015-03-27 17:52:07 -0700 All reviewed patches have been landed. Closing bug. 249593 2015-03-27 12:10:34 -0700 2015-03-27 17:52:03 -0700 [PATCH] Proposed Fix selectable.patch text/plain 4934 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE2Y2I2NjkuLjNjNWJiYjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDE1LTAzLTI3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgRXhjZXB0aW9uOiBUeXBlRXJyb3I6IEF0dGVtcHRlZCB0byBhc3NpZ24gdG8gcmVhZG9ubHkg LSBET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbC5qcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMTM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRGF0YUdyaWROb2RlcyBkbyBub3QgaGF2ZSBhIHNlbGVj dGFibGUgc2V0dGVyLiBUcmVlRWxlbWVudHMgZG8uCisgICAgICAgIERhdGFHcmlkTm9kZXMgYXJl IGFsd2F5cyBzZWxlY3RhYmxlLiBNYXRjaCBjdXJyZW50IGJlaGF2aW9yIGJ5CisgICAgICAgIHJl bW92aW5nIGFsbCBpbnN0YW5jZXMgb2YgYXR0ZW1wdGluZyB0byBzZXQgdGhlIHNlbGVjdGFiaWxp dHkKKyAgICAgICAgd2hpY2ggd291bGQsIHVuZGVyIHN0cmljdCBtb2RlLCByZXN1bHQgaW4gYW4g ZXJyb3IuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVG cmFtZUNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkFwcGxpY2F0aW9uQ2Fj aGVGcmFtZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5fcG9wdWxhdGVEYXRhR3JpZCk6CisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9Db29raWVTdG9yYWdlQ29udGVudFZpZXcuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuQ29va2llU3RvcmFnZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5fcmVi dWlsZFRhYmxlKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTU5vZGVEZXRhaWxz U2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTU5vZGVEZXRhaWxzU2lk ZWJhclBhbmVsLnByb3RvdHlwZS5fY3JlYXRlQXR0cmlidXRlc0RhdGFHcmlkKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbCk6CisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9ET01TdG9yYWdlQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuRE9NU3RvcmFnZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5yZXNldCk6CisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qczoKKworMjAxNS0wMy0yNyAgSm9zZXBo IFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IEFkZCBTZXR0ZXIgSWNvbiBmb3IgT2JqZWN0VHJlZVZpZXcKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzEyOQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BcHBsaWNhdGlvbkNhY2hlRnJhbWVD b250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0FwcGxpY2F0aW9uQ2FjaGVGcmFtZUNvbnRlbnRWaWV3LmpzCmluZGV4IDc4YTg5YzMuLjVkODYx MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0FwcGxpY2F0aW9uQ2FjaGVGcmFtZUNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVGcmFtZUNvbnRlbnRW aWV3LmpzCkBAIC0yMTksNyArMjE5LDYgQEAgV2ViSW5zcGVjdG9yLkFwcGxpY2F0aW9uQ2FjaGVG cmFtZUNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICBzaXplOiBOdW1i ZXIuYnl0ZXNUb1N0cmluZyhyZXNvdXJjZS5zaXplKQogICAgICAgICAgICAgfTsKICAgICAgICAg ICAgIHZhciBub2RlID0gbmV3IFdlYkluc3BlY3Rvci5EYXRhR3JpZE5vZGUoZGF0YSk7Ci0gICAg ICAgICAgICBub2RlLnNlbGVjdGFibGUgPSB0cnVlOwogICAgICAgICAgICAgdGhpcy5fZGF0YUdy aWQuYXBwZW5kQ2hpbGQobm9kZSk7CiAgICAgICAgIH0KICAgICB9LApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29va2llU3RvcmFnZUNvbnRl bnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29v a2llU3RvcmFnZUNvbnRlbnRWaWV3LmpzCmluZGV4IDNhMTBkNWYuLjEwZDRlNzIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Nvb2tpZVN0b3Jh Z2VDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9Db29raWVTdG9yYWdlQ29udGVudFZpZXcuanMKQEAgLTE0OCw3ICsxNDgsNiBAQCBX ZWJJbnNwZWN0b3IuQ29va2llU3RvcmFnZUNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgICAgICBkYXRhWyJleHBpcmVzIl0gPSBjb29raWUuc2Vzc2lvbiA/IFdlYkluc3BlY3Rv ci5VSVN0cmluZygiU2Vzc2lvbiIpIDogbmV3IERhdGUoY29va2llLmV4cGlyZXMpLnRvTG9jYWxl U3RyaW5nKCk7CiAKICAgICAgICAgICAgIHZhciBub2RlID0gbmV3IFdlYkluc3BlY3Rvci5EYXRh R3JpZE5vZGUoZGF0YSk7Ci0gICAgICAgICAgICBub2RlLnNlbGVjdGFibGUgPSB0cnVlOwogICAg ICAgICAgICAgbm9kZS5jb29raWUgPSBjb29raWU7CiAKICAgICAgICAgICAgIHRoaXMuX2RhdGFH cmlkLmFwcGVuZENoaWxkKG5vZGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NTm9kZURldGFpbHNTaWRlYmFyUGFuZWwuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWlsc1NpZGVi YXJQYW5lbC5qcwppbmRleCA0ZWM4ZWI3Li5lZjQ3MjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5l bC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01O b2RlRGV0YWlsc1NpZGViYXJQYW5lbC5qcwpAQCAtNTg0LDggKzU4NCw2IEBAIFdlYkluc3BlY3Rv ci5ET01Ob2RlRGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIERPTU5vZGVEZXRhaWxzU2lkZWJh clBhbmVsIGV4dGVuCiAgICAgICAgICAgICB2YXIgYXR0cmlidXRlID0gYXR0cmlidXRlc1tpXTsK IAogICAgICAgICAgICAgdmFyIG5vZGUgPSBuZXcgV2ViSW5zcGVjdG9yLkRhdGFHcmlkTm9kZSh7 bmFtZTogYXR0cmlidXRlLm5hbWUsIHZhbHVlOiBhdHRyaWJ1dGUudmFsdWUgfHwgIiJ9LCBmYWxz ZSk7Ci0gICAgICAgICAgICBub2RlLnNlbGVjdGFibGUgPSB0cnVlOwotCiAgICAgICAgICAgICBk YXRhR3JpZC5hcHBlbmRDaGlsZChub2RlKTsKICAgICAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01TdG9yYWdlQ29udGVudFZp ZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9ET01TdG9y YWdlQ29udGVudFZpZXcuanMKaW5kZXggNDA2YTM1Zi4uMTQ3MDg5NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NU3RvcmFnZUNvbnRlbnRW aWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RP TVN0b3JhZ2VDb250ZW50Vmlldy5qcwpAQCAtODAsNyArODAsNiBAQCBXZWJJbnNwZWN0b3IuRE9N U3RvcmFnZUNvbnRlbnRWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICAgICAgY29u dGludWU7CiAgICAgICAgICAgICAgICAgdmFyIGRhdGEgPSB7a2V5OiBlbnRyeVswXSwgdmFsdWU6 IGVudHJ5WzFdfTsKICAgICAgICAgICAgICAgICB2YXIgbm9kZSA9IG5ldyBXZWJJbnNwZWN0b3Iu RGF0YUdyaWROb2RlKGRhdGEsIGZhbHNlKTsKLSAgICAgICAgICAgICAgICBub2RlLnNlbGVjdGFi bGUgPSB0cnVlOwogICAgICAgICAgICAgICAgIHRoaXMuX2RhdGFHcmlkLmFwcGVuZENoaWxkKG5v ZGUpOwogICAgICAgICAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCmluZGV4IGU1MmQ4N2MuLjk5MDA4MDYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFH cmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0Rh dGFHcmlkLmpzCkBAIC0xNDEsNyArMTQxLDYgQEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkLmNyZWF0 ZVNvcnRhYmxlRGF0YUdyaWQgPSBmdW5jdGlvbihjb2x1bW5OYW1lcywgdmFsdWVzKQogICAgICAg ICAgICAgZGF0YVtjb2x1bW5OYW1lc1tqXV0gPSB2YWx1ZXNbbnVtQ29sdW1ucyAqIGkgKyBqXTsK IAogICAgICAgICB2YXIgbm9kZSA9IG5ldyBXZWJJbnNwZWN0b3IuRGF0YUdyaWROb2RlKGRhdGEs IGZhbHNlKTsKLSAgICAgICAgbm9kZS5zZWxlY3RhYmxlID0gZmFsc2U7CiAgICAgICAgIGRhdGFH cmlkLmFwcGVuZENoaWxkKG5vZGUpOwogICAgIH0KIAo=