143137 2015-03-27 10:54:57 -0700 [WK2][NetworkCache] Rename requestNeedsRevalidation() to requestRequiresRevalidation() 2015-03-27 13:17:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue koivisto oldest_to_newest 1080657 0 cdumez 2015-03-27 10:54:57 -0700 Rename requestNeedsRevalidation() to requestRequiresRevalidation() as I think it is more accurate. It is not the request that needs revalidating. The requests just requires us to revalidate the response. 1080658 1 249584 cdumez 2015-03-27 10:56:16 -0700 Created attachment 249584 Patch 1080659 2 cdumez 2015-03-27 10:57:03 -0700 Alternatively, requestRequiresResponseRevalidation() would be clear I think but it is a bit long. 1080720 3 249584 commit-queue 2015-03-27 13:17:45 -0700 Comment on attachment 249584 Patch Clearing flags on attachment: 249584 Committed r182074: <http://trac.webkit.org/changeset/182074> 1080721 4 commit-queue 2015-03-27 13:17:49 -0700 All reviewed patches have been landed. Closing bug. 249584 2015-03-27 10:56:16 -0700 2015-03-27 13:17:45 -0700 Patch bug-143137-20150327105536.patch text/plain 2338 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmYwYzc3ODM0ZjVhMTE1 NDFhOThkOTMyZDQ1NDY2MTFmNWYzN2Q2ZS4uMTBhZTNjNDQ4MTE4NGQ5ODM5MzE4MTdmMzliNjVk MTc2ODY3OWU3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAzLTI3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1bTmV0d29ya0NhY2hl XSBSZW5hbWUgcmVxdWVzdE5lZWRzUmV2YWxpZGF0aW9uKCkgdG8gcmVxdWVzdFJlcXVpcmVzUmV2 YWxpZGF0aW9uKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0MzEzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbmFtZSByZXF1ZXN0TmVlZHNSZXZhbGlkYXRpb24oKSB0byByZXF1ZXN0UmVxdWlyZXNS ZXZhbGlkYXRpb24oKSBhcyBJCisgICAgICAgIHRoaW5rIGl0IGlzIG1vcmUgYWNjdXJhdGUuIEl0 IGlzIG5vdCB0aGUgcmVxdWVzdCB0aGF0IG5lZWRzIHJldmFsaWRhdGluZy4KKyAgICAgICAgVGhl IHJlcXVlc3RzIGp1c3QgcmVxdWlyZXMgdXMgdG8gcmV2YWxpZGF0ZSB0aGUgcmVzcG9uc2UuCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwOgorICAgICAg ICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OnJlcXVlc3RSZXF1aXJlc1JldmFsaWRhdGlvbik6Cisg ICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6Y2FuVXNlKToKKyAgICAgICAgKFdlYktpdDo6 TmV0d29ya0NhY2hlOjpyZXF1ZXN0TmVlZHNSZXZhbGlkYXRpb24pOiBEZWxldGVkLgorCiAyMDE1 LTAzLTI2ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXNw ZWN0IGNhY2hlLWNvbnRyb2wgZGlyZWN0aXZlcyBpbiByZXF1ZXN0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwIGIvU291cmNl L1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAppbmRleCBlNDYx ZDRmNzQ1ZDNlMTJlODI2ZWUxMDUzMTI3MjY3ZDVhMDFhNjUxLi41OWRiYWQ5NTUzNTA1NTc1NTE2 NWIxNDU0Mjg5ZjgwMGI3YmI2OTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdv cmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHAKQEAgLTE2OSw3ICsxNjksNyBAQCBzdGF0 aWMgYm9vbCByZXNwb25zZUhhc0V4cGlyZWQoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25z ZSYgcmVzcG9uc2UsIHN0ZDo6YwogICAgIHJldHVybiBoYXNFeHBpcmVkOwogfQogCi1zdGF0aWMg Ym9vbCByZXF1ZXN0TmVlZHNSZXZhbGlkYXRpb24oY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1 ZXN0JiByZXF1ZXN0KQorc3RhdGljIGJvb2wgcmVxdWVzdFJlcXVpcmVzUmV2YWxpZGF0aW9uKGNv bnN0IFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKIHsKICAgICBhdXRvIHJlcXVl c3REaXJlY3RpdmVzID0gV2ViQ29yZTo6cGFyc2VDYWNoZUNvbnRyb2xEaXJlY3RpdmVzKHJlcXVl c3QuaHR0cEhlYWRlckZpZWxkcygpKTsKICAgICBpZiAocmVxdWVzdERpcmVjdGl2ZXMubm9DYWNo ZSkKQEAgLTE5Miw3ICsxOTIsNyBAQCBzdGF0aWMgVXNlRGVjaXNpb24gY2FuVXNlKGNvbnN0IEVu dHJ5JiBlbnRyeSwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0JiByZQogICAgIGlmIChj YWNoZVBvbGljeUFsbG93c0V4cGlyZWQocmVxdWVzdC5jYWNoZVBvbGljeSgpKSkKICAgICAgICAg cmV0dXJuIFVzZURlY2lzaW9uOjpVc2U7CiAKLSAgICBib29sIG5lZWRzUmV2YWxpZGF0aW9uID0g cmVxdWVzdE5lZWRzUmV2YWxpZGF0aW9uKHJlcXVlc3QpIHx8IHJlc3BvbnNlSGFzRXhwaXJlZChl bnRyeS5yZXNwb25zZSgpLCBlbnRyeS50aW1lU3RhbXAoKSk7CisgICAgYm9vbCBuZWVkc1JldmFs aWRhdGlvbiA9IHJlcXVlc3RSZXF1aXJlc1JldmFsaWRhdGlvbihyZXF1ZXN0KSB8fCByZXNwb25z ZUhhc0V4cGlyZWQoZW50cnkucmVzcG9uc2UoKSwgZW50cnkudGltZVN0YW1wKCkpOwogICAgIGlm ICghbmVlZHNSZXZhbGlkYXRpb24pCiAgICAgICAgIHJldHVybiBVc2VEZWNpc2lvbjo6VXNlOwog Cg==