143134 2015-03-27 10:10:48 -0700 Avoid using hardcoded values for JSValue::Int32Tag, if possible. 2015-03-30 13:13:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue ggaren oldest_to_newest 1080632 0 peavo 2015-03-27 10:10:48 -0700 This seems to be a Visual Studio workaround, which probably is not needed anymore. 1080633 1 249577 peavo 2015-03-27 10:12:28 -0700 Created attachment 249577 Patch 1080648 2 249577 ggaren 2015-03-27 10:35:22 -0700 Comment on attachment 249577 Patch r=me if you can get EWS to build this on Windows, but it doesn't currently. 1080650 3 peavo 2015-03-27 10:39:15 -0700 (In reply to comment #2) > Comment on attachment 249577 [details] > Patch > > r=me if you can get EWS to build this on Windows, but it doesn't currently. There seems to be a problem applying the patch: urllib2.URLError: <urlopen error [Errno 8] hostname nor servname provided, or not known> I'm not sure what that means, I'll try uploading the patch again :) 1080652 4 249581 peavo 2015-03-27 10:41:31 -0700 Created attachment 249581 Patch 1080701 5 peavo 2015-03-27 12:25:03 -0700 Patch is building on Windows now. 1080809 6 249581 ggaren 2015-03-27 16:56:16 -0700 Comment on attachment 249581 Patch r=me 1080895 7 peavo 2015-03-27 23:27:33 -0700 (In reply to comment #6) > Comment on attachment 249581 [details] > Patch > > r=me Thanks :) 1081280 8 249581 commit-queue 2015-03-30 13:13:06 -0700 Comment on attachment 249581 Patch Clearing flags on attachment: 249581 Committed r182151: <http://trac.webkit.org/changeset/182151> 1081281 9 commit-queue 2015-03-30 13:13:11 -0700 All reviewed patches have been landed. Closing bug. 249577 2015-03-27 10:12:28 -0700 2015-03-27 10:41:22 -0700 Patch bug-143134-20150327181140.patch text/plain 2518 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgyMDY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTAzLTI3ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAg ICAgICBBdm9pZCB1c2luZyBoYXJkY29kZWQgdmFsdWVzIGZvciBKU1ZhbHVlOjpJbnQzMlRhZywg aWYgcG9zc2libGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDMxMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGppdC9KU0ludGVyZmFjZUpJVC5oOgorICAgICAgICAqIGppdC9SZXBhdGNoLmNwcDoK KyAgICAgICAgKEpTQzo6dHJ5Q2FjaGVHZXRCeUlEKToKKwogMjAxNS0wMy0yNyAgTWljaGFlbCBT YWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBPYmplY3RzIHdpdGggbnVtZXJp YyBwcm9wZXJ0aWVzIGludGVybWl0dGVudGx5IGdldCBhIHBoYW50b20gJ2xlbmd0aCcgcHJvcGVy dHkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSlNJbnRlcmZhY2VKSVQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pTSW50ZXJmYWNlSklULmgJKHJl dmlzaW9uIDE4MjA1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSlNJbnRlcmZhY2VK SVQuaAkod29ya2luZyBjb3B5KQpAQCAtNTAsOSArNTAsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAg ICAgICAgfQogCiAjaWYgVVNFKEpTVkFMVUUzMl82NCkKLSAgICAgICAgLy8gQ2FuJ3QganVzdCBw cm9wb2dhdGUgSlNWYWx1ZTo6SW50MzJUYWcgYXMgdmlzdWFsIHN0dWRpbyBkb2Vzbid0IGxpa2Ug aXQKLSAgICAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIEludDMyVGFnID0gMHhmZmZmZmZmZjsK LSAgICAgICAgQ09NUElMRV9BU1NFUlQoSW50MzJUYWcgPT0gSlNWYWx1ZTo6SW50MzJUYWcsIElu dDMyVGFnX291dF9vZl9zeW5jKTsKKyAgICAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIEludDMy VGFnID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KEpTVmFsdWU6OkludDMyVGFnKTsKICNlbHNlCiAg ICAgICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBJbnQzMlRhZyA9IHN0YXRpY19jYXN0PHVuc2ln bmVkPihUYWdUeXBlTnVtYmVyID4+IDMyKTsKICNlbmRpZgpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9SZXBhdGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L1JlcGF0Y2guY3BwCShyZXZpc2lvbiAxODIwNTcpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L1JlcGF0Y2guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02ODQsNyArNjg0LDcgQEAg c3RhdGljIElubGluZUNhY2hlQWN0aW9uIHRyeUNhY2hlR2V0QnlJRAogI2lmIFVTRShKU1ZBTFVF NjQpCiAgICAgICAgICAgICBzdHViSml0Lm9yNjQoQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1t NjQoVGFnVHlwZU51bWJlciksIHJlc3VsdEdQUik7CiAjZWxpZiBVU0UoSlNWQUxVRTMyXzY0KQot ICAgICAgICAgICAgc3R1YkppdC5tb3ZlKEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZEltbTMyKDB4 ZmZmZmZmZmYpLCByZXN1bHRUYWdHUFIpOyAvLyBKU1ZhbHVlOjpJbnQzMlRhZworICAgICAgICAg ICAgc3R1YkppdC5tb3ZlKEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZEltbTMyKEpTVmFsdWU6Oklu dDMyVGFnKSwgcmVzdWx0VGFnR1BSKTsKICNlbmRpZgogCiAgICAgICAgICAgICBNYWNyb0Fzc2Vt Ymxlcjo6SnVtcCBzdWNjZXNzLCBmYWlsOwpAQCAtNzE4LDcgKzcxOCw3IEBAIHN0YXRpYyBJbmxp bmVDYWNoZUFjdGlvbiB0cnlDYWNoZUdldEJ5SUQKICNpZiBVU0UoSlNWQUxVRTY0KQogICAgICAg ICBzdHViSml0Lm9yNjQoQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1tNjQoVGFnVHlwZU51bWJl ciksIHJlc3VsdEdQUik7CiAjZWxpZiBVU0UoSlNWQUxVRTMyXzY0KQotICAgICAgICBzdHViSml0 Lm1vdmUoQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1tMzIoMHhmZmZmZmZmZiksIHJlc3VsdFRh Z0dQUik7IC8vIEpTVmFsdWU6OkludDMyVGFnCisgICAgICAgIHN0dWJKaXQubW92ZShBc3NlbWJs eUhlbHBlcnM6OlRydXN0ZWRJbW0zMihKU1ZhbHVlOjpJbnQzMlRhZyksIHJlc3VsdFRhZ0dQUik7 CiAjZW5kaWYKIAogICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcCBzdWNjZXNzID0gc3R1Ykpp dC5qdW1wKCk7Cg== 249581 2015-03-27 10:41:31 -0700 2015-03-30 13:13:06 -0700 Patch bug-143134-20150327184043.patch text/plain 2518 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgyMDY3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE1LTAzLTI3ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAg ICAgICBBdm9pZCB1c2luZyBoYXJkY29kZWQgdmFsdWVzIGZvciBKU1ZhbHVlOjpJbnQzMlRhZywg aWYgcG9zc2libGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNDMxMzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGppdC9KU0ludGVyZmFjZUpJVC5oOgorICAgICAgICAqIGppdC9SZXBhdGNoLmNwcDoK KyAgICAgICAgKEpTQzo6dHJ5Q2FjaGVHZXRCeUlEKToKKwogMjAxNS0wMy0yNyAgTWljaGFlbCBT YWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBPYmplY3RzIHdpdGggbnVtZXJp YyBwcm9wZXJ0aWVzIGludGVybWl0dGVudGx5IGdldCBhIHBoYW50b20gJ2xlbmd0aCcgcHJvcGVy dHkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSlNJbnRlcmZhY2VKSVQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pTSW50ZXJmYWNlSklULmgJKHJl dmlzaW9uIDE4MjA1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSlNJbnRlcmZhY2VK SVQuaAkod29ya2luZyBjb3B5KQpAQCAtNTAsOSArNTAsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAg ICAgICAgfQogCiAjaWYgVVNFKEpTVkFMVUUzMl82NCkKLSAgICAgICAgLy8gQ2FuJ3QganVzdCBw cm9wb2dhdGUgSlNWYWx1ZTo6SW50MzJUYWcgYXMgdmlzdWFsIHN0dWRpbyBkb2Vzbid0IGxpa2Ug aXQKLSAgICAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIEludDMyVGFnID0gMHhmZmZmZmZmZjsK LSAgICAgICAgQ09NUElMRV9BU1NFUlQoSW50MzJUYWcgPT0gSlNWYWx1ZTo6SW50MzJUYWcsIElu dDMyVGFnX291dF9vZl9zeW5jKTsKKyAgICAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIEludDMy VGFnID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KEpTVmFsdWU6OkludDMyVGFnKTsKICNlbHNlCiAg ICAgICAgIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBJbnQzMlRhZyA9IHN0YXRpY19jYXN0PHVuc2ln bmVkPihUYWdUeXBlTnVtYmVyID4+IDMyKTsKICNlbmRpZgpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2ppdC9SZXBhdGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L1JlcGF0Y2guY3BwCShyZXZpc2lvbiAxODIwNTcpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaml0L1JlcGF0Y2guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02ODQsNyArNjg0LDcgQEAg c3RhdGljIElubGluZUNhY2hlQWN0aW9uIHRyeUNhY2hlR2V0QnlJRAogI2lmIFVTRShKU1ZBTFVF NjQpCiAgICAgICAgICAgICBzdHViSml0Lm9yNjQoQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1t NjQoVGFnVHlwZU51bWJlciksIHJlc3VsdEdQUik7CiAjZWxpZiBVU0UoSlNWQUxVRTMyXzY0KQot ICAgICAgICAgICAgc3R1YkppdC5tb3ZlKEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZEltbTMyKDB4 ZmZmZmZmZmYpLCByZXN1bHRUYWdHUFIpOyAvLyBKU1ZhbHVlOjpJbnQzMlRhZworICAgICAgICAg ICAgc3R1YkppdC5tb3ZlKEFzc2VtYmx5SGVscGVyczo6VHJ1c3RlZEltbTMyKEpTVmFsdWU6Oklu dDMyVGFnKSwgcmVzdWx0VGFnR1BSKTsKICNlbmRpZgogCiAgICAgICAgICAgICBNYWNyb0Fzc2Vt Ymxlcjo6SnVtcCBzdWNjZXNzLCBmYWlsOwpAQCAtNzE4LDcgKzcxOCw3IEBAIHN0YXRpYyBJbmxp bmVDYWNoZUFjdGlvbiB0cnlDYWNoZUdldEJ5SUQKICNpZiBVU0UoSlNWQUxVRTY0KQogICAgICAg ICBzdHViSml0Lm9yNjQoQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1tNjQoVGFnVHlwZU51bWJl ciksIHJlc3VsdEdQUik7CiAjZWxpZiBVU0UoSlNWQUxVRTMyXzY0KQotICAgICAgICBzdHViSml0 Lm1vdmUoQXNzZW1ibHlIZWxwZXJzOjpUcnVzdGVkSW1tMzIoMHhmZmZmZmZmZiksIHJlc3VsdFRh Z0dQUik7IC8vIEpTVmFsdWU6OkludDMyVGFnCisgICAgICAgIHN0dWJKaXQubW92ZShBc3NlbWJs eUhlbHBlcnM6OlRydXN0ZWRJbW0zMihKU1ZhbHVlOjpJbnQzMlRhZyksIHJlc3VsdFRhZ0dQUik7 CiAjZW5kaWYKIAogICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcCBzdWNjZXNzID0gc3R1Ykpp dC5qdW1wKCk7Cg==