143120 2015-03-26 16:31:33 -0700 Optimized Fullscreen fails to cleanup becuase of no longer necessary release of m_playerController in exitFullscreen() 2015-03-27 10:56:05 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) iPhone / iPad Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue eric.carlson jer.noble jonlee webkit-bug-importer oldest_to_newest 1080482 0 jeremyj-wk 2015-03-26 16:31:33 -0700 Optimized Fullscreen fails to cleanup becuase of no longer necessary release of m_playerController in exitFullscreen() 1080484 1 249540 jeremyj-wk 2015-03-26 16:36:01 -0700 Created attachment 249540 Patch 1080486 2 jeremyj-wk 2015-03-26 16:37:07 -0700 rdar://problem/19445613 1080509 3 249540 eric.carlson 2015-03-26 17:29:12 -0700 Comment on attachment 249540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249540&action=review > Source/WebCore/ChangeLog:11 > + WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releaseing it prematurely can actually prevent the exit Nit: "Releaseing"-" "Releasing" 1080523 4 jonlee 2015-03-26 18:38:11 -0700 rdar://problem/20263463 1080548 5 jeremyj-wk 2015-03-26 22:43:54 -0700 (In reply to comment #3) > Comment on attachment 249540 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249540&action=review > > > Source/WebCore/ChangeLog:11 > > + WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releaseing it prematurely can actually prevent the exit > > Nit: "Releaseing"-" "Releasing" Fixes that and three other typos! 1080549 6 249552 jeremyj-wk 2015-03-26 22:44:00 -0700 Created attachment 249552 Patch for landing. 1080554 7 249552 commit-queue 2015-03-26 23:37:32 -0700 Comment on attachment 249552 Patch for landing. Clearing flags on attachment: 249552 Committed r182052: <http://trac.webkit.org/changeset/182052> 249540 2015-03-26 16:36:01 -0700 2015-03-26 17:29:12 -0700 Patch bug-143120-20150326163523.patch text/plain 1978 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGMzNGZiNTg5ZDI0NjE0 ODA4MGUyNGNmNzY1YmUwZTVlOTQzYmQ1ZS4uMjVmMjJlOTYzMzkzZGI5ZGEyY2QxZGQxODZkNzY1 NDFlYjM5N2UwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAzLTI2ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBPcHRpbWl6ZWQgRnVsbHNj cmVlbiBmYWlscyB0byBjbGVhbnVwIGJlY3Vhc2Ugb2Ygbm8gbG9uZ2VyIG5lY2Vzc2FyeSByZWxl YXNlIG9mIG1fcGxheWVyQ29udHJvbGxlciBpbiBleGl0RnVsbHNjcmVlbigpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMxMjAKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB1c2VkIHRvIHJlbGVhc2Ug bV9wbGF5ZXJDb250cm9sbGVyIGluIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Ojpl eGl0RnVsbHNjcmVlbigpIGluIG9yZGVyIHRvIG1ha2Ugc3VyZSAKKyAgICAgICAgbWVkaWEgc3Rh dGUgd2FzIHJlc2V0LiBUaGlzIGlzIG5vIGxvbmdlciBuZWNlc3NhcnkgYXMgd2Ugbm93IGhhdmUg YSB3YXkgdGhlIG1vZGVsIGNhbiBleHBsaWNpdGx5IHJlcXVlc3QgcmVzdHRpbmcgdGhlCisgICAg ICAgIG1lZGlhIHN0YXRlIHZpYSByZXNldE1lZGlhU3RhdGUoKS4gbV9wbGF5ZXJDb250cm9sbGVy IGlzIGFscmVhZHkgcmVsZWFzZWQgaW4gCisgICAgICAgIFdlYlZpZGVvRnVsbHNjcmVlbkludGVy ZmFjZUFWS2l0OjpjbGVhbnVwRnVsbHNjcmVlbkludGVybmFsKCkuIFJlbGVhc2VpbmcgaXQgcHJl bWF0dXJlbHkgY2FuIGFjdHVhbGx5IHByZXZlbnQgdGhlIGV4aXQKKyAgICAgICAgZnVsbGxzY3Jl ZW4gcHJvY2VzcyBmcm9tIGNvbXBsZXRpbmcgc3VjY2Vzc2Z1bGx5LgorCisgICAgICAgICogcGxh dGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tOgorICAgICAgICAo V2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmV4aXRGdWxsc2NyZWVuKToKKwogMjAx NS0wMy0yNiAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFw cGx5IGJsdXIgZWZmZWN0IHRvIG1lZGlhIGNvbnRyb2wgYmFja2dyb3VuZC4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5J bnRlcmZhY2VBVktpdC5tbQppbmRleCA4ZWFmZTVmNzE1YzljMTEyNDFiNjAxZjkyOWNkNGQyOWVi MGI4YmJiLi4xYTAzYmRiMjM0M2FlNzZiNjhlYTI2MjFiMTQ5YmZkMTdkY2Q4YTJmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJm YWNlQVZLaXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVs bHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCkBAIC0xMDI0LDggKzEwMjQsNiBAQCB2b2lkIFdlYlZp ZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpleGl0RnVsbHNjcmVlbihjb25zdCBXZWJDb3Jl OjpJbnRSZWN0JiBmaQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgbV9wbGF5ZXJDb250 cm9sbGVyID0gbmlsOwotCiAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVl dWUoKSwgW3N0cm9uZ1RoaXMsIGZpbmFsUmVjdF0gewogICAgICAgICBzdHJvbmdUaGlzLT5leGl0 RnVsbHNjcmVlbkludGVybmFsKGZpbmFsUmVjdCk7CiAgICAgfSk7Cg== 249552 2015-03-26 22:44:00 -0700 2015-03-26 23:37:32 -0700 Patch for landing. bug-143120-20150326224321.patch text/plain 1975 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTgyMDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGMzNGZiNTg5ZDI0NjE0 ODA4MGUyNGNmNzY1YmUwZTVlOTQzYmQ1ZS4uMTE1ZjA5ZTM1NWY5YTQ4MTNmZWY5MjY5ZjRmMWM1 MWY4YzgxZjRiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTAzLTI2ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBPcHRpbWl6ZWQgRnVsbHNj cmVlbiBmYWlscyB0byBjbGVhbnVwIGJlY2F1c2Ugb2Ygbm8gbG9uZ2VyIG5lY2Vzc2FyeSByZWxl YXNlIG9mIG1fcGxheWVyQ29udHJvbGxlciBpbiBleGl0RnVsbHNjcmVlbigpCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMxMjAKKworICAgICAgICBS ZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgV2UgdXNlZCB0byByZWxlYXNlIG1f cGxheWVyQ29udHJvbGxlciBpbiBXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6ZXhp dEZ1bGxzY3JlZW4oKSBpbiBvcmRlciB0byBtYWtlIHN1cmUgCisgICAgICAgIG1lZGlhIHN0YXRl IHdhcyByZXNldC4gVGhpcyBpcyBubyBsb25nZXIgbmVjZXNzYXJ5IGFzIHdlIG5vdyBoYXZlIGEg d2F5IHRoZSBtb2RlbCBjYW4gZXhwbGljaXRseSByZXF1ZXN0IHJlc2V0dGluZyB0aGUKKyAgICAg ICAgbWVkaWEgc3RhdGUgdmlhIHJlc2V0TWVkaWFTdGF0ZSgpLiBtX3BsYXllckNvbnRyb2xsZXIg aXMgYWxyZWFkeSByZWxlYXNlZCBpbiAKKyAgICAgICAgV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJm YWNlQVZLaXQ6OmNsZWFudXBGdWxsc2NyZWVuSW50ZXJuYWwoKS4gUmVsZWFzaW5nIGl0IHByZW1h dHVyZWx5IGNhbiBhY3R1YWxseSBwcmV2ZW50IHRoZSBleGl0CisgICAgICAgIGZ1bGxzY3JlZW4g cHJvY2VzcyBmcm9tIGNvbXBsZXRpbmcgc3VjY2Vzc2Z1bGx5LgorCisgICAgICAgICogcGxhdGZv cm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tOgorICAgICAgICAoV2Vi VmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmV4aXRGdWxsc2NyZWVuKToKKwogMjAxNS0w My0yNiAgUm9nZXIgRm9uZyAgPHJvZ2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFwcGx5 IGJsdXIgZWZmZWN0IHRvIG1lZGlhIGNvbnRyb2wgYmFja2dyb3VuZC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktp dC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VBVktpdC5tbQppbmRleCA4ZWFmZTVmNzE1YzljMTEyNDFiNjAxZjkyOWNkNGQyOWViMGI4 YmJiLi4xYTAzYmRiMjM0M2FlNzZiNjhlYTI2MjFiMTQ5YmZkMTdkY2Q4YTJmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNl QVZLaXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNj cmVlbkludGVyZmFjZUFWS2l0Lm1tCkBAIC0xMDI0LDggKzEwMjQsNiBAQCB2b2lkIFdlYlZpZGVv RnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpleGl0RnVsbHNjcmVlbihjb25zdCBXZWJDb3JlOjpJ bnRSZWN0JiBmaQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgbV9wbGF5ZXJDb250cm9s bGVyID0gbmlsOwotCiAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUo KSwgW3N0cm9uZ1RoaXMsIGZpbmFsUmVjdF0gewogICAgICAgICBzdHJvbmdUaGlzLT5leGl0RnVs bHNjcmVlbkludGVybmFsKGZpbmFsUmVjdCk7CiAgICAgfSk7Cg==