143118 2015-03-26 15:34:25 -0700 Relevant repainted objects callback is inaccurate and inconsistent for PDF documents 2015-03-26 16:07:28 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned andersca bdakin commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser thorton oldest_to_newest 1080430 0 bdakin 2015-03-26 15:34:25 -0700 The relevant repainted objects callback is inaccurate and inconsistent for PDF documents. Its behavior varies with window size and window focus. rdar://problem/13371582 1080438 1 249522 bdakin 2015-03-26 15:43:51 -0700 Created attachment 249522 Patch 1080462 2 bdakin 2015-03-26 16:07:28 -0700 Thanks Tim! http://trac.webkit.org/changeset/182033 249522 2015-03-26 15:43:51 -0700 2015-03-26 15:58:38 -0700 Patch for-review.txt text/plain 4695 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MjAyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM0IEBACisyMDE1LTAzLTI2ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSZWxldmFudCByZXBhaW50ZWQgb2Jq ZWN0cyBjYWxsYmFjayBpcyBpbmFjY3VyYXRlIGFuZCBpbmNvbnNpc3RlbnQgZm9yIFBERiAKKyAg ICAgICAgZG9jdW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNDMxMTgKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFy Oi8vcHJvYmxlbS8xMzM3MTU4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEludmVzdGlnYXRpbmcgdGhpcyBidWcgcmVzdWx0ZWQgaW4gZmluZGluZyB0 d28gdGhpbmdzIHRoYXQgc2hvdWxkIGNoYW5nZSBmb3IgdGhlIAorICAgICAgICByZWxldmFudCBy ZXBhaW50ZWQgb2JqZWN0cyBoZXVyaXN0aWMuIEZpcnN0LCB3ZSBzaG91bGQgbm90IGNvdW50IGFu eSBvYmplY3RzIAorICAgICAgICBwYWludGVkIHdoaWxlIHVwZGF0aW5nIGNvbnRyb2wgdGludHMu IEFuZCBzZWNvbmRseSwgd2Ugc2hvdWxkIG5vdCB1c2UgaXQgYXQgYWxsIAorICAgICAgICBmb3Ig cGx1Z2luIGRvY3VtZW50cy4gSW4gb3RoZXIgZG9jdW1lbnRzLCB3ZSBjb3VudCB0aGUgcGx1Z2lu IGFyZWEgYXMg4oCccGFpbnRlZOKAnSAKKyAgICAgICAgd2hlbiB3ZSBnZXQgdG8gcGFpbnQgd2hl dGhlciBvciBub3QgdGhlIHBsdWdpbiBoYXMgYWN0dWFsbHkgbG9hZGVkLiBUaGlzIGlzIAorICAg ICAgICBpbnRlbnRpb25hbCBiZWNhdXNlIGl0IGFsbG93cyB1cyB0byBhY2NvdW50IGZvciBjaHVu a3Mgb2YgdGhlIHBhZ2UgdGhhdCB3aWxsIGJlIAorICAgICAgICBmaWxsZWQgaW4gYnkgcG9zc2li bHkgc2xvdy1sb2FkaW5nIGFkcy4gSG93ZXZlciwgaWYgdGhlIHBsdWdpbiBpcyB0aGUgd2hvbGUg CisgICAgICAgIGRvY3VtZW50LCB0aGVuIHRoZSBoZXVyaXN0aWMganVzdCBkb2VzbuKAmXQgbWFr ZSBhbnkgc2Vuc2UgYW5kIGl0IGxlYXN0IHRvIAorICAgICAgICBpbmNvbnNpc3RlbnQgYmVoYXZp b3IgYXQgZGlmZmVyZW50IHdpbmRvdyBzaXplcy4gU28gd2XigJlsbCBvbmx5IGNvdW50IHBsdWdp bnMgd2hlbiAKKyAgICAgICAgdGhlIGRvY3VtZW50IGlzIG5vdCBhIHBsdWdpbiBkb2N1bWVudC4g CisKKyAgICAgICAgRG9u4oCZdCBjb3VudCBvYmplY3RzIGR1cmluZyB0aGlzIHBhaW50IQorICAg ICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6 dXBkYXRlQ29udHJvbFRpbnRzKToKKyAgICAgICAgKiBwYWdlL1BhZ2UuaDoKKyAgICAgICAgKFdl YkNvcmU6OlBhZ2U6OnNldElzQ291bnRpbmdSZWxldmFudFJlcGFpbnRlZE9iamVjdHMpOgorCisg ICAgICAgIE1ha2Ugc3VyZSB0aGUgZG9jdW1lbnQgaXMgbm90IGEgcGx1Z2luIGRvY3VtZW50Lgor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJFbWJlZGRlZE9iamVjdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJFbWJlZGRlZE9iamVjdDo6cGFpbnQpOgorCiAyMDE1LTAzLTI2ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEFjY2Vzc2liaWxp dHkgY3Jhc2hpbmcgYmVjYXVzZSBNZWRpYVBsYXllciBpcyBsYXlpbmcgb3V0IFVJIG9mZiB0aGUg bWFpbiB0aHJlYWQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHJldmlzaW9uIDE4 MTk4NSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMzczNyw5ICszNzM3LDIwIEBAIHZvaWQgRnJhbWVWaWV3Ojp1cGRhdGVDb250cm9sVGlu dHMoKQogICAgIGlmIChmcmFtZSgpLmRvY3VtZW50KCktPnVybCgpLmlzRW1wdHkoKSkKICAgICAg ICAgcmV0dXJuOwogCisgICAgLy8gQXMgbm90ZWQgYWJvdmUsIHRoaXMgaXMgYSAiZmFrZSIgcGFp bnQsIHNvIHdlIHNob3VsZCBwYXVzZSBjb3VudGluZyByZWxldmFudCByZXBhaW50ZWQgb2JqZWN0 cy4KKyAgICBQYWdlKiBwYWdlID0gZnJhbWUoKS5wYWdlKCk7CisgICAgYm9vbCBpc0N1cnJlbnRs eUNvdW50aW5nUmVsZXZhbnRSZXBhaW50ZWRPYmplY3QgPSBmYWxzZTsKKyAgICBpZiAocGFnZSkg eworICAgICAgICBpc0N1cnJlbnRseUNvdW50aW5nUmVsZXZhbnRSZXBhaW50ZWRPYmplY3QgPSBw YWdlLT5pc0NvdW50aW5nUmVsZXZhbnRSZXBhaW50ZWRPYmplY3RzKCk7CisgICAgICAgIHBhZ2Ut PnNldElzQ291bnRpbmdSZWxldmFudFJlcGFpbnRlZE9iamVjdHMoZmFsc2UpOworICAgIH0KKwog ICAgIFJlbmRlclZpZXcqIHJlbmRlclZpZXcgPSB0aGlzLT5yZW5kZXJWaWV3KCk7CiAgICAgaWYg KChyZW5kZXJWaWV3ICYmIHJlbmRlclZpZXctPnRoZW1lKCkuc3VwcG9ydHNDb250cm9sVGludHMo KSkgfHwgaGFzQ3VzdG9tU2Nyb2xsYmFycygpKQogICAgICAgICBwYWludENvbnRyb2xUaW50cygp OworCisgICAgaWYgKHBhZ2UpCisgICAgICAgIHBhZ2UtPnNldElzQ291bnRpbmdSZWxldmFudFJl cGFpbnRlZE9iamVjdHMoaXNDdXJyZW50bHlDb3VudGluZ1JlbGV2YW50UmVwYWludGVkT2JqZWN0 KTsKIH0KIAogdm9pZCBGcmFtZVZpZXc6OnBhaW50Q29udHJvbFRpbnRzKCkKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BhZ2UvUGFnZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uv UGFnZS5oCShyZXZpc2lvbiAxODE5ODUpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuaAko d29ya2luZyBjb3B5KQpAQCAtMzU5LDYgKzM1OSw3IEBAIHB1YmxpYzoKICAgICBXRUJDT1JFX0VY UE9SVCBDb2xvciBwYWdlRXh0ZW5kZWRCYWNrZ3JvdW5kQ29sb3IoKSBjb25zdDsKIAogICAgIGJv b2wgaXNDb3VudGluZ1JlbGV2YW50UmVwYWludGVkT2JqZWN0cygpIGNvbnN0OworICAgIHZvaWQg c2V0SXNDb3VudGluZ1JlbGV2YW50UmVwYWludGVkT2JqZWN0cyhib29sIGlzQ291bnRpbmcpIHsg bV9pc0NvdW50aW5nUmVsZXZhbnRSZXBhaW50ZWRPYmplY3RzID0gaXNDb3VudGluZzsgfQogICAg IHZvaWQgc3RhcnRDb3VudGluZ1JlbGV2YW50UmVwYWludGVkT2JqZWN0cygpOwogICAgIHZvaWQg cmVzZXRSZWxldmFudFBhaW50ZWRPYmplY3RDb3VudGVyKCk7CiAgICAgdm9pZCBhZGRSZWxldmFu dFJlcGFpbnRlZE9iamVjdChSZW5kZXJPYmplY3QqLCBjb25zdCBMYXlvdXRSZWN0JiBvYmplY3RQ YWludFJlY3QpOwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVtYmVkZGVk T2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy RW1iZWRkZWRPYmplY3QuY3BwCShyZXZpc2lvbiAxODE5ODUpCisrKyBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyRW1iZWRkZWRPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDYs MTQgKzI0NiwxNyBAQCB2b2lkIFJlbmRlckVtYmVkZGVkT2JqZWN0OjpwYWludChQYWludEluCiB7 CiAgICAgUGFnZSogcGFnZSA9IGZyYW1lKCkucGFnZSgpOwogCisgICAgLy8gVGhlIHJlbGV2YW50 IHJlcGFpbnRlZCBvYmplY3QgaGV1cmlzdGljIGlzIG5vdCB0dW5lZCBmb3IgcGx1Z2luIGRvY3Vt ZW50cy4KKyAgICBib29sIGNvdW50c1Rvd2FyZHNSZWxldmFudE9iamVjdHMgPSBwYWdlICYmICFk b2N1bWVudCgpLmlzUGx1Z2luRG9jdW1lbnQoKSAmJiBwYWludEluZm8ucGhhc2UgPT0gUGFpbnRQ aGFzZUZvcmVncm91bmQ7CisKICAgICBpZiAoaXNQbHVnaW5VbmF2YWlsYWJsZSgpKSB7Ci0gICAg ICAgIGlmIChwYWdlICYmIHBhaW50SW5mby5waGFzZSA9PSBQYWludFBoYXNlRm9yZWdyb3VuZCkK KyAgICAgICAgaWYgKGNvdW50c1Rvd2FyZHNSZWxldmFudE9iamVjdHMpCiAgICAgICAgICAgICBw YWdlLT5hZGRSZWxldmFudFVucGFpbnRlZE9iamVjdCh0aGlzLCB2aXN1YWxPdmVyZmxvd1JlY3Qo KSk7CiAgICAgICAgIFJlbmRlclJlcGxhY2VkOjpwYWludChwYWludEluZm8sIHBhaW50T2Zmc2V0 KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlmIChwYWdlICYmIHBhaW50SW5mby5w aGFzZSA9PSBQYWludFBoYXNlRm9yZWdyb3VuZCkKKyAgICBpZiAoY291bnRzVG93YXJkc1JlbGV2 YW50T2JqZWN0cykKICAgICAgICAgcGFnZS0+YWRkUmVsZXZhbnRSZXBhaW50ZWRPYmplY3QodGhp cywgdmlzdWFsT3ZlcmZsb3dSZWN0KCkpOwogCiAgICAgUmVuZGVyV2lkZ2V0OjpwYWludChwYWlu dEluZm8sIHBhaW50T2Zmc2V0KTsK