143079 2015-03-25 21:42:28 -0700 [WK2] Let the compiler generate the NetworkCache::Key move constructor 2015-03-26 09:24:54 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue koivisto oldest_to_newest 1080194 0 cdumez 2015-03-25 21:42:28 -0700 Let the compiler generate the NetworkCache::Key move constructor. The generated one will do exactly the same thing as the one we currently have, except that it will move the m_hash member as well. I don't see any reason why we weren't moving that member before (it is an std::array so it seems like we would want to move it). 1080195 1 249471 cdumez 2015-03-25 21:47:15 -0700 Created attachment 249471 Patch 1080297 2 249471 commit-queue 2015-03-26 09:24:49 -0700 Comment on attachment 249471 Patch Clearing flags on attachment: 249471 Committed r182011: <http://trac.webkit.org/changeset/182011> 1080298 3 commit-queue 2015-03-26 09:24:54 -0700 All reviewed patches have been landed. Closing bug. 249471 2015-03-25 21:47:15 -0700 2015-03-26 09:24:49 -0700 Patch bug-143079-20150325214638.patch text/plain 2690 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxOTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWNiNTk2NzkzYzVjZjE4 MDhhYzhjZWM0YTU2ZmViNWJlNTgyZTUyNi4uYjcyOTM0MTBhYzI5YWY5Njc0OTQwZWRhMjZjZTgz ZDkzMzJmMWRiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAzLTI1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl0gTGV0IHRoZSBjb21w aWxlciBnZW5lcmF0ZSB0aGUgTmV0d29ya0NhY2hlOjpLZXkgbW92ZSBjb25zdHJ1Y3RvcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMDc5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGV0IHRoZSBjb21w aWxlciBnZW5lcmF0ZSB0aGUgTmV0d29ya0NhY2hlOjpLZXkgbW92ZSBjb25zdHJ1Y3Rvci4gVGhl CisgICAgICAgIGdlbmVyYXRlZCBvbmUgd2lsbCBkbyBleGFjdGx5IHRoZSBzYW1lIHRoaW5nIGFz IHRoZSBvbmUgd2UgaGFkIGV4Y2VwdAorICAgICAgICB0aGF0IGl0IHdpbGwgbW92ZSB0aGUgbV9o YXNoIG1lbWJlciBhcyB3ZWxsLiBJIGRvbid0IHNlZSBhbnkgcmVhc29uIHdoeQorICAgICAgICB3 ZSB3ZXJlbid0IG1vdmluZyB0aGlzIG1lbWJlciBiZWZvcmUgKGl0IGlzIGFuIHN0ZDo6YXJyYXk8 dWludDhfdCwgMTY+KS4KKworICAgICAgICBBbHNvIGhhdmUgdGhlIGNvbXBpbGVyIGdlbmVyYXRl IGEgbW92ZSBhc3NpZ25tZW50IG9wZXJhdG9yIGZvcgorICAgICAgICBjb25zaXN0ZW5jeS4gQWx0 aG91Z2ggaXQgaXMgbm90IGN1cnJlbnRseSB1c2VmdWwsIGl0IGNvdWxkIGJlIGF0IHNvbWUKKyAg ICAgICAgcG9pbnQuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2Fj aGVLZXkuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OktleTo6S2V5KTogRGVs ZXRlZC4KKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVLZXkuaDoK KwogMjAxNS0wMy0yNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAog ICAgICAgICBBZGQgYSBwcmVmZXJlbmNlIHRvIHByZXZlbnQgInVzZXItc2NhbGFibGU9bm8iIGZy b20gaGF2aW5nIGFueSBlZmZlY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZUtleS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVLZXkuY3BwCmluZGV4IGMyYTMwMDY4Mjc4MzY0N2Ex YWQ5YmQwOGZmM2E1MTMxNTM4NTZiNmYuLjIwODE4MjgxZjM1MDdmYTAzMDM0ZTY0MzRjYjUwOTM2 NTU3MzcyMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hl L05ldHdvcmtDYWNoZUtleS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3Mv Y2FjaGUvTmV0d29ya0NhY2hlS2V5LmNwcApAQCAtNDQsMTQgKzQ0LDYgQEAgS2V5OjpLZXkoY29u c3QgS2V5JiBvKQogewogfQogCi1LZXk6OktleShLZXkmJiBvKQotICAgIDogbV9tZXRob2QoV1RG Ojptb3ZlKG8ubV9tZXRob2QpKQotICAgICwgbV9wYXJ0aXRpb24oV1RGOjptb3ZlKG8ubV9wYXJ0 aXRpb24pKQotICAgICwgbV9pZGVudGlmaWVyKFdURjo6bW92ZShvLm1faWRlbnRpZmllcikpCi0g ICAgLCBtX2hhc2goby5tX2hhc2gpCi17Ci19Ci0KIEtleTo6S2V5KGNvbnN0IFN0cmluZyYgbWV0 aG9kLCBjb25zdCBTdHJpbmcmIHBhcnRpdGlvbiwgY29uc3QgU3RyaW5nJiBpZGVudGlmaWVyKQog ICAgIDogbV9tZXRob2QobWV0aG9kLmlzb2xhdGVkQ29weSgpKQogICAgICwgbV9wYXJ0aXRpb24o cGFydGl0aW9uLmlzb2xhdGVkQ29weSgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0 d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlS2V5LmggYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVLZXkuaAppbmRleCBjZjA0YTg3NDA3ZDgxZmFh Y2UyZTRiYWIxNmRlYTk4ZDlmZjY1MDFhLi42Nzk1NmM4ZThjNjM2ZDY5MTlhNTBjNTZjYTEzZjQ4 OWMwMzRlOTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNo ZS9OZXR3b3JrQ2FjaGVLZXkuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9j YWNoZS9OZXR3b3JrQ2FjaGVLZXkuaApAQCAtNDMsMTAgKzQzLDExIEBAIHB1YmxpYzoKIAogICAg IEtleSgpIHsgfQogICAgIEtleShjb25zdCBLZXkmKTsKLSAgICBLZXkoS2V5JiYpOworICAgIEtl eShLZXkmJikgPSBkZWZhdWx0OwogICAgIEtleShjb25zdCBTdHJpbmcmIG1ldGhvZCwgY29uc3Qg U3RyaW5nJiBwYXJ0aXRpb24sIGNvbnN0IFN0cmluZyYgaWRlbnRpZmllcik7CiAKICAgICBLZXkm IG9wZXJhdG9yPShjb25zdCBLZXkmKTsKKyAgICBLZXkmIG9wZXJhdG9yPShLZXkmJikgPSBkZWZh dWx0OwogCiAgICAgYm9vbCBpc051bGwoKSBjb25zdCB7IHJldHVybiBtX2lkZW50aWZpZXIuaXNO dWxsKCk7IH0KIAo=