143070 2015-03-25 20:18:58 -0700 [WK2][NetworkCache] Compute if a cached response has expired only when actually needed 2015-03-26 09:22:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue koivisto oldest_to_newest 1080172 0 cdumez 2015-03-25 20:18:58 -0700 Compute if a cached response has expired only when actually needed: - This is not a history navigation and - It does not have "Cache-Control: no-cache" header Currently, we determine if the response has expired unconditionally and we often end up not using this information. 1080173 1 249467 cdumez 2015-03-25 20:21:07 -0700 Created attachment 249467 Patch 1080294 2 249467 commit-queue 2015-03-26 09:22:28 -0700 Comment on attachment 249467 Patch Clearing flags on attachment: 249467 Committed r182010: <http://trac.webkit.org/changeset/182010> 1080295 3 commit-queue 2015-03-26 09:22:33 -0700 All reviewed patches have been landed. Closing bug. 249467 2015-03-25 20:21:07 -0700 2015-03-26 09:22:28 -0700 Patch bug-143070-20150325202029.patch text/plain 3955 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxOTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWNiNTk2NzkzYzVjZjE4 MDhhYzhjZWM0YTU2ZmViNWJlNTgyZTUyNi4uOGY0YmUzNTE2MWI0Y2I4ZWYwNmYyMWU4OTIxYTU2 MWVjMTYzOGRkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE1LTAzLTI1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgW1dLMl1bTmV0d29ya0NhY2hl XSBDb21wdXRlIGlmIGEgY2FjaGVkIHJlc3BvbnNlIGhhcyBleHBpcmVkIG9ubHkgd2hlbiBhY3R1 YWxseSBuZWVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE0MzA3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIENvbXB1dGUgaWYgYSBjYWNoZWQgcmVzcG9uc2UgaGFzIGV4cGlyZWQgb25seSB3aGVuIGFj dHVhbGx5IG5lZWRlZDoKKyAgICAgICAgLSBUaGlzIGlzIG5vdCBhIGhpc3RvcnkgbmF2aWdhdGlv bgorICAgICAgICBhbmQKKyAgICAgICAgLSBJdCBkb2VzIG5vdCBoYXZlICJDYWNoZS1Db250cm9s OiBuby1jYWNoZSIgaGVhZGVyCisKKyAgICAgICAgUHJldmlvdXNseSwgd2Ugd291bGQgYWx3YXlz IGRldGVybWluZSBpZiB0aGUgcmVzcG9uc2UgaGFzIGV4cGlyZWQgYW5kCisgICAgICAgIHdlIG9m dGVuIGVuZCB1cCBub3QgdXNpbmcgdGhpcyBpbmZvcm1hdGlvbi4KKworICAgICAgICAqIE5ldHdv cmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdv cmtDYWNoZTo6cmVzcG9uc2VIYXNFeHBpcmVkKToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0Nh Y2hlOjpjYW5Vc2UpOgorCiAyMDE1LTAzLTI1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25A YXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIHByZWZlcmVuY2UgdG8gcHJldmVudCAidXNlci1z Y2FsYWJsZT1ubyIgZnJvbSBoYXZpbmcgYW55IGVmZmVjdApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcCBiL1NvdXJjZS9XZWJL aXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZS5jcHAKaW5kZXggNDdlYTU5OTUx MzM1MTViZGMwOWY4OTcyN2FkNGY0M2I0NTk2YjA0OC4uNGI3Njk4YmU5NGVmMGY2MzNiNjc5Mjg0 NTIwYWY4NDc0OTgzYzc4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvY2FjaGUvTmV0d29ya0NhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGUuY3BwCkBAIC0xNTAsNiArMTUwLDI1IEBAIHN0YXRpYyBi b29sIGNhY2hlUG9saWN5QWxsb3dzRXhwaXJlZChXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3RDYWNo ZVBvbGljeSBwb2xpY3kpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitzdGF0aWMgaW5saW5lIGJv b2wgcmVzcG9uc2VIYXNFeHBpcmVkKGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmIHJl c3BvbnNlLCBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRzIHRpbWVzdGFtcCkKK3sKKyAgICBpZiAo cmVzcG9uc2UuY2FjaGVDb250cm9sQ29udGFpbnNOb0NhY2hlKCkpCisgICAgICAgIHJldHVybiB0 cnVlOworCisgICAgYXV0byBkb3VibGVUaW1lU3RhbXAgPSBzdGQ6OmNocm9ubzo6ZHVyYXRpb248 ZG91YmxlPih0aW1lc3RhbXApOworICAgIGRvdWJsZSBhZ2UgPSBXZWJDb3JlOjpjb21wdXRlQ3Vy cmVudEFnZShyZXNwb25zZSwgZG91YmxlVGltZVN0YW1wLmNvdW50KCkpOworICAgIGRvdWJsZSBs aWZldGltZSA9IFdlYkNvcmU6OmNvbXB1dGVGcmVzaG5lc3NMaWZldGltZUZvckhUVFBGYW1pbHko cmVzcG9uc2UsIGRvdWJsZVRpbWVTdGFtcC5jb3VudCgpKTsKKworICAgIGJvb2wgaGFzRXhwaXJl ZCA9IGFnZSA+IGxpZmV0aW1lOworCisjaWZuZGVmIExPR19ESVNBQkxFRAorICAgIGlmIChoYXNF eHBpcmVkKQorICAgICAgICBMT0coTmV0d29ya0NhY2hlLCAiKE5ldHdvcmtQcm9jZXNzKSBuZWVk c1JldmFsaWRhdGlvbiBoYXNFeHBpcmVkIGFnZT0lZiBsaWZldGltZT0lZiIsIGFnZSwgbGlmZXRp bWUpOworI2VuZGlmCisKKyAgICByZXR1cm4gaGFzRXhwaXJlZDsKK30KKwogc3RhdGljIFVzZURl Y2lzaW9uIGNhblVzZShjb25zdCBFbnRyeSYgZW50cnksIGNvbnN0IFdlYkNvcmU6OlJlc291cmNl UmVxdWVzdCYgcmVxdWVzdCkKIHsKICAgICBpZiAoIXZlcmlmeVZhcnlpbmdSZXF1ZXN0SGVhZGVy cyhlbnRyeS52YXJ5aW5nUmVxdWVzdEhlYWRlcnMoKSwgcmVxdWVzdCkpIHsKQEAgLTE1NywxOCAr MTc2LDEzIEBAIHN0YXRpYyBVc2VEZWNpc2lvbiBjYW5Vc2UoY29uc3QgRW50cnkmIGVudHJ5LCBj b25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIHJlCiAgICAgICAgIHJldHVybiBVc2VEZWNp c2lvbjo6Tm9EdWVUb1ZhcnlpbmdIZWFkZXJNaXNtYXRjaDsKICAgICB9CiAKLSAgICBib29sIGFs bG93RXhwaXJlZCA9IGNhY2hlUG9saWN5QWxsb3dzRXhwaXJlZChyZXF1ZXN0LmNhY2hlUG9saWN5 KCkpOwotICAgIGF1dG8gZG91YmxlVGltZVN0YW1wID0gc3RkOjpjaHJvbm86OmR1cmF0aW9uPGRv dWJsZT4oZW50cnkudGltZVN0YW1wKCkpOwotICAgIGRvdWJsZSBhZ2UgPSBXZWJDb3JlOjpjb21w dXRlQ3VycmVudEFnZShlbnRyeS5yZXNwb25zZSgpLCBkb3VibGVUaW1lU3RhbXAuY291bnQoKSk7 Ci0gICAgZG91YmxlIGxpZmV0aW1lID0gV2ViQ29yZTo6Y29tcHV0ZUZyZXNobmVzc0xpZmV0aW1l Rm9ySFRUUEZhbWlseShlbnRyeS5yZXNwb25zZSgpLCBkb3VibGVUaW1lU3RhbXAuY291bnQoKSk7 Ci0gICAgYm9vbCBpc0V4cGlyZWQgPSBhZ2UgPiBsaWZldGltZTsKLSAgICAvLyBXZSBuZXZlciBy ZXZhbGlkYXRlIGluIHRoZSBjYXNlIG9mIGEgaGlzdG9yeSBuYXZpZ2F0aW9uIChpLmUuIGFsbG93 RXhwaXJlZCBpcyB0cnVlKS4KLSAgICBib29sIG5lZWRzUmV2YWxpZGF0aW9uID0gIWFsbG93RXhw aXJlZCAmJiAoZW50cnkucmVzcG9uc2UoKS5jYWNoZUNvbnRyb2xDb250YWluc05vQ2FjaGUoKSB8 fCBpc0V4cGlyZWQpOworICAgIC8vIFdlIG5ldmVyIHJldmFsaWRhdGUgaW4gdGhlIGNhc2Ugb2Yg YSBoaXN0b3J5IG5hdmlnYXRpb24gKGkuZS4gY2FjaGVQb2xpY3lBbGxvd3NFeHBpcmVkKCkgcmV0 dXJucyB0cnVlKS4KKyAgICBib29sIG5lZWRzUmV2YWxpZGF0aW9uID0gIWNhY2hlUG9saWN5QWxs b3dzRXhwaXJlZChyZXF1ZXN0LmNhY2hlUG9saWN5KCkpICYmIHJlc3BvbnNlSGFzRXhwaXJlZChl bnRyeS5yZXNwb25zZSgpLCBlbnRyeS50aW1lU3RhbXAoKSk7CiAgICAgaWYgKCFuZWVkc1JldmFs aWRhdGlvbikKICAgICAgICAgcmV0dXJuIFVzZURlY2lzaW9uOjpVc2U7CiAKICAgICBib29sIGhh c1ZhbGlkYXRvckZpZWxkcyA9IGVudHJ5LnJlc3BvbnNlKCkuaGFzQ2FjaGVWYWxpZGF0b3JGaWVs ZHMoKTsKLSAgICBMT0coTmV0d29ya0NhY2hlLCAiKE5ldHdvcmtQcm9jZXNzKSBuZWVkc1JldmFs aWRhdGlvbiBoYXNWYWxpZGF0b3JGaWVsZHM9JWQgaXNFeHBpcmVkPSVkIGFnZT0lZiBsaWZldGlt ZT0lZiIsIGlzRXhwaXJlZCwgaGFzVmFsaWRhdG9yRmllbGRzLCBhZ2UsIGxpZmV0aW1lKTsKKyAg ICBMT0coTmV0d29ya0NhY2hlLCAiKE5ldHdvcmtQcm9jZXNzKSBuZWVkc1JldmFsaWRhdGlvbiBo YXNWYWxpZGF0b3JGaWVsZHM9JWQiLCBoYXNWYWxpZGF0b3JGaWVsZHMpOwogICAgIGlmICghaGFz VmFsaWRhdG9yRmllbGRzKQogICAgICAgICByZXR1cm4gVXNlRGVjaXNpb246Ok5vRHVlVG9NaXNz aW5nVmFsaWRhdG9yRmllbGRzOwogCg==