143068 2015-03-25 18:58:37 -0700 [Cocoa] RemoteInspectorXPCConnection::deserializeMessage() leaks a NSDictionary under Objective-C GC 2015-03-25 20:11:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aestes aestes darin joepeck mitz oldest_to_newest 1080155 0 aestes 2015-03-25 18:58:37 -0700 [Cocoa] RemoteInspectorXPCConnection::deserializeMessage() leaks a NSDictionary under Objective-C GC 1080157 1 249462 aestes 2015-03-25 19:00:55 -0700 Created attachment 249462 Patch 1080161 2 249462 mitz 2015-03-25 19:34:21 -0700 Comment on attachment 249462 Patch Could you have fixed this by adopting the result of _CFXPCCreate… into a RetainPtr and not having to think about GC here? 1080164 3 aestes 2015-03-25 19:52:05 -0700 (In reply to comment #2) > Comment on attachment 249462 [details] > Patch > > Could you have fixed this by adopting the result of _CFXPCCreate… into a > RetainPtr and not having to think about GC here? Oh, yes! I guess I didn't know / forgot that RetainPtr had an autorelease(). I'll assume that your r+ is still good for doing that instead :) Thanks! 1080170 4 aestes 2015-03-25 20:11:46 -0700 Committed r181992: <http://trac.webkit.org/changeset/181992> 249462 2015-03-25 19:00:55 -0700 2015-03-25 19:53:25 -0700 Patch bug-143068-20150325190018.patch text/plain 1771 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxOTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MTcyZTY0Y2M2MjBhYmY4M2M0NTUzZjg1YWFhOTJjY2U3MmM2ODMxLi40MmMwMTMwZTQ3YjAzYjQz MGQ4ODhmNmVkMmI2Y2U5ODc4NGU0OTc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0wMy0yNSAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CisK KyAgICAgICAgW0NvY29hXSBSZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9uOjpkZXNlcmlhbGl6 ZU1lc3NhZ2UoKSBsZWFrcyBhIE5TRGljdGlvbmFyeSB1bmRlciBPYmplY3RpdmUtQyBHQworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMDY4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv cmVtb3RlL1JlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb24ubW06CisgICAgICAgIChJbnNwZWN0 b3I6OlJlbW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb246OmRlc2VyaWFsaXplTWVzc2FnZSk6IENh bGxlZCBDRkJyaWRnaW5nUmVsZWFzZSgpIGluc3RlYWQgb2YgLWF1dG9yZWxlYXNlLgorCiAyMDE1 LTAzLTI1ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIEpJ VENvbXBpbGF0aW9uQ2FuRmFpbCBpbiBtb3JlIHBsYWNlcywgYW5kIG1ha2UgdGhlIGZhaWwgcGF0 aCBvZiBKSVRDb21waWxhdGlvbk11c3RTdWNjZWVkIGEgY3Jhc2ggaW5zdGVhZCBvZiBhdHRlbXB0 aW5nIEdDCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90 ZS9SZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9uLm1tIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yWFBDQ29ubmVjdGlvbi5tbQppbmRleCA3 NjE0ODE1NzcxYmU5ZjQ2MDFjZTMxNmRiMWNlYjZjODFiOTZkZGVkLi42M2M3MGM3MGI1YjY1MTU3 ZDY2ZDI1MzdkMDdlZTQ4N2ExMjNmNjhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3JYUENDb25uZWN0aW9uLm1tCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL1JlbW90ZUluc3BlY3RvclhQ Q0Nvbm5lY3Rpb24ubW0KQEAgLTEyMyw3ICsxMjMsNyBAQCBOU0RpY3Rpb25hcnkgKlJlbW90ZUlu c3BlY3RvclhQQ0Nvbm5lY3Rpb246OmRlc2VyaWFsaXplTWVzc2FnZSh4cGNfb2JqZWN0X3Qgb2Jq ZQogCiAgICAgTlNEaWN0aW9uYXJ5ICpkaWN0aW9uYXJ5ID0gc3RhdGljX2Nhc3Q8TlNEaWN0aW9u YXJ5ICo+KF9DRlhQQ0NyZWF0ZUNGT2JqZWN0RnJvbVhQQ01lc3NhZ2UoeHBjRGljdGlvbmFyeSkp OwogICAgIEFTU0VSVF9XSVRIX01FU1NBR0UoZGljdGlvbmFyeSwgIlVuYWJsZSB0byBkZXNlcmlh bGl6ZSB4cGMgbWVzc2FnZSIpOwotICAgIHJldHVybiBbZGljdGlvbmFyeSBhdXRvcmVsZWFzZV07 CisgICAgcmV0dXJuIENGQnJpZGdpbmdSZWxlYXNlKGRpY3Rpb25hcnkpOwogfQogCiB2b2lkIFJl bW90ZUluc3BlY3RvclhQQ0Nvbm5lY3Rpb246OmhhbmRsZUV2ZW50KHhwY19vYmplY3RfdCBvYmpl Y3QpCg==