143062 2015-03-25 15:30:10 -0700 Web Inspector: Add ESLint "Disallow Undeclared Variables" rule and enable ES6 env 2015-03-25 17:47:45 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 tobi+webkit webkit-unassigned commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1080060 0 tobi+webkit 2015-03-25 15:30:10 -0700 As a consequence of further usage of ES6 syntax and a regression that could have been spotted by ESLint we should add the following 2 things: - es6 environment (allow use of ES6 syntax including class) - no-undef - disallow use of undeclared variables unless mentioned in a /*global */ block http://eslint.org/docs/rules/no-undef.html 1080061 1 webkit-bug-importer 2015-03-25 15:30:32 -0700 <rdar://problem/20300065> 1080065 2 249433 tobi+webkit 2015-03-25 15:37:03 -0700 Created attachment 249433 patch 1080106 3 249433 joepeck 2015-03-25 17:00:02 -0700 Comment on attachment 249433 patch r=me 1080132 4 249433 commit-queue 2015-03-25 17:47:41 -0700 Comment on attachment 249433 patch Clearing flags on attachment: 249433 Committed r181987: <http://trac.webkit.org/changeset/181987> 1080133 5 commit-queue 2015-03-25 17:47:45 -0700 All reviewed patches have been landed. Closing bug. 249433 2015-03-25 15:37:03 -0700 2015-03-25 17:47:41 -0700 patch bug-143062-20150325233625.patch text/plain 1473 tobi+webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxOTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl NWQyOThhZDcwYjViNDNiNDlkNWVkYjliZDM3ODQzNGNlOGJjYzhhLi4yZGUzMWU3NDczODc4NDVm YzM3NmViY2Q1NzMzZTczOWZjZDgxOTYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNS0wMy0yNSAgVG9iaWFzIFJlaXNzICA8dG9iaSt3ZWJraXRAYmFzZWNv ZGUuZGU+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIEVTTGludCAiRGlzYWxsb3cgVW5k ZWNsYXJlZCBWYXJpYWJsZXMiIHJ1bGUgYW5kIGVuYWJsZSBFUzYgZW52CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMwNjIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFU0xpbnQ6IEFkZCBzdXBwb3J0IGZv ciBlczYgZW52aXJvbm1lbnQgYW5kICJuby11bmRlZiIgcnVsZSB3aGljaCBkaXNhbGxvd3MKKyAg ICAgICAgdXNlIG9mIHVuZGVjbGFyZWQgdmFyaWFibGVzIHVubGVzcyBtZW50aW9uZWQgaW4gYSAv Kmdsb2JhbCAqLyBibG9jay4KKworICAgICAgICAqIC5lc2xpbnRyYzoKKwogMjAxNS0wMy0yNSAg TmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5z cGVjdG9yOiBjb25zb2xlLnRhYmxlIHdpdGggc291cmNlIGNvZGUgbG9jYXRpb24gbG9vayBwb29y CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvLmVzbGludHJjIGIvU291cmNlL1dl Ykluc3BlY3RvclVJLy5lc2xpbnRyYwppbmRleCA4ZmY4NTMzN2U0ZjEyYzIwMDA5NTA5OWQyZGM3 OWM3MjZjYzM4MTVjLi5hYWYyZDhhZjBkYmQ1ZmYwOGE1MGMzN2E2NzJhYzIxM2JmNmMzNDk4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvLmVzbGludHJjCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS8uZXNsaW50cmMKQEAgLTI2LDYgKzI2LDcgQEAKIHsKICAgICAiZW52Ijog ewogICAgICAgICAiYnJvd3NlciI6IHRydWUsCisgICAgICAgICJlczYiOiB0cnVlLAogICAgICAg ICAibm9kZSI6IGZhbHNlLAogICAgIH0sCiAgICAgImdsb2JhbHMiOiB7CkBAIC02OCw2ICs2OSw3 IEBACiAgICAgICAgICJuby1wcm90byI6IDAsCiAgICAgICAgICJuby1yZXR1cm4tYXNzaWduIjog MiwKICAgICAgICAgIm5vLXRyYWlsaW5nLXNwYWNlcyI6IDIsCisgICAgICAgICJuby11bmRlZiI6 IDIsCiAgICAgICAgICJuby11bmRlcnNjb3JlLWRhbmdsZSI6IDAsCiAgICAgICAgICJuby11bnVz ZWQtZXhwcmVzc2lvbnMiOiAyLAogICAgICAgICAibm8td3JhcC1mdW5jIjogMiwK