143057 2015-03-25 13:45:32 -0700 REGRESSION (r181660): Safari navigates to link after a starting and canceling a force preview 2015-03-25 14:10:36 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin thorton oldest_to_newest 1080025 0 bdakin 2015-03-25 13:45:32 -0700 REGRESSION (r181660): Safari navigates to link after a starting and canceling a force preview rdar://problem/20251436 1080027 1 249424 bdakin 2015-03-25 13:58:52 -0700 Created attachment 249424 Patch 1080030 2 249424 thorton 2015-03-25 14:01:02 -0700 Comment on attachment 249424 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249424&action=review > Source/WebCore/ChangeLog:12 > + m_immediateActionStage indicates that an immediate action has either began or begun? 1080031 3 bdakin 2015-03-25 14:10:36 -0700 http://trac.webkit.org/changeset/181971 249424 2015-03-25 13:58:52 -0700 2015-03-25 14:01:02 -0700 Patch for-review.txt text/plain 5147 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTk2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTAzLTI1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTgxNjYwKTog U2FmYXJpIG5hdmlnYXRlcyB0byBsaW5rIGFmdGVyIGEgc3RhcnRpbmcgYW5kIGNhbmNlbGluZyBh IAorICAgICAgICBmb3JjZSBwcmV2aWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDMwNTcKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAg ICAgICByZGFyOi8vcHJvYmxlbS8yMDI1MTQzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIHZhbHVlIGZvciBBY3Rpb25V cGRhdGVkIHRvIHRoZSBJbW1lZGlhdGVBY3Rpb25TdGFnZSBlbnVtLiBOb3cgaWYgCisgICAgICAg IG1faW1tZWRpYXRlQWN0aW9uU3RhZ2UgaW5kaWNhdGVzIHRoYXQgYW4gaW1tZWRpYXRlIGFjdGlv biBoYXMgZWl0aGVyIGJlZ2FuIG9yIAorICAgICAgICBjb21wbGV0ZWQgdGhlbiB3ZSBjYW4gaGF2 ZSB0aGUgc2FtZSBiZWhhdmlvci4KKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZU1vdXNlUmVsZWFzZUV2ZW50KToK KyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5oOgorCiAyMDE1LTAzLTI1ICBEZWFuIEphY2tz b24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBNZWRpYUNvbnRyb2xzOiBVc2UgZm9udCB3 aXRoIGZpeGVkIG51bWJlciB3aWR0aApJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhh bmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVy LmNwcAkocmV2aXNpb24gMTgxOTA3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRs ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDYxLDkgKzIwNjEsOSBAQCBib29sIEV2ZW50SGFu ZGxlcjo6aGFuZGxlTW91c2VSZWxlYXNlRXZlCiAgICAgaWYgKG1fZnJhbWVTZXRCZWluZ1Jlc2l6 ZWQpCiAgICAgICAgIHJldHVybiAhZGlzcGF0Y2hNb3VzZUV2ZW50KGV2ZW50TmFtZXMoKS5tb3Vz ZXVwRXZlbnQsIG1fZnJhbWVTZXRCZWluZ1Jlc2l6ZWQuZ2V0KCksIHRydWUsIG1fY2xpY2tDb3Vu dCwgcGxhdGZvcm1Nb3VzZUV2ZW50LCBmYWxzZSk7CiAKLSAgICAvLyBJZiBhbiBpbW1lZGlhdGUg YWN0aW9uIHdhcyBjb21wbGV0ZWQgdXNpbmcgdGhpcyBzZXJpZXMgb2YgbW91c2UgZXZlbnRzLCB0 aGVuIHdlIHNob3VsZCBzZW5kIG1vdXNldXAgdG8KKyAgICAvLyBJZiBhbiBpbW1lZGlhdGUgYWN0 aW9uIGJlZ2FuIG9yIHdhcyBjb21wbGV0ZWQgdXNpbmcgdGhpcyBzZXJpZXMgb2YgbW91c2UgZXZl bnRzLCB0aGVuIHdlIHNob3VsZCBzZW5kIG1vdXNldXAgdG8KICAgICAvLyB0aGUgRE9NIGFuZCBy ZXR1cm4gbm93IHNvIHRoYXQgd2UgZG9uJ3QgcGVyZm9ybSBvdXIgb3duIGRlZmF1bHQgYmVoYXZp b3JzLgotICAgIGlmIChtX2ltbWVkaWF0ZUFjdGlvblN0YWdlID09IEltbWVkaWF0ZUFjdGlvblN0 YWdlOjpBY3Rpb25Db21wbGV0ZWQpIHsKKyAgICBpZiAobV9pbW1lZGlhdGVBY3Rpb25TdGFnZSA9 PSBJbW1lZGlhdGVBY3Rpb25TdGFnZTo6QWN0aW9uQ29tcGxldGVkIHx8IG1faW1tZWRpYXRlQWN0 aW9uU3RhZ2UgPT0gSW1tZWRpYXRlQWN0aW9uU3RhZ2U6OkFjdGlvblVwZGF0ZWQpIHsKICAgICAg ICAgbV9pbW1lZGlhdGVBY3Rpb25TdGFnZSA9IEltbWVkaWF0ZUFjdGlvblN0YWdlOjpOb25lOwog ICAgICAgICByZXR1cm4gIWRpc3BhdGNoTW91c2VFdmVudChldmVudE5hbWVzKCkubW91c2V1cEV2 ZW50LCBtX2xhc3RFbGVtZW50VW5kZXJNb3VzZS5nZXQoKSwgdHJ1ZSwgbV9jbGlja0NvdW50LCBw bGF0Zm9ybU1vdXNlRXZlbnQsIGZhbHNlKTsKICAgICB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9w YWdlL0V2ZW50SGFuZGxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl bnRIYW5kbGVyLmgJKHJldmlzaW9uIDE4MTkwNykKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZl bnRIYW5kbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMCw2ICsxMjAsNyBAQCBlbnVtIENoZWNr RHJhZ0h5c3RlcmVzaXMgeyBTaG91bGRDaGVja0RyCiBlbnVtIGNsYXNzIEltbWVkaWF0ZUFjdGlv blN0YWdlIHsKICAgICBOb25lLAogICAgIFBlcmZvcm1lZEhpdFRlc3QsCisgICAgQWN0aW9uVXBk YXRlZCwKICAgICBBY3Rpb25DYW5jZWxsZWQsCiAgICAgQWN0aW9uQ29tcGxldGVkCiB9OwpJbmRl eDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwkocmV2aXNpb24gMTgxOTY5KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTUtMDMtMjUgIEJldGggRGFraW4g IDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxODE2NjApOiBTYWZh cmkgbmF2aWdhdGVzIHRvIGxpbmsgYWZ0ZXIgYSBzdGFydGluZyBhbmQgY2FuY2VsaW5nIGEgCisg ICAgICAgIGZvcmNlIHByZXZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MzA1NworICAgICAgICAtYW5kIGNvcnJlc3BvbmRpbmctCisgICAgICAg IHJkYXI6Ly9wcm9ibGVtLzIwMjUxNDM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWx3YXlzIGNhbGwgX3BhZ2UtPmltbWVkaWF0ZUFjdGlvbkRpZFVw ZGF0ZSgpIHNvIHRoYXQgdGhlIEV2ZW50SGFuZGxlcuKAmXMgCisgICAgICAgIEltbWVkaWF0ZUFj dGlvblN0YWdlIGlzIGFwcHJvcHJpYXRlbHkgdXBkYXRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3Mv bWFjL1dLSW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tJbW1lZGlh dGVBY3Rpb25Db250cm9sbGVyIGltbWVkaWF0ZUFjdGlvblJlY29nbml6ZXJEaWRVcGRhdGVBbmlt YXRpb246XSk6CisKKyAgICAgICAgVXBkYXRlIHRoZSBFdmVudEhhbmRsZXLigJlzIEltbWVkaWF0 ZUFjdGlvblN0YWdlLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1h Yy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6aW1tZWRpYXRlQWN0aW9uRGlkVXBkYXRl KToKKwogMjAxNS0wMy0yNSAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIGEgcHJlZiB0byBlbmFibGUgdGhlIG5ldyBibG9jay1pbnNpZGUtaW5saW5lIG1vZGVs CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLSW1tZWRpYXRlQWN0aW9uQ29u dHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dL SW1tZWRpYXRlQWN0aW9uQ29udHJvbGxlci5tbQkocmV2aXNpb24gMTgxOTA3KQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0ltbWVkaWF0ZUFjdGlvbkNvbnRyb2xsZXIubW0JKHdv cmtpbmcgY29weSkKQEAgLTIxMiwxMCArMjEyLDkgQEAgLSAodm9pZClpbW1lZGlhdGVBY3Rpb25S ZWNvZ25pemVyRGlkVXBkYQogICAgIGlmIChpbW1lZGlhdGVBY3Rpb25SZWNvZ25pemVyICE9IF9p bW1lZGlhdGVBY3Rpb25SZWNvZ25pemVyKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoX2hp dFRlc3RSZXN1bHQuY29udGVudFByZXZlbnRzRGVmYXVsdCkgewotICAgICAgICBfcGFnZS0+aW1t ZWRpYXRlQWN0aW9uRGlkVXBkYXRlKFtpbW1lZGlhdGVBY3Rpb25SZWNvZ25pemVyIGFuaW1hdGlv blByb2dyZXNzXSk7CisgICAgX3BhZ2UtPmltbWVkaWF0ZUFjdGlvbkRpZFVwZGF0ZShbaW1tZWRp YXRlQWN0aW9uUmVjb2duaXplciBhbmltYXRpb25Qcm9ncmVzc10pOworICAgIGlmIChfaGl0VGVz dFJlc3VsdC5jb250ZW50UHJldmVudHNEZWZhdWx0KQogICAgICAgICByZXR1cm47Ci0gICAgfQog CiAgICAgX3BhZ2UtPnNldFRleHRJbmRpY2F0b3JBbmltYXRpb25Qcm9ncmVzcyhbaW1tZWRpYXRl QWN0aW9uUmVjb2duaXplciBhbmltYXRpb25Qcm9ncmVzc10pOwogfQpJbmRleDogU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XZWJQYWdlTWFjLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQkocmV2 aXNpb24gMTgxOTA3KQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9X ZWJQYWdlTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMTU4LDYgKzExNTgsOCBAQCB2b2lkIFdl YlBhZ2U6OmZvY3VzQW5kU2VsZWN0TGFzdEFjdGlvbk1lCiAKIHZvaWQgV2ViUGFnZTo6aW1tZWRp YXRlQWN0aW9uRGlkVXBkYXRlKGZsb2F0IGZvcmNlKQogeworICAgIG1fcGFnZS0+bWFpbkZyYW1l KCkuZXZlbnRIYW5kbGVyKCkuc2V0SW1tZWRpYXRlQWN0aW9uU3RhZ2UoSW1tZWRpYXRlQWN0aW9u U3RhZ2U6OkFjdGlvblVwZGF0ZWQpOworCiAgICAgRWxlbWVudCogZWxlbWVudCA9IG1fbGFzdEFj dGlvbk1lbnVIaXRUZXN0UmVzdWx0LmlubmVyRWxlbWVudCgpOwogICAgIGlmICghZWxlbWVudCkK ICAgICAgICAgcmV0dXJuOwo=