<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>14305</bug_id>
          
          <creation_ts>2007-06-21 23:46:55 -0700</creation_ts>
          <short_desc>Web Inspector marks local files with server-side compression tip (Patch Included)</short_desc>
          <delta_ts>2007-06-22 09:59:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>523.x (Safari 3)</version>
          <rep_platform>All</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Richard Connamacher">richardconnamacher</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>6799</commentid>
    <comment_count>0</comment_count>
    <who name="Richard Connamacher">richardconnamacher</who>
    <bug_when>2007-06-21 23:46:55 -0700</bug_when>
    <thetext>Web Inspector provides server-side compression advice to files that do not originate from a server. (For example, inspecting Web Inspector determines that its own code could be sped up using zlib?)

I&apos;ve included my fix, a patch to inspector/Resource.js to add one extra check (to verify non-local origin) before marking a resource with this tip.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>6800</commentid>
    <comment_count>1</comment_count>
      <attachid>15176</attachid>
    <who name="Richard Connamacher">richardconnamacher</who>
    <bug_when>2007-06-21 23:48:19 -0700</bug_when>
    <thetext>Created attachment 15176
Patch to inspector/Resource.js</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>6803</commentid>
    <comment_count>2</comment_count>
      <attachid>15176</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2007-06-21 23:54:21 -0700</bug_when>
    <thetext>Comment on attachment 15176
Patch to inspector/Resource.js

The patch looks good, but it needs a ChangeLog entry as well. You can use WebKitTools/Scripts/prepare-ChangeLog to get you started.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>6791</commentid>
    <comment_count>3</comment_count>
      <attachid>15177</attachid>
    <who name="Richard Connamacher">richardconnamacher</who>
    <bug_when>2007-06-22 00:06:03 -0700</bug_when>
    <thetext>Created attachment 15177
ChangeLog

Please note I don&apos;t currently have an svn checkout.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>6716</commentid>
    <comment_count>4</comment_count>
      <attachid>15177</attachid>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2007-06-22 09:58:45 -0700</bug_when>
    <thetext>Comment on attachment 15177
ChangeLog

Please include the ChangeLog in your patch next time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>6715</commentid>
    <comment_count>5</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2007-06-22 09:59:50 -0700</bug_when>
    <thetext>Landed in r23738.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>15176</attachid>
            <date>2007-06-21 23:48:19 -0700</date>
            <delta_ts>2007-06-22 09:58:01 -0700</delta_ts>
            <desc>Patch to inspector/Resource.js</desc>
            <filename>Resource.js.diff</filename>
            <type>text/plain</type>
            <size>652</size>
            <attacher name="Richard Connamacher">richardconnamacher</attacher>
            
              <data encoding="base64">77u/LS0tIC9Vc2Vycy9yaWNoY29uL0FwcGxpY2F0aW9ucy9XZWJraXQvV2ViS2l0LmFwcC9Db250
ZW50cy9SZXNvdXJjZXMvV2ViQ29yZS5mcmFtZXdvcmsvVmVyc2lvbnMvQS9SZXNvdXJjZXMvaW5z
cGVjdG9yL1Jlc291cmNlLmpzICAyMDA3LTA2LTIxIDE1OjM5OjM0LjAwMDAwMDAwMCAtMDcwMAor
KysgL1VzZXJzL3JpY2hjb24vQXBwbGljYXRpb25zL1dlYmtpdC9XZWJLaXQgY29weS5hcHAvQ29u
dGVudHMvUmVzb3VyY2VzL1dlYkNvcmUuZnJhbWV3b3JrL1ZlcnNpb25zL0EvUmVzb3VyY2VzL2lu
c3BlY3Rvci9SZXNvdXJjZS5qcyAgICAgMjAwNy0wNi0yMSAyMzozMTowMi4wMDAwMDAwMDAgLTA3
MDAKQEAgLTQxNSw2ICs0MTUsNyBAQAogICAgIF9zaG91bGRDb21wcmVzczogZnVuY3Rpb24oKQog
ICAgIHsKICAgICAgICAgcmV0dXJuIFdlYkluc3BlY3Rvci5SZXNvdXJjZS5UeXBlLmlzVGV4dFR5
cGUodGhpcy50eXBlKQorICAgICAgICAgICAgJiYgdGhpcy5kb21haW4KICAgICAgICAgICAgICYm
ICEoIkNvbnRlbnQtRW5jb2RpbmciIGluIHRoaXMucmVzcG9uc2VIZWFkZXJzKQogICAgICAgICAg
ICAgJiYgdGhpcy5jb250ZW50TGVuZ3RoICE9PSB1bmRlZmluZWQKICAgICAgICAgICAgICYmIHRo
aXMuY29udGVudExlbmd0aCA+PSA1MTI7Cg==
</data>
<flag name="review"
          id="6256"
          type_id="1"
          status="+"
          setter="timothy"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>15177</attachid>
            <date>2007-06-22 00:06:03 -0700</date>
            <delta_ts>2007-06-22 09:58:45 -0700</delta_ts>
            <desc>ChangeLog</desc>
            <filename>ChangeLog</filename>
            <type>text/plain</type>
            <size>252</size>
            <attacher name="Richard Connamacher">richardconnamacher</attacher>
            
              <data encoding="base64">77u/MjAwNy0wNi0yMSAgUmljaGFyZCBDb25uYW1hY2hlciAgPHJpY2hAaW5kaWVpbWFnZS5jb20+
CgrCoCDCoCDCoCDCoCBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQoKICAgICAgICBQcmV2ZW50
IHNlcnZlci1zaWRlIGNvbXByZXNzaW9uIHRpcCBmcm9tIGJlaW5nIGdpdmVuIHRvIGxvY2FsIGZp
bGVzIChCdWcgIzE0MzA1KQogICAgICAgIAogICAgICAgICogcGFnZS9pbnNwZWN0b3IvUmVzb3Vy
Y2UuanM6IF9zaG91bGRDb21wcmVzcygp
</data>
<flag name="review"
          id="6257"
          type_id="1"
          status="+"
          setter="timothy"
    />
          </attachment>
      

    </bug>

</bugzilla>