143035 2015-03-24 20:54:53 -0700 Mavericks WK1 still runs JSC tests 2015-03-26 04:25:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap fpizlo ggaren lforschler mark.lam mmirman msaboff ossy rniwa oldest_to_newest 1079853 0 ap 2015-03-24 20:54:53 -0700 Looks like we missed Mavericks WK1 when disabling JSC tests. 1079854 1 249384 ap 2015-03-24 20:57:43 -0700 Created attachment 249384 proposed fix 1079882 2 249384 ossy 2015-03-25 00:10:36 -0700 Comment on attachment 249384 proposed fix On Yosemite we have dedicated JSC testers, but on Mavericks we don't, that's why the WK1 bots run the JSC tests too. 1079883 3 ap 2015-03-25 00:18:18 -0700 Yes, but that wasn't the plan. We need layout tests to be fast stronger than we need JSC coverage on Mavericks. 1079899 4 249384 ossy 2015-03-25 01:44:47 -0700 Comment on attachment 249384 proposed fix rs=me if Apple don't need JSC test coverage on Mavericks any more. 1079900 5 ossy 2015-03-25 01:47:02 -0700 Additionally this change means that Bot watcher's dashboard won't signal any JSC regressions any more. Do we really want it? 1079901 6 249384 ossy 2015-03-25 01:50:07 -0700 Comment on attachment 249384 proposed fix Ah, one more thing, please update the unit test too. 1079913 7 ossy 2015-03-25 02:33:38 -0700 (In reply to comment #6) > Comment on attachment 249384 [details] > proposed fix > > Ah, one more thing, please update the unit test too. I meant this one: https://trac.webkit.org/browser/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py#L367 1079969 8 ap 2015-03-25 10:01:54 -0700 Committed <http://trac.webkit.org/r181962>. As for JSC regressions, Mark Lam is going to look into adding not just the new queue, but also 32-bit and CLOOP LLINT ones to the dashboard. 1080255 9 ossy 2015-03-26 04:25:58 -0700 (In reply to comment #8) > Committed <http://trac.webkit.org/r181962>. We need a master restart to apply this change. > As for JSC regressions, Mark Lam is going to look into adding not just the > new queue, but also 32-bit and CLOOP LLINT ones to the dashboard. I missed it, I filed a bug report for it not so long ago - bug143091, feel free to close it as duplicated if you have another one. 249384 2015-03-24 20:57:43 -0700 2015-03-25 01:50:07 -0700 proposed fix JSCTests.txt text/plain 2386 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4MTkyOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTAzLTI0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIE1hdmVyaWNrcyBXSzEgc3RpbGwgcnVucyBKU0MgdGVzdHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzAzNQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb246IEJyaW5nIE1hdmVyaWNrcyBX SzEgaW4gbGluZQorICAgICAgICB3aXRoIG90aGVyIGJvdHMuCisKIDIwMTUtMDMtMjQgIEJlbmph bWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBVUkwgZmls dGVyIHBhdHRlcm5zIG1hdGNoaW5nIGNvbnNpc3RlbnQgYW5kIGFkZCBhIHNpbXBsZSBjYW5vbmlj YWxpemF0aW9uIHN0ZXAKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL2NvbmZpZy5qc29uCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL2NvbmZpZy5qc29uCShyZXZpc2lvbiAxODE4 NDUpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9j b25maWcuanNvbgkod29ya2luZyBjb3B5KQpAQCAtNzUsNyArNzUsNyBAQAogICAgICAgICAgICAg ICAgICAgICAgICJ0cmlnZ2VycyI6IFsibWF2ZXJpY2tzLWRlYnVnLXRlc3RzLXdrMSIsICJtYXZl cmlja3MtZGVidWctdGVzdHMtd2syIl0sCiAgICAgICAgICAgICAgICAgICAgICAgInNsYXZlbmFt ZXMiOiBbImJvdDEwMSIsICJib3QxMDUiXQogICAgICAgICAgICAgICAgICAgICB9LAotICAgICAg ICAgICAgICAgICAgICB7ICJuYW1lIjogIkFwcGxlIE1hdmVyaWNrcyBEZWJ1ZyBXSzEgKFRlc3Rz KSIsICJ0eXBlIjogIlRlc3RXZWJLaXQxIiwgImJ1aWxkZGlyIjogIm1hdmVyaWNrcy1kZWJ1Zy10 ZXN0cy13azEiLAorICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogIkFwcGxlIE1hdmVyaWNr cyBEZWJ1ZyBXSzEgKFRlc3RzKSIsICJ0eXBlIjogIlRlc3RXZWJLaXQxQWxsQnV0SlNDIiwgImJ1 aWxkZGlyIjogIm1hdmVyaWNrcy1kZWJ1Zy10ZXN0cy13azEiLAogICAgICAgICAgICAgICAgICAg ICAgICJwbGF0Zm9ybSI6ICJtYWMtbWF2ZXJpY2tzIiwgImNvbmZpZ3VyYXRpb24iOiAiZGVidWci LCAiYXJjaGl0ZWN0dXJlcyI6IFsieDg2XzY0Il0sCiAgICAgICAgICAgICAgICAgICAgICAgImFk ZGl0aW9uYWxBcmd1bWVudHMiOiBbIi0tbm8tcmV0cnktZmFpbHVyZXMiXSwKICAgICAgICAgICAg ICAgICAgICAgICAic2xhdmVuYW1lcyI6IFsiYm90MTI0IiwgImJvdDEwOCJdCkBAIC05OCw3ICs5 OCw3IEBACiAgICAgICAgICAgICAgICAgICAgICAgInRyaWdnZXJzIjogWyJtYXZlcmlja3MtcmVs ZWFzZS10ZXN0cy13azEiLCAibWF2ZXJpY2tzLXJlbGVhc2UtdGVzdHMtd2syIiwgIm1hdmVyaWNr cy1yZWxlYXNlLXBlcmYiXSwKICAgICAgICAgICAgICAgICAgICAgICAic2xhdmVuYW1lcyI6IFsi Ym90MzAxIiwgImJvdDMwNiJdCiAgICAgICAgICAgICAgICAgICAgIH0sCi0gICAgICAgICAgICAg ICAgICAgIHsgIm5hbWUiOiAiQXBwbGUgTWF2ZXJpY2tzIFJlbGVhc2UgV0sxIChUZXN0cykiLCAi dHlwZSI6ICJUZXN0V2ViS2l0MSIsICJidWlsZGRpciI6ICJtYXZlcmlja3MtcmVsZWFzZS10ZXN0 cy13azEiLAorICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogIkFwcGxlIE1hdmVyaWNrcyBS ZWxlYXNlIFdLMSAoVGVzdHMpIiwgInR5cGUiOiAiVGVzdFdlYktpdDFBbGxCdXRKU0MiLCAiYnVp bGRkaXIiOiAibWF2ZXJpY2tzLXJlbGVhc2UtdGVzdHMtd2sxIiwKICAgICAgICAgICAgICAgICAg ICAgICAicGxhdGZvcm0iOiAibWFjLW1hdmVyaWNrcyIsICJjb25maWd1cmF0aW9uIjogInJlbGVh c2UiLCAiYXJjaGl0ZWN0dXJlcyI6IFsieDg2XzY0Il0sCiAgICAgICAgICAgICAgICAgICAgICAg ImFkZGl0aW9uYWxBcmd1bWVudHMiOiBbIi0tbm8tcmV0cnktZmFpbHVyZXMiXSwKICAgICAgICAg ICAgICAgICAgICAgICAic2xhdmVuYW1lcyI6IFsiYm90MTk5IiwgImJvdDE1MSJdCg==