143030 2015-03-24 17:24:50 -0700 REGRESSION: Inspector doesn't get focused when opened in dock mode 2015-03-24 19:43:22 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 126800 1 rniwa rniwa andersca graouts joepeck jonowells mattbaker nvasilyev sam thorton timothy webkit-bug-importer oldest_to_newest 1079788 0 rniwa 2015-03-24 17:24:50 -0700 When Web Inspector is opened in the docked mode, it doesn't become the first responder even through the caret rendered by CodeMirror starts blinking. 1079789 1 webkit-bug-importer 2015-03-24 17:25:22 -0700 <rdar://problem/20285019> 1079792 2 249369 rniwa 2015-03-24 17:40:23 -0700 Created attachment 249369 Patch 1079796 3 249369 joepeck 2015-03-24 18:05:14 -0700 Comment on attachment 249369 Patch Looks good to me! Needs a WK2 Owner's approval 1079798 4 249369 timothy 2015-03-24 18:09:31 -0700 Comment on attachment 249369 Patch Should we fix WKWebView to "forward" first responder status when it gets becomeFirstResponder? That way no one else runs into this issue. 1079800 5 rniwa 2015-03-24 18:12:25 -0700 (In reply to comment #4) > Comment on attachment 249369 [details] > Patch > > Should we fix WKWebView to "forward" first responder status when it gets > becomeFirstResponder? That way no one else runs into this issue. I don't think so at least not according to Andres. He suggested making WKWebView return NO in acceptsFirstResponder but I'd prefer landing it as a separate patch. 1079805 6 timothy 2015-03-24 18:19:32 -0700 If you were a third party developer, how would you get the WKView to make it the first responder. You couldn't. Please fix this properly. 1079832 7 rniwa 2015-03-24 19:35:37 -0700 (In reply to comment #6) > If you were a third party developer, how would you get the WKView to make it > the first responder. You couldn't. You'd create your own WKView via: [WKView initWithFrame] > Please fix this properly. If you think this API design is wrong, please file a separate bug. That's a much broader scope than fixing this regression. Quite frankly, I don't even want to work on this bug if it wasn't blocking the bug 126800. 1079833 8 thorton 2015-03-24 19:37:22 -0700 (In reply to comment #7) > (In reply to comment #6) > > If you were a third party developer, how would you get the WKView to make it > > the first responder. You couldn't. > > You'd create your own WKView via: [WKView initWithFrame] WKView is not API. 1079834 9 249369 rniwa 2015-03-24 19:37:39 -0700 Comment on attachment 249369 Patch Clearing flags on attachment: 249369 Committed r181927: <http://trac.webkit.org/changeset/181927> 1079835 10 rniwa 2015-03-24 19:37:44 -0700 All reviewed patches have been landed. Closing bug. 1079839 11 rniwa 2015-03-24 19:43:22 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > If you were a third party developer, how would you get the WKView to make it > > > the first responder. You couldn't. > > > > You'd create your own WKView via: [WKView initWithFrame] > > WKView is not API. Huh, I guess it's SPI but not API? Anyway, we should move that discussion into another bug. 249369 2015-03-24 17:40:23 -0700 2015-03-24 19:37:39 -0700 Patch fix143030 text/plain 2145 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTkyMikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAzLTI0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEluc3BlY3RvciBkb2Vzbid0IGdl dCBmb2N1c2VkIHdoZW4gb3BlbmVkIGluIGRvY2sgbW9kZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzMDMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IHBsYXRmb3Jt QnJpbmdUb0Zyb250IGFuZCBwbGF0Zm9ybUF0dGFjaCBjYWxsaW5nIG1ha2VGaXJzdFJlc3BvbmRl ciBvbiBXS1dlYlZpZXcsCisgICAgICAgIHdoaWNoIGFyZW4ndCBpbnRlbmRlZCB0byBiZWNvbWUg dGhlIGZpcnN0IHJlc3BvbmRlci4gRml4ZWQgdGhlIGJ1ZyBieSBjYWxsaW5nIG1ha2VGaXJzdFJl c3BvbmRlciBvbiB0aGUgV0tWaWV3CisgICAgICAgIHN1YnZpZXcgb2YgdGhlIFdLV2ViVmlldywg d2hpY2ggaXMgaW50ZW5kZWQgdG8gYmUgdXNlZCBhcyB0aGUgZmlyc3QgcmVzcG9uZGVyIG9uIGJl aGFsZiBvZiB0aGUgd2ViIHZpZXcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dlYkluc3Bl Y3RvclByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6cGxh dGZvcm1CcmluZ1RvRnJvbnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6 cGxhdGZvcm1BdHRhY2gpOgorCiAyMDE1LTAzLTI0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IGNyYXNoIGluIFdlYktpdDo6UmVtb3RlT2JqZWN0 UmVnaXN0cnk6OnNlbmRJbnZvY2F0aW9uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0JKHJldmlzaW9uIDE4MTg2NikK KysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0J KHdvcmtpbmcgY29weSkKQEAgLTYyMCw3ICs2MjAsNyBAQAogCiAgICAgLy8gRklYTUUgPHJkYXI6 Ly9wcm9ibGVtLzEwOTM3Njg4PjogdGhpcyB3aWxsIG5vdCBicmluZyBhIGJhY2tncm91bmQgdGFi IGluIFNhZmFyaSB0byB0aGUgZnJvbnQsIG9ubHkgaXRzIHdpbmRvdy4KICAgICBbbV9pbnNwZWN0 b3JWaWV3LmdldCgpLndpbmRvdyBtYWtlS2V5QW5kT3JkZXJGcm9udDpuaWxdOwotICAgIFttX2lu c3BlY3RvclZpZXcuZ2V0KCkud2luZG93IG1ha2VGaXJzdFJlc3BvbmRlcjptX2luc3BlY3RvclZp ZXcuZ2V0KCldOworICAgIFttX2luc3BlY3RvclZpZXcuZ2V0KCkud2luZG93IG1ha2VGaXJzdFJl c3BvbmRlcjptX2luc3BlY3RvclZpZXctPl9wYWdlLT53a1ZpZXcoKV07CiB9CiAKIGJvb2wgV2Vi SW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtSXNGcm9udCgpCkBAIC04MjEsOCArODIxLDcgQEAKICAg ICBpbnNwZWN0ZWRWaWV3RnJhbWVEaWRDaGFuZ2UoY3VycmVudERpbWVuc2lvbik7CiAKICAgICBb W2luc3BlY3RlZFZpZXcgc3VwZXJ2aWV3XSBhZGRTdWJ2aWV3Om1faW5zcGVjdG9yVmlldy5nZXQo KSBwb3NpdGlvbmVkOk5TV2luZG93QmVsb3cgcmVsYXRpdmVUbzppbnNwZWN0ZWRWaWV3XTsKLQot ICAgIFtbaW5zcGVjdGVkVmlldyB3aW5kb3ddIG1ha2VGaXJzdFJlc3BvbmRlcjptX2luc3BlY3Rv clZpZXcuZ2V0KCldOworICAgIFttX2luc3BlY3RvclZpZXcuZ2V0KCkud2luZG93IG1ha2VGaXJz dFJlc3BvbmRlcjptX2luc3BlY3RvclZpZXctPl9wYWdlLT53a1ZpZXcoKV07CiB9CiAKIHZvaWQg V2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtRGV0YWNoKCkK