143021 2015-03-24 14:51:18 -0700 [iOS] Remove unused keyboard code in WKSelectPopover class 2015-03-24 16:38:25 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enrica enrica joepeck oldest_to_newest 1079729 0 enrica 2015-03-24 14:51:18 -0700 Cleanup task. 1079731 1 249356 enrica 2015-03-24 14:55:34 -0700 Created attachment 249356 Patch 1079767 2 249356 joepeck 2015-03-24 16:22:34 -0700 Comment on attachment 249356 Patch Looks good to me You can probably remove a bunch of UIKeyboard stuff from UIKitSPI.h, since I would guess this might be the only place it is used. 1079769 3 enrica 2015-03-24 16:28:06 -0700 (In reply to comment #2) > Comment on attachment 249356 [details] > Patch > > Looks good to me > > You can probably remove a bunch of UIKeyboard stuff from UIKitSPI.h, since I > would guess this might be the only place it is used. Unfortunately the keyboard is still widely used in WKContentViewInteraction.mm Thanks for the review! 1079774 4 enrica 2015-03-24 16:38:25 -0700 Committed revision 181919. 249356 2015-03-24 14:55:34 -0700 2015-03-24 16:22:34 -0700 Patch removekbfromselectpopover.txt text/plain 2230 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTkwOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTAzLTI0ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVtb3ZlIHVudXNl ZCBrZXlib2FyZCBjb2RlIGluIFdLU2VsZWN0UG9wb3ZlciBjbGFzcy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzAyMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdLU2VsZWN0UG9wb3ZlciBjcmVhdGVk IGFuIGluc3RhbmNlIG9mIFVJS2V5Ym9hcmQgdGhhdCB3YXMKKyAgICAgICAgaW5pdGlhbGl6ZWQg aW4gaW5pdFdpdGhWaWV3IGJ1dCBuZXZlciB1c2VkLiBSZW1vdmluZyB0aGUKKyAgICAgICAgb2Jz b2xldGUgY29kZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGb3JtU2VsZWN0 UG9wb3Zlci5tbToKKyAgICAgICAgKC1bV0tTZWxlY3RQb3BvdmVyIGluaXRXaXRoVmlldzpoYXNH cm91cHM6XSk6CisKIDIwMTUtMDMtMjQgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgog CiAgICAgICAgIEFkZCBldmVudHMgcmVsYXRlZCB0byBmb3JjZSBjbGljayBnZXN0dXJlCkluZGV4 OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBvcG92ZXIu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0Zv cm1TZWxlY3RQb3BvdmVyLm1tCShyZXZpc2lvbiAxODE4NjgpCisrKyBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL2Zvcm1zL1dLRm9ybVNlbGVjdFBvcG92ZXIubW0JKHdvcmtpbmcgY29weSkK QEAgLTM2OSw3ICszNjksNiBAQCAtICh2b2lkKWRlbGV0ZUJhY2t3YXJkCiBAaW1wbGVtZW50YXRp b24gV0tTZWxlY3RQb3BvdmVyIHsKICAgICBXS0NvbnRlbnRWaWV3ICpfdmlldzsKICAgICBSZXRh aW5QdHI8V0tTZWxlY3RUYWJsZVZpZXdDb250cm9sbGVyPiBfdGFibGVWaWV3Q29udHJvbGxlcjsK LSAgICBSZXRhaW5QdHI8VUlLZXlib2FyZD4gX2tleWJvYXJkOwogfQogCiAtIChpbnN0YW5jZXR5 cGUpaW5pdFdpdGhWaWV3OihXS0NvbnRlbnRWaWV3ICopdmlldyBoYXNHcm91cHM6KEJPT0wpaGFz R3JvdXBzCkBAIC0zODEsNyArMzgwLDYgQEAgLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoVmlldzoo V0tDb250ZW50VgogICAgIENHUmVjdCBmcmFtZTsKICAgICBmcmFtZS5vcmlnaW4gPSBDR1BvaW50 WmVybzsKICAgICBmcmFtZS5zaXplID0gW1VJS2V5Ym9hcmQgZGVmYXVsdFNpemVGb3JJbnRlcmZh Y2VPcmllbnRhdGlvbjpbVUlBcHAgaW50ZXJmYWNlT3JpZW50YXRpb25dXTsKLSAgICBfa2V5Ym9h cmQgPSBhZG9wdE5TKFtbVUlLZXlib2FyZCBhbGxvY10gaW5pdFdpdGhGcmFtZTpmcmFtZV0pOwog CiAgICAgX3RhYmxlVmlld0NvbnRyb2xsZXIgPSBhZG9wdE5TKFtbV0tTZWxlY3RUYWJsZVZpZXdD b250cm9sbGVyIGFsbG9jXSBpbml0V2l0aFZpZXc6dmlldyBoYXNHcm91cHM6aGFzR3JvdXBzXSk7 CiAgICAgW190YWJsZVZpZXdDb250cm9sbGVyIHNldFBvcG92ZXI6c2VsZl07CkBAIC00MDcsMTAg KzQwNSw2IEBAICAgICBmcmFtZS5zaXplID0gW1VJS2V5Ym9hcmQgZGVmYXVsdFNpemUKICAgICBb bmF2Q29udHJvbGxlciByZWxlYXNlXTsKICAgICAKICAgICBbW1VJS2V5Ym9hcmRJbXBsIHNoYXJl ZEluc3RhbmNlXSBzZXREZWxlZ2F0ZTpfdGFibGVWaWV3Q29udHJvbGxlci5nZXQoKV07Ci0gICAg W19rZXlib2FyZCBzZXRTaXplOltVSUtleWJvYXJkIGRlZmF1bHRTaXplRm9ySW50ZXJmYWNlT3Jp ZW50YXRpb246W1VJQXBwIGludGVyZmFjZU9yaWVudGF0aW9uXV1dOwotICAgIFtfa2V5Ym9hcmQg cHJlcGFyZUZvckdlb21ldHJ5Q2hhbmdlXTsKLSAgICBbX2tleWJvYXJkIGdlb21ldHJ5Q2hhbmdl RG9uZTpOT107Ci0gICAgW19rZXlib2FyZCBhY3RpdmF0ZV07CiAgICAgCiAgICAgcmV0dXJuIHNl bGY7CiB9Cg==