143015 2015-03-24 13:26:02 -0700 Web Inspector: Workaround issue causing uncaught exception in Inspector 2015-03-24 14:17:40 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck burg commit-queue graouts joepeck jonowells mattbaker nvasilyev rniwa timothy webkit-bug-importer oldest_to_newest 1079679 0 joepeck 2015-03-24 13:26:02 -0700 * SUMMARY Workaround for: <https://webkit.org/b/143012> ES6: Classes: Early return in sub-class constructor results in returning undefined instead of instance ReplayManager is the only constructor (base or derived!) that early returns. 1079680 1 webkit-bug-importer 2015-03-24 13:26:30 -0700 <rdar://problem/20280493> 1079681 2 webkit-bug-importer 2015-03-24 13:26:34 -0700 <rdar://problem/20280491> 1079684 3 249344 joepeck 2015-03-24 13:27:12 -0700 Created attachment 249344 [PATCH] Proposed Fix 1079715 4 249344 commit-queue 2015-03-24 14:17:34 -0700 Comment on attachment 249344 [PATCH] Proposed Fix Clearing flags on attachment: 249344 Committed r181905: <http://trac.webkit.org/changeset/181905> 1079716 5 commit-queue 2015-03-24 14:17:40 -0700 All reviewed patches have been landed. Closing bug. 249344 2015-03-24 13:27:12 -0700 2015-03-24 14:17:34 -0700 [PATCH] Proposed Fix return-fix.patch text/plain 4241 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNlMTcwOTMuLjMxYmUyM2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAzLTI0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogV29ya2Fy b3VuZCBpc3N1ZSBjYXVzaW5nIHVuY2F1Z2h0IGV4Y2VwdGlvbiBpbiBJbnNwZWN0b3IKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzAxNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdvcmthcm91bmQgPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzE0MzAxMj4gYW5kIGF2b2lkIGVhcmx5IHJldHVybmluZyBpbiBj b25zdHJ1Y3RvcnMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1JlcGxh eU1hbmFnZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVwbGF5TWFuYWdlci5jbGFzcy5S ZXBsYXlNYW5hZ2VyKToKKwogMjAxNS0wMy0xNyAgSm9ubyBXZWxscyAgPGpvbm93ZWxsc0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogRGVidWdnZXIgc2lkZWJhciBzaG91bGQg aGF2ZSBhIGZpbHRlciBidXR0b24gZm9yIGJyZWFrcG9pbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9SZXBsYXlNYW5hZ2VyLmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvUmVwbGF5 TWFuYWdlci5qcwppbmRleCAxYmIwYmE1Li5hMDg2MDhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9SZXBsYXlNYW5hZ2VyLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1JlcGxh eU1hbmFnZXIuanMKQEAgLTQ5LDMyICs0OSwzMCBAQCBXZWJJbnNwZWN0b3IuUmVwbGF5TWFuYWdl ciA9IGNsYXNzIFJlcGxheU1hbmFnZXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiAgICAg ICAgIC8vIGZvciB0aGUgZHVyYXRpb24gb2YgdGhlIHBsYXliYWNrIGNvbW1hbmQgdW50aWwgYW5v dGhlciBwbGF5YmFjayBiZWdpbnMuCiAgICAgICAgIHRoaXMuX3BsYXliYWNrU3BlZWQgPSBXZWJJ bnNwZWN0b3IuUmVwbGF5TWFuYWdlci5QbGF5YmFja1NwZWVkLlJlYWxUaW1lOwogCi0gICAgICAg IGlmICghd2luZG93LlJlcGxheUFnZW50KQotICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBp ZiAod2luZG93LlJlcGxheUFnZW50KSB7CisgICAgICAgICAgICB2YXIgaW5zdGFuY2UgPSB0aGlz OworICAgICAgICAgICAgdGhpcy5faW5pdGlhbGl6YXRpb25Qcm9taXNlID0gUmVwbGF5QWdlbnQu Y3VycmVudFJlcGxheVN0YXRlKCkKKyAgICAgICAgICAgICAgICAudGhlbihmdW5jdGlvbihwYXls b2FkKSB7CisgICAgICAgICAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHBheWxvYWQuc2Vzc2lv blN0YXRlIGluIFdlYkluc3BlY3Rvci5SZXBsYXlNYW5hZ2VyLlNlc3Npb25TdGF0ZSwgIlVua25v d24gc2Vzc2lvbiBzdGF0ZTogIiArIHBheWxvYWQuc2Vzc2lvblN0YXRlKTsKKyAgICAgICAgICAg ICAgICAgICAgY29uc29sZS5hc3NlcnQocGF5bG9hZC5zZWdtZW50U3RhdGUgaW4gV2ViSW5zcGVj dG9yLlJlcGxheU1hbmFnZXIuU2VnbWVudFN0YXRlLCAiVW5rbm93biBzZWdtZW50IHN0YXRlOiAi ICsgcGF5bG9hZC5zZWdtZW50U3RhdGUpOwogCi0gICAgICAgIHZhciBpbnN0YW5jZSA9IHRoaXM7 CisgICAgICAgICAgICAgICAgICAgIGluc3RhbmNlLl9hY3RpdmVTZXNzaW9uSWRlbnRpZmllciA9 IHBheWxvYWQuc2Vzc2lvbklkZW50aWZpZXI7CisgICAgICAgICAgICAgICAgICAgIGluc3RhbmNl Ll9hY3RpdmVTZWdtZW50SWRlbnRpZmllciA9IHBheWxvYWQuc2VnbWVudElkZW50aWZpZXI7Cisg ICAgICAgICAgICAgICAgICAgIGluc3RhbmNlLl9zZXNzaW9uU3RhdGUgPSBXZWJJbnNwZWN0b3Iu UmVwbGF5TWFuYWdlci5TZXNzaW9uU3RhdGVbcGF5bG9hZC5zZXNzaW9uU3RhdGVdOworICAgICAg ICAgICAgICAgICAgICBpbnN0YW5jZS5fc2VnbWVudFN0YXRlID0gV2ViSW5zcGVjdG9yLlJlcGxh eU1hbmFnZXIuU2VnbWVudFN0YXRlW3BheWxvYWQuc2VnbWVudFN0YXRlXTsKKyAgICAgICAgICAg ICAgICAgICAgaW5zdGFuY2UuX2N1cnJlbnRQb3NpdGlvbiA9IHBheWxvYWQucmVwbGF5UG9zaXRp b247CiAKLSAgICAgICAgdGhpcy5faW5pdGlhbGl6YXRpb25Qcm9taXNlID0gUmVwbGF5QWdlbnQu Y3VycmVudFJlcGxheVN0YXRlKCkKLSAgICAgICAgICAgIC50aGVuKGZ1bmN0aW9uKHBheWxvYWQp IHsKLSAgICAgICAgICAgICAgICBjb25zb2xlLmFzc2VydChwYXlsb2FkLnNlc3Npb25TdGF0ZSBp biBXZWJJbnNwZWN0b3IuUmVwbGF5TWFuYWdlci5TZXNzaW9uU3RhdGUsICJVbmtub3duIHNlc3Np b24gc3RhdGU6ICIgKyBwYXlsb2FkLnNlc3Npb25TdGF0ZSk7Ci0gICAgICAgICAgICAgICAgY29u c29sZS5hc3NlcnQocGF5bG9hZC5zZWdtZW50U3RhdGUgaW4gV2ViSW5zcGVjdG9yLlJlcGxheU1h bmFnZXIuU2VnbWVudFN0YXRlLCAiVW5rbm93biBzZWdtZW50IHN0YXRlOiAiICsgcGF5bG9hZC5z ZWdtZW50U3RhdGUpOwotCi0gICAgICAgICAgICAgICAgaW5zdGFuY2UuX2FjdGl2ZVNlc3Npb25J ZGVudGlmaWVyID0gcGF5bG9hZC5zZXNzaW9uSWRlbnRpZmllcjsKLSAgICAgICAgICAgICAgICBp bnN0YW5jZS5fYWN0aXZlU2VnbWVudElkZW50aWZpZXIgPSBwYXlsb2FkLnNlZ21lbnRJZGVudGlm aWVyOwotICAgICAgICAgICAgICAgIGluc3RhbmNlLl9zZXNzaW9uU3RhdGUgPSBXZWJJbnNwZWN0 b3IuUmVwbGF5TWFuYWdlci5TZXNzaW9uU3RhdGVbcGF5bG9hZC5zZXNzaW9uU3RhdGVdOwotICAg ICAgICAgICAgICAgIGluc3RhbmNlLl9zZWdtZW50U3RhdGUgPSBXZWJJbnNwZWN0b3IuUmVwbGF5 TWFuYWdlci5TZWdtZW50U3RhdGVbcGF5bG9hZC5zZWdtZW50U3RhdGVdOwotICAgICAgICAgICAg ICAgIGluc3RhbmNlLl9jdXJyZW50UG9zaXRpb24gPSBwYXlsb2FkLnJlcGxheVBvc2l0aW9uOwot Ci0gICAgICAgICAgICAgICAgaW5zdGFuY2UuX2luaXRpYWxpemVkID0gdHJ1ZTsKLSAgICAgICAg ICAgIH0pLnRoZW4oZnVuY3Rpb24oKSB7Ci0gICAgICAgICAgICAgICAgcmV0dXJuIFJlcGxheUFn ZW50LmdldEF2YWlsYWJsZVNlc3Npb25zKCk7Ci0gICAgICAgICAgICB9KS50aGVuKGZ1bmN0aW9u KHBheWxvYWQpIHsKLSAgICAgICAgICAgICAgICBmb3IgKHZhciBzZXNzaW9uSWQgb2YgcGF5bG9h ZC5pZHMpCi0gICAgICAgICAgICAgICAgICAgIGluc3RhbmNlLnNlc3Npb25DcmVhdGVkKHNlc3Np b25JZCk7Ci0gICAgICAgICAgICB9KS5jYXRjaChmdW5jdGlvbihlcnJvcikgewotICAgICAgICAg ICAgICAgIGNvbnNvbGUuZXJyb3IoIlJlcGxheU1hbmFnZXIgaW5pdGlhbGl6YXRpb24gZmFpbGVk OiAiLCBlcnJvcik7Ci0gICAgICAgICAgICAgICAgdGhyb3cgZXJyb3I7Ci0gICAgICAgICAgICB9 KTsKKyAgICAgICAgICAgICAgICAgICAgaW5zdGFuY2UuX2luaXRpYWxpemVkID0gdHJ1ZTsKKyAg ICAgICAgICAgICAgICB9KS50aGVuKGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgICAgICAgICBy ZXR1cm4gUmVwbGF5QWdlbnQuZ2V0QXZhaWxhYmxlU2Vzc2lvbnMoKTsKKyAgICAgICAgICAgICAg ICB9KS50aGVuKGZ1bmN0aW9uKHBheWxvYWQpIHsKKyAgICAgICAgICAgICAgICAgICAgZm9yICh2 YXIgc2Vzc2lvbklkIG9mIHBheWxvYWQuaWRzKQorICAgICAgICAgICAgICAgICAgICAgICAgaW5z dGFuY2Uuc2Vzc2lvbkNyZWF0ZWQoc2Vzc2lvbklkKTsKKyAgICAgICAgICAgICAgICB9KS5jYXRj aChmdW5jdGlvbihlcnJvcikgeworICAgICAgICAgICAgICAgICAgICBjb25zb2xlLmVycm9yKCJS ZXBsYXlNYW5hZ2VyIGluaXRpYWxpemF0aW9uIGZhaWxlZDogIiwgZXJyb3IpOworICAgICAgICAg ICAgICAgICAgICB0aHJvdyBlcnJvcjsKKyAgICAgICAgICAgICAgICB9KTsKKyAgICAgICAgfQog ICAgIH0KIAogICAgIC8vIFB1YmxpYwo=