143007 2015-03-24 09:31:53 -0700 AX: table cells that use display:block render the table inaccessible to VoiceOver 2015-03-25 23:03:04 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro ap bfulgham commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1079620 0 cfleizach 2015-03-24 09:31:53 -0700 If a table cell uses display: block, then cellForColumnAndRow fails because the child of the row is not a table cell. VoiceOver is then unable to navigate the table <rdar://problem/20196222> 1079648 1 249337 cfleizach 2015-03-24 11:52:03 -0700 Created attachment 249337 patch 1079649 2 commit-queue 2015-03-24 11:53:51 -0700 Attachment 249337 did not pass style-queue: ERROR: Source/WebCore/accessibility/AccessibilityTableCell.cpp:70: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1079655 3 cfleizach 2015-03-24 12:28:02 -0700 (In reply to comment #2) > Attachment 249337 [details] did not pass style-queue: > > > ERROR: Source/WebCore/accessibility/AccessibilityTableCell.cpp:70: Multi > line control clauses should use braces. [whitespace/braces] [4] > Total errors found: 1 in 5 files > seems like a false positive > > If any of these errors are false positives, please file a bug against > check-webkit-style. 1080111 4 249337 cfleizach 2015-03-25 17:08:15 -0700 Comment on attachment 249337 patch Thanks! 1080134 5 249337 commit-queue 2015-03-25 17:54:35 -0700 Comment on attachment 249337 patch Clearing flags on attachment: 249337 Committed r181988: <http://trac.webkit.org/changeset/181988> 1080135 6 commit-queue 2015-03-25 17:54:40 -0700 All reviewed patches have been landed. Closing bug. 1080176 7 ap 2015-03-25 20:28:45 -0700 This new test is broken on Windows, Efl and Gtk. Can this be fixed quickly, or should we roll out? https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Ftable-cell-display-block.html @@ -1,14 +1,18 @@ +CONSOLE MESSAGE: line 29: TypeError: undefined is not an object (evaluating 'table.cellForColumnAndRow') +a1 +b1 c1 +a2 +b2 c2 +a1 +b1 c1 +a2 +b2 c2 This tests that if a table cell uses display:block, the table cell will still be accessible On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS cell1a.isEqual(cell1b) is true -PASS cell1a.role is 'AXRole: AXCell' -PASS domCell1.style.display is 'block' -PASS table2.role is 'AXRole: AXGroup' -PASS cell2.role is 'AXRole: AXStaticText' -PASS successfullyParsed is true +FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined). 1080200 8 cfleizach 2015-03-25 22:24:14 -0700 We should make this a Mac only test if these other platforms don't implement cellForColAndRoe (In reply to comment #7) > This new test is broken on Windows, Efl and Gtk. Can this be fixed quickly, > or should we roll out? > > > https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=accessibility%2Ftable-cell-display-block.html > > > @@ -1,14 +1,18 @@ > +CONSOLE MESSAGE: line 29: TypeError: undefined is not an object (evaluating > 'table.cellForColumnAndRow') > +a1 > +b1 c1 > +a2 > +b2 c2 > +a1 > +b1 c1 > +a2 > +b2 c2 > This tests that if a table cell uses display:block, the table cell will > still be accessible > > On success, you will see a series of "PASS" messages, followed by "TEST > COMPLETE". > > > -PASS cell1a.isEqual(cell1b) is true > -PASS cell1a.role is 'AXRole: AXCell' > -PASS domCell1.style.display is 'block' > -PASS table2.role is 'AXRole: AXGroup' > -PASS cell2.role is 'AXRole: AXStaticText' > -PASS successfullyParsed is true > +FAIL successfullyParsed should be true (of type boolean). Was undefined (of > type undefined). 1080203 9 bfulgham 2015-03-25 22:36:14 -0700 Could you please skip this test on Windows (and perhaps others) and file a bug to remind us to fix this? 1080205 10 cfleizach 2015-03-25 22:44:03 -0700 (In reply to comment #9) > Could you please skip this test on Windows (and perhaps others) and file a > bug to remind us to fix this? Ok on it. Thanks 1080213 11 cfleizach 2015-03-25 23:03:04 -0700 (In reply to comment #10) > (In reply to comment #9) > > Could you please skip this test on Windows (and perhaps others) and file a > > bug to remind us to fix this? > > Ok on it. Thanks Tests skipped http://trac.webkit.org/changeset/182002 Windows https://bugs.webkit.org/show_bug.cgi?id=143081 Linux https://bugs.webkit.org/show_bug.cgi?id=143083 249337 2015-03-24 11:52:03 -0700 2015-03-25 17:54:35 -0700 patch patch text/plain 5287 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTg5NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTAzLTI0ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IHRhYmxlIGNlbGxz IHRoYXQgdXNlIGRpc3BsYXk6YmxvY2sgcmVuZGVyIHRoZSB0YWJsZSBpbmFjY2Vzc2libGUgdG8g Vm9pY2VPdmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDMwMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXaGVuIGRpc3BsYXk6YmxvY2sgaXMgdXNlZCBvbiBhIHRhYmxlIGNlbGwsIGl0IHdhcyBiZWlu ZyBpZ25vcmVkIGJlY2F1c2UgaXQgd2FzIGFub255bW91cy4KKyAgICAgICAgVGhpcyBpcyBzdGls bCBhIHZhbGlkIHNjZW5hcmlvIGhvd2V2ZXIgaWYgaXQncyBzdGlsbCBpbnNpZGUgb2YgYSB2YWxp ZCB0YWJsZS4KKworICAgICAgICBUZXN0OiBhY2Nlc3NpYmlsaXR5L3RhYmxlLWNlbGwtZGlzcGxh eS1ibG9jay5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlUYWJs ZUNlbGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVRhYmxlQ2VsbDo6Y29t cHV0ZUFjY2Vzc2liaWxpdHlJc0lnbm9yZWQpOgorCiAyMDE1LTAzLTI0ICBZb2F2IFdlaXNzICA8 eW9hdkB5b2F2LndzPgogCiAgICAgICAgIFN0b3AgaW1hZ2UgZnJvbSBkaXNwbGF5aW5nIHdoZW4g c3JjIGF0dHJpYnV0ZSBpcyByZW1vdmVkIG9yIGVtcHRpZWQKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlQ2VsbC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGVDZWxsLmNwcAko cmV2aXNpb24gMTgxMzk4KQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5VGFibGVDZWxsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjQsOCArNjQsMTAgQEAKICAg ICBpZiAoZGVjaXNpb24gPT0gSWdub3JlT2JqZWN0KQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICAKLSAgICAvLyBJZ25vcmUgYW5vbnltb3VzIHRhYmxlIGNlbGxzLgotICAgIGlmICghbm9kZSgp KQorICAgIC8vIElnbm9yZSBhbm9ueW1vdXMgdGFibGUgY2VsbHMgYXMgbG9uZyBhcyB0aGV5J3Jl IG5vdCBpbiBhIHRhYmxlIChpZS4gd2hlbiBkaXNwbGF5OnRhYmxlIGlzIHVzZWQpLgorICAgIFJl bmRlck9iamVjdCogcmVuZGVyVGFibGUgPSBpczxSZW5kZXJUYWJsZUNlbGw+KG1fcmVuZGVyZXIp ID8gZG93bmNhc3Q8UmVuZGVyVGFibGVDZWxsPigqbV9yZW5kZXJlcikudGFibGUoKSA6IG51bGxw dHI7CisgICAgYm9vbCBpblRhYmxlID0gcmVuZGVyVGFibGUgJiYgcmVuZGVyVGFibGUtPm5vZGUo KSAmJiAocmVuZGVyVGFibGUtPm5vZGUoKS0+aGFzVGFnTmFtZSh0YWJsZVRhZykgfHwgbm9kZUhh c1JvbGUocmVuZGVyVGFibGUtPm5vZGUoKSwgImdyaWQiKSk7CisgICAgaWYgKCFub2RlKCkgJiYg IWluVGFibGUpCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICAKICAgICBpZiAoIWlzVGFi bGVDZWxsKCkpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxODE4OTcpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNS0wMy0yNCAgQ2hyaXMg RmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCisgICAgICAgIEFYOiB0YWJsZSBjZWxs cyB0aGF0IHVzZSBkaXNwbGF5OmJsb2NrIHJlbmRlciB0aGUgdGFibGUgaW5hY2Nlc3NpYmxlIHRv IFZvaWNlT3ZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQzMDA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L3RhYmxlLWNlbGwtZGlzcGxheS1ibG9jay1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvdGFibGUtY2VsbC1kaXNwbGF5LWJsb2Nr Lmh0bWw6IEFkZGVkLgorCiAyMDE1LTAzLTI0ICBZb2F2IFdlaXNzICA8eW9hdkB5b2F2LndzPgog CiAgICAgICAgIFN0b3AgaW1hZ2UgZnJvbSBkaXNwbGF5aW5nIHdoZW4gc3JjIGF0dHJpYnV0ZSBp cyByZW1vdmVkIG9yIGVtcHRpZWQKSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvdGFi bGUtY2VsbC1kaXNwbGF5LWJsb2NrLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9hY2Nlc3NpYmlsaXR5L3RhYmxlLWNlbGwtZGlzcGxheS1ibG9jay1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3RhYmxlLWNlbGwtZGlz cGxheS1ibG9jay1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNCBAQAor VGhpcyB0ZXN0cyB0aGF0IGlmIGEgdGFibGUgY2VsbCB1c2VzIGRpc3BsYXk6YmxvY2ssIHRoZSB0 YWJsZSBjZWxsIHdpbGwgc3RpbGwgYmUgYWNjZXNzaWJsZQorCitPbiBzdWNjZXNzLCB5b3Ugd2ls bCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01Q TEVURSIuCisKKworUEFTUyBjZWxsMWEuaXNFcXVhbChjZWxsMWIpIGlzIHRydWUKK1BBU1MgY2Vs bDFhLnJvbGUgaXMgJ0FYUm9sZTogQVhDZWxsJworUEFTUyBkb21DZWxsMS5zdHlsZS5kaXNwbGF5 IGlzICdibG9jaycKK1BBU1MgdGFibGUyLnJvbGUgaXMgJ0FYUm9sZTogQVhHcm91cCcKK1BBU1Mg Y2VsbDIucm9sZSBpcyAnQVhSb2xlOiBBWFN0YXRpY1RleHQnCitQQVNTIHN1Y2Nlc3NmdWxseVBh cnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNz aWJpbGl0eS90YWJsZS1jZWxsLWRpc3BsYXktYmxvY2suaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3RhYmxlLWNlbGwtZGlzcGxheS1ibG9jay5odG1sCShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS90YWJsZS1jZWxsLWRpc3BsYXkt YmxvY2suaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDUxIEBACis8IURPQ1RZUEUgaHRt bD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPGRpdiBpZD0iY29u dGVudCI+CisKKzx0YWJsZSBib3JkZXI9MSBpZD0idGFibGUxIj4KKyAgPHRyPjx0ZCBpZD0iY2Vs bDEiIHN0eWxlPSJkaXNwbGF5OmJsb2NrOyI+YTE8L3RkPjx0ZD5iMTwvdGQ+PHRkPmMxPC90ZD48 L3RyPgorICA8dHI+PHRkIHN0eWxlPSJkaXNwbGF5OmJsb2NrOyI+YTI8L3RkPjx0ZD5iMjwvdGQ+ PHRkPmMyPC90ZD48L3RyPgorPC90YWJsZT4KKworPHRhYmxlIGJvcmRlcj0xIGlkPSJ0YWJsZTIi IHJvbGU9Imdyb3VwIj4KKyAgPHRyPjx0ZCBpZD0iY2VsbDIiIHN0eWxlPSJkaXNwbGF5OmJsb2Nr OyI+YTE8L3RkPjx0ZD5iMTwvdGQ+PHRkPmMxPC90ZD48L3RyPgorICA8dHI+PHRkIHN0eWxlPSJk aXNwbGF5OmJsb2NrOyI+YTI8L3RkPjx0ZD5iMjwvdGQ+PHRkPmMyPC90ZD48L3RyPgorPC90YWJs ZT4KKworPC9kaXY+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUi PjwvZGl2PgorPHNjcmlwdD4KKworICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIHRoYXQgaWYg YSB0YWJsZSBjZWxsIHVzZXMgZGlzcGxheTpibG9jaywgdGhlIHRhYmxlIGNlbGwgd2lsbCBzdGls bCBiZSBhY2Nlc3NpYmxlIik7CisKKyAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9s bGVyKSB7CisgICAgICAgIHZhciB0YWJsZSA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmFjY2Vz c2libGVFbGVtZW50QnlJZCgidGFibGUxIik7CisgICAgICAgIHZhciBjZWxsMWEgPSB0YWJsZS5j ZWxsRm9yQ29sdW1uQW5kUm93KDAsIDApOworICAgICAgICB2YXIgY2VsbDFiID0gdGFibGUuY2hp bGRBdEluZGV4KDApLmNoaWxkQXRJbmRleCgwKTsKKworICAgICAgICBzaG91bGRCZVRydWUoImNl bGwxYS5pc0VxdWFsKGNlbGwxYikiKTsKKyAgICAgICAgc2hvdWxkQmUoImNlbGwxYS5yb2xlIiwg IidBWFJvbGU6IEFYQ2VsbCciKTsKKyAgICAgICAgCisgICAgICAgIHZhciBkb21DZWxsMSA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJjZWxsMSIpOworICAgICAgICBzaG91bGRCZSgiZG9tQ2Vs bDEuc3R5bGUuZGlzcGxheSIsICInYmxvY2snIik7CisKKyAgICAgICAgLy8gTm93IGNoZWNrIGEg dGFibGUgdGhhdCB1c2VzIGEgZGlmZmVyZW50IHJvbGUgdG8gbWFrZSBzdXJlIHdlIGRvbid0IGhh dmUgYW55IGNlbGwgcm9sZXMuCisgICAgICAgIHZhciB0YWJsZTIgPSBhY2Nlc3NpYmlsaXR5Q29u dHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoInRhYmxlMiIpOworICAgICAgICBzaG91bGRC ZSgidGFibGUyLnJvbGUiLCAiJ0FYUm9sZTogQVhHcm91cCciKTsKKyAgICAgICAgdmFyIGNlbGwy ID0gdGFibGUyLmNoaWxkQXRJbmRleCgwKS5jaGlsZEF0SW5kZXgoMCk7CisgICAgICAgIHNob3Vs ZEJlKCJjZWxsMi5yb2xlIiwgIidBWFJvbGU6IEFYU3RhdGljVGV4dCciKTsKKworICAgICAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29udGVudCIpLnN0eWxlLnZpc2liaWxpdHkgPSAiaGlk ZGVuIjsKKyAgICB9CisKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL2pz LXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==