143005 2015-03-24 08:44:57 -0700 Add back previously broken assert from bug 141869 2015-03-27 14:57:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam webkit-unassigned commit-queue oldest_to_newest 1079616 0 saam 2015-03-24 08:44:57 -0700 Assert broke debug builds because it referenced an undeclared function parameter. But, if the parameter is declared, the assert is valid. 1079801 1 249371 saam 2015-03-24 18:14:15 -0700 Created attachment 249371 patch 1079802 2 249371 msaboff 2015-03-24 18:15:29 -0700 Comment on attachment 249371 patch Looks like it will build! r=me 1079818 3 249371 commit-queue 2015-03-24 19:02:07 -0700 Comment on attachment 249371 patch Rejecting attachment 249371 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: mes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/TypeProfilerLog.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/ExceptionHelpers.o runtime/ExceptionHelpers.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.appspot.com/results/5717390864154624 1079826 4 saam 2015-03-24 19:22:49 -0700 (In reply to comment #3) > Comment on attachment 249371 [details] > patch > > Rejecting attachment 249371 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', > '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', > '--no-clean', '--no-update', '--build-style=release', '--port=mac']" > exit_code: 2 cwd: /Volumes/Data/EWS/WebKit > > Last 500 characters of output: > mes/Data/EWS/WebKit/Source/JavaScriptCore/runtime/TypeProfilerLog.cpp -o > /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/ > JavaScriptCore.build/Objects-normal/x86_64/TypeProfilerLog.o > > ** BUILD FAILED ** > > > The following build commands failed: > CompileC > /Volumes/Data/EWS/WebKit/WebKitBuild/JavaScriptCore.build/Release/ > JavaScriptCore.build/Objects-normal/x86_64/ExceptionHelpers.o > runtime/ExceptionHelpers.cpp normal x86_64 c++ > com.apple.compilers.llvm.clang.1_0.compiler > (1 failure) > > Full output: http://webkit-queues.appspot.com/results/5717390864154624 This seems weird. Builds fine on my machine. I'll update locally and see if it breaks on my clean build. 1080618 5 249573 saam 2015-03-27 09:34:43 -0700 Created attachment 249573 patch lets give this another go. If bots are okay with it, I will cq+ 1080711 6 249599 saam 2015-03-27 12:51:49 -0700 Created attachment 249599 patch one more time should be using ASSERT_UNUSED 1080764 7 249599 commit-queue 2015-03-27 14:57:20 -0700 Comment on attachment 249599 patch Clearing flags on attachment: 249599 Committed r182083: <http://trac.webkit.org/changeset/182083> 1080765 8 commit-queue 2015-03-27 14:57:25 -0700 All reviewed patches have been landed. Closing bug. 249371 2015-03-24 18:14:15 -0700 2015-03-27 09:34:43 -0700 patch clean-backup.diff text/plain 1562 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgxOTIzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTAzLTI0ICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBBZGQgYmFjayBwcmV2aW91c2x5IGJyb2tlbiBhc3NlcnQgZnJvbSBidWcgMTQxODY5Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMwMDUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUv RXhjZXB0aW9uSGVscGVycy5jcHA6CisgICAgICAgIChKU0M6OmludmFsaWRQYXJhbWV0ZXJJblNv dXJjZUFwcGVuZGVyKToKKwogMjAxNS0wMy0yNCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVh QGdtYWlsLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTgxNDU4KTogSGVhcCB1c2UtYWZ0 ZXItZnJlZSBpbiBKU1NldEl0ZXJhdG9yIGRlc3RydWN0b3IKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCShyZXZpc2lvbiAx ODE4OTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25IZWxwZXJz LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA2LDggKzIwNiwxMCBAQCBzdGF0aWMgU3RyaW5nIG5v dEFGdW5jdGlvblNvdXJjZUFwcGVuZGVyCiAgICAgcmV0dXJuIGJ1aWxkZXIudG9TdHJpbmcoKTsK IH0KIAotc3RhdGljIFN0cmluZyBpbnZhbGlkUGFyYW1ldGVySW5Tb3VyY2VBcHBlbmRlcihjb25z dCBTdHJpbmcmIG9yaWdpbmFsTWVzc2FnZSwgY29uc3QgU3RyaW5nJiBzb3VyY2VUZXh0LCBSdW50 aW1lVHlwZSwgRXJyb3JJbnN0YW5jZTo6U291cmNlVGV4dFdoZXJlRXJyb3JPY2N1cnJlZCBvY2N1 cnJlbmNlKQorc3RhdGljIFN0cmluZyBpbnZhbGlkUGFyYW1ldGVySW5Tb3VyY2VBcHBlbmRlcihj b25zdCBTdHJpbmcmIG9yaWdpbmFsTWVzc2FnZSwgY29uc3QgU3RyaW5nJiBzb3VyY2VUZXh0LCBS dW50aW1lVHlwZSB0eXBlLCBFcnJvckluc3RhbmNlOjpTb3VyY2VUZXh0V2hlcmVFcnJvck9jY3Vy cmVkIG9jY3VycmVuY2UpCiB7CisgICAgQVNTRVJUKHR5cGUgIT0gVHlwZU9iamVjdCk7CisKICAg ICBpZiAob2NjdXJyZW5jZSA9PSBFcnJvckluc3RhbmNlOjpGb3VuZEFwcHJveGltYXRlU291cmNl KQogICAgICAgICByZXR1cm4gZGVmYXVsdEFwcHJveGltYXRlU291cmNlRXJyb3Iob3JpZ2luYWxN ZXNzYWdlLCBzb3VyY2VUZXh0KTsKIAo= 249573 2015-03-27 09:34:43 -0700 2015-03-27 12:51:49 -0700 patch clean-backup.diff text/plain 1568 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgyMDYyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTAzLTI3ICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBBZGQgYmFjayBwcmV2aW91c2x5IGJyb2tlbiBhc3NlcnQgZnJvbSBidWcgMTQxODY5Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMwMDUKKwor ICAgICAgICBSZXZpZXdlZCBieSBNaWNoYWVsIFNhYm9mZi4KKworICAgICAgICAqIHJ1bnRpbWUv RXhjZXB0aW9uSGVscGVycy5jcHA6CisgICAgICAgIChKU0M6OmludmFsaWRQYXJhbWV0ZXJJblNv dXJjZUFwcGVuZGVyKToKKwogMjAxNS0wMy0yNyAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFw cGxlLmNvbT4KIAogICAgICAgICBPYmplY3RzIHdpdGggbnVtZXJpYyBwcm9wZXJ0aWVzIGludGVy bWl0dGVudGx5IGdldCBhIHBoYW50b20gJ2xlbmd0aCcgcHJvcGVydHkKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCShyZXZp c2lvbiAxODIwNjIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25I ZWxwZXJzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA2LDggKzIwNiwxMCBAQCBzdGF0aWMgU3Ry aW5nIG5vdEFGdW5jdGlvblNvdXJjZUFwcGVuZGVyCiAgICAgcmV0dXJuIGJ1aWxkZXIudG9TdHJp bmcoKTsKIH0KIAotc3RhdGljIFN0cmluZyBpbnZhbGlkUGFyYW1ldGVySW5Tb3VyY2VBcHBlbmRl cihjb25zdCBTdHJpbmcmIG9yaWdpbmFsTWVzc2FnZSwgY29uc3QgU3RyaW5nJiBzb3VyY2VUZXh0 LCBSdW50aW1lVHlwZSwgRXJyb3JJbnN0YW5jZTo6U291cmNlVGV4dFdoZXJlRXJyb3JPY2N1cnJl ZCBvY2N1cnJlbmNlKQorc3RhdGljIFN0cmluZyBpbnZhbGlkUGFyYW1ldGVySW5Tb3VyY2VBcHBl bmRlcihjb25zdCBTdHJpbmcmIG9yaWdpbmFsTWVzc2FnZSwgY29uc3QgU3RyaW5nJiBzb3VyY2VU ZXh0LCBSdW50aW1lVHlwZSB0eXBlLCBFcnJvckluc3RhbmNlOjpTb3VyY2VUZXh0V2hlcmVFcnJv ck9jY3VycmVkIG9jY3VycmVuY2UpCiB7CisgICAgQVNTRVJUKHR5cGUgIT0gVHlwZU9iamVjdCk7 CisKICAgICBpZiAob2NjdXJyZW5jZSA9PSBFcnJvckluc3RhbmNlOjpGb3VuZEFwcHJveGltYXRl U291cmNlKQogICAgICAgICByZXR1cm4gZGVmYXVsdEFwcHJveGltYXRlU291cmNlRXJyb3Iob3Jp Z2luYWxNZXNzYWdlLCBzb3VyY2VUZXh0KTsKIAo= 249599 2015-03-27 12:51:49 -0700 2015-03-27 14:57:20 -0700 patch clean-backup.diff text/plain 1581 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgyMDYyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE1LTAzLTI3ICBTYWFtIEJhcmF0aSAgPHNhYW1iYXJhdGkxQGdtYWlsLmNvbT4KKworICAg ICAgICBBZGQgYmFjayBwcmV2aW91c2x5IGJyb2tlbiBhc3NlcnQgZnJvbSBidWcgMTQxODY5Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMwMDUKKwor ICAgICAgICBSZXZpZXdlZCBieSBNaWNoYWVsIFNhYm9mZi4KKworICAgICAgICAqIHJ1bnRpbWUv RXhjZXB0aW9uSGVscGVycy5jcHA6CisgICAgICAgIChKU0M6OmludmFsaWRQYXJhbWV0ZXJJblNv dXJjZUFwcGVuZGVyKToKKwogMjAxNS0wMy0yNyAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFw cGxlLmNvbT4KIAogICAgICAgICBPYmplY3RzIHdpdGggbnVtZXJpYyBwcm9wZXJ0aWVzIGludGVy bWl0dGVudGx5IGdldCBhIHBoYW50b20gJ2xlbmd0aCcgcHJvcGVydHkKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCShyZXZp c2lvbiAxODIwNjIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGNlcHRpb25I ZWxwZXJzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjA2LDggKzIwNiwxMCBAQCBzdGF0aWMgU3Ry aW5nIG5vdEFGdW5jdGlvblNvdXJjZUFwcGVuZGVyCiAgICAgcmV0dXJuIGJ1aWxkZXIudG9TdHJp bmcoKTsKIH0KIAotc3RhdGljIFN0cmluZyBpbnZhbGlkUGFyYW1ldGVySW5Tb3VyY2VBcHBlbmRl cihjb25zdCBTdHJpbmcmIG9yaWdpbmFsTWVzc2FnZSwgY29uc3QgU3RyaW5nJiBzb3VyY2VUZXh0 LCBSdW50aW1lVHlwZSwgRXJyb3JJbnN0YW5jZTo6U291cmNlVGV4dFdoZXJlRXJyb3JPY2N1cnJl ZCBvY2N1cnJlbmNlKQorc3RhdGljIFN0cmluZyBpbnZhbGlkUGFyYW1ldGVySW5Tb3VyY2VBcHBl bmRlcihjb25zdCBTdHJpbmcmIG9yaWdpbmFsTWVzc2FnZSwgY29uc3QgU3RyaW5nJiBzb3VyY2VU ZXh0LCBSdW50aW1lVHlwZSB0eXBlLCBFcnJvckluc3RhbmNlOjpTb3VyY2VUZXh0V2hlcmVFcnJv ck9jY3VycmVkIG9jY3VycmVuY2UpCiB7CisgICAgQVNTRVJUX1VOVVNFRCh0eXBlLCB0eXBlICE9 IFR5cGVPYmplY3QpOworCiAgICAgaWYgKG9jY3VycmVuY2UgPT0gRXJyb3JJbnN0YW5jZTo6Rm91 bmRBcHByb3hpbWF0ZVNvdXJjZSkKICAgICAgICAgcmV0dXJuIGRlZmF1bHRBcHByb3hpbWF0ZVNv dXJjZUVycm9yKG9yaWdpbmFsTWVzc2FnZSwgc291cmNlVGV4dCk7CiAK